[PATCH weston v2] shell: clear popup grab interface on remove_popup_grab and popup_grab_end

Fixes a segfault. Steps to reproduce: * start weston with the x11 backend * open a terminal * click on the icon in the top left corner, choose close * close the x11 window containing weston --- src/shell.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/shell.c b/src/shell.c index de5d

[PATCH weston] shell: clear popup grab interface on remove_popup_grab

Fixes a segfault. Steps to reproduce: * start weston with the x11 backend * open a terminal * click on the icon in the top left corner, choose close * close the x11 window containing weston --- src/shell.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/shell.c b/src/shell.c index de5d6

[PATCH weston v2] desktop-shell: better error logging

v2: only call cairo_surface_status once --- clients/desktop-shell.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/clients/desktop-shell.c b/clients/desktop-shell.c index 41e7daa..38af6c6 100644 --- a/clients/desktop-shell.c +++ b/clients/desktop-shell.c @@ -519,13 +519

[PATCH weston] desktop-shell: better error logging

--- clients/desktop-shell.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/clients/desktop-shell.c b/clients/desktop-shell.c index 41e7daa..ce2366d 100644 --- a/clients/desktop-shell.c +++ b/clients/desktop-shell.c @@ -524,8 +524,10 @@ load_icon_or_fallback(const char *icon

[PATCH weston] compositor: don't let weston terminate with dpms set to off if possible

This will not catch the cases where weston crashes, but it's at least better than the current state. --- src/compositor.c | 28 +++- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/src/compositor.c b/src/compositor.c index a3d1ede..7a656e7 100644 --- a/src/co

[PATCH weston] compositor: add information about the fbdev backend to --help output

--- src/compositor.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/compositor.c b/src/compositor.c index c3e6bed..7a656e7 100644 --- a/src/compositor.c +++ b/src/compositor.c @@ -3467,7 +3467,8 @@ usage(int error_code) "Core options:\n\n"

[PATCH weston] compositor: add WESTON_COMPOSITOR_OFFSCREEN state

This state is used when the user switches the vt. It turns of rendering and frame events, but doesn't set the DPMS state to off. As a part of this change, also turn off the idle timer when entering the SLEEPING or OFFSCREEN states, which fixes https://bugs.freedesktop.org/show_bug.cgi?id=61910 (rp

[PATCH 3/3] compositor-rpi: Use correct enum, removes a warning

--- src/compositor-rpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compositor-rpi.c b/src/compositor-rpi.c index 9571e85..8163d85 100644 --- a/src/compositor-rpi.c +++ b/src/compositor-rpi.c @@ -577,7 +577,7 @@ rpi_element_dmx_move(struct rpi_element *element,

[PATCH 2/3 v3] compositor: turn off the idle timer when sleeping

Also updates the drm, fbdev and rpi backend to use weston_compositor_set_sleeping() and not set the state manually. Fixes https://bugs.freedesktop.org/show_bug.cgi?id=61910 (rpi backend untested). v2: don't set DPMS state when switching VT. v3: move unrelated enum change into its own commit. ---

Re: [PATCH weston] compositor-x11: Fix multiple outputs

Sorry, seems to have been fixed already, please disregard. http://lists.freedesktop.org/archives/wayland-devel/2013-March/007824.html On Sun, Mar 10, 2013 at 3:46 PM, Philipp Brüschweiler wrote: > Fixes https://bugs.freedesktop.org/show_bug.cgi?id=61672 > --- > src/compositor-x

[PATCH weston] compositor-x11: Fix multiple outputs

Fixes https://bugs.freedesktop.org/show_bug.cgi?id=61672 --- src/compositor-x11.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/src/compositor-x11.c b/src/compositor-x11.c index 8e052dd..85318d9 100644 --- a/src/compositor-x11.c +++ b/src/compositor-x

[PATCH weston 2/2 v2] compositor: turn off the idle timer when sleeping

Also updates the drm, fbdev and rpi backend to use weston_compositor_set_sleeping() and not set the state manually. Fixes https://bugs.freedesktop.org/show_bug.cgi?id=61910 (rpi backend untested). v2: don't set DPMS state when switching VT. --- src/compositor-drm.c | 2 +- src/compositor-fbde

[PATCH weston 2/2 v3] weston-launch: return better value if weston dies because of a signal

Before this commit, weston-launch returned 0 if weston was killed by a signal. This makes it hard to automatically test weston by using weston-launch, as there is no way to know why weston was terminated. This commit makes weston-launch return 10+N instead, where N is the code of the signal that t

[PATCH weston 2/2] compositor: turn off the idle timer when sleeping

Also updates the drm, fbdev and rpi backend to use weston_compositor_sleep() and not set the state manually. Fixes https://bugs.freedesktop.org/show_bug.cgi?id=61910 (rpi backend untested). --- src/compositor-drm.c | 2 +- src/compositor-fbdev.c | 2 +- src/compositor-rpi.c | 4 ++-- src/comp

[PATCH weston 1/2] compositor: remove unused field option_idle_time

--- src/compositor.c | 1 - src/compositor.h | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/src/compositor.c b/src/compositor.c index a2860fd..7df9658 100644 --- a/src/compositor.c +++ b/src/compositor.c @@ -3497,7 +3497,6 @@ int main(int argc, char *argv[]) sigacti

[PATCH weston 2/2 v2] weston-launch: return correct error code if weston dies because of a signal

Partial fix for https://bugs.freedesktop.org/show_bug.cgi?id=60935. If weston dies because of a signal, 10+N is now returned. But I can't reproduce the SIGHUP using the fbdev backend. --- src/weston-launch.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/src/

[PATCH weston 2/2] weston-launch: return correct error code if weston dies because of a signal

Partial fix for https://bugs.freedesktop.org/show_bug.cgi?id=60935. The correct code is now returned, but I can't reproduce the SIGHUP using the fbdev backend. --- src/weston-launch.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/src/weston-launch.c b/src/wes

[PATCH weston 1/2] weston-launch: move function calls out of assert()

--- src/weston-launch.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/weston-launch.c b/src/weston-launch.c index bc7f8a2..98f0111 100644 --- a/src/weston-launch.c +++ b/src/weston-launch.c @@ -209,6 +209,7 @@ setup_launcher_socket(struct weston_launch *wl) st

Re: [PATCH] pixman-renderer: don't forget to initialize the debug fields

Sorry, forgot Reply All. On Fri, Mar 8, 2013 at 9:04 PM, Philipp Brüschweiler wrote: > On Fri, Mar 8, 2013 at 8:44 PM, Scott Moreau wrote: > >> >> >> On Fri, Mar 8, 2013 at 12:35 PM, Philipp Brüschweiler >> wrote: >> >>> Fixes https

[PATCH] pixman-renderer: don't forget to initialize the debug fields

Fixes https://bugs.freedesktop.org/show_bug.cgi?id=61930 --- src/pixman-renderer.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/pixman-renderer.c b/src/pixman-renderer.c index 9571f6f..9dbe9f0 100644 --- a/src/pixman-renderer.c +++ b/src/pixman-renderer.c @@ -485,6 +485,8 @@ pixman_re

[PATCH 4/4] editor: more intuitive cursor positioning

Compute the nearest glyph edge instead of taking the one to the left of the cursor. Also fixes a segfault when trying to compute the position for an empty buffer. --- clients/editor.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/clients/editor.c b/client

[PATCH 3/4] editor: take text offset into account when computing cursor position

--- clients/editor.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/clients/editor.c b/clients/editor.c index 7140e53..7e6845f 100644 --- a/clients/editor.c +++ b/clients/editor.c @@ -700,6 +700,8 @@ text_entry_draw_preedit(struct text_entry *entry, cairo_t *

[PATCH 2/4] editor: make selection a lighter shade of blue, much easier to read

--- clients/editor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clients/editor.c b/clients/editor.c index c656b06..7140e53 100644 --- a/clients/editor.c +++ b/clients/editor.c @@ -639,7 +639,7 @@ text_entry_draw_selection(struct text_entry *entry, cairo_t *cr) c

[PATCH 1/4] editor: fix assert to take preedit string into account

--- clients/editor.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/clients/editor.c b/clients/editor.c index 5643338..c656b06 100644 --- a/clients/editor.c +++ b/clients/editor.c @@ -500,7 +500,8 @@ text_entry_update_layout(struct text_entry *entry) { char *text;

[PATCH 1/2] cursor: Add a default cursor theme

This theme is loaded when the specified cursor theme can not be found. These cursors are extracted from the xorg sources and transformed into xpm files by a small helper program (commited separately). --- cursor/bottom_left_corner.xpm | 48 ++ cursor/bottom_right_corner.xpm | 48 ++

[PATCH] screensaver: fix decoding of transparency in xpm files

Use 0 as transparent pixel. This is needed when using premultiplied alpha. --- clients/wscreensaver-glue.c | 6 +++--- 1 Datei geändert, 3 Zeilen hinzugefügt(+), 3 Zeilen entfernt(-) diff --git a/clients/wscreensaver-glue.c b/clients/wscreensaver-glue.c index a548599..55d0a8c 100644 --- a/clients

[RFC weston 3/3] eventdemo: add logging of relative motion

--- clients/eventdemo.c | 33 + 1 Datei geändert, 29 Zeilen hinzugefügt(+), 4 Zeilen entfernt(-) diff --git a/clients/eventdemo.c b/clients/eventdemo.c index 569a8c1..db807ec 100644 --- a/clients/eventdemo.c +++ b/clients/eventdemo.c @@ -76,6 +76,9 @@ static int lo

[RFC weston 2/3] toytoolkit: add support for relative pointers

Only the motion events of relative_pointers are acted upon, as the other events are identical to the "normal" pointer. --- clients/window.c | 76 ++-- clients/window.h | 7 ++ 2 Dateien geändert, 81 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-

[RFC weston 1/3] compositor: implement relative motion

notify_motion() now takes both absolute and relative motion parameters and relays this motion to the grab. The grab can then send the absolute motion to the "normal" pointer and the relative motion to the relative pointer. Support for raw pointers should work analogously, but is not implemented ye

[RFC wayland] seat: add wl_relative_pointer

This pointer is equivalent to the "normal" pointer, except that it sends relative motion events. --- protocol/wayland.xml | 93 +++ src/data-device.c| 3 +- src/wayland-server.c | 101 +++ src/waylan

Re: [PATCH wayland] Add a relative_grab request to the wl_shell_surface interface

The consensus seems to be that we need relative/raw motion and that it should be orthogonal to clipping/grabbing. I have now tried my hand at implementing relative motion by introducing a wl_relative_pointer (no raw motion yet, but it should not be hard to extend the implementation analogously). Th

[PATCH] toytoolkit: supply correct widget in motion_handler callback

--- clients/window.c | 2 +- 1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-) diff --git a/clients/window.c b/clients/window.c index 4ddbd2f..330d96f 100644 --- a/clients/window.c +++ b/clients/window.c @@ -2013,7 +2013,7 @@ pointer_handle_motion(void *data, struct wl_pointer *point

[PATCH] workspaces: don't segfault on invalid move_surface_to_workspace request

Also fixes the off-by-one in toytoolkit that exposed the issue. --- clients/window.c | 2 +- src/shell.c | 4 2 Dateien geändert, 5 Zeilen hinzugefügt(+), 1 Zeile entfernt(-) diff --git a/clients/window.c b/clients/window.c index 472aabf..4ddbd2f 100644 --- a/clients/window.c +++ b/clie

[PATCH] desktop-shell: don't segfault on invalid icon path

Instead draw a fallback icon and proceed as normal. https://bugs.freedesktop.org/show_bug.cgi?id=53860 v2: coding style fixes v3: memory leak, draw icon instead of relying on external files --- clients/desktop-shell.c | 36 +++- 1 Datei geändert, 35 Zeilen hinzuge

[PATCH] desktop-shell: don't segfault on invalid icon path

Instead load a fallback icon and proceed as normal. https://bugs.freedesktop.org/show_bug.cgi?id=53860 v2: coding style fixes --- clients/desktop-shell.c | 20 +++- 1 Datei geändert, 19 Zeilen hinzugefügt(+), 1 Zeile entfernt(-) diff --git a/clients/desktop-shell.c b/clients/des

[PATCH] desktop-shell: don't segfault on invalid icon path

Instead load a fallback icon and proceed as normal. https://bugs.freedesktop.org/show_bug.cgi?id=53860 --- clients/desktop-shell.c | 19 ++- 1 Datei geändert, 18 Zeilen hinzugefügt(+), 1 Zeile entfernt(-) diff --git a/clients/desktop-shell.c b/clients/desktop-shell.c index dc87e7

[PATCH weston 2/2] relative-grab-demo: small demo client using relative grab

= clickdot.c clickdot_LDADD = $(toolkit_libs) diff --git a/clients/relative-grab-demo.c b/clients/relative-grab-demo.c new file mode 100644 index 000..ca0b927 --- /dev/null +++ b/clients/relative-grab-demo.c @@ -0,0 +1,171 @@ +/* + * Copyright © 2012 Philipp Brüschweiler + * + * Permission to use

[PATCH weston 1/2] relative-grab: first implementation

Support the relative_grab request introduced to wayland by a different patch. notify_motion is renamed to notify_motion_absolute; a new function called notify_motion_relative is added. A data source (i.e. pointer driver, be it evdev or an x11 pointer) should call the notify_motion function that wo

[PATCH wayland] Add a relative_grab request to the wl_shell_surface interface

This request can be used to grab the pointer of a specified seat. A pointer grabbed in this way will be made invisible and won't send any more motion events. Instead it reports relative motion using the motion event on the returned object. A grab can be broken by the application by destroying the

[RFC] Grab & relative motion

Hi everyone, This small patch series implements a simple type of grab & relative motion combination in both wayland and weston. For more details, please look at the commit messages. I'd be great to get some feedback on this, I'm not even sure if the general direction of the protocol change & impl

[PATCH] desktop-shell: respect CURSOR_NONE as grab cursor

--- clients/desktop-shell.c | 3 +++ 1 Datei geändert, 3 Zeilen hinzugefügt(+) diff --git a/clients/desktop-shell.c b/clients/desktop-shell.c index 97b2066..dc87e75 100644 --- a/clients/desktop-shell.c +++ b/clients/desktop-shell.c @@ -806,6 +806,9 @@ desktop_shell_grab_cursor(void *data,

[PATCH] toytoolkit: try multiple names when loading cursors

The correspondence between cursor functions and names of cursors has never been standardized. As a consequence, each cursor function can be represented as a cursor with one of several names. Be more robust when loading cursor by trying all known names that correspond to a cursor. This should fix h

Re: [PATCH 10/14] tablet-shell: add event in tablet-client protocol.

On Tue, Aug 21, 2012 at 1:49 PM, wrote: > From: Ning Tang > > When a client is binded, the server side will send an event to let the > client set fullscreen. > If the client don't response, it will remain centered. > > Signed-off-by: Ning Tang > > --- > protocol/tablet-shell.xml | 2 ++ > sr

Re: [PATCH 07/14] tablet-shell: add layout indicator on homescreen.

On Tue, Aug 21, 2012 at 1:49 PM, wrote: > From: Ning Tang > > We could know how many layouts in total and our current layout. > Keyword in ini file is the path to indicator images, use the format of > 1-f.png(focus) 1.png 2-f.png... > > Signed-off-by: Ning Tang > > --- > clients/tablet-shell.

Re: [PATCH 09/14] tablet-shell: add shell_surface in tablet-shell.

On Tue, Aug 21, 2012 at 1:49 PM, wrote: > From: Ning Tang > > Since now toytoolkit and simple programs use shell_surface to show on > screen, we add it in tablet-shell to let them show. > But we only need serveral feature in tablet shell, the wl_shell is too > big and not suitable for tablet-she

Re: [PATCH 06/14] tablet-shell: add trash function when dragging launcher icon.

On Tue, Aug 21, 2012 at 1:49 PM, wrote: > From: Ning Tang > > Determine whether to accpet the data by the allocation of trash area. If > the icon is in it, then drop event will delete either the icon image as > well as tag in ini file. > > Signed-off-by: Ning Tang > > --- > clients/tablet-she

Re: [PATCH 04/14] tablet-shell: add sliding effect of layout.

On Tue, Aug 21, 2012 at 1:49 PM, wrote: > From: Ning Tang > > Use frame callback to enable layout moving, so dragging layout > will cause layout's offset changes. > And redraw function will allocate corresponding positions to launchers. > The allocation of layout won't change until sliding ends.

Re: [PATCH 03/14] tablet-shell: break the connection between launcher and homescreen.

On Tue, Aug 21, 2012 at 1:49 PM, wrote: > From: Ning Tang > > Launcher is totally depend on layout and add layout > redraw function to manage drawing launchers. > > Signed-off-by: Ning Tang > > --- > clients/tablet-shell.c | 133 > + > weston-t

Re: [PATCH 02/14] tablet-shell: add layout structure on homescreen.

On Tue, Aug 21, 2012 at 1:49 PM, wrote: > From: Ning Tang > > It is a base for further operations on layout. Launchers are put in a > certain layout. > > Signed-off-by: Ning Tang > > --- > clients/tablet-shell.c | 62 > +++--- > weston-tablet.ini

[PATCH] terminal: support entering non-ascii characters

Unless the alt modifier is active and the MODE_ALT_SENDS_ESC mode is not set, any value over 127 is converted to a UTF8 sequence. Part of https://bugs.freedesktop.org/show_bug.cgi?id=53648 should be fixed with this. Part of https://bugs.freedesktop.org/show_bug.cgi?id=52419 is fixed, but interest

[PATCH] toytoolkit: don't ignore resizes with negative width or height

E.g. this can happen when you grab the lower right corner of a window and move over the top of the window when resizing. In this case, the changed width is still important and should be acted upon. https://bugs.freedesktop.org/show_bug.cgi?id=53560 --- clients/window.c | 3 --- 1 Datei geändert,

[PATCH 2/2] weston-info: an output can have multiple modes

--- clients/weston-info.c | 59 +-- 1 Datei geändert, 38 Zeilen hinzugefügt(+), 21 Zeilen entfernt(-) diff --git a/clients/weston-info.c b/clients/weston-info.c index d4b70da..95e45b1 100644 --- a/clients/weston-info.c +++ b/clients/weston-info.c @@

[PATCH 1/2] weston-info: remove timerfd termination hack

Use wl_display_roundtrip to listen exactly as long as necessary. --- clients/weston-info.c | 93 ++- 1 Datei geändert, 11 Zeilen hinzugefügt(+), 82 Zeilen entfernt(-) diff --git a/clients/weston-info.c b/clients/weston-info.c index 4604bbf..d4b70da

[PATCH] weston-info: client that print out information about the running compositor

\ desktop-shell-client-protocol.h \ diff --git a/clients/weston-info.c b/clients/weston-info.c new file mode 100644 index 000..4604bbf --- /dev/null +++ b/clients/weston-info.c @@ -0,0 +1,475 @@ +/* + * Copyright © 2012 Philipp Brüschweiler + * + * Permission to use, copy, modify

[PATCH] event-test: fix compilation

Also fixes a compiler warning in test-client. The test is still failing, but that's for another patch. https://bugs.freedesktop.org/show_bug.cgi?id=53462 --- tests/event-test.c | 7 +-- tests/test-client.c | 7 --- 2 Dateien geändert, 9 Zeilen hinzugefügt(+), 5 Zeilen entfernt(-) diff -

[PATCH] toytoolkit: remove unused actions from titlebar menu

They were introduced in b3cca0a41130ff45b70b730cb8f2273dd91531a5 but never actually implemented. Removing them should at least stop users from wondering if weston is broken. https://bugs.freedesktop.org/show_bug.cgi?id=52455 --- clients/window.c | 8 +++- 1 Datei geändert, 3 Zeilen hinzugefüg

[PATCH] socket-test: don't try to be clever, fail if no XDG_RUNTIME_DIR is set

Not only setenv(), also putenv() allocates memory on my system (glibc 2.16.0). Just fail with a clear message if XDG_RUNTIME_DIR is not set. https://bugs.freedesktop.org/show_bug.cgi?id=52618 --- tests/socket-test.c | 21 ++--- 1 Datei geändert, 10 Zeilen hinzugefügt(+), 11 Zeilen

[PATCH 4/4] eventdemo: add axis logging

https://bugs.freedesktop.org/show_bug.cgi?id=52453 --- clients/eventdemo.c | 30 ++ 1 Datei geändert, 30 Zeilen hinzugefügt(+) diff --git a/clients/eventdemo.c b/clients/eventdemo.c index 49e4399..569a8c1 100644 --- a/clients/eventdemo.c +++ b/clients/eventdemo.c @@ -7

[PATCH 3/4] toytoolkit: add axis handler

--- clients/window.c | 19 +++ clients/window.h | 8 2 Dateien geändert, 27 Zeilen hinzugefügt(+) diff --git a/clients/window.c b/clients/window.c index dd65328..c274541 100644 --- a/clients/window.c +++ b/clients/window.c @@ -179,6 +179,7 @@ struct widget { widg

[PATCH 2/4] eventdemo: fix --no-border

This was broken by commit 29af3ebce676b3cdd516dedc0cbedc47f70ce425 --- clients/eventdemo.c | 18 ++ 1 Datei geändert, 10 Zeilen hinzugefügt(+), 8 Zeilen entfernt(-) diff --git a/clients/eventdemo.c b/clients/eventdemo.c index 5556a75..49e4399 100644 --- a/clients/eventdemo.c +++ b

[PATCH 1/4] eventdemo: fix incorrect comments

--- clients/eventdemo.c | 8 1 Datei geändert, 4 Zeilen hinzugefügt(+), 4 Zeilen entfernt(-) diff --git a/clients/eventdemo.c b/clients/eventdemo.c index 22dade3..5556a75 100644 --- a/clients/eventdemo.c +++ b/clients/eventdemo.c @@ -90,7 +90,7 @@ struct eventdemo { /** * \brief CAL

[PATCH] shell: don't segfault when pressing super+k when no surface is focused

--- src/shell.c | 7 ++- 1 Datei geändert, 6 Zeilen hinzugefügt(+), 1 Zeile entfernt(-) diff --git a/src/shell.c b/src/shell.c index 51480ce..4d6bc4f 100644 --- a/src/shell.c +++ b/src/shell.c @@ -3271,12 +3271,17 @@ static void force_kill_binding(struct wl_seat *seat, uint32_t time, uint32_

[PATCH] image: handle multiple images correctly

Don't stop the application when only one window is closed. Don't stall indefinitely if no valid image file is given as input. --- clients/image.c | 29 ++--- 1 Datei geändert, 26 Zeilen hinzugefügt(+), 3 Zeilen entfernt(-) diff --git a/clients/image.c b/clients/image.c ind

Re: [PATCH] dnd: fix segfault on grabbing

This fixes https://bugs.freedesktop.org/show_bug.cgi?id=50487 Cheers, Philipp On Mon, Aug 13, 2012 at 8:04 PM, Philipp Brüschweiler wrote: > Some cursor themes don't include a "grabbing" icon, causing a segfault. > This patch fixes this by just reverting to the st

[PATCH] dnd: fix segfault on grabbing

Some cursor themes don't include a "grabbing" icon, causing a segfault. This patch fixes this by just reverting to the stardard cursor instead. --- clients/dnd.c | 7 +++ 1 Datei geändert, 7 Zeilen hinzugefügt(+) diff --git a/clients/dnd.c b/clients/dnd.c index 6f55e95..44c1541 100644 --- a/c

Re: [PATCH] wl-server: add wl_client_get_object_for_interface

Consider this retracted. Cheers, Philipp On Sat, Aug 11, 2012 at 12:15 PM, Philipp Brüschweiler wrote: > This method makes it possible to get access to an object assigned to a > client that implements a certain interface and has a certain data. > --- > src/wayland-s

[PATCH v2 3/3] editor: correctly handle multiple seats

Text fields are drawn as activated if at least one seat has activated the corresponding text model. --- clients/editor.c | 18 +++--- 1 Datei geändert, 11 Zeilen hinzugefügt(+), 7 Zeilen entfernt(-) diff --git a/clients/editor.c b/clients/editor.c index a5347fe..76bbcb3 100644 --- a/c

[PATCH v2 2/3] shell: make {show,hide}_input_panels idempotent

This prevents issues that arise when using multiple seats (at least with the current implementation in text-backend.c). --- src/shell.c | 6 ++ 1 Datei geändert, 6 Zeilen hinzugefügt(+) diff --git a/src/shell.c b/src/shell.c index 87e688c..3dd2f6e 100644 --- a/src/shell.c +++ b/src/shell.c @@

[PATCH v2 1/3] keyboard: fix to make it work in the presence of multiple seats

Multiple seats imply multiple input methods. Each input method is now held in a keyboard_input_method struct. On a button click, a commit is sent to each input method. --- clients/keyboard.c | 44 +++- 1 Datei geändert, 35 Zeilen hinzugefügt(+), 9 Zeilen ent

Re: [PATCH 1/2] text: add assigned_seat event to the input_method interface

o input from all seats and forward to all > active text_models (as long as we do not have a virtual keyboard surface > per seat). I think that should both be possible with just the > input_method_context interface we talked about on Friday. > > Best regards, > Jan Arne > > &g

[PATCH 1/2] text: add assigned_seat event to the input_method interface

This event notifies the input method to which seat it is assigned. This is necessary to distinguish multiple input methods when multiple seats are used. --- protocol/text.xml | 4 src/text-backend.c | 23 +-- 2 Dateien geändert, 21 Zeilen hinzugefügt(+), 6 Zeilen entfern

[PATCH] wl-server: add wl_client_get_object_for_interface

This method makes it possible to get access to an object assigned to a client that implements a certain interface and has a certain data. --- src/wayland-server.c | 34 ++ src/wayland-server.h | 4 2 Dateien geändert, 38 Zeilen hinzugefügt(+) diff --git a/src

[PATCH 2/2] keyboard: fix to make it work in the presence of multiple seats

If a certain seat causes a button click, send the commit_string to the input method that is assigned to the same seat. --- clients/keyboard.c | 81 -- 1 Datei geändert, 72 Zeilen hinzugefügt(+), 9 Zeilen entfernt(-) diff --git a/clients/keyboard

Re: [PATCH 4/5] text: Assign text_model to a wl_seat

This will not work with multiple seats, right? I guess the input_method struct would have to be broken up into a 'global' part (containing the global object bindings) and a per seat part. Or am I missing something? Cheers, Philipp On Fri, Aug 10, 2012 at 4:47 PM, Jan Arne Petersen wrote: > From:

Re: [PATCH] shell: show input panel on configure, if activated

the other input field of the editor (even though input methods and panels are supposed to be activated). This patch fixes that. Cheers, Philipp On Fri, Aug 10, 2012 at 4:19 PM, Kristian Høgsberg wrote: > On Fri, Aug 10, 2012 at 10:42:54AM +0200, Philipp Brüschweiler wrote: > > I'm

[PATCH v2] shell: show input panel on configure, if activated

--- src/shell.c | 30 ++ 1 Datei geändert, 18 Zeilen hinzugefügt(+), 12 Zeilen entfernt(-) diff --git a/src/shell.c b/src/shell.c index 9c8a8a9..5d4fb41 100644 --- a/src/shell.c +++ b/src/shell.c @@ -2520,13 +2520,22 @@ unlock(struct wl_listener *listener, void *data)

[PATCH] shell: show input panel on configure, if activated

--- src/shell.c | 29 + 1 Datei geändert, 17 Zeilen hinzugefügt(+), 12 Zeilen entfernt(-) diff --git a/src/shell.c b/src/shell.c index 9c8a8a9..670cfd6 100644 --- a/src/shell.c +++ b/src/shell.c @@ -2520,13 +2520,22 @@ unlock(struct wl_listener *listener, void *data)

[PATCH] shell: move input panels into a designated layer

This makes the separation between panels and input panels clearer and prevents the (desktop) panel from removing existing input panels on redraw. The input panel layer is below the panel layer. --- src/shell.c | 39 +-- 1 Datei geändert, 29 Zeilen hinzugefügt(+

[PATCH] shell: don't remove all other panels on desktop panel redraw

panel_configure used to call configure_static_surface which removes all other surfaces in the panel layer. This unfortunately includes input panels, such as the one spawned by the keyboard client. As a result, the keyboard panel was removed on each redraw of the desktop panel, i.e. each full minute

[PATCH v3] shell: don't abuse link_layer for keeping track of input panel surfaces

Input panel surfaces were kept in a list by using layer_link of weston_surface. This was pretty hacky and resulted in the bug that an input panel surface was not removed from the list if it was unmapped at the time of destruction. This patch wraps the surface in a new input_panel_surface struct an

[PATCH v2] shell: don't abuse link_layer for keeping track of input panel surfaces

Input panel surfaces were kept in a list by using layer_link of weston_surface. This was pretty hacky and resulted in the bug that an input panel surface was not removed from the list if it was unmapped at the time of destruction. This patch properly keeps track of input panel surfaces. Destructio

[PATCH] compositor: remove destroyed surfaces from layer lists even if unmapped

This bug can be observed in action using the following steps: * ./editor * (in another terminal) ./keyboard * click into a field of the editor (the keyboard appears) * click outside of a field of the editor (keybord disappears) * kill the keyboard (ctrl-c) * click into a field of the editor again -

Re: Compiling Newest Wayland on Ubuntu 12.04 Precise

I'm on nouveau as well. The drm backend has never worked for me. On Wed, Jul 25, 2012 at 9:51 AM, Scott Moreau wrote: > On Wed, Jul 25, 2012 at 1:39 AM, Philipp Brüschweiler > wrote: >> >> I had the same problem. Enabling gallium-egl fixed it: >> >> On

Re: Compiling Newest Wayland on Ubuntu 12.04 Precise

I had the same problem. Enabling gallium-egl fixed it: On the mesa autogen.sh line (line 322) replace '--disable-gallium-egl' by '--enable-gallium-egl' Cheers, Philipp On Wed, Jul 25, 2012 at 8:25 AM, Bill Spitzak wrote: > On 07/24/2012 09:46 PM, Bill Spitzak wrote: > >>> You took the script th

[PATCH 3/3] text: add a composing input method demo

-protocol.h \ diff --git a/clients/hiragana-ime.c b/clients/hiragana-ime.c new file mode 100644 index 000..122b52b --- /dev/null +++ b/clients/hiragana-ime.c @@ -0,0 +1,546 @@ +/* + * Copyright © 2012 Philipp Brüschweiler + * + * Permission to use, copy, modify, distribute, and sell this

[PATCH 2/3] text: add preedit_string and a reset event

--- clients/editor.c | 77 +++--- protocol/text.xml | 6 + src/text-backend.c | 23 ++-- 3 Dateien geändert, 95 Zeilen hinzugefügt(+), 11 Zeilen entfernt(-) diff --git a/clients/editor.c b/clients/editor.c index 19f7073..ba235bc

[PATCH 1/3] text: add keyboard events

* add request_keyboard so input methods can signal that they want to receive keyboard events * keyboard events are grabbed with wl_keyboard_grab and relayed to the input method using the created wl_keyboard interface --- protocol/text.xml | 5 +- src/compositor.c | 2 +- src/compositor.

Re: [PATCH 4/6] text: start support for keyboard events

Hi Kristian, Thank you for including my patches. I'll try to follow the style guidelines from now on :) On Sun, Jul 22, 2012 at 6:24 PM, Kristian Høgsberg wrote: > On Wed, Jul 11, 2012 at 10:25:32PM +0200, Philipp Brüschweiler wrote: >> * add the request_keyboard_input request

Re: [PATCH 1/6] editor: deactivate old text model before activating the new one

Ping. With these patches (and some others) I managed to get a basic ibus client working. (https://github.com/Blei/ibus/tree/ibus-wayland/client/wayland) Cheers, Philipp On Wed, Jul 11, 2012 at 10:25 PM, Philipp Brüschweiler wrote: > --- > clients/editor.

[PATCH] toytoolkit: refactor the main loop

* make the epoll fd available to users * make it possible to iterate the main loop by hand these two changes make it possible to integrate the display main loop into main loops of other frameworks (such as glib) --- clients/window.c | 55 ++- cl

[PATCH 6/6] text: add a composing input method demo

= \ desktop-shell.c \ desktop-shell-client-protocol.h \ diff --git a/clients/hiragana-ime.c b/clients/hiragana-ime.c new file mode 100644 index 000..a860082 --- /dev/null +++ b/clients/hiragana-ime.c @@ -0,0 +1,381 @@ +/* + * Copyright © 2012 Philipp

[PATCH 5/6] Add the keymap event to input_method

--- protocol/text.xml | 14 +- src/text-backend.c | 12 +++- 2 Dateien geändert, 24 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-) diff --git a/protocol/text.xml b/protocol/text.xml index e51057a..54df12e 100644 --- a/protocol/text.xml +++ b/protocol/text.xml @@ -1,5 +1,5 @@ -

[PATCH 4/6] text: start support for keyboard events

* add the request_keyboard_input request to signal that the input method wants to receive keyboard events * add key and modifier events * keyboard events are grabbed with wl_keyboard_grab and relayed to the input method --- protocol/text.xml | 28 +++ src/compositor.c | 15 +++---

[PATCH 3/6] Extract the text_model_manager interface from input_method

This is necessary because all clients need a way to create text_models, but only one client at a time can be bound to the input_method global (else we don't know to whom we are supposed to send events). --- clients/editor.c | 9 +++--- protocol/text.xml | 4 ++- src/text-backend.c | 85 ++

[PATCH 2/6] text-backend: minor fixes

* make sure deactivation is done consistently when a text_model is destroyed * zero out allocated objects --- src/text-backend.c | 29 + 1 Datei geändert, 17 Zeilen hinzugefügt(+), 12 Zeilen entfernt(-) diff --git a/src/text-backend.c b/src/text-backend.c index 1d2c2

[PATCH 1/6] editor: deactivate old text model before activating the new one

--- clients/editor.c | 36 ++-- 1 Datei geändert, 22 Zeilen hinzugefügt(+), 14 Zeilen entfernt(-) diff --git a/clients/editor.c b/clients/editor.c index 145ba20..9498d53 100644 --- a/clients/editor.c +++ b/clients/editor.c @@ -20,6 +20,7 @@ * CONNECTION WITH THE

[PATCH] Remove some dead code

Hi everyone, Patch is attached. Cheers Philipp 0001-Remove-dead-code.patch Description: Binary data ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: Input Methods

moved somewhere else, either a new interface (text_model_manager? yuck, better names are welcome) or moved to an already existing interface (no idea which one would be suitable). Thoughts? Cheers Philipp On Tue, Jul 10, 2012 at 4:44 PM, Jan Arne Petersen wrote: > Hi, > > > On 0

Re: Input Methods

Hi Jan, Thanks for your answer. I have finally managed to get something going, using a wl_keyboard_grab. This seems to work, but has the problem that it completely grabs the text_model until the text_model gets deactivated. I have looked at wl_keyboard_set_focus a bit, and it seems to me that for