Re: How to get the protocol version of the peer side

Thanks a lot, the patch set seems work now. URL: https://pwu.fedorapeople.org/wayland/preedit_with_mode_v8/ Peng ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel

How to get the protocol version of the peer side

Hi, Currently we are extending the wayland text input v3 protocol to support preedit_commit_mode event. URL: https://gitlab.freedesktop.org/wayland/wayland-protocols/-/merge_requests/30 The protocol version is bumped in the following branch. URL: https://gitlab.freedesktop.org/pwu/wayland

[PATCH v4] Fixes CJK wide character display

By jumping two columns when wide character prints, and draw wide background under wide character. --- clients/terminal.c | 31 +-- 1 file changed, 29 insertions(+), 2 deletions(-) diff --git a/clients/terminal.c b/clients/terminal.c index 6701fb6..9da1a56 100644 --- a/

[PATCH v4] Fixes CJK wide character display

Hi, I used ZERO WIDTH SPACE(U+200B) as the invalid UTF-8 character, also ignore these filler cells in terminal_send_selection. Please review it again, thanks. Peng Wu (1): Fixes CJK wide character display clients/terminal.c | 31 +-- 1 file changed, 29

[PATCH v3] Fixes CJK wide character display

By jumping two columns when wide character prints, and draw wide cursor under wide character. --- clients/Makefile.am | 2 +- clients/terminal.c | 26 -- 2 files changed, 25 insertions(+), 3 deletions(-) diff --git a/clients/Makefile.am b/clients/Makefile.am index 09963c

[PATCH v3] Fixes CJK wide character display

Hi, I re-write the patch for CJK wide character display. Please review it, thanks. Peng Wu (1): Fixes CJK wide character display clients/Makefile.am | 2 +- clients/terminal.c | 26 -- 2 files changed, 25 insertions(+), 3 deletions(-) -- 1.8.3.1

Re: [PATCH v2 1/3] Handle CJK wide glyph rendering

In the past I tested too little about this, really sorry for that. Thanks, Peng Wu ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH v2 1/3] Handle CJK wide glyph rendering

x27;s an example, it misses support for a lot of things and I recommend > avoiding adding complex features. > Because we want weston terminal has i18n support, such as CJK glyph display. > Anyhow, here is an example how to move the cursor for multi-width > characters: > https:

Re: [PATCH v2 1/3] Handle CJK wide glyph rendering

th font (aka > only single or double widths) but the terminal should work "okay" with > a proportional font, forcing it into fixed positions. > > I think Peng's implementation is in line with other virtual terminals. > > On Sun, Jul 21, 2013 at 9:46 PM, Peng Wu wr

Re: [PATCH v2 1/3] Handle CJK wide glyph rendering

Frankly speaking, I suspect that your new fix will break some program which uses newt with proportional font. PS: newt is a library for text mode user interfaces. On Thu, 2013-07-18 at 11:23 -0700, Bill Spitzak wrote: > I propose the drawing code be changed to something like this: > >char* s

Re: [PATCH v2 1/3] Handle CJK wide glyph rendering

On Wed, 2013-07-17 at 09:53 -0700, Bill Spitzak wrote: > For a demo > client I would skip trying to interpret wcwidth on incoming text, > just > act like each glyph takes one character cell. But this will cause rendering problems when display CJK characters. The CJK glyphs will overlap each othe

Re: [PATCH 2/2] Some CJK glyphs are wide, which occupy two columns. If the glyph is wide, then use two columns instead of one.

Hi David, I just re-send the v2 patch set, please review it. Thanks, Peng Wu On Wed, 2013-07-10 at 16:18 +0200, David Herrmann wrote: > I recommend just leaving multi-width support out of terminal.c. It > adds complexity (including wcwidth()) and seems misplaced in a debug > he

[PATCH v2 3/3] Fixes compute selection

Correctly compute the mouse selection when some wide glyphs in rows. --- clients/terminal.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/clients/terminal.c b/clients/terminal.c index d45b740..37f1af8 100644 --- a/clients/terminal.c +++ b/clients/terminal.c @@ -2437,6 +2437,8

[PATCH v2 2/3] Fixes cursor rendering for wide glyphs

Show the cursor at the right position, and use wide cursor under wide glyph. --- clients/terminal.c | 29 + 1 file changed, 25 insertions(+), 4 deletions(-) diff --git a/clients/terminal.c b/clients/terminal.c index 97e315f..d45b740 100644 --- a/clients/terminal.c +++

[PATCH v2 1/3] Handle CJK wide glyph rendering

Some CJK glyphs are wide, which occupy two columns. If the glyph is wide, then use two columns instead of one. --- clients/Makefile.am | 2 +- clients/terminal.c | 45 +++-- 2 files changed, 40 insertions(+), 7 deletions(-) diff --git a/clients/Makefile.a

[PATCH v2 0/3] Improves CJK wide character handling

duplicating codes. BTW, could I use wcwidth from ? Peng Wu (3): Handle CJK wide glyph rendering Fixes cursor rendering for wide glyphs Fixes compute selection clients/Makefile.am | 2 +- clients/terminal.c | 88 +++-- 2 files changed, 79

[PATCH] wcap: Fix README typo

--- wcap/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/wcap/README b/wcap/README index 666a708..0994a1b 100644 --- a/wcap/README +++ b/wcap/README @@ -2,7 +2,7 @@ WCAP Tools WCAP is the video capture format used by Weston (Weston CAPture). It's a simple, lossless f

[PATCH] Fixes a typo in wcap/README

Fixes trivial typo Peng Wu (1): wcap: Fix README typo wcap/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.8.3.1 ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo

Re: [PATCH 2/2] Some CJK glyphs are wide, which occupy two columns. If the glyph is wide, then use two columns instead of one.

Hi Kristian, Actually the terminal patch only uses functions from glib. Is it okay to use glib.h or should I try to duplicate the code in the terminal? I will check the text selection for the dual-width characters soon. Thanks, Peng Wu Refer URL: https://git.gnome.org/browse/glib/tree

Re: [PATCH 1/2] As some CJK fonts are dual-width, use the average width of ASCII glyphs instead of the max_x_advance of the font, just like the vte project.

ent widths. Do not use the width > of space as it is much too small. > > Kristian Høgsberg wrote: > > On Thu, Jun 06, 2013 at 03:32:41PM +0800, Peng Wu wrote: > >> --- > >> clients/terminal.c | 55 > >> -- &

[PATCH 2/2] Some CJK glyphs are wide, which occupy two columns. If the glyph is wide, then use two columns instead of one.

--- clients/Makefile.am | 2 +- clients/terminal.c | 18 -- 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/clients/Makefile.am b/clients/Makefile.am index cad0d40..d37d66a 100644 --- a/clients/Makefile.am +++ b/clients/Makefile.am @@ -104,7 +104,7 @@ weston_scree

[PATCH 1/2] As some CJK fonts are dual-width, use the average width of ASCII glyphs instead of the max_x_advance of the font, just like the vte project.

--- clients/terminal.c | 55 -- 1 file changed, 41 insertions(+), 14 deletions(-) diff --git a/clients/terminal.c b/clients/terminal.c index 2985726..0d4f726 100644 --- a/clients/terminal.c +++ b/clients/terminal.c @@ -54,6 +54,16 @@ terminal_de

[PATCH 0/2] terminal: Handle dual-width fonts

In CJK locale, there are some dual-width fonts. When start weston terminal in CJK locale, the glyph will occupy many empty space. I changed to use the average ASCII glyph width instead of the maximum glyph width, like vte project. Peng Wu (2): As some CJK fonts are dual-width, use the average

[PATCH] fixes trivial typo

--- doc/publican/sources/Protocol.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/publican/sources/Protocol.xml b/doc/publican/sources/Protocol.xml index f576542..1a7a7da 100644 --- a/doc/publican/sources/Protocol.xml +++ b/doc/publican/sources/Protocol.xml @@ -453,7 +

[PATCH] Fixes a typo in doc/publican/sources/Protocol.xml

The doc/publican/sources/Protocol.xml use 'trasnfer', fixes it as 'transfer'. Peng Wu (1): fixes trivial typo doc/publican/sources/Protocol.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.8.1.4 ___ waylan