Re: [PATCH] selection: send selection events to all connected clients

2013-04-15 Thread Pekka Vuorela
On ma, 2013-04-15 at 10:05 -0400, Yichao Yu wrote: > On Mon, Apr 15, 2013 at 9:44 AM, Pekka Paalanen wrote: > >> > >> Clipboard manager (or all other programs that need clipboard > >> monitoring) may be special, but I don't see why it is necessary to > >> break every single toolkits' api by don't

Re: Auto key repeat in wayland.

2013-03-19 Thread Pekka Vuorela
On 19.03.2013 22:13, Bill Spitzak wrote: Yichao Yu wrote: I am just wondering if those clients also don't want auto-repeat for text input. If there is a way to turn off auto-repeat for a client, should that also turn off the auto-repeat when the input method grab the keyboard from the client?

Re: [PATCH 00/13] Clean up text protocol and move to wayland

2013-03-19 Thread Pekka Vuorela
On 18.03.2013 16:21, Jan Arne Petersen wrote: On 03/08/2013 09:17 PM, Pekka Vuorela wrote: Before moving to Wayland, one thing that I'd like to be covered good is the good old synchronization problem. Suppose input method commits "a", then "b", and then decides

Re: [PATCH 00/13] Clean up text protocol and move to wayland

2013-03-08 Thread Pekka Vuorela
On 19.02.2013 20:26, Jan Arne Petersen wrote: From: Jan Arne Petersen This series finalizes the first version of the text protocol and moves it from Weston to Wayland, so that it can be implemented in toolkits. It adds the missing language/text-direction support to the protocol. text_model ge

Re: [PATCH 00/13] Clean up text protocol and move to wayland

2013-02-19 Thread Pekka Vuorela
On 19.02.2013 22:11, Jan Arne Petersen wrote: On 19.02.2013 20:01, Yichao Yu wrote: On Tue, Feb 19, 2013 at 1:26 PM, Jan Arne Petersen wrote: From: Jan Arne Petersen This series finalizes the first version of the text protocol and moves it from Weston to Wayland, so that it can be implemente

Re: [PATCH RFC] text: Add language and text-direction to protocol

2013-02-02 Thread Pekka Vuorela
I think this generally looks good. Few notes below. On 31.01.2013 18:44, Jan Arne Petersen wrote: diff --git a/protocol/text.xml b/protocol/text.xml index 28d12ed..640f4eb 100644 --- a/protocol/text.xml +++ b/protocol/text.xml @@ -150,6 +150,14 @@ Requests input panels (virtual keybo

Re: Questions and thoughts about input method protocol

2013-02-02 Thread Pekka Vuorela
On 01.02.2013 21:53, Yichao Yu wrote: On Fri, Feb 1, 2013 at 1:48 PM, Pekka Vuorela wrote: On 01.02.2013 00:45, Yichao Yu wrote: On Thu, Jan 31, 2013 at 5:19 PM, Pekka Vuorela wrote: I was talking about input method _automatically_ changing to one layout or another based on what was used

Re: Questions and thoughts about input method protocol

2013-02-01 Thread Pekka Vuorela
On 01.02.2013 00:45, Yichao Yu wrote: On Thu, Jan 31, 2013 at 5:19 PM, Pekka Vuorela wrote: On 31.01.2013 02:54, Yichao Yu wrote: Hi, On Wed, Jan 30, 2013 at 4:09 PM, Pekka Vuorela wrote: I was talking about input method _automatically_ changing to one layout or another based on what

Re: Questions and thoughts about input method protocol

2013-02-01 Thread Pekka Vuorela
On 31.01.2013 19:54, Weng Xuetian wrote: On Wednesday 30 January 2013 23:09:20,Pekka Vuorela : I would try to find better ways to achieve targeted goals. One feature I've myself been thinking is virtual keyboard used with messaging app knowing what language, or type of language, the reci

Re: [PATCH 0/5] Input method support cleanup

2013-01-31 Thread Pekka Vuorela
On 31.01.2013 22:18, Jan Arne Petersen wrote: On 31.01.2013 16:38, Yichao Yu wrote: On Thu, Jan 31, 2013 at 9:52 AM, Jan Arne Petersen wrote: From: Jan Arne Petersen Another series of input method support patches. Mostly some cleanups in the protocol: * Remove some unused requests events (s

Re: Questions and thoughts about input method protocol

2013-01-31 Thread Pekka Vuorela
On 31.01.2013 02:54, Yichao Yu wrote: Hi, On Wed, Jan 30, 2013 at 4:09 PM, Pekka Vuorela wrote: On 29.01.2013 04:49, Yichao Yu wrote: Hi, With the comment on the recent patches for the input method protocol, it seems that we are finally on the way to support cursor following. However I

Re: Questions and thoughts about input method protocol

2013-01-30 Thread Pekka Vuorela
On 29.01.2013 04:49, Yichao Yu wrote: Hi, With the comment on the recent patches for the input method protocol, it seems that we are finally on the way to support cursor following. However I still have some questions about the protocol (and it's limitation). 1, Is there any plan to support xway

Re: [PATCH 00/18] Input method support patches

2013-01-22 Thread Pekka Vuorela
On 16.01.2013 22:26, Jan Arne Petersen wrote: From: Jan Arne Petersen There are some penfing input method support patches. I rebased them on master. * Add pre-edit styling support to the text protocol and the keyboard and editor examples. The editor example client depends on pango (for text la

Re: [PATCH v2 1/3] text: Add content type support to text protocol

2012-12-10 Thread Pekka Vuorela
On 10.12.2012 12:19, Jan Arne Petersen wrote: From: Jan Arne Petersen --- a/protocol/text.xml +++ b/protocol/text.xml @@ -83,8 +83,58 @@ - + + +Content hint is a bitmask to allow to modify the behavior of the text input + + + Cor

Re: [PATCH 1/3] text: Add content type support to text protocol

2012-12-06 Thread Pekka Vuorela
On 04.12.2012 23:24, Jan Arne Petersen wrote: On 12/03/2012 09:26 PM, Pekka Vuorela wrote: On ma, 2012-12-03 at 15:15 +0100, Jan Arne Petersen wrote: From: Jan Arne Petersen Support content types in text protocol. Content is defined by a hint bitmask and a purpose field. +++ b/protocol

Re: [PATCH 1/5] text: add pre-edit styling support to protocol

2012-12-04 Thread Pekka Vuorela
On 30.11.2012 18:01, Jan Arne Petersen wrote: From: Jan Arne Petersen Also add a separate preedit-cursor event and add a commit argument to preedit-string to allow to support commit on reset. Fix editor and keyboard example to adapt to the protocol changes. [...] diff --git a/protocol/text.xm

Re: [PATCH 2/3] editor: add support for invoke_action

2012-12-04 Thread Pekka Vuorela
On 04.12.2012 00:10, Jan Arne Petersen wrote: From: Jan Arne Petersen Call invoke_action request when a currently composed word is clicked. Signed-off-by: Jan Arne Petersen --- clients/editor.c | 52 +--- 1 file changed, 41 insertions(+), 11

Re: [PATCH 1/3] text: Add content type support to text protocol

2012-12-03 Thread Pekka Vuorela
On ma, 2012-12-03 at 15:15 +0100, Jan Arne Petersen wrote: > From: Jan Arne Petersen > > Support content types in text protocol. Content is defined by a hint > bitmask and a purpose field. > +++ b/protocol/text.xml > @@ -83,8 +83,42 @@ > > > > - > - > + > + > +

Re: [PATCH weston 1/2] window: Only set menu element when menu widget is focused

2012-10-19 Thread Pekka Vuorela
2012/10/19 Jonas Ådahl : > Motion handlers are called for either grabbed or focused widgets. If a > menu is displayed, thus grabbed, motion events relative to the parent > surface are delivered to the menu widget motion handler even though it > is not in focus. By checking that the menu widget is t

Re: Comments on Weston's text interface

2012-10-15 Thread Pekka Vuorela
On ma, 2012-10-15 at 15:30 +0200, Jan Arne Petersen wrote: > Hi, > > On 10/02/2012 10:29 PM, Pekka Vuorela wrote: > > As mentioned earlier, I've been checking out a bit how the input method > > interface "text" has been proceeding in Weston. Nice stuff on the

Re: [PATCH weston 1/2] Clip pointer input to menu surface.

2012-10-07 Thread Pekka Vuorela
On su, 2012-10-07 at 15:12 -0600, Scott Moreau wrote: > > > On Sun, Oct 7, 2012 at 12:21 PM, Pekka Vuorela > wrote: > On su, 2012-10-07 at 04:28 -0600, Scott Moreau wrote: > > Don't send motion events to the surface when the pointer is &

Re: [PATCH weston 1/2] Clip pointer input to menu surface.

2012-10-07 Thread Pekka Vuorela
On su, 2012-10-07 at 04:28 -0600, Scott Moreau wrote: > Don't send motion events to the surface when the pointer is not over the menu. > This was also causing items to be selected when clicking outside of the menu. Wouldn't it be quite a lousy grab if only events on top of the grabbing window woul

Comments on Weston's text interface

2012-10-02 Thread Pekka Vuorela
Hi guys, As mentioned earlier, I've been checking out a bit how the input method interface "text" has been proceeding in Weston. Nice stuff on the editor and virtual keyboard apps. Based on those, I came up with bunch of questions, suggestions and comments. First, how does this and normal hardwar

[PATCH web] Remove obsolete build flag for drm

2012-09-26 Thread Pekka Vuorela
--enable-nouveau-experimental-api been long gone. --- building.html |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/building.html b/building.html index b5884a7..e8e1e39 100644 --- a/building.html +++ b/building.html @@ -78,7 +78,7 @@ dependencies are development packages of

[PATCH weston] Require mouse release on top of frame button to trigger action

2012-09-26 Thread Pekka Vuorela
As common UI convention, allows action to be avoided by dragging outside the button after mouse press. --- clients/window.c | 32 1 file changed, 32 insertions(+) diff --git a/clients/window.c b/clients/window.c index c5bccdc..f3b61de 100644 --- a/clients/window

[PATCH weston 4/4] Protect window callbacks from deleted windows

2012-09-17 Thread Pekka Vuorela
Calling window_destroy() was able to cause segfault for callbacks triggering afterwards. --- clients/window.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/clients/window.c b/clients/window.c index 330d96f..c5bccdc 100644 --- a/clients/window.c +++ b/clients

[PATCH weston 3/4] PDF viewer to run until and only when it has existing windows

2012-09-17 Thread Pekka Vuorela
I.e. not to close whole application when one of the windows is closed. --- clients/view.c | 29 ++--- 1 file changed, 26 insertions(+), 3 deletions(-) diff --git a/clients/view.c b/clients/view.c index 8ecce8a..1bb9b9b 100644 --- a/clients/view.c +++ b/clients/view.c @@

[PATCH weston 2/4] Fix memory leak in PDF viewer

2012-09-17 Thread Pekka Vuorela
--- clients/view.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/clients/view.c b/clients/view.c index 394cc8a..8ecce8a 100644 --- a/clients/view.c +++ b/clients/view.c @@ -220,7 +220,7 @@ view_create(struct display *display, file = g_file_new_for_commandline_

[PATCH weston 1/4] Fix PDF viewer not to produce garbage windows for nonexistent files

2012-09-17 Thread Pekka Vuorela
Was calling window_flush() on redraw handler which already happens on window redrawing. --- clients/view.c |1 - 1 file changed, 1 deletion(-) diff --git a/clients/view.c b/clients/view.c index b40a992..394cc8a 100644 --- a/clients/view.c +++ b/clients/view.c @@ -78,7 +78,6 @@ redraw_handler(