Re: Compiling Weston with musl-libc (WAS: [PATCH weston] weston-launch: use custom error function)

On 30 September 2016 at 12:59, Eric Engestrom wrote: > On Fri, Sep 30, 2016 at 11:36:24AM +0100, Murray Calavera wrote: > > On 30 September 2016 at 11:10, Eric Engestrom > > > wrote: > > > > > On Thu, Sep 29, 2016 at 09:26:16PM +0100, Murray Calavera wrote: &

Re: [PATCH weston] weston-launch: use custom error function

On 30 September 2016 at 11:10, Eric Engestrom wrote: > On Thu, Sep 29, 2016 at 09:26:16PM +0100, Murray Calavera wrote: > > error.h is a gnu extension and not available in other > > popular libcs like musl. This patch provides a replacement. > > > > Signed-off-by: M

[PATCH weston] weston-launch: use custom error function

error.h is a gnu extension and not available in other popular libcs like musl. This patch provides a replacement. Signed-off-by: Murray Calavera --- libweston/weston-launch.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/libweston/weston-launch.c b

[PATCH weston] configure: remove double equal test bashism

Signed-off-by: Murray Calavera --- configure.ac | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index f35e887..72715a6 100644 --- a/configure.ac +++ b/configure.ac @@ -440,10 +440,10 @@ AS_IF([test "x$enable_resize_optimization&quo

Re: [wayland] client: remove duplicate wl_event_queue_init

I can't read, ignore this. Sorry. On 13/09/2016, Murray Calavera wrote: > Signed-off-by: Murray Calavera > --- > src/wayland-client.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/wayland-client.c b/src/wayland-client.c > index 03c087a..c995a09 100644 &g

[wayland] client: remove duplicate wl_event_queue_init

Signed-off-by: Murray Calavera --- src/wayland-client.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/wayland-client.c b/src/wayland-client.c index 03c087a..c995a09 100644 --- a/src/wayland-client.c +++ b/src/wayland-client.c @@ -932,7 +932,6 @@ wl_display_connect_to_fd(int fd

[PATCH weston] clients: fix incorrect format handling in simple-shm

the `shm_format` function seems to assume the `wl_shm_format` enum has bit-exclusive enumerations which is not true. Signed-off-by: Murray Calavera --- clients/simple-shm.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/clients/simple-shm.c b/clients/simple-shm.c

Re: [PATCH weston 1/2] text backend should handle existing seats on init.

​Hello, New patches are here: http://patchwork.freedesktop.org/patch/51584 http://patchwork.freedesktop.org/patch/51585​ >​ What was the crash exactly? The crash​ happens because the seat is assigned an input method as soon as the text backend is initialized. So If you try to call text_input_a

[PATCH weston 2/2] move text_backend initialization into the shell plugin

Whether a input method is used should be the responsibility of the shell because some shells may not want to implement an input method at all Signed-off-by: Murray Calavera Reviewed-by: Pekka Paalanen --- desktop-shell/shell.c | 3 +++ ivi-shell/ivi-shell.c | 3 +++ src/compositor.c | 2

[PATCH weston 1/2] text: handle existing seats on init

a following patch will be moving text init call into shell modules, which will be called much later than in current code Signed-off-by: Murray Calavera --- src/text-backend.c | 27 ++- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/src/text-backend.c b

Re: [PATCH weston] Add config option to disable input method

Hello again. I tried again, thanks for being so patient with me. Here are the patches: http://patchwork.freedesktop.org/patch/51464/ http://patchwork.freedesktop.org/patch/51465/ And the optional one: http://patchwork.freedesktop.org/patch/51466/ > This is all just Weston-specifics anyway, right

[PATCH weston] cleanup text backend style

Signed-off-by: Murray Calavera --- src/text-backend.c | 157 + 1 file changed, 98 insertions(+), 59 deletions(-) diff --git a/src/text-backend.c b/src/text-backend.c index 01cb70a..64a3c1b 100644 --- a/src/text-backend.c +++ b/src/text

[PATCH weston] don't attempt to start input method if path is empty

This allows a user to explicitly disable the input method by setting path to blank; Signed-off-by: Murray Calavera --- src/text-backend.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/text-backend.c b/src/text-backend.c index 64a3c1b..3c349d4 100644 --- a/src/text-backend.c +++ b

[PATCH weston 2/2] Move text_backend initialization into the shell plugin

Whether a input method is used should be the responsibility of the shell because some shells may not want to implement an input method at all. Signed-off-by: Murray Calavera --- desktop-shell/shell.c | 3 +++ ivi-shell/ivi-shell.c | 3 +++ src/compositor.c | 2 -- 3 files changed, 6

[PATCH weston 1/2] text backend should handle existing seats on init.

Currently the text backend will crash the compositor if seats have already been created. Signed-off-by: Murray Calavera --- src/text-backend.c | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/src/text-backend.c b/src/text-backend.c index

Re: [PATCH weston] Add config option to disable input method

> Rather than this new config option, I would be much happier seeing the > shell plugin directly indicating whether it supports input methods or > not. I'm not too sure about this, but I think the text backend has to be initialized first so I don't know how it can be launched or configured from th

[PATCH weston] Whitespace corrections

Signed-off-by: Murray Calavera --- clients/window.h | 4 ++-- shared/cairo-util.h | 2 +- src/compositor-x11.c | 2 +- src/libbacklight.c| 2 +- src/libbacklight.h| 2 +- src/weston-launch.c | 10 +- wcap/main.c | 2 +- wcap

[PATCH weston] Add config option to disable input method

When building a shell-plugin the developer might not want to implement an input method. Nevertheless weston will look for one, print errors complaining that the input method died and then give up. Signed-off-by: Murray Calavera --- man/weston.ini.man | 9 - src/compositor.c | 6