Re: [PATCH wayland] wayland-egl: rename wl_egl_window::private to driver_private

2017-12-13 Thread Miguel Angel Vico Moya
Ship it! Reviewed-by: Miguel A Vico Moya -- Miguel On Wed, Dec 13, 2017 at 4:05 AM -0800, "Emil Velikov" mailto:emil.l.veli...@gmail.com>> wrote: From: Emil Velikov private is a reserved keyword in C++. Thus if one is to have a backend driver written in said language build will fail as b

Re: [PATCH wayland v2 1/8] wayland-egl: import libwayland-egl.so frontend library from Mesa

2017-12-12 Thread Miguel Angel Vico
Hi, On Tue, 12 Dec 2017 20:58:30 +0100 Arnaud Vrac wrote: > Hi Emil, > > On Tue, Oct 10, 2017 at 3:43 PM, Emil Velikov > wrote: > > From: Emil Velikov > > > > Currently the client-facing libwayland-egl API is defined by a header > > file shipped by Wayland, but the implementation is left to

Re: [PATCH wayland v2 1/8] wayland-egl: import libwayland-egl.so frontend library from Mesa

2017-10-11 Thread Miguel Angel Vico
A straightforward addition. Reviewed-by: Miguel A Vico Moya On Tue, 10 Oct 2017 14:43:43 +0100 Emil Velikov wrote: > From: Emil Velikov > > Currently the client-facing libwayland-egl API is defined by a header > file shipped by Wayland, but the implementation is left to each vendor. > > Thi

Re: [PATCH wayland v2 4/8] wayland-egl: introduce wayland-egl-backend.pc

2017-10-11 Thread Miguel Angel Vico
Looks fine. Reviewed-by: Miguel A Vico Moya On Tue, 10 Oct 2017 14:43:46 +0100 Emil Velikov wrote: > From: Emil Velikov > > File will be installed alongside the backend header. > > This way vendor implementations have enough information about the > interface and they can build their backend

Re: XDC 2017 feedback

2017-09-27 Thread Miguel Angel Vico
Hi, In general, I think the organization was great. I agree having everything happen in a single room was a good point. Here's some of my personal feedback: * I didn't like the tables layout at all. I found it to be extremely uncomfortable to have to look sideways in order to see the screens

Re: [PATCH weston v2 1/1] compositor-drm: Unref current & pending fb when deactivating the session

2017-08-11 Thread Miguel Angel Vico
Indeed. Pekka's fix is equivalent. I missed that. Thank you. On Fri, 11 Aug 2017 10:06:28 +0100 Daniel Stone wrote: > Hi Miguel, > > On 11 August 2017 at 00:55, Miguel A. Vico wrote: > > we stopped forcing a modeset when restoring the session. The motivation > > was that we would use a stale

[ANNOUNCE] NVIDIA EGL External Platform interface and Wayland library release

2017-01-18 Thread Miguel Angel Vico
Hi all, Along with our 378.09 BETA driver release this morning, we have published our work-in-progress EGL External Platform interface source code. For a little bit of context, you can find my XDC 2016 talk about this at https://www.x.org/wiki/Events/XDC2016/Program/vico_egl_external_platform_

Re: How to handle DRM crtc_id, connector_id greater than 31

2016-12-07 Thread Miguel Angel Vico
On Wed, 7 Dec 2016 13:30:34 +0200 Pekka Paalanen wrote: > * PGP Signed by an unknown key > > On Tue, 6 Dec 2016 16:21:30 -0800 > Miguel Angel Vico wrote: > > > Hi Eric, > > > > The problem here is we are using crtc_id and connector_id as > > index

Re: How to handle DRM crtc_id, connector_id greater than 31

2016-12-06 Thread Miguel Angel Vico
Hi Eric, The problem here is we are using crtc_id and connector_id as indexes, while they aren't. Nothing keeps DRM drivers from advertising CRTC and connectors with ids that aren't sequential and starting at 0 or 1. The right fix is to use indexes instead of ids to update bitmasks. drm_output:

Re: [PATCH weston] simple-egl: Do not set EGL up until XDG setup is complete

2016-11-21 Thread Miguel Angel Vico
Well, I agree this fix would allow non-compliant implementations to keep misusing wl_surface.commit, and that could potentially remove any motivation to find an appropriate resolution for the bug below. I'm fine with deferring this patch, but I still think applications should not start setting EGL

Re: [PATCH weston v2 1/3] gl-renderer: Add EGLDevice enumeration support

2016-11-14 Thread Miguel Angel Vico
Thanks, Pekka. Inline. On Mon, 7 Nov 2016 16:22:49 +0200 Pekka Paalanen wrote: > * PGP Signed by an unknown key > > On Wed, 18 May 2016 17:51:36 +0200 > "Miguel A. Vico" wrote: > > > EGLDevice provides means to enumerate native devices. > > > > In preparation for follow-on changes to suppor

Re: [RFC wayland] Add wl_proxy destruction callbacks

2016-06-07 Thread Miguel Angel Vico
On Mon, 30 May 2016 17:44:58 +0200 Daniel Vetter wrote: > > Just a quick comment: I guess a piglit testcase to demonstrate the > failure (or well, just any minimal test) would be awesome. That way > folks can quickly figure out what all goes wrong without this. > -Daniel Sure. I'm going to be

Re: [RFC wayland] Add wl_proxy destruction callbacks

2016-06-07 Thread Miguel Angel Vico
Hi, Sorry for the slow response. Inline. On Tue, 31 May 2016 11:18:25 +0300 Pekka Paalanen wrote: > * PGP Signed by an unknown key > > On Mon, 30 May 2016 13:10:42 +0200 > Miguel Angel Vico wrote: > > > Hi all, > > > > A few days ago, I had a litt

[RFC wayland] Add wl_proxy destruction callbacks

2016-05-30 Thread Miguel Angel Vico
Hi all, A few days ago, I had a little chat over IRC with Pekka about addition of proxy objects destruction callbacks to the wayland client protocol. Summing up, we recently ran into some applications where native objects (wl_surface, wl_egl_window, wl_display) used by EGL are destroyed/made inv

Re: [PATCH weston 1/5] gl-renderer: Rename gl_renderer_create to gl_renderer_display_create

2016-05-18 Thread Miguel Angel Vico
Thank you all for your clarifications. I'm about to send updated revisions of all patches. I made a rebase and fixed all indentation/alignment issues across all patches. Thanks. On Wed, 18 May 2016 15:31:32 +0100 Daniel Stone wrote: > Hi, > > On 18 May 2016 at 15:25, Derek Foreman wrote: > >

Re: [PATCH weston 1/5] gl-renderer: Rename gl_renderer_create to gl_renderer_display_create

2016-05-12 Thread Miguel Angel Vico
Thanks Derek. Inline. On Thu, 12 May 2016 08:54:26 -0500 Derek Foreman wrote: > On 11/05/16 10:53 AM, Miguel Angel Vico wrote: > > Thanks, Yong. > > > > Inline. > > > > On Wed, 11 May 2016 09:45:15 -0500 > > Yong Bakos wrote: > > >

Re: [PATCH weston 0/5] gl-renderer: Renaming of things and minor improvements

2016-05-11 Thread Miguel Angel Vico
Hi Bryce, It's fine to defer these patches to next release. Thanks for the heads-up. Miguel. On Wed, 11 May 2016 11:23:17 -0700 Bryce Harrington wrote: > On Wed, May 11, 2016 at 02:48:13PM +0200, Miguel A. Vico wrote: > > Hi, > > > > Feedback for the first revision has been addressed. Here i

Re: [PATCH weston 1/5] gl-renderer: Rename gl_renderer_create to gl_renderer_display_create

2016-05-11 Thread Miguel Angel Vico
Thanks, Yong. Inline. On Wed, 11 May 2016 09:45:15 -0500 Yong Bakos wrote: > On May 11, 2016, at 7:48 AM, Miguel A. Vico > wrote: > > > > No functional change. This patch only renames gl_renderer_create() > > to gl_renderer_display_create(), which is something more > > descriptive of what the

Re: Introduction and updates from NVIDIA

2016-05-11 Thread Miguel Angel Vico
ou have doubts or suggestions about the patches. I'm also available on Freenode IRC as 'mvicomoya'. Thanks, Miguel. On Mon, 21 Mar 2016 17:28:13 +0100 Miguel Angel Vico wrote: > Hi all, > > First of all, I'd like to introduce myself to the Wayland community: > My

Re: Request for review of EGL_WL_wayland_eglstream extension

2016-05-02 Thread Miguel Angel Vico
Sorry, I forgot to explicitly add Daniel Stone, as this is directly addressing one of his concerns. Thanks. On Mon, 2 May 2016 12:59:05 +0200 Miguel Angel Vico wrote: > Hi guys, > > As most of you already know, we've been lately working on adding > Wayland support to our

Request for review of EGL_WL_wayland_eglstream extension

2016-05-02 Thread Miguel Angel Vico
Hi guys, As most of you already know, we've been lately working on adding Wayland support to our drivers by using EGLStreams and friends. As part of that effort, I've been working through the feedback I got from you last time. In order to address one of Daniel Stone's concerns about modifying cu

Re: Introduction and updates from NVIDIA

2016-04-06 Thread Miguel Angel Vico
On Wed, 6 Apr 2016 13:14:26 +0100 Daniel Stone wrote: > Hi, > > On 6 April 2016 at 09:41, Jonas Ã…dahl wrote: > > On Mon, Apr 04, 2016 at 04:27:56PM +0100, Daniel Stone wrote: > >> Again this comes down to the synchronisation. In this case, > >> assuming a mailbox stream: > >> - wl_egl_sur

Re: Introduction and updates from NVIDIA

2016-04-02 Thread Miguel Angel Vico
for the thorough responses, Daniel. > > > > No problem; as I said, I'm actually really happy to see an > > implementation out there. > > > > > On Tue, Mar 22, 2016 at 01:49:59PM +0000, Daniel Stone wrote: > > >> On 21 March 2016 at 16:28, Miguel Angel

Re: [PATCH 7/7] compositor-drm: Add support for EGLDevice+EGLOutput

2016-03-22 Thread Miguel Angel Vico
Hi Daniel, On Tue, 22 Mar 2016 11:20:47 + Daniel Stone wrote: > Hi, > > On 21 March 2016 at 16:41, Miguel A. Vico > wrote: > > As previously stated, EGLDevice and EGLOutput will provide means > > to access native device objects and different portions of display > > control hardware respect

Re: [PATCH 5/7] compositor-drm: Gracefully handle vblank and flip invalid timestamps

2016-03-22 Thread Miguel Angel Vico
Hi, On Tue, 22 Mar 2016 09:30:51 + Daniel Stone wrote: > Hi, > > On 22 March 2016 at 08:50, Daniel Vetter wrote: > > On Tue, Mar 22, 2016 at 08:47:12AM +, Daniel Stone wrote: > >> This is odd. Instant queries failing is fine, but in which > >> circumstances can you fail to return a v

Re: [PATCH 4/7] gl-renderer: Add support for EGLDevice+EGLOutput

2016-03-22 Thread Miguel Angel Vico
Hi Daniel, On Tue, 22 Mar 2016 10:53:38 + Daniel Stone wrote: > Hi Miguel, > > On 21 March 2016 at 16:37, Miguel A. Vico > wrote: > > EGLDevice provides means to enumerate native devices, and then > > create an EGL display connection from them. > > > > Similarly, EGLOutput will provide mea

Re: [PATCH 2/7] gl-renderer: Refactor gl_renderer_output_window_create()

2016-03-22 Thread Miguel Angel Vico
Hi Daniel, On Tue, 22 Mar 2016 09:02:55 + Daniel Stone wrote: > Hi Miguel, > > On 21 March 2016 at 16:37, Miguel A. Vico > wrote: > > + egl_surface = gl_renderer_create_window_surface(gr, > > + > > window_for_legacy, > > + > > window_for_platform, > > + > > config_attribs, > > +

Re: [PATCH 1/7] gl-renderer: Renaming of things and minor improvements

2016-03-22 Thread Miguel Angel Vico
Hi Daniel, On Tue, 22 Mar 2016 09:06:25 + Daniel Stone wrote: > Hi Miguel, > > On 21 March 2016 at 16:37, Miguel A. Vico > wrote: > > In preparation for follow-on changes to support frame presentation > > through EGLDevice+EGLOutput, this change includes the following: > > -Rename gl_ren

Introduction and updates from NVIDIA

2016-03-21 Thread Miguel Angel Vico
Hi all, First of all, I'd like to introduce myself to the Wayland community: My name is Miguel A. Vico, and I've been working as a Software Engineer for NVIDIA for some time now, more specifically, in the Linux drivers team. Although I've never spoken before, I've been lately following the amazing