Re: [PATCH v2] clients: teach simple-dmabuf-v4l to deal with flipped input

Thanks, -mf On 02/07/2017 08:17 PM, Bryce Harrington wrote: On Tue, Feb 07, 2017 at 11:48:47AM +0200, Pekka Paalanen wrote: On Mon, 6 Feb 2017 12:57:41 -0500 Micah Fedke wrote: The v4l2 API can be queried to detect if the input video image is horizontally or vertically flipped. If the image is

[PATCH 4/4] tests: add transform and scale tests

These tests check all combinations of wl_surface::set_buffer_transform and wl_surface::set_buffer_scale --- Makefile.am| 7 +- tests/reference/transform_and_scale-01.png | Bin 0 -> 4133 bytes tests/reference/transform_and_scale-02.png | Bin 0 -> 2731 bytes tests

[PATCH 2/4] tests: promote subsurface-shot-test's write_visual_diff() to a utility function

This function writes out a png file containing the visual diff between a reference image and a screenshot. --- tests/subsurface-shot-test.c | 24 - tests/weston-test-client-helper.c | 44 +++ tests/weston-test-client-helper.h | 5 +

[PATCH 1/4] tests: add a blank reference png for test development

This png can be used as a reference image (diff will fail, of course) for a new test until an appropriate reference image can be generated. --- tests/reference/blank.png | Bin 0 -> 624 bytes 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 tests/reference/blank.png diff --git

[PATCH 3/4] tests: promote subsurface-shot-tests's check_screen() to a utility function

This function takes a screenshot of a provided client, compares it to a reference image, outputs the result as a PNG, and returns a value indicating whether the two images matched or not. A difference image is generated if the screenshot and reference do not match. --- tests/subsurface-shot-test.

[PATCH 0/4] Add transform and scale tests

hough. Micah Fedke (4): tests: add a blank reference png for test development tests: promote subsurface-shot-test's write_visual_diff() to a utility function tests: promote subsurface-shot-tests's check_screen() to a utility function tests: add transform and scale test

[PATCH] testing: add section about debugging individual tests with gdb

--- testing.html | 18 ++ 1 file changed, 18 insertions(+) diff --git a/testing.html b/testing.html index e5781fe..c005df1 100644 --- a/testing.html +++ b/testing.html @@ -184,4 +184,22 @@ way to learn how to leverage these API's is to study some of the existing tests (e.g. test

[PATCH v2] clients: teach simple-dmabuf-v4l to deal with flipped input

linux_buffer_params_v1 does not support horizontal flipping. Signed-off-by: Micah Fedke --- This version addresses Pekka's comments by renaming check_v4l2_control to check_v4l2_control_bool, removing the len parameter, separating out the logic tests in check_v4l2_control_bool and fixing spacing issues. cl

[PATCH 0/2] fix remaining y-invert issues

pi to detect whether its incoming video stream is flipped, and communicate this to the compositor via linux_buffer_params_v1. Currently it only uses the ZWP_LINUX_BUFFER_PARAMS_V1_FLAGS_Y_INVERT, as there is no flag for horizontal inversion. Micah Fedke (2): compositor-drm: don't put

[PATCH 1/2] compositor-drm: don't put y-inverted / interlaced / bottom-first dmabufs on overlays

This patch checks the attribute flags on incoming dmabufs and refuses to put them overlays if they have any of the flags set (currently: ZWP_LINUX_BUFFER_PARAMS_V1_FLAGS_Y_INVERT, ZWP_LINUX_BUFFER_PARAMS_V1_FLAGS_INTERLACED and ZWP_LINUX_BUFFER_PARAMS_V1_FLAGS_BOTTOM_FIRST), instead defaulting to t

[PATCH 2/2] clients: teach simple-dmabuf-v4l to deal with flipped input

The v4l2 API can be queried to detect if the input video image is horizontally or vertically flipped. If the image is y-flipped, we can set the ZWP_LINUX_BUFFER_PARAMS_V1_FLAGS_Y_INVERT flag to notify the compositor. If the image is h-flipped, we can only print a warning since linux_buffer_params_

Re: [PATCH weston 7/7] compositor: damage pending subsurfaces when committing them

t note that there may be some room for future optimization in the subsurface damage code above. This, and the rest of the series, Reviewed-by: Micah Fedke -- Micah Fedke Collabora Ltd. +44 1223 362967 https://www.collabora.com/ https://twitter.com/collaboraltd