[PATCH] client: Fix source comment typos

2012-10-20 Thread Martin Olsson
--- src/wayland-client.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/wayland-client.c b/src/wayland-client.c index 7e50b40..28fe127 100644 --- a/src/wayland-client.c +++ b/src/wayland-client.c @@ -732,7 +732,7 @@ dispatch_event(struct wl_display *display, str

[PATCH] Fix spelling errors

2012-09-29 Thread Martin Olsson
--- clients/eventdemo.c |4 ++-- protocol/text.xml|2 +- src/compositor-drm.c |2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/clients/eventdemo.c b/clients/eventdemo.c index 569a8c1..e59b076 100644 --- a/clients/eventdemo.c +++ b/clients/eventdemo.c @@ -210,7

[PATCH] Fixup source comment in wayland-util.h and fix typo in TODO

2012-07-09 Thread Martin Olsson
--- TODO |2 +- src/wayland-util.h |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/TODO b/TODO index b0c4fb3..677782d 100644 --- a/TODO +++ b/TODO @@ -19,7 +19,7 @@ Core wayland protocol bigger atomic change. To be researched a bit. - Maybe tr

[PATCH] doc: fix some typos in documentation

2012-07-09 Thread Martin Olsson
--- doc/Wayland/en_US/Protocol.xml |4 ++-- protocol/wayland.xml |4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/Wayland/en_US/Protocol.xml b/doc/Wayland/en_US/Protocol.xml index 09ed2ba..9a7db53 100644 --- a/doc/Wayland/en_US/Protocol.xml +++ b/doc/Wa

Re: [PATCH 4/5] server: Don't crash for wl_seat_set_touch(seat, NULL)

2012-07-09 Thread Martin Olsson
Pekka already sent a (still unmerged) patch for this on the 5th of July, subject: [PATCH wayland 2/2] server: fix wl_seat_set_{keyboard,touch} So probably just drop my patch. M On 07/09/2012 11:35 AM, Martin Olsson wrote: --- src/wayland-server.c |2 +- 1 file changed, 1 insertion

[PATCH 5/5] shm: Plug leak in shm_create_pool()

2012-07-09 Thread Martin Olsson
--- src/wayland-shm.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/src/wayland-shm.c b/src/wayland-shm.c index 62afc3b..7565623 100644 --- a/src/wayland-shm.c +++ b/src/wayland-shm.c @@ -188,29 +188,27 @@ shm_create_pool(struct wl_client *client, struct wl

[PATCH 3/5] scanner: Plug memory leak in end_element()

2012-07-09 Thread Martin Olsson
--- src/scanner.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/scanner.c b/src/scanner.c index 4d4537c..0076d92 100644 --- a/src/scanner.c +++ b/src/scanner.c @@ -462,7 +462,7 @@ end_element(void *data, const XML_Char *name) char *text = strndup(ctx->c

[PATCH 0/5] a few cppcheck static analysis fixes

2012-07-09 Thread Martin Olsson
Martin Olsson (5): Add cscope.out to .gitignore wayland-cursor: Add error handling for shm_pool_create() scanner: Plug memory leak in end_element() server: Don't crash for wl_seat_set_touch(seat, NULL) shm: Plug leak in shm_create_pool() .gitignore |1 + cursor/wa

[PATCH 2/5] wayland-cursor: Add error handling for shm_pool_create()

2012-07-09 Thread Martin Olsson
--- cursor/wayland-cursor.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/cursor/wayland-cursor.c b/cursor/wayland-cursor.c index 7621020..36a8b54 100644 --- a/cursor/wayland-cursor.c +++ b/cursor/wayland-cursor.c @@ -49,27 +49,29 @@ shm_pool_create(st

[PATCH 4/5] server: Don't crash for wl_seat_set_touch(seat, NULL)

2012-07-09 Thread Martin Olsson
--- src/wayland-server.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wayland-server.c b/src/wayland-server.c index d141682..9f9d6b3 100644 --- a/src/wayland-server.c +++ b/src/wayland-server.c @@ -759,7 +759,7 @@ wl_seat_set_touch(struct wl_seat *seat, struct wl_touc

[PATCH 1/5] Add cscope.out to .gitignore

2012-07-09 Thread Martin Olsson
--- .gitignore |1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 904eb50..a33c7fa 100644 --- a/.gitignore +++ b/.gitignore @@ -27,3 +27,4 @@ /stamp-h1 Makefile Makefile.in +cscope.out -- 1.7.9.5 ___ wayland-devel m

Re: [PATCH] clients: Free resources on exit in eventdemo

2012-07-08 Thread Martin Olsson
On 07/08/2012 03:09 PM, Pekka Paalanen wrote: Looks good to me now, I assume you tested this program exits properly. Btw. have you tried Valgrind on these? Yes I tried it; FWIW with the new call to display_destroy the eventdemo app now hits invalid read, invalid write and finally an assert. H

[PATCH] clients: Silence 2x gcc 4.6.3 "warn_unused_result" compiler warnings

2012-07-08 Thread Martin Olsson
window.c:1173:6: warning: ignoring return value of ‘read’, declared with attribute warn_unused_result [-Wunused-result] desktop-shell.c:305:6: warning: ignoring return value of ‘read’, declared with attribute warn_unused_result [-Wunused-result] --- clients/desktop-shell.c |3 ++- clients/wi

[PATCH] clients: Free resources on exit in eventdemo

2012-07-08 Thread Martin Olsson
--- clients/eventdemo.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/clients/eventdemo.c b/clients/eventdemo.c index daf3283..22dade3 100644 --- a/clients/eventdemo.c +++ b/clients/eventdemo.c @@ -261,6 +261,7 @@ motion_handler(struct widget *widget, struct input *input,

[PATCH] clients: Add clients/weston-screensaver to clients/.gitignore

2012-07-08 Thread Martin Olsson
--- clients/.gitignore |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clients/.gitignore b/clients/.gitignore index fe50580..2506d3a 100644 --- a/clients/.gitignore +++ b/clients/.gitignore @@ -23,7 +23,7 @@ weston-desktop-shell weston-tablet-shell weston-screenshooter w

[PATCH 03/10] clients: Don't leak "menu" on error path in clients/window.c

2012-07-07 Thread Martin Olsson
--- clients/window.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/clients/window.c b/clients/window.c index 8f3c942..f81d06f 100644 --- a/clients/window.c +++ b/clients/window.c @@ -3133,8 +3133,10 @@ window_show_menu(struct display *display, return;

[PATCH 04/10] shared: Don't leak file descriptor in shared/image-loader.c

2012-07-07 Thread Martin Olsson
--- shared/image-loader.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/shared/image-loader.c b/shared/image-loader.c index a3218df..b47c1a7 100644 --- a/shared/image-loader.c +++ b/shared/image-loader.c @@ -359,8 +359,10 @@ load_image(const char *filename) if (

[PATCH 10/10] clients: Silence 2x gcc 4.6.3 "warn_unused_result" compiler warnings

2012-07-07 Thread Martin Olsson
window.c:1173:6: warning: ignoring return value of ‘read’, declared with attribute warn_unused_result [-Wunused-result] desktop-shell.c:305:6: warning: ignoring return value of ‘read’, declared with attribute warn_unused_result [-Wunused-result] --- clients/desktop-shell.c |3 ++- clients/wi

[PATCH 05/10] compositor-android: Add proper error handling in android_compositor_create()

2012-07-07 Thread Martin Olsson
--- src/compositor-android.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/src/compositor-android.c b/src/compositor-android.c index 54cfa2e..98956f6 100644 --- a/src/compositor-android.c +++ b/src/compositor-android.c @@ -419,31 +419,39 @@ android_c

[PATCH 00/10] fix cppcheck and compiler warnings

2012-07-07 Thread Martin Olsson
These patches silence some issues found by the cppcheck static analyzer, and it also fixes two compiler warnings. Martin Olsson (10): clients: Add clients/weston-screensaver to clients/.gitignore clients: Free resources on exit in eventdemo clients: Don't leak "menu" o

[PATCH 06/10] compositor-wayland: Add error handling in wayland_compositor_create()

2012-07-07 Thread Martin Olsson
--- src/compositor-wayland.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c index ea09730..9df7228 100644 --- a/src/compositor-wayland.c +++ b/src/compositor-wayland.c @@ -847,16 +847,16 @@ wayland_c

[PATCH 01/10] clients: Add clients/weston-screensaver to clients/.gitignore

2012-07-07 Thread Martin Olsson
--- clients/.gitignore |1 + 1 file changed, 1 insertion(+) diff --git a/clients/.gitignore b/clients/.gitignore index fe50580..b43992b 100644 --- a/clients/.gitignore +++ b/clients/.gitignore @@ -23,6 +23,7 @@ weston-desktop-shell weston-tablet-shell weston-screenshooter weston-terminal +

[PATCH 09/10] wcap: Plug memory leak in wcap_decoder_create()

2012-07-07 Thread Martin Olsson
--- wcap/wcap-decode.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/wcap/wcap-decode.c b/wcap/wcap-decode.c index 425ccff..3dc7e6d 100644 --- a/wcap/wcap-decode.c +++ b/wcap/wcap-decode.c @@ -120,8 +120,10 @@ wcap_decoder_create(const char *filename) re

[PATCH 07/10] compositor-x11: Add error handling in x11_compositor_create()

2012-07-07 Thread Martin Olsson
--- src/compositor-x11.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/src/compositor-x11.c b/src/compositor-x11.c index 5afaa7a..f2f0cb1 100644 --- a/src/compositor-x11.c +++ b/src/compositor-x11.c @@ -1064,17 +1064,17 @@ x11_compositor_create(str

[PATCH 02/10] clients: Free resources on exit in eventdemo

2012-07-07 Thread Martin Olsson
--- clients/eventdemo.c | 13 + 1 file changed, 13 insertions(+) diff --git a/clients/eventdemo.c b/clients/eventdemo.c index daf3283..bc066be 100644 --- a/clients/eventdemo.c +++ b/clients/eventdemo.c @@ -261,6 +261,7 @@ motion_handler(struct widget *widget, struct input *input, u

[PATCH 08/10] xwayland: Don't leak fd while reading lock file in src/xwayland/launcher.c

2012-07-07 Thread Martin Olsson
--- src/xwayland/launcher.c |1 + 1 file changed, 1 insertion(+) diff --git a/src/xwayland/launcher.c b/src/xwayland/launcher.c index 0184c08..035c8e3 100644 --- a/src/xwayland/launcher.c +++ b/src/xwayland/launcher.c @@ -274,6 +274,7 @@ create_lockfile(int display, char *lockfile, size_t lsi