Re: [PATCH] xdg-foreign-v2: Fix various documentation issues from the API change

2017-10-10 Thread Marco Martin
sorry i'm insisting on this.. what is still needed for those? can then be pushed? -- Marco Martin On Mon, Oct 2, 2017 at 2:55 PM, Marco Martin wrote: > ping? shouldn't the 3 patches in total be pushed now? > > -- > Marco Martin > > On Tue, Sep 26, 2017 at 3:53 P

Re: [PATCH] xdg-foreign-v2: Fix various documentation issues from the API change

2017-10-02 Thread Marco Martin
ping? shouldn't the 3 patches in total be pushed now? -- Marco Martin On Tue, Sep 26, 2017 at 3:53 PM, Jonas Ådahl wrote: > It stilled referred to the removed requests, so change those places to > refer to the renamed ones. > > While at it, also change documentation to

Re: [PATCH] xdg-foreign-v2: Fix various documentation issues from the API change

2017-09-26 Thread Marco Martin
Changes look fine to me, in the end my patches would be pushed as is and then this one pushed on top, right? -- Marco Martin On Tue, Sep 26, 2017 at 3:53 PM, Jonas Ådahl wrote: > It stilled referred to the removed requests, so change those places to > refer to the renamed ones. > >

Re: [PATCH 2/2] foreignv2: rename export and import calls

2017-09-26 Thread Marco Martin
ping? On Mon, Sep 18, 2017 at 2:09 PM, Marco Martin wrote: > as export is a reserved keyword in C++, in order for the > output generated by wayland_scanner to compile correctly > rename export to export_toplevel and import to import_toplevel > this needs a new protocol vers

Re: [PATCH wayland-protocols v2] Introduce xdg-foreign protocol

2017-09-18 Thread Marco Martin
ok, i tried to split the patch and send them with git send-email -- Marco Martin On Thu, Sep 14, 2017 at 11:54 AM, Jonas Ådahl wrote: > On Tue, Sep 12, 2017 at 08:44:39PM +0200, Marco Martin wrote: >> On Tue, Aug 22, 2017 at 6:07 PM, Marco Martin wrote: >> >> You'll n

[PATCH 1/2] add a new version of the foreign protocol

2017-09-18 Thread Marco Martin
some methods will be renamed, so we need a new, not retrocompatible protocol --- Makefile.am | 1 + unstable/xdg-foreign/xdg-foreign-unstable-v2.xml | 182 +++ 2 files changed, 183 insertions(+) create mode 100644 unstable/xdg-foreign/xdg

[PATCH 2/2] foreignv2: rename export and import calls

2017-09-18 Thread Marco Martin
as export is a reserved keyword in C++, in order for the output generated by wayland_scanner to compile correctly rename export to export_toplevel and import to import_toplevel this needs a new protocol version as is an incompatible change Signed-off-by: Marco Martin --- unstable/xdg-foreign

Re: [PATCH wayland-protocols v2] Introduce xdg-foreign protocol

2017-09-12 Thread Marco Martin
On Tue, Aug 22, 2017 at 6:07 PM, Marco Martin wrote: >> You'll need to create an "unstable v2" version, as this is a >> non-backward compatible change. To do that, copy the XML file, changing > > attached a patch that adds the new v2 file, comments adressed ping

Re: [PATCH wayland-protocols v2] Introduce xdg-foreign protocol

2017-08-22 Thread Marco Martin
On Monday 21 August 2017 10:49:55 Jonas Ådahl wrote: > On Thu, Aug 17, 2017 at 05:05:35PM +0200, Marco Martin wrote: > > On Thu, Aug 10, 2017 at 3:47 AM, Jonas Ådahl wrote: > > > Anyhow, "export_surface" or maybe even "export_toplevel" (as that is the >

Re: [PATCH wayland-protocols v2] Introduce xdg-foreign protocol

2017-08-17 Thread Marco Martin
tly replacing the old relationships or sending protocol errors?) -- Marco Martin ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH wayland-protocols v2] Introduce xdg-foreign protocol

2017-08-17 Thread Marco Martin
ell then. here attached a patch to rename the calls to export_toplevel and import_toplevel, is that ok? -- Marco Martin From 79a050a0a22cb9f04d7679fe2fcd28e797e6957c Mon Sep 17 00:00:00 2001 From: Marco Martin Date: Thu, 17 Aug 2017 16:58:33 +0200 Subject: [PATCH] rename export and import calls

Re: [PATCH wayland-protocols v2] Introduce xdg-foreign protocol

2017-08-10 Thread Marco Martin
On Thu, Aug 10, 2017 at 3:47 AM, Jonas Ådahl wrote: > On Wed, Aug 09, 2017 at 01:42:51PM +0200, Marco Martin wrote: >> On Wednesday 27 July 2016 15:54:58 Jonas Ĺdahl wrote: >> > xdg-foreign is a protocol meant to enable setting up inter surface >> > relationships ac

Re: [PATCH wayland-protocols v2] Introduce xdg-foreign protocol

2017-08-09 Thread Marco Martin
med to something else, even just a bit more redundant as export_surface which would be safer as compilers are concerned? -- Marco Martin ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel