[PATCH][weston] animation: Fix potential leak of memory pointed to by move

2015-10-03 Thread Lucas Tanure
Free move before return if animation is null. Signed-off-by: Lucas Tanure --- src/animation.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/animation.c b/src/animation.c index cc7482d..2c7943f 100644 --- a/src/animation.c +++ b/src/animation.c @@ -471,8 +471,10

[PATCH][weston] ivi-layout-transition: Standardize the check for layout_transition_register

2015-09-30 Thread Lucas Tanure
Check the return from layout_transition_register in order to fix potential leak of memory pointed to by transition. And don't register a null transition. Signed-off-by: Lucas Tanure --- ivi-shell/ivi-layout-transition.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff

Re: [PATCH][weston 1/3] ivi-layout-transition: Fix potential leak of memory pointed to by transition

2015-09-23 Thread Lucas Tanure
On Wed, Sep 23, 2015 at 9:06 PM, Bryce Harrington wrote: > On Wed, Sep 23, 2015 at 10:33:21AM -0300, Lucas Tanure wrote: > > Free transition in ivi_layout_transition_fade_layer if we fail to > > allocate memory for data > > > > Signed-off-by: Lucas Tanure > > D

[PATCH][weston 3/3] ivi-layout-transition: Fix potential leak of memory pointed to by transition

2015-09-23 Thread Lucas Tanure
Destroy transition if layout_transition_register was not ok, we can't just free transition, we need to call layout_transition_destroy in order to free private_data from transition Signed-off-by: Lucas Tanure --- ivi-shell/ivi-layout-transition.c | 3 ++- 1 file changed, 2 insertions(

[PATCH][weston 1/3] ivi-layout-transition: Fix potential leak of memory pointed to by transition

2015-09-23 Thread Lucas Tanure
Free transition in ivi_layout_transition_fade_layer if we fail to allocate memory for data Signed-off-by: Lucas Tanure --- ivi-shell/ivi-layout-transition.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ivi-shell/ivi-layout-transition.c b/ivi-shell/ivi-layout-transition.c index 150e301

[PATCH][weston 2/3] ivi-layout-transition: Fix potential leak of memory pointed to by transition

2015-09-23 Thread Lucas Tanure
Check if transition is not null and if layout_transition_register was ok before return, if not, free transition Signed-off-by: Lucas Tanure --- ivi-shell/ivi-layout-transition.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ivi-shell/ivi-layout-transition.c b/ivi

Re: [PATCH][weston] ivi_layout_surface_add_notification: Fix potential leak of memory pointed to by 'notification'

2015-09-22 Thread Lucas Tanure
Ok. Thanks, I forgot that one. On Tue, Sep 22, 2015, 21:18 Bryce Harrington wrote: > On Tue, Sep 22, 2015 at 05:18:05PM -0700, Bryce Harrington wrote: > > On Sat, Sep 19, 2015 at 06:24:58PM -0300, Lucas Tanure wrote: > > > Signed-off-by: Lucas Tanure > > > >

Re: [PATCH][weston 1/2] ivi-layout-transition: Change layout_transition_register return type

2015-09-22 Thread Lucas Tanure
On Tue, Sep 22, 2015 at 6:38 PM, Bryce Harrington wrote: > On Tue, Sep 22, 2015 at 02:36:44PM -0700, Bryce Harrington wrote: > > On Mon, Sep 21, 2015 at 02:10:32PM -0300, Lucas Tanure wrote: > > > layout_transition_register could not work and we need to free trans in > >

[PATCH][weston 2/2] ivi-layout-transition: Fix potential leak of memory pointed to by transition

2015-09-21 Thread Lucas Tanure
Check if layout_transition_register worked, otherwise destroy transition Signed-off-by: Lucas Tanure --- ivi-shell/ivi-layout-transition.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ivi-shell/ivi-layout-transition.c b/ivi-shell/ivi-layout-transition.c index 8d477b4

[PATCH][weston 1/2] ivi-layout-transition: Change layout_transition_register return type

2015-09-21 Thread Lucas Tanure
layout_transition_register could not work and we need to free trans in the calling function. Signed-off-by: Lucas Tanure --- ivi-shell/ivi-layout-transition.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/ivi-shell/ivi-layout-transition.c b/ivi-shell/ivi-layout

[PATCH][weston, v2] ivi-layout-transition: Fix potential leak of memory pointed to by transition

2015-09-21 Thread Lucas Tanure
Free transition before return. We don't need to use layout_transition_destroy, because transition was not registered yet. v2: consolidate memory leaks fixes Signed-off-by: Lucas Tanure --- ivi-shell/ivi-layout-transition.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ivi-shel

[PATCH][weston] vaapi-recorder: Fix allocator sizeof operand mismatch

2015-09-20 Thread Lucas Tanure
Result of 'calloc' is converted to a pointer of type 'unsigned int', which is incompatible with sizeof operand type 'int' Signed-off-by: Lucas Tanure --- src/vaapi-recorder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vaapi-recorder.

[PATCH][weston] ivi-layout-transition: Fix potential leak of memory pointed to by 'transition'

2015-09-19 Thread Lucas Tanure
Free transition before return. We don't need to use layout_transition_destroy, because transition was not registered yet. Signed-off-by: Lucas Tanure --- ivi-shell/ivi-layout-transition.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ivi-shell/ivi-layout-transition.c b/ivi-shel

[PATCH][weston] ivi_layout_surface_add_notification: Fix potential leak of memory pointed to by 'notification'

2015-09-19 Thread Lucas Tanure
Signed-off-by: Lucas Tanure --- ivi-shell/ivi-layout.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ivi-shell/ivi-layout.c b/ivi-shell/ivi-layout.c index 24bd8dd..061f156 100644 --- a/ivi-shell/ivi-layout.c +++ b/ivi-shell/ivi-layout.c @@ -1532,6 +1532,7

[PATCH][weston] create_fade_view_transition: Fix potential leak of memory pointed to by 'transition'

2015-09-19 Thread Lucas Tanure
Free transition before return. We don't need to use layout_transition_destroy, because transition was not registered yet. Signed-off-by: Lucas Tanure --- ivi-shell/ivi-layout-transition.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ivi-shell/ivi-layout-transition.c b/ivi-shel

[PATCH][weston]ivi-shell-transition: Fix potential leak of memory pointed to by 'transition'

2015-09-19 Thread Lucas Tanure
Free transition before return. We don't need to use layout_transition_destroy, because transition was not registered yet. Signed-off-by: Lucas Tanure --- ivi-shell/ivi-layout-transition.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ivi-shell/ivi-layout-transition.c b/ivi-shel

[PATCH][weston] Fix potential leak of memory pointed to by 'transition'

2015-09-19 Thread Lucas Tanure
Free transition before return. We don't need to use layout_transition_destroy, because transition was not registered yet. Signed-off-by: Lucas Tanure --- ivi-shell/ivi-layout-transition.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ivi-shell/ivi-layout-transition.c b/ivi-shel