Re: [PATCH 1/2] compositor-drm: call EGL cleanup functions on exit

2012-04-30 Thread Kristian Hoegsberg
On Mon, Apr 30, 2012 at 01:31:28PM +0300, Ander Conselvan de Oliveira wrote: That looks good, applied. Kristian > --- > src/compositor-drm.c |6 ++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/src/compositor-drm.c b/src/compositor-drm.c > index dcd5e99..e7433f7 1

Re: [PATCH 2/2] compositor-drm: don't create and destroy kms fbs on every frame

2012-04-30 Thread Kristian Hoegsberg
On Mon, Apr 30, 2012 at 01:31:29PM +0300, Ander Conselvan de Oliveira wrote: > Use the new gbm_get/set_user_data() to reuse the kms fbs if the gbm > surface's bo's are reused. This doesn't look right. drm_output_render() always allocates and sets user data, which overwrite previously set user dat

Re: [PATCH v2] xwayland: Fix infinite loop on quick movement through menus

2012-04-27 Thread Kristian Hoegsberg
On Wed, Apr 25, 2012 at 10:00:42PM +0200, Tomasz Borowik wrote: > On Wed, 25 Apr 2012 10:34:14 -0400 > Kristian Hoegsberg wrote: > > > On Wed, Apr 25, 2012 at 03:06:57PM +0200, Tomasz Borowik wrote: > > > From 3abf39489deb3eb048174630dc7d41908674408b Mon Sep 17 00:00:00

Re: Weston on Android - First light

2012-04-27 Thread Kristian Hoegsberg
On Fri, Apr 27, 2012 at 03:56:41PM +0300, Pekka Paalanen wrote: > Hi all, > > I am happy to announce the first step towards a Wayland stack on > Android: simple-shm runs with Weston on a Galaxy Nexus! > > The whole story, a picture, and a video: > http://ppaalanen.blogspot.com/2012/04/first-light

Re: [PATCH] shell: allocate enough memory for shsurf->ping_timer

2012-04-27 Thread Kristian Hoegsberg
On Fri, Apr 27, 2012 at 01:55:55PM +0300, Ander Conselvan de Oliveira wrote: Thanks Ander, committed. Kristian > src/shell.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/src/shell.c b/src/shell.c > index 9c844b5..2001133 100644 > --- a/src/shell.c > +++ b/src/s

Re: [PULL weston] simple fixes

2012-04-27 Thread Kristian Hoegsberg
On Thu, Apr 26, 2012 at 04:02:32PM +0300, Pekka Paalanen wrote: > Hi Kristian, > > here is a set of minor fixes, mostly simple-shm related. The series > includes soreau's patch for xserver variable from the mailing list, > since I hit that problem, too. > > http://cgit.collabora.com/git/user/pq/w

Re: [PATCH v3] shell: Fix not remove rotation for fullscreen surf

2012-04-27 Thread Kristian Hoegsberg
On Fri, Apr 27, 2012 at 09:07:24AM +0800, zhiwen...@linux.intel.com wrote: > From: Alex Wu > > This patch is for Bug 48906. It remove rotation when entering > fullscreen and restore rotation when exiting. Thanks, applied. I edited the commit message to include the full path to the bug, like t

Re: [PATCH] shell: Fix Bug 48906

2012-04-25 Thread Kristian Hoegsberg
On Tue, Apr 24, 2012 at 02:30:43AM +0800, zhiwen...@linux.intel.com wrote: > From: Alex Wu > > Rotation and then fullscreen leads to fullscreen display rotation. That's looks like the right approach. Should we restore the rotation when we come back from fullscreen? Kristian > --- > src/shell

Re: [PATCH v2] gears: Allow model rotation with pointer

2012-04-25 Thread Kristian Hoegsberg
On Tue, Apr 24, 2012 at 11:28:26AM -0600, Scott Moreau wrote: > --- > clients/gears.c | 69 +++--- > 1 files changed, 65 insertions(+), 4 deletions(-) Awesome, I don't know how we lived without it. Committed. Btw, when you do a v2 patch, do you

Re: [PULL wayland] More OS compatibility wrappers

2012-04-25 Thread Kristian Hoegsberg
On Wed, Apr 25, 2012 at 12:48:49PM +0300, Pekka Paalanen wrote: > Hi Kristian, > > here are the rest of my OS compatibility wrappers for Wayland. Every > wrapper, except accept4, has two unit tests: a normal one and a forced > fallback one. > > The accept4 patch adds a configure test for it, the

Re: [PATCH v2 2/2] shell-animation: add conf option in shell

2012-04-25 Thread Kristian Hoegsberg
On Wed, Apr 25, 2012 at 02:32:28PM +0300, Pekka Paalanen wrote: > On Wed, 25 Apr 2012 19:09:52 +0800 > juan.j.z...@linux.intel.com wrote: > > > From: Juan Zhao > > > > Now we can choose zoom or fade in weston.ini > > to fulfill and customize the user experence easier. > > > > Signed-off-by: Jua

Re: [PATCH v2] xwayland: Fix infinite loop on quick movement through menus

2012-04-25 Thread Kristian Hoegsberg
On Wed, Apr 25, 2012 at 03:06:57PM +0200, Tomasz Borowik wrote: > From 3abf39489deb3eb048174630dc7d41908674408b Mon Sep 17 00:00:00 2001 > From: timon37 > Date: Wed, 25 Apr 2012 13:28:35 +0200 > Subject: [PATCH] Fix infinite loop in xwl_screen_post_damage > > Happens when first two windows are da

Re: [PATCH 6/6] xwayland: don't race with weston

2012-04-22 Thread Kristian Hoegsberg
On Mon, Apr 16, 2012 at 05:31:51PM +0300, Tiago Vignatti wrote: > Signed-off-by: Tiago Vignatti Ok, I now see the race you're talking about. We can't do a roundtrip here though, we can hit a mutual deadlock between weston and X, where weston waits for a reply to get xcb_get_property(), while X i

Re: [RFC] shell: modifier bindings configurable

2012-04-20 Thread Kristian Hoegsberg
On Fri, Apr 20, 2012 at 06:54:25PM +0300, Tiago Vignatti wrote: > Weston under X in Ubuntu has this bad behavior, mixing Unity's key bindings > with the ones in Weston. So I'd like to see the modifiers configurable on > Weston. I like it! > - I changed two key combination bindings, the rotation a

Re: Wayland client library thread safety

2012-04-20 Thread Kristian Hoegsberg
On Thu, Apr 19, 2012 at 03:38:39PM +0200, Arnaud Vrac wrote: > Hello everyone, > > I am hitting a bug when using Qt5 and wayland on an embedded platform, > for which I have written a custom EGL backend. The problem is that Qt5 > (QtQuick2 actually) renders in a separate thread, when the wayland >

Re: [PATCH 3/3 v2] Send surface enter/leave events

2012-04-20 Thread Kristian Hoegsberg
On Thu, Apr 19, 2012 at 10:50:09PM -0400, cdah...@redhat.com wrote: > From: Casey Dahlin > > These new protocol events allow us to tell which outputs a surface is on, and > potentially update where we allocate our buffers from. This patch has a few problems, but I've debugged it and committed wi

Re: [PATCH 2/3] Add an id field to outputs

2012-04-20 Thread Kristian Hoegsberg
On Thu, Apr 19, 2012 at 10:50:08PM -0400, cdah...@redhat.com wrote: > From: Casey Dahlin > > All outputs now have a unique integer ID, allocated from a bitfield pool in > the > compositor. Committed this one with a few edits as described below. > Signed-off-by: Casey Dahlin > --- > src/compo

Re: [PATCH 1/3] Change find_resource_for_surface to find_resource_for_client

2012-04-20 Thread Kristian Hoegsberg
On Thu, Apr 19, 2012 at 10:50:07PM -0400, cdah...@redhat.com wrote: > From: Casey Dahlin > > This function has generic applications and should be made generic. This one is fine, applied. I edited out the TODO comment as discussed on the list. Kristian > Signed-off-by: Casey Dahlin > --- > s

Re: [PATCH] compositor-drm: Remove an useless code line.

2012-04-19 Thread Kristian Hoegsberg
On Thu, Apr 19, 2012 at 10:08:59AM +0800, zhiwen...@linux.intel.com wrote: > From: Alex Wu Oh yeah, that one is hard to get to. Kristian > --- > src/compositor-drm.c |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/src/compositor-drm.c b/src/compositor-drm.c > ind

Re: [PATCH 0/3] implemented the "driver" mode fullscreen for drm backend.

2012-04-18 Thread Kristian Hoegsberg
On Tue, Apr 17, 2012 at 05:20:46PM +0800, zhiwen...@linux.intel.com wrote: > The following changes since commit e4faa2ab051aca454f3952f458dac42491e54954: > > compositor: init shell after xserver (2012-04-16 16:38:30 -0400) > > are available in the git repository at: > g...@gitorious.org:wayla

Re: [PATCH] Add support for surface enter/leave events

2012-04-18 Thread Kristian Hoegsberg
On Tue, Apr 17, 2012 at 05:23:02PM -0400, cdah...@redhat.com wrote: > From: Casey Dahlin Thanks, that looks good, a lot of the logic is in place here. I was thinking that we would use a uint32_t bit mask instead of the array and the bubble sort. weston_output needs a new output->id fied, surfac

Re: [PATCH 4/6] xserver: log locally

2012-04-16 Thread Kristian Hoegsberg
On Mon, Apr 16, 2012 at 05:31:43PM +0300, Tiago Vignatti wrote: > useful for weston on non-suid environments. I'm not sure about this one. We're just launching the X server, it needs to know how to start up and log in the right place. Kristian > Signed-off-by: Tiago Vignatti > --- > src/Makef

Re: [PATCH 5/6] compositor: init shell after xserver

2012-04-16 Thread Kristian Hoegsberg
On Mon, Apr 16, 2012 at 05:31:44PM +0300, Tiago Vignatti wrote: > This reverts a snip from commit d012e9df. On that commit, it was lost the > ability of calling X applications from desktop panel; xserver module > was setting DISPLAY only later, after panel was already launched. Ah, yes, makes sens

Re: [PATCH 2/6] desktop-shell: use more consistent name for the main structure

2012-04-16 Thread Kristian Hoegsberg
On Mon, Apr 16, 2012 at 05:31:41PM +0300, Tiago Vignatti wrote: > wl_shell is more likely to be used for core protocol specific. Now it follows > pretty much the same style of what tablet-shell is using. > > No functional changes. Yup, that looks better. Kristian > Signed-off-by: Tiago Vignatti

Re: [PATCH 1/6] desktop-shell: use description tags and improve protocol doc a bit

2012-04-16 Thread Kristian Hoegsberg
On Mon, Apr 16, 2012 at 05:31:40PM +0300, Tiago Vignatti wrote: > Signed-off-by: Tiago Vignatti Ah, nice, thanks. Kristian > --- > protocol/desktop-shell.xml | 33 +++-- > 1 files changed, 23 insertions(+), 10 deletions(-) > > diff --git a/protocol/desktop-shell.x

Re: [PATCH 5/6] xwayland: follow wayland change to serial numbers

2012-04-16 Thread Kristian Hoegsberg
On Mon, Apr 16, 2012 at 05:31:50PM +0300, Tiago Vignatti wrote: > Signed-off-by: Tiago Vignatti The input device attach request expects the enter event serial number for the window that currently has pointer focus. I made the change here and comitted. Kristian > --- > hw/xfree86/xwayland/xway

Re: [PATCH 4/6] xwayland: track shm pool protocol changes

2012-04-16 Thread Kristian Hoegsberg
On Mon, Apr 16, 2012 at 05:31:49PM +0300, Tiago Vignatti wrote: > Signed-off-by: Tiago Vignatti Thanks, applied. What happened to 3/6? Kristian > --- > hw/xfree86/xwayland/xwayland-cursor.c |7 +-- > hw/xfree86/xwayland/xwayland.c|9 ++--- > 2 files changed, 11 inserti

Re: [PATCH 1/6] xwayland: use stub for wl_input_device_listener track the protocol

2012-04-16 Thread Kristian Hoegsberg
On Mon, Apr 16, 2012 at 05:31:46PM +0300, Tiago Vignatti wrote: > otherwise it segfaults. Thanks, applied. > Signed-off-by: Tiago Vignatti > --- > hw/xfree86/xwayland/xwayland-input.c | 72 > -- > 1 files changed, 68 insertions(+), 4 deletions(-) > > diff --g

Re: [PATCH] Add wl_display_disconnect to the client header

2012-04-12 Thread Kristian Hoegsberg
On Wed, Apr 11, 2012 at 04:57:29PM +0100, Neil Roberts wrote: > Commit fdbbc38a added a wl_display_disconnect function to the 0.85 > branch so that Mesa can continue to build against both that branch and > master. However it was missing a declaration in the header so Mesa > would still fail to buil

Re: [PATCH] shell: handle surface destruction during move, resize and rotate grabs

2012-04-09 Thread Kristian Hoegsberg
On Wed, Apr 04, 2012 at 05:48:05PM +0300, Ander Conselvan de Oliveira wrote: > When the surface being moved, resized or rotated was destroyed, the > compositor would crash. > > Fix this by using a destroy listener on the referenced surface. To > reduce code duplication, the surface reference and t

Re: [PATCH] screenshooter: Properly handle multiple outputs.

2012-04-04 Thread Kristian Hoegsberg
On Wed, Apr 04, 2012 at 01:51:08AM -0600, Scott Moreau wrote: > --- Looks pretty good. There are a few small comments below, but the overall approach is good. > Tested: Side-by-side and stacked output configurations, in x11 and drm. > Shooting under drm glitches sometimes and either or both outp

Re: [PATCH 1/2] client: tablet-shell: fallback in the lack of lockscreen icon

2012-04-03 Thread Kristian Hoegsberg
On Wed, Mar 28, 2012 at 08:56:48PM +0300, Tiago Vignatti wrote: > lockscreen, homescreen and shell launchers are falling back okay already and > only lockscreen icon was missing some way to keep the shell client running in > the absence of images. This patch fix it. Thanks, comitted. Kristian > S

Re: [PATCH] Fix `unused-result' warnings.

2012-04-03 Thread Kristian Hoegsberg
On Fri, Mar 30, 2012 at 11:10:27PM +0200, Jonas Ådahl wrote: > Signed-off-by: Jonas Ådahl > --- > > This fixes all warnings using gcc 4.6.1. Thanks, applied. Kristian > clients/dnd.c |4 +++- > clients/window.c |4 +++- > shared/image-loader.c | 17 + > 3

Re: [PATCH v2 1/4] shell: add fullscreen path for activate() and switcher

2012-03-29 Thread Kristian Hoegsberg
On Tue, Mar 13, 2012 at 11:18:23PM +0800, zhiwen...@linux.intel.com wrote: > From: Alex Wu > > For activate(), stack the surface atop fullscreen layer instead of > toplevel layer. > For switcher, involve the fullscreen surfaces into surface iteration, > and make fullscreen surface and its black s

Re: [PATCH 0/4] documentation move from .tex to docbook

2012-03-28 Thread Kristian Hoegsberg
On Thu, Mar 29, 2012 at 10:50:09AM +1000, Peter Hutterer wrote: > > This moves the documentation into the docbook sources, removing the need for > the .tex file. Because the current docbook also includes some parts copied > from the website, the first three chapters are somewhat redundant. Nice,

Re: [PATCH 1/2] Properly dispose event sources and event loops

2012-03-28 Thread Kristian Hoegsberg
On Wed, Mar 28, 2012 at 10:36:09PM +0200, Jonas Ådahl wrote: > Signed-off-by: Jonas Ådahl Very nice clean up, thanks. I moved the inline variable declaration in evdev_add_devices() (const char *sysname) up alongside const char *path; Other than that, applied as is Kristian > --- > src/compos

Re: [Web] [PATCH 3/3] Update xwayland branch from xwayland to xwayland-1.10.

2012-03-27 Thread Kristian Hoegsberg
On Mon, Mar 26, 2012 at 12:37:04PM -0400, Darxus wrote: I just pushed branches of xserver and the intel driver rebased to work on xserver 1.12. Do you want to see if those work for you (aside from the problem of the windows currently not showing up)? We'll update the branches to xwayland-1.12 on

Re: [PATCH] Window.c delay redraws with frame callback

2012-03-24 Thread Kristian Hoegsberg
On Fri, Mar 23, 2012 at 11:59:08PM +0100, Martin Minarik wrote: > Don't ignore schedule redraw between idle_redraw() triggering and the > frame callback. The frame callback now sets redraw_from_callback and > forces window schedule redraw. > > The flags prevent getting into idle_redraw again until

Re: [PATCH v2] Add simple memory leak check to all tests.

2012-03-24 Thread Kristian Hoegsberg
On Fri, Mar 23, 2012 at 10:01:23AM -0700, U. Artie Eoff wrote: > From: "U. Artie Eoff" > > Wrap all tests with a memory balance check to detect potential > memory leaks. > Fixed a few tests that had memory leaks contained in the tests > themselves. Thanks Artie, looks good. Kristian > Signed-of

Re: [PATCH v2] Secure screenshooter protocol.

2012-03-24 Thread Kristian Hoegsberg
On Fri, Mar 23, 2012 at 04:42:04PM -0600, Scott Moreau wrote: Thanks, that looks good. Kristian > --- > > Changed in this version: s/screenshot/screenshooter/ > > clients/Makefile.am |9 + > src/screenshooter.c | 40 +++- > 2 files changed, 44

Re: [PATCH] shell: fix matrix invertible bug in rotation handler

2012-03-22 Thread Kristian Hoegsberg
On Thu, Mar 22, 2012 at 10:22:04PM +0100, Rafal Mielniczuk wrote: > While activating and deactivating rotation mechanism without moving > the pointer, rotation matrix from rotate_grab object is not being > initialised and damage shell surface rotation matrix in > rotate_grab_button handler, making

Re: [PATCH] Add simple memory leak check to all tests.

2012-03-22 Thread Kristian Hoegsberg
On Thu, Mar 22, 2012 at 01:37:20PM -0700, U. Artie Eoff wrote: > From: "U. Artie Eoff" > > Wrap all test cases with a memory balance check to > detect potential memory leaks. > Fixed a few tests that had memory leaks contained > in the test themselves. Thanks Artie, that's cool and good to see t

Re: [PATCH] weston: Don't ask for EGL depth buffer if not needed

2012-03-22 Thread Kristian Hoegsberg
On Thu, Mar 22, 2012 at 02:59:32AM -0700, Bill Spitzak wrote: > On 03/22/2012 01:43 AM, Pekka Paalanen wrote: > > >>PS: I have not heard anything about my changes to wayland (there are 5 > >>patches). One of them fixed a major bug for me. I believe my EAGAIN > >>changes are a mistake and should be

Re: [PATCH 3/5] drm: plane src coords are 16.16 fixed point

2012-03-22 Thread Kristian Hoegsberg
On Tue, Mar 20, 2012 at 10:48:55AM -0700, Jesse Barnes wrote: > On Sun, 11 Mar 2012 19:48:43 -0500 > Rob Clark wrote: > > > From: Rob Clark > > > > --- > > src/compositor-drm.c |9 - > > 1 files changed, 4 insertions(+), 5 deletions(-) > > > > diff --git a/src/compositor-drm.c b/s

Re: [PATCH] evdev: fix input lag when processing input from output repaint

2012-03-22 Thread Kristian Hoegsberg
On Tue, Mar 20, 2012 at 09:36:33PM -0700, Chase Douglas wrote: > On 03/20/2012 05:02 PM, Kristian Hoegsberg wrote: > > On Tue, Mar 20, 2012 at 11:54:56AM +0200, Ander Conselvan de Oliveira wrote: > >> When the compositor is in a repaint cycle, input is processed only once >

Re: [PATCH] shell: correct position of a surface before rotating it.

2012-03-22 Thread Kristian Hoegsberg
On Wed, Mar 21, 2012 at 10:40:20PM +0100, Rafal Mielniczuk wrote: > How to reproduce: rotate the surface to something like 45 degrees, > resize it drastically, continue to rotate. The surface will jump > some space and the rotation point will not be in the center > of the surface. > > Fix is to sh

Re: [PATCH] event-loop: Use two-step destruction of event loop sources.

2012-03-21 Thread Kristian Hoegsberg
On Wed, Mar 21, 2012 at 10:31:24AM +0100, Jonas Ådahl wrote: > Instead of directly freeing an event source upon removal put it in a > queue later handled by the event loop; either after a dispatch or upon > event loop destruction. > > This is necessary to avoid already queued up event sources to b

Re: [PATCH] shell: correct position of a surface before rotating it.

2012-03-20 Thread Kristian Hoegsberg
On Tue, Mar 20, 2012 at 12:14:33AM +0100, Rafał Mielniczuk wrote: > From: Rafal Mielniczuk > > How to reproduce: rotate the surface to something like 45 degrees, > resize it drastically, continue to rotate. The surface will jump > some space and the rotation point will not be in the center > of t

Re: [PATCH] evdev: fix input lag when processing input from output repaint

2012-03-20 Thread Kristian Hoegsberg
On Tue, Mar 20, 2012 at 11:54:56AM +0200, Ander Conselvan de Oliveira wrote: > When the compositor is in a repaint cycle, input is processed only once > per frame. However, a call to evdev_input_device_data() would handle at > most 8 events at time. When there was more than 8 events pending for a >

Re: [PATCH] weston_surface: initialize pitch

2012-03-20 Thread Kristian Hoegsberg
On Tue, Mar 20, 2012 at 01:48:46AM +0800, zhaojuan...@gmail.com wrote: > From: Juan Zhao > > Initializing pitch to 1 to avoid xxx/pitch errors > This won't influence the valid texture coordinate calculation, because > in that case buffer_attach will provide the correct value. > --- Thanks, look

Re: [PATCH] weston: don't hang in wait()

2012-03-20 Thread Kristian Hoegsberg
On Sat, Mar 17, 2012 at 03:22:03PM -0700, Bill Spitzak wrote: > Pausing weston (with ^Z in the shell) and putting it in the > background made it hang. > > It actually never called sigchld when I killed or made clients exit, > so it is not clear if this handler is needed at all. Oh, yeah, oops. T

Re: [PATCH] weston: Don't ask for EGL depth buffer if not needed

2012-03-20 Thread Kristian Hoegsberg
On Sat, Mar 17, 2012 at 01:43:52PM -0700, Bill Spitzak wrote: > This makes the compositor and demo clients work on the current > nouveau nvfx driver. Obviously does not fix any clients that > actually want a depth buffer, but this does allow more people to at > least try wayland. Ok, yeah, that's

Re: [PATCH] configure: Add option to disable building documentation.

2012-03-20 Thread Kristian Hoegsberg
On Sat, Mar 17, 2012 at 07:09:39PM +0200, ustun.ergeno...@gmail.com wrote: > From: Üstün Ergenoğlu Yeah, not a bad idea. thanks, Kristian > Signed-off-by: Üstün Ergenoğlu > --- > configure.ac | 10 +- > 1 files changed, 9 insertions(+), 1 deletions(-) > > diff --git a/configure.ac

Re: [PATCH v2] evdev: use mtdev for multitouch devices

2012-03-20 Thread Kristian Hoegsberg
On Fri, Mar 16, 2012 at 05:33:03PM -0300, Tiago Vignatti wrote: > mtdev library translates all multitouch based devices to the slotted evdev > protocol. It provides an uniform interface for Weston, which eases mt > implementation when dealing with a big variety of devices. > > Weston on drm now di

Re: [PATCH 3/3] compositor: properly restore keyboard_focus in notify_keyboard_focus()

2012-03-20 Thread Kristian Hoegsberg
On Fri, Mar 16, 2012 at 05:25:11PM +0200, Ander Conselvan de Oliveira wrote: > Commit f992b2fc removed the saved keyboard focus logic to fix a crash > when the saved surface is destroyed. However, setting keyboard focus to > the first surface on the list ends up trying to set the focus to the > cur

Re: [PATCH] cairo-util: load_cairo_surface returns NULL if loading the file fails.

2012-03-20 Thread Kristian Hoegsberg
On Wed, Mar 14, 2012 at 10:07:58PM +0200, ustun.ergeno...@gmail.com wrote: > From: Ustun Ergenoglu Thanks, applied. Kristian > Otherwise a non-existent file in the configuration crashes the desktop shell. > > Signed-off-by: Ustun Ergenoglu > --- > clients/cairo-util.c |4 > 1 files

Re: [PATCH] test: add a unit test for the event loop post dispatch check

2012-03-20 Thread Kristian Hoegsberg
On Wed, Mar 14, 2012 at 02:47:40PM +0200, Ander Conselvan de Oliveira wrote: > --- > Figured that now that we have unit tests, I should write a test that > fails without the previous patch and passes with it. Thanks Ander. Kristian > tests/Makefile.am |7 - > tests/event-loop-test

Re: [PATCH] event-loop: always do the post-dispatch check

2012-03-20 Thread Kristian Hoegsberg
On Tue, Mar 13, 2012 at 01:16:13PM +0200, Ander Conselvan de Oliveira wrote: > The post-dispatch check on wl_event_loop_dispatch() was not being run > if epoll_wait returned 0 events, making the check unreliable. > --- > > With the changes on Weston to process input during output repaint, this > b

Re: [PATCH 2/2] compositor: use smoother range for backlight control

2012-03-20 Thread Kristian Hoegsberg
On Mon, Mar 12, 2012 at 07:40:09PM -0300, Tiago Vignatti wrote: > now it goes from 0 to 255. Looks good, thanks. Kristian > Signed-off-by: Tiago Vignatti > --- > src/compositor-drm.c | 12 ++-- > src/compositor.h |2 +- > src/shell.c | 17 +++-- > 3 file

Re: [PATCH 1/2] tests: add backlight test

2012-03-20 Thread Kristian Hoegsberg
On Mon, Mar 12, 2012 at 07:40:08PM -0300, Tiago Vignatti wrote: > Signed-off-by: Tiago Vignatti Thanks, applied. Kristian > --- > tests/Makefile.am|9 ++- > tests/setbacklight.c | 191 > ++ > 2 files changed, 199 insertions(+), 1 deletio

Re: [PATCH] shell: Fix 2 switcher crashes.

2012-03-20 Thread Kristian Hoegsberg
On Mon, Mar 12, 2012 at 04:06:01PM +0800, zhiwen...@linux.intel.com wrote: > From: Alex Wu > > In case of no regular window, switcher will crash in switch_next() > due to "next == NULL" and in switcher_destroy() due to > "switcher->current == NULL". Thanks, applied. Kristian > --- > src/shell.

Re: [PATCH 5/5] RFC: add eglWaitGL()

2012-03-20 Thread Kristian Hoegsberg
On Sun, Mar 11, 2012 at 07:48:45PM -0500, Rob Clark wrote: > From: Rob Clark > > For deferred rendering GPUs, some magic under the hood of eglSwapBuffers() > is responsible for making sure rendering has actually started. (glFlush() > doesn't do the trick.) > > I've managed to make weston drm co

Re: [PATCH] compositor: Fix pick an incorrect surface due to dirty surface_list

2012-03-11 Thread Kristian Hoegsberg
On Fri, Mar 09, 2012 at 11:57:36AM +0800, zhiwen...@linux.intel.com wrote: > From: Alex Wu > > When a new toplevel window is activated and positioned under the > cursor, the pointer focus still on the previous window. The botton > event can not deliver to the new window. The root cause is that >

Re: [PATCH v2] Flush the connection if we have to many marshaled fds

2012-03-10 Thread Kristian Hoegsberg
On Fri, Mar 09, 2012 at 12:51:42PM +0200, Ander Conselvan de Oliveira wrote: > The buffer used by wl_connection_data to receive a cmsg is 128 bytes > long. This can hold at most 28 fds but when a cmsg is generated for > sending the fds, there is no check for this limitation. The man page > for recv

Re: Patch for compositor-drm.c

2012-03-08 Thread Kristian Hoegsberg
On Wed, Mar 07, 2012 at 03:00:04PM -0500, Christopher Michael wrote: > Hi All, > > Attached is a patch which fixes some cleanup issues for the > drm-based compositor. Basically, if we fail to allocate space for > the crtcs in the compositor, then we need to free the drm mode > resources before exi

Re: [PATCH] shell: don't assign output for surface of type none

2012-03-08 Thread Kristian Hoegsberg
On Mon, Mar 05, 2012 at 03:39:23PM +0200, Ander Conselvan de Oliveira wrote: > If map is called with a surface of type none it will call > weston_surface_assign_output, even though the surface will > not be mapped. > > This change was lost with the changes for using wl_layers. Oops, sorry. Appli

Re: [PATCH] shell: Fix segment fault when clicking to activate a NULL pointer_focus

2012-03-08 Thread Kristian Hoegsberg
On Mon, Mar 05, 2012 at 02:13:13PM +0800, zhiwen...@linux.intel.com wrote: > From: Alex Wu > > This can happen for instance running a toytoolkit application, launching > the popup menu and then clicking on a surface that does not belong to > the client that create the popup surface. Thanks. I a

Re: [PATCH] compositor-drm: fix libbacklight build

2012-03-04 Thread Kristian Hoegsberg
On Fri, Mar 02, 2012 at 05:52:25PM +0200, Pekka Paalanen wrote: > On Fri, 02 Mar 2012 17:37:53 +0200 > Tiago Vignatti wrote: > > > On 03/02/2012 05:33 PM, Pekka Paalanen wrote: > > > Bad inclusion of DRM headers, missing some system headers. > > > > > > > thanks, Pekka. I had that in my branch a

Re: Wayland and jhbuild

2012-03-04 Thread Kristian Hoegsberg
On Sat, Mar 03, 2012 at 05:34:45PM +0100, Rodney Lorrimar wrote: > Hi Alberto, > > I have updated the wayland moduleset in jhbuild according to the latest > build instructions on the wayland website. This includes adding libxcb > from git and xorg dri2proto. A number of configure options were enab

Re: [PATCH 0/3] Fix some makefile problems discovered by distcheck

2012-03-04 Thread Kristian Hoegsberg
On Sat, Mar 03, 2012 at 05:32:56PM -0500, Gaetan Nadon wrote: > There is yet another one which I have not found the cause: > > It appears that libffi.so cannot found while running distcheck. > On my system, it is located at: > /usr/lib/x86_64-linux-gnu/libffi.so Thanks Gaetan, looks good and also

Re: [PATCH 1/2] Terminate drag if data source is destroyed

2012-03-02 Thread Kristian Hoegsberg
On Fri, Mar 02, 2012 at 03:45:56PM +0200, Ander Conselvan de Oliveira wrote: > --- > src/data-device.c| 56 +++-- > src/wayland-server.h |1 + > 2 files changed, 41 insertions(+), 16 deletions(-) Thanks Ander, that looks good. Kristian > diff

Re: [PATCH weston 5/5] compositor: split drag surface update into smaller functions

2012-03-01 Thread Kristian Hoegsberg
On Thu, Mar 01, 2012 at 02:09:45PM +0200, Ander Conselvan de Oliveira wrote: Thanks, applied. Kristian > --- > src/compositor.c | 58 +++-- > 1 files changed, 42 insertions(+), 16 deletions(-) > > diff --git a/src/compositor.c b/src/compositor.c

Re: [PATCH weston 4/5] compositor: fix crash when a drag surface is destroyed during the drag

2012-03-01 Thread Kristian Hoegsberg
On Thu, Mar 01, 2012 at 02:09:44PM +0200, Ander Conselvan de Oliveira wrote: > This can happen for instance if the client that started the drag > crashes. Weston would crash because of the invalid surface pointed by > device->drag_surface. Looks good, applied. Kristian > Fix this by reseting the

Re: [PATCH 2/3] Fix server crash when a client dies during a drag with an icon

2012-03-01 Thread Kristian Hoegsberg
On Thu, Mar 01, 2012 at 02:09:42PM +0200, Ander Conselvan de Oliveira wrote: > If a client dies during a drag that it started using an icon surface, > the server could crash because the icon surface is not valid anymore. > > Fix this by using a destroy listener to reset device->drag_surface to > n

Re: [PATCH 3/3] Terminate a drag if the origin surface is destroyed

2012-03-01 Thread Kristian Hoegsberg
On Thu, Mar 01, 2012 at 02:09:43PM +0200, Ander Conselvan de Oliveira wrote: This one I'm not sure about. Obviously if the source client goes away, we need to end the grab, but we only need the origin surface to verify that the client has an implicit grab. Once the drag is started I think it sho

Re: [PATCH 1/3] Fix wl_data_offer source destroy listener

2012-03-01 Thread Kristian Hoegsberg
On Thu, Mar 01, 2012 at 02:09:41PM +0200, Ander Conselvan de Oliveira wrote: > The listener function implementation was getting a wrong pointer to the > wl_data_offer object because the resource parameter is actually the > data source and not the data offer. Yeah, oops, good catch. Kristian > --

Re: Thinking about popup windows

2012-02-29 Thread Kristian Hoegsberg
On Wed, Feb 29, 2012 at 07:14:11PM +, Rob Bradford wrote: > > This and the patches for weston are an attempt at how a client could > communicate with the compositor about positioning surfaces. The > slightly weird thing is that you make this request not against the > surface you are going to p

Re: [PATCH] compositor: add dpms and backlight support

2012-02-29 Thread Kristian Hoegsberg
On Wed, Feb 29, 2012 at 10:45:35AM -0800, Jesse Barnes wrote: > Looks pretty good, thanks. For future patches can you include a > version and short changelog of what's changed from the last patch? > Just makes things easier to track (even for the patch author, in my > experience). > > Few notes o

Re: [PATCH 0/6] Publican documentation integration

2012-02-29 Thread Kristian Hoegsberg
On Wed, Feb 29, 2012 at 12:57:28PM +1000, Peter Hutterer wrote: > > Branch available from > git://people.freedesktop.org/~whot/wayland.git :publican > > This adds a docbook tree hooked up to build with publican. Default make will > build both html and pdf. > > The make distchecks hooks aren't pr

Re: [PATCH] protocol: Clarify the documentation for the fullscreen protocol

2012-02-29 Thread Kristian Hoegsberg
On Wed, Feb 29, 2012 at 09:59:43AM +0200, Pekka Paalanen wrote: > On Tue, 28 Feb 2012 16:48:26 + > Rob Bradford wrote: > > > From: Rob Bradford > > > > --- > > protocol/wayland.xml | 53 > > - > > 1 files changed, 34 insertions(+), 19 dele

Re: [PATCH] weston: Change path for default terminal launcher to ${prefix}/bin

2012-02-29 Thread Kristian Hoegsberg
On Wed, Feb 29, 2012 at 05:31:03PM +0100, Rodney Lorrimar wrote: > If you don't have anything at ~/.config/weston-desktop-shell.ini and > have weston installed somewhere other than /usr, then this patch will > help. Thanks, that's better. Kristian > Cheers, > > Signed-off-by: Rodney Lorrimar >

Re: [PATCH] Reverses the order of a socket creation in weston/compositor.c

2012-02-29 Thread Kristian Hoegsberg
On Wed, Feb 29, 2012 at 10:22:23AM +0100, Igor Makarov wrote: > Hello all, > So, when I trying to start weston with 'wayland-backend.so' on ARM > device I got errors related to socket connection. > This error appear because 'backed_init' start client-socket connection > to server-socket that is ab

Re: Catastrophic blocking

2012-02-29 Thread Kristian Hoegsberg
On Wed, Feb 29, 2012 at 10:58:56AM +0200, Pekka Paalanen wrote: > On Tue, 28 Feb 2012 14:32:21 -0500 > Kristian Hoegsberg wrote: > > > On Mon, Feb 27, 2012 at 04:57:42PM +0100, Samuel Rødal wrote: > > > Ignore previous patch, here's the cor

Re: [PATCH] Allow update function to not be set in wl_display_get_fd

2012-02-28 Thread Kristian Hoegsberg
On Mon, Feb 27, 2012 at 04:57:42PM +0100, Samuel Rødal wrote: > Ignore previous patch, here's the correct version. > From 4e1bedaaf05b576f5191f8fe3a34904ab9707414 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Samuel=20R=C3=B8dal?= > Date: Mon, 27 Feb 2012 15:17:20 +0100 > Subject: [PATCH] Allow upda

Re: [RFC] [PATCH] Renamed client side wl_display_destroy() to wl_display_disconnect()

2012-02-28 Thread Kristian Hoegsberg
On Mon, Feb 27, 2012 at 05:10:03PM +0100, Samuel Rødal wrote: > The only problem I see with this is that the "disconnect" naming can > be confusing as the wl_display handle is actually freed as well. I like it, it pairs better with wl_display_connect. I don't think it's a problem that the name is

Re: [fullscreen-v8 PATCH 2/3] shell: Add implementation of fullscreen.

2012-02-28 Thread Kristian Hoegsberg
On Tue, Feb 28, 2012 at 06:08:38PM +0800, zhiwen...@linux.intel.com wrote: > From: Alex Wu > > All the fullscreen things (black surface, raise atop panels, transform, > positioning) > are handled in map() or configure(). Ok, looking good, we're almost there now :) A few comments below (and plea

Re: [PATCH] compositor: make the input region of drag surfaces empty

2012-02-28 Thread Kristian Hoegsberg
On Tue, Feb 28, 2012 at 05:59:33PM +0200, Ander Conselvan de Oliveira wrote: > With the input region changes, drag surfaces were being picked and > receiving events which led to problems on the client side. > --- > src/compositor.c | 16 > 1 files changed, 16 insertions(+), 0 de

Re: [fullscreen-v8 PATCH 1/3] compositor: Export functions and add weston_suface::force_configure for fullscreen

2012-02-28 Thread Kristian Hoegsberg
On Tue, Feb 28, 2012 at 06:07:54PM +0800, zhiwen...@linux.intel.com wrote: > From: Alex Wu Thanks, applied with a little edit to make the check in weston_surface_destroy an assert instead. If we end up in that case, it's an internal error and we need to catch it, not silently ignore it. Also, p

Re: [PATCH 2/3] shell: Add implementation of fullscreen.

2012-02-26 Thread Kristian Hoegsberg
On Sun, Feb 26, 2012 at 03:21:37PM +0800, zhiwen...@linux.intel.com wrote: > From: Alex Wu Nice. There are a few issues below and one thing I didn't figure out right now was that when you raise a window over the fullscreen window and then re-raise the fullscreen window, the black surface renders

Re: [PATCH 1/3] compositor: Export 3 functions from compositor.c

2012-02-26 Thread Kristian Hoegsberg
On Sun, Feb 26, 2012 at 03:21:36PM +0800, zhiwen...@linux.intel.com wrote: > From: Alex Wu Looks ok, just one comment below. Kristian > This will facilitate the implementation of fullscreen. > --- > src/compositor.c |6 +++--- > src/compositor.h | 10 ++ > 2 files changed, 13 in

Re: [PATCH] util: Comments before wl_list were a bit off, fixed the example usage.

2012-02-26 Thread Kristian Hoegsberg
On Sat, Feb 25, 2012 at 12:56:32PM +0200, Ustun Ergenoglu wrote: > From: Üstün Ergenoğlu Yeah, that's better. Thanks. Kristian > Signed-off-by: Üstün Ergenoğlu > --- > src/wayland-util.h | 16 > 1 files changed, 12 insertions(+), 4 deletions(-) > > diff --git a/src/wayland

Re: [PATCH] Restructure output zoom key handling.

2012-02-26 Thread Kristian Hoegsberg
On Thu, Feb 23, 2012 at 10:28:37PM -0700, Scott Moreau wrote: > This effectively eats the keybinding events, as we don't want them sent to > clients. Thanks, as discussed in irc, this is the right fix. PS: Keep commit message lines under 78 characters. Kristian > --- > src/shell.c | 60

Re: [RFC v4] Introduce output zoom.

2012-02-23 Thread Kristian Hoegsberg
On Wed, Feb 22, 2012 at 02:21:41PM -0700, Scott Moreau wrote: > Ideally, we would want to use +Scroll binding but that will have > to wait for axis events. For now we just use keybindings. Zoom in/out with > Super+Up/Down. Applied with a minor edit to really fix the code-before-declaration thing.

Re: [PATCH] Fix pointer position clipping.

2012-02-23 Thread Kristian Hoegsberg
On Wed, Feb 22, 2012 at 01:57:51PM -0700, Scott Moreau wrote: Yup, good fix, applied. Kristian > --- > src/compositor.c |8 > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/src/compositor.c b/src/compositor.c > index 5a424fa..1963322 100644 > --- a/src/composito

Re: [PATCH RFC] protocol: add xslt stylesheet to prettify the protocol

2012-02-23 Thread Kristian Hoegsberg
On Thu, Feb 23, 2012 at 03:58:37PM +1000, Peter Hutterer wrote: > Includes rudimentary styling only. > > Signed-off-by: Peter Hutterer > --- > A few things to note: > - I'm not a designer > - Having a html version of the protocol makes it a lot easier to read, and > it certainly reveals missing

Re: [PATCH] compositor-drm: Fix output still scanout framebuffer after the scanout client was interrupted.

2012-02-22 Thread Kristian Hoegsberg
On Fri, Feb 17, 2012 at 11:57:58AM +0800, zhiwen...@linux.intel.com wrote: > From: Alex Wu > > If the scanout client was interrupted (e.g. by Ctrl-C), > compositor-drm.c::page_flip_handler() > was not guaranteed to be invoked for the last scanout > drmModePageFlip(), so that pen

Re: Towards 1.0

2012-02-22 Thread Kristian Hoegsberg
On Mon, Feb 20, 2012 at 04:00:21PM -0800, Andy Lutomirski wrote: > On 02/17/2012 09:01 AM, Kristian Høgsberg wrote: > > ICCCM > > > > - clipboard manager interface? what's needed? just notification > > that the selection has gone away. should the clipboard manager be > > able to take over the

Re: [PATCH] gbm: track buffer format through DRI drivers

2012-02-22 Thread Kristian Hoegsberg
On Tue, Feb 21, 2012 at 12:56:11PM -0800, Jesse Barnes wrote: > GBM needs the buffer format in order to communicate with DRM and clients > for things like scanout. > > So track the DRI format requested in the various back ends and use it to > return the DRI format back to GBM when requested. GBM

Re: [PATCH] shell: Fix never map fullscreen/transient surface.

2012-02-22 Thread Kristian Hoegsberg
On Wed, Feb 22, 2012 at 02:50:46PM +0800, zhiwen...@linux.intel.com wrote: > From: Alex Wu > >If client send set_fullscreen/set_transient request before the first > attach, >compositor has no chance to map the surface due to "if (es->output == > NULL)". Ah yes, thanks. Committ

Re: [weston PATCH v6 3/7] Shell: Hide panels when we have a top fullscreen surface.

2012-02-21 Thread Kristian Hoegsberg
On Fri, Feb 17, 2012 at 03:26:12PM +0800, juan.j.z...@linux.intel.com wrote: > From: Zhiwen Wu I agree with the behavior we're going for here: when the fullscreen surface is on top, we hide the panels, when switch to a different client, we bring the panels back. However, I think we're better off

  1   2   >