Re: Dual display in clone mode or extended mode with Weston

2018-06-22 Thread Konstantin Kharlamov
On 21.06.2018 21:44, Matheus Santana wrote: On Thu, Jun 21, 2018 at 5:11 AM, Pekka Paalanen > wrote: On Wed, 13 Jun 2018 17:40:59 +0530 Ashvini Deshmukh mailto:ashvini2...@gmail.com>> wrote: > Hello All, > > I have read queries for dual displ

Re: [PATCH libinput 2/4] touchpad: reset the wobble detection for non-pointer events

2018-05-02 Thread Konstantin Kharlamov
On 30.04.2018 08:33, Peter Hutterer wrote: If we get an event other than a motion event we're not wobbling so we need to reset and restart. Signed-off-by: Peter Hutterer IMO this shouldn't matter, because if a user managed to consciously trigger an event other than movement, it would definit

Re: [PATCH v4 libinput 3/3] touchpad: add wobbling detection

2018-03-01 Thread Konstantin Kharlamov
Looks fine to me. The series is Reviewed-by: Konstantin Kharlamov On 01.03.2018 09:39, Peter Hutterer wrote: From: Konstantin Kharlamov The details are explained in comment in the code. That aside, I shall mention the check is so light, that it shouldn't influence CPU performance even

[PATCH libinput] indentation: add .dir-locals.el for emacs

2018-02-25 Thread Konstantin Kharlamov
It's pretty basic as compared to e.g. one of Mesa, but I don't see what else could be needed, and if anything, it can be added later. Signed-off-by: Konstantin Kharlamov --- .dir-locals.el | 4 1 file changed, 4 insertions(+) create mode 100644 .dir-locals.el diff --git a/.dir

Re: [PATCH v2] touchpad: add wobbling detection

2018-02-22 Thread Konstantin Kharlamov
On 21.02.2018 03:33, Peter Hutterer wrote: It should work like it previously did; what bothers me however — shouldn't that be specific to a touch, but not touchpad? Couldn't that get triggered e.g. by 2-finger scrolling? (whatever that is, I dunno, touching with 2 finger doesn't scroll for me — I

[PATCH 2/2 v3 libinput] touchpad: add wobbling detection

2018-02-21 Thread Konstantin Kharlamov
. * increased timeout from 20ms to 40ms just in case — it's still out of human ability anyway, and in fact can be increased even further * ignore Y-only changes, again just in case — it could happen that Y and X events would be sent separately, and break the heuristi

Re: [PATCH v2] touchpad: add wobbling detection

2018-02-20 Thread Konstantin Kharlamov
On 20.02.2018 17:31, Konstantin Kharlamov wrote: On 20.02.2018 13:44, Konstantin Kharlamov wrote: On 20.02.2018 09:34, Peter Hutterer wrote: On Sun, Feb 18, 2018 at 11:14:55PM +0300, Konstantin Kharlamov wrote: +static inline void +tp_detect_wobbling(struct tp_dispatch *tp, int x_diff

Re: [PATCH v2] touchpad: add wobbling detection

2018-02-20 Thread Konstantin Kharlamov
On 20.02.2018 13:44, Konstantin Kharlamov wrote: On 20.02.2018 09:34, Peter Hutterer wrote: On Sun, Feb 18, 2018 at 11:14:55PM +0300, Konstantin Kharlamov wrote: +static inline void +tp_detect_wobbling(struct tp_dispatch *tp, int x_diff, uint64_t time) +{ +    if (tp->hysteresis.enab

Re: [PATCH v2] touchpad: add wobbling detection

2018-02-20 Thread Konstantin Kharlamov
On 20.02.2018 09:34, Peter Hutterer wrote: On Sun, Feb 18, 2018 at 11:14:55PM +0300, Konstantin Kharlamov wrote: +static inline void +tp_detect_wobbling(struct tp_dispatch *tp, int x_diff, uint64_t time) +{ + if (tp->hysteresis.enabled) + return; + + /* Idea: if we

Re: [PATCH 0/2 libinput] [RFC] Add touchpad wobbliness detection

2018-02-19 Thread Konstantin Kharlamov
gnore movements of that length. No idea how's that gonna work, will check on holidays. On 19.02.2018 10:59, Peter Hutterer wrote: On Sun, Feb 18, 2018 at 01:09:22PM +0300, Konstantin Kharlamov wrote: For the purposes it seems to work fine — it's marked RFC because I see a small oddness, a

[PATCH v2] touchpad: add wobbling detection

2018-02-18 Thread Konstantin Kharlamov
;t default-init it — it's just that asking oneself a question "what default value should it have" results in "none". Signed-off-by: Konstantin Kharlamov --- src/evdev-mt-touchpad.c | 33 + src/evdev-mt-touchpad.h | 2 ++ 2 files changed, 35 ins

[PATCH 0/2 libinput] [RFC] Add touchpad wobbliness detection

2018-02-18 Thread Konstantin Kharlamov
set should be fine. Though it would be nice if someone with a "non-wobbly" touchpad could test that it does not enable hysteresis for them (it all should be good, but testing never hurts :) P.S.: I don't have commit rights. Konstantin Kharlamov (2): touchpad: remove the code

[PATCH 1/2 libinput] touchpad: remove the code for disabling hysteresis

2018-02-18 Thread Konstantin Kharlamov
Signed-off-by: Konstantin Kharlamov --- src/evdev-mt-touchpad.c | 21 + 1 file changed, 1 insertion(+), 20 deletions(-) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index 3ae1da29..ead76456 100644 --- a/src/evdev-mt-touchpad.c +++ b/src/evdev-mt-touchpad.c

[PATCH 2/2 libinput] touchpad: add wobbling detection

2018-02-18 Thread Konstantin Kharlamov
The details are explained in comment in the code. That aside, I shall mention the check is so light, that it shouldn't influence CPU performance even a bit, and can blindly be kept always enabled. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104828 Signed-off-by: Konstantin Khar