Re: [PATCH] scanner: Use unit32_t instead of uint

2016-07-17 Thread Khem Raj
On Sun, Jul 17, 2016 at 3:36 PM, Peter Hutterer wrote: > On Fri, Jul 15, 2016 at 04:23:48PM -0700, Khem Raj wrote: >> uint32_t is C99 defined stdint type >> >> Signed-off-by: Khem Raj > > subject line says unit32_t :) ah a typo. Can we git commit amend before ap

[PATCH] scanner: Use unit32_t instead of uint

2016-07-15 Thread Khem Raj
uint32_t is C99 defined stdint type Signed-off-by: Khem Raj --- src/scanner.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/scanner.c b/src/scanner.c index 6e2c3a3..ebae4cc 100644 --- a/src/scanner.c +++ b/src/scanner.c @@ -819,7 +819,7 @@ find_enumeration(struct

Re: [PATCH weston] log: Open log file CLOEXEC so child processes don't get the fd

2015-06-04 Thread Khem Raj
> On Jun 4, 2015, at 9:13 AM, Derek Foreman wrote: > > On 04/06/15 11:03 AM, Khem Raj wrote: >> >> On Jun 4, 2015 8:54 AM, "Derek Foreman" > <mailto:der...@osg.samsung.com>> wrote: >>> >>> Uses a glibc extension to fopen(), but we s

Re: [PATCH weston] log: Open log file CLOEXEC so child processes don't get the fd

2015-06-04 Thread Khem Raj
On Jun 4, 2015 8:54 AM, "Derek Foreman" wrote: > > Uses a glibc extension to fopen(), but we seem ok with glibc > extensions elsewhere (such as printf %m)... I have been using wayland/weston with musl. So this fix is not good from portability aspect. There might be glibc ' isms there but it's be

Re: [PATCH weston] make error() portable

2015-05-30 Thread Khem Raj
> On May 30, 2015, at 12:02 PM, Jon A. Cruz wrote: > > On 05/29/2015 09:14 PM, Khem Raj wrote: >> error() is not posix but gnu extension so may not be available on all >> kind of systemsi e.g. musl. > > Hi, > > Just including a few low-level notes.

[PATCH weston] make error() portable

2015-05-29 Thread Khem Raj
error() is not posix but gnu extension so may not be available on all kind of systemsi e.g. musl. Signed-off-by: Khem Raj --- configure.ac| 2 ++ src/weston-error.h | 20 src/weston-launch.c | 2 +- 3 files changed, 23 insertions(+), 1 deletion(-) create mode

Re: [libinput][PATCH] test: Move litest_log and litest_vlog outside ifdef LIBUBWIND block

2015-05-25 Thread Khem Raj
On Mon, May 25, 2015 at 4:08 PM, Peter Hutterer wrote: > On Thu, May 21, 2015 at 12:12:15PM -0700, Khem Raj wrote: >> litest_log is used in the else block as well, and we get errors like >> test/litest.c:240: error: undefined reference to 'litest_log' >> >>

[libinput][PATCH] test: Move litest_log and litest_vlog outside ifdef LIBUBWIND block

2015-05-25 Thread Khem Raj
litest_log is used in the else block as well, and we get errors like test/litest.c:240: error: undefined reference to 'litest_log' Signed-off-by: Khem Raj --- test/litest.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/test/litest.c b/test/lite

[PATCH] test: Move litest_log and litest_vlog outside ifdef LIBUBWIND block

2015-05-22 Thread Khem Raj
litest_log is used in the else block as well, and we get errors like test/litest.c:240: error: undefined reference to 'litest_log' Signed-off-by: Khem Raj --- test/litest.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/test/litest.c b/test/lite