the opening /* even if there was whitespace at the start of
the very first line.
Only emits a */ if a /* was printed.
Signed-off-by: Derek Foreman
Looks good to me:
Reviewed-by: Jon A. Cruz
---
src/scanner.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff
Adds an initial implementation of a testing tool that uses the unit
test framework to run checks against an arbitrary Wayland compositor.
Note that this is not intended for Weston-specific testing, but for
generic Wayland testing.
Signed-off-by: Jon A. Cruz
---
Changes from v1:
- Added test
Cleaned up test runner script to unify sections launching weston.
This makes the sections more legible and differences easier to spot.
Signed-off-by: Jon A. Cruz
---
tests/weston-tests-env | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/tests/weston
Cleaned up test runner script to unify sections launching weston.
This makes the sections more legible and differences easier to spot.
Signed-off-by: Jon A. Cruz
---
tests/weston-tests-env | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/tests/weston
On 11/05/2015 10:17 AM, Pekka Paalanen wrote:
> On Fri, 16 Oct 2015 12:23:47 -0700
> "Jon A. Cruz" wrote:
>
>> On 10/15/2015 01:51 AM, Pekka Paalanen wrote:
>>> I think it's better to land this stuff in pieces than massage a
>>> humongous re
Fixed instance where spaces were used instead of tabs.
Changes since v1:
* rebased
Signed-off-by: Jon A. Cruz
---
src/wayland-server-core.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/wayland-server-core.h b/src/wayland-server-core.h
index 55a2db0..73f2dd2 100644
A few of the header files had function prototypes that were not
following project conventions, sometimes even in the same file.
Corrected these to follow as per wayland-os.h.
Signed-off-by: Jon A. Cruz
---
src/wayland-client-core.h | 160 ++
src/wayland
Generated code was unconditionally adding a space to lines
in comments for copyright blocks even if the line was blank.
Updated to not add trailing whitespace for blank lines.
Signed-off-by: Jon A. Cruz
---
src/scanner.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src
Fixed instances where spaces were used instead of tabs.
Signed-off-by: Jon A. Cruz
---
src/wayland-client-core.h | 2 +-
src/wayland-server-core.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/wayland-client-core.h b/src/wayland-client-core.h
index dea70d9..d8f7f2e
During review of the addition of waycheck, it was pointed out that there
could be problems due to ZUC_TEST_F() creating an input parameter with a
hidden implicit name. This change addresses that by making the name of
the passed in parameter a required third input on the ZUC_TEST_F() macro.
Jon A
Instead of using the implicit name 'data', changed the test
with fixture macro ZUC_TEST_F() to use an additional value
to explicitly set the name to use for test data from the
fixture.
Signed-off-by: Jon A. Cruz
---
tests/config-parser-test.c
* Clarify documentation on ZUC_ASSERT_* behavior in regards to return
vs. abort()
* Added overview section on return behavior.
* Fixed spelling
* Removed outdated reference to tap function.
Changes since v1:
* Incorporated grammatical feedback.
Signed-off-by: Jon A. Cruz
---
tools/zunitc
This patch addresses some feedback of review from unrelated changes
of adding waycheck. Since that review pointed out some lack of
clarity in return behavior, it seemed appropriate to address it
independent of adding waycheck.
Jon A. Cruz (1):
zunitc: Clarify documentation on return behavior
This patch addresses some feedback of review from unrelated changes
of adding waycheck. Since that review pointed out some lack of
clarity in return behavior, it seemed appropriate to address it
independent of adding waycheck.
Jon A. Cruz (1):
zunitc: Clarify documentation on return behavior
* Clarify documentation on ZUC_ASSERT_* behavior in regards to return
vs. abort()
* Added overview section on return behavior.
* Fixed spelling
* Removed outdated reference to tap function.
Signed-off-by: Jon A. Cruz
---
tools/zunitc/doc/zunitc.dox | 80
l patch in this set?
I'd say that running it as a separate set might make juggling git a
little easier on me. But not to a degree to outweigh what would make
reviewing things easier.
--
Jon A. Cruz - Senior Open Source Developer
Samsung Open Source Group
j...@osg.samsung.com
__
ful in the context of acceptance testing, while
leaving the third phase's submission to be useful for unit and/or
integration testing.
Jon A. Cruz (1):
tests: Adding simple waycheck validation tool.
.gitignore |1 +
Makefile.am
Adds an initial implementation of a testing tool that uses the unit
test framework to run checks against an arbitrary Wayland compositor.
Note that this is not intended for Weston-specific testing, but for
generic Wayland testing.
Signed-off-by: Jon A. Cruz
---
.gitignore
Adds a config item to prevent doxygen from using absolute paths in
generated diagrams. This trims off the base directory during config to
leave just relative paths.
Signed-off-by: Jon A. Cruz
---
doc/doxygen/tooldev.doxygen.in | 1 +
doc/doxygen/tools.doxygen.in | 1 +
2 files changed, 2
code using them is minimized. These can also have
"_internal" or such as part of their name.
Upon occasion I've used a #define of UNIT_TEST to avoid exposing certain
things during normal builds. This doesn't necessarily need to expose
functions directly, but could be some hook/
ny other groups
I've been the main person to deliver fixtures and mocks to allow other
people to write tests against them. Ideally we do the heavy lifting once
and then allow individual developers to easily test a much wider range
of functionality and scenarios.
Pragmatically, If I don't m
/weston-ivi.ini : $(srcdir)/ivi-shell/weston.ini.in
> - $(AM_V_GEN)$(SED) \
> + $(AM_V_GEN)$(MKDIR_P) $(dir $@) && $(SED) \
> -e 's|@bindir[@]|$(bindir)|g' \
> -e 's|@abs_top_builddir[@]|$(abs_top_builddir)|g&#
On 07/07/2015 05:35 AM, Pekka Paalanen wrote:
> On Thu, 2 Jul 2015 23:36:47 -0700
> "Jon A. Cruz" wrote:
>
>> Signed-off-by: Jon A. Cruz
>> ---
>> .gitignore | 2 +
>> Makefile.am| 22
Signed-off-by: Jon A. Cruz
---
Makefile.am| 9 +-
tests/config-parser-test.c | 371 +
2 files changed, 319 insertions(+), 61 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index 0ab5b0a..118bafb 100644
--- a/Makefile.am
+++ b
to non-defaults only.
- Relocated Doxygen specific input files to match Wayland structure.
Jon A. Cruz (3):
Enables output in the JUnit XML format.
Converted the config parser test to the new framework.
Adding doxygen setup and info for the testing framework.
.gitignore
Signed-off-by: Jon A. Cruz
---
.gitignore | 2 +
Makefile.am| 22 +++
README | 6 +++
configure.ac | 20 ++
doc/doxygen/devtools.dox | 51 +
doc/doxygen
: Jon A. Cruz
---
Makefile.am | 9 +
configure.ac | 25 ++
tools/zunitc/src/zuc_junit_reporter.c | 470 ++
tools/zunitc/src/zuc_junit_reporter.h | 38 +++
tools/zunitc/src/zunitc_impl.c| 17 ++
5 files
On 07/07/2015 04:49 AM, Pekka Paalanen wrote:
> On Thu, 2 Jul 2015 23:36:45 -0700
> "Jon A. Cruz" wrote:
>
>> Adds basic support for optionally outputting in the XML format
>> commonly used by JUnit compatible tools.
>>
>> This format is supported
On 07/07/2015 05:08 AM, Pekka Paalanen wrote:
> On Thu, 2 Jul 2015 23:36:46 -0700
> "Jon A. Cruz" wrote:
>
>> Signed-off-by: Jon A. Cruz
>> ---
>> Makefile.am| 10 +-
>> tests/config-parser-test.c | 371
>>
Factoring in the comments by Bryce, this looks good to me.
Acked-by: Jon A. Cruz
On 07/14/2015 03:07 AM, Pekka Paalanen wrote:
> From: Pekka Paalanen
>
> What is libweston and where do we intend to go with it.
>
> Cc: Giulio Camuffo
> Signed-off-by: Pekka Paalanen
>
ndent building blocks a program can use to build a Wayland
compositor"?
This doesn't have to be set in stone immediately. However it does go to
address the points where there is code not "in libweston" but "in
main.c" that is doing work that some would consider the
Signed-off-by: Jon A. Cruz
---
.gitignore | 2 +
Makefile.am| 22 +++
configure.ac | 20 ++
doc/doxygen/devtools.dox | 51 +
doc/doxygen/tooldev.doxygen.in | 11 ++
doc/doxygen/tools.dox
e.
- Updated fixture construction, including being able to specify the Wayland
instance to connect to.
- Reduced Doxygen config files to non-defaults only.
- Relocated Doxygen specific input files to match Wayland structure.
Jon A. Cruz (4):
Added simple unit/integration test framework and corres
: Jon A. Cruz
---
Makefile.am | 9 +
configure.ac | 26 ++
tools/zunitc/src/zuc_junit_reporter.c | 488 ++
tools/zunitc/src/zuc_junit_reporter.h | 38 +++
tools/zunitc/src/zunitc_impl.c| 17 ++
5 files
Signed-off-by: Jon A. Cruz
---
Makefile.am| 10 +-
tests/config-parser-test.c | 371 +
2 files changed, 320 insertions(+), 61 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index 89d9e4c..42f0ed4 100644
--- a/Makefile.am
+++ b
On 07/02/2015 11:02 PM, Pekka Paalanen wrote:
> On Thu, 02 Jul 2015 18:12:21 -0700
> "Jon A. Cruz" wrote:
>
>> On 06/25/2015 07:18 AM, Pekka Paalanen wrote:
>>> On Sat, 20 Jun 2015 15:47:47 -0700
>>> "Jon A. Cruz" wrote:
On 06/25/2015 07:18 AM, Pekka Paalanen wrote:
> On Sat, 20 Jun 2015 15:47:47 -0700
> "Jon A. Cruz" wrote:
>
>> > +static void *setup_test_config(void *data)
>> > +{
>> > + struct weston_config *config = load_config(d
On 06/25/2015 07:18 AM, Pekka Paalanen wrote:
> On Sat, 20 Jun 2015 15:47:47 -0700
> "Jon A. Cruz" wrote:
>
>> > Signed-off-by: Jon A. Cruz
>> > ---
>> > Makefile.am| 9 +-
>> > tests/config-parser-test.c | 368
>
e something in perhaps a README/CONTRIBUTING or such.
On the other hand, it could be considered non-obvious that the both-null
case is the valid uninitialized situation and thus could warrant a
comment after all. Given that there already was some misreading of
Peter's intent, it might help
On 06/25/2015 05:36 AM, Pekka Paalanen wrote:
> On Sat, 20 Jun 2015 15:47:44 -0700
> "Jon A. Cruz" wrote:
>
>> Signed-off-by: Jon A. Cruz
>> ---
>> tools/zunitc/src/main.c | 11 ++-
>> 1 file changed, 10 insertions(+), 1 deletion(-)
>>
ith bad parameter
>
> Signed-off-by: Nobuhiko Tanibata
> Reviewed-by: Pekka Paalanen
Looks good.
Reviewed-by: Jon A. Cruz
> ---
> tests/ivi_layout-internal-test.c | 69
>
> 1 file changed, 69 insertions(+)
>
> diff --
of creating ivi-layer
> - notification of removing ivi-layer
>
> Signed-off-by: Nobuhiko Tanibata
> Reviewed-by: Pekka Paalanen
Looks good.
Reviewed-by: Jon A. Cruz
> ---
> tests/ivi_layout-internal-test.c | 152
> +++
> 1 file chang
ff-by: Nobuhiko Tanibata
> Reviewed-by: Pekka Paalanen
Looks good.
Reviewed-by: Jon A. Cruz
> ---
> tests/ivi_layout-test-plugin.c | 22 ++
> tests/ivi_layout-test.c| 1 +
> 2 files changed, 23 insertions(+)
>
> diff --git a/tests/ivi_layout-t
ivi-surface configure
> - notification of creating ivi-surface
> - notification of removing ivi-surface
>
> Signed-off-by: Nobuhiko Tanibata
> Reviewed-by: Pekka Paalanen
Looks good.
Reviewed-by: Jon A. Cruz
> ---
> tests/ivi_layout-test-plugin.c | 172
> +++
e.
>
> [Pekka: add serialization checks, rename the global, rewrite commit message.]
> Signed-off-by: Pekka Paalanen
Looks good.
Reviewed-by: Jon A. Cruz
> ---
> tests/ivi_layout-test-plugin.c | 45
> --
> 1 file changed, 35 i
er with bad parameter
> - destroy ivi-layer in the ivi-screen and call commit_changes
>
> Signed-off-by: Nobuhiko Tanibata
> Reviewed-by: Pekka Paalanen
Looks good.
Reviewed-by: Jon A. Cruz
> ---
> tests/ivi_layout-internal-test.c | 102
> +++
er with bad parameter
> - destroy ivi-layer in the ivi-screen and call commit_changes
>
> Signed-off-by: Nobuhiko Tanibata
> Reviewed-by: Pekka Paalanen
Looks good.
Reviewed-by: Jon A. Cruz
> ---
> tests/ivi_layout-internal-test.c | 102
> +++
der of ivi-layers in ivi-screen
>
> Signed-off-by: Nobuhiko Tanibata
> Reviewed-by: Pekka Paalanen
Looks good.
Reviewed-by: Jon A. Cruz
> ---
> tests/ivi_layout-internal-test.c | 105
> ++-
> 1 file changed, 104 insertions(+), 1 deletion(-
- orientation
> - dimension
> - position
> - destination rectangle
> - source rectangle
>
> Signed-off-by: Nobuhiko Tanibata
> Reviewed-by: Pekka Paalanen
Looks good.
Reviewed-by: Jon A. Cruz
> ---
> tests/ivi_layout-internal-test.c | 277
>
_changes
> - call set_source_rectangle, destroy ivi-layer, and commit_changes
> - call set_destination_rectangle, destroy ivi-layer, and commit_changes
> - create duplicate
> - destroy ivi-layer and call get_layer
>
> Signed-off-by: Nobuhiko Tanibata
> Reviewed-by: Pekka Paalane
fter a ivi_surface in render order is destoryed
>
> Signed-off-by: Nobuhiko Tanibata
> Reviewed-by: Pekka Paalanen
Looks good.
Reviewed-by: Jon A. Cruz
> ---
> tests/ivi_layout-test-plugin.c | 113
> +
> tests/ivi_layout-test.c
Tanibata
> Reviewed-by: Pekka Paalanen
Looks good.
Reviewed-by: Jon A. Cruz
> ---
> tests/ivi-test.h | 4
> tests/ivi_layout-test-plugin.c | 42
> ++
> tests/ivi_layout-test.c| 27 +++
set_destination_rectangle, destroy ivi-surface, and
> commit_changes
>
> Signed-off-by: Nobuhiko Tanibata
> Reviewed-by: Pekka Paalanen
Looks good.
Reviewed-by: Jon A. Cruz
> ---
> tests/ivi_layout-test-plugin.c | 134
> +
> tes
orientation with bad parameter
> - dimension with bad parameter
> - position with bad parameter
> - source_rectangle with bad parameter
> - properties with bad parameter
>
> Signed-off-by: Nobuhiko Tanibata
> Reviewed-by: Pekka Paalanen
Looks good.
Reviewed-by: Jon A.
With those details explained, this looks good.
Reviewed-by: Jon A. Cruz
On 06/23/2015 05:56 AM, Pekka Paalanen wrote:
> On Mon, 22 Jun 2015 17:28:23 -0700
> "Jon A. Cruz" wrote:
>
>> On 06/21/2015 11:33 PM, Nobuhiko Tanibata wrote:
>>> From: Nobuhiko
On 06/24/2015 09:32 AM, Bill Spitzak wrote:
> On Tue, Jun 23, 2015 at 9:55 PM, Jon A. Cruz wrote:
>
>>
>> Looking into it more, I think I've figured out much of that on my part
>> comes from C++ and other OO languages I've worked in. Especially with
>>
(either in later revisions or in follow-ups as needed).
> More below.
>
>
> On Thu, 11 Jun 2015 22:01:27 -0700
> "Jon A. Cruz" wrote:
>
>> Added a simple C-based test framework and an example program
>> that uses it to run through some simple wayland cli
rsions. Nice. I've been in a few situations where this
really helps. Looks good.
Reviewed-by: Jon A. Cruz
> ---
> Makefile.am | 59 ++-
> configure.ac | 3 +++
> src/input.c | 2 +-
> 3 files changed, 42 insertions(+), 2
I think it would be quite worth it to
complete the final 20% and not punt by hardcoding.
Secondary issue is that we've now ended up with overloading the term
"compositor" in our code to have "weston_compositor" and
"compositor_x11" belonging to different sets. Howe
Oh I forgot an item on the placement of comments.
On 06/23/2015 04:31 PM, Jon A. Cruz wrote:
>
> Minor doxygen note: the explicit "\brief" is not needed, and the brief
> description should end with a '.' to allow the auto-brief to pick it up.
>
> Overall
Just a few minor low-level items in this feedback...
On 06/22/2015 01:02 PM, Giulio Camuffo wrote:
> The backends used to have lots of code dealing with weston specific configs.
> To allow them to be used by other compositors with their own configurations
> remove all the usage of weston_config fr
wn by calling the compositor's exit vfunc which is set by the
> libweston application.
> - weston_compositor_destroy(compositor) is called by the libweston
> application when tearing down the compositor. The compositor is destroyed
> and the memory freed.
> ---
Reviewed-by: Jon
r my backend into main compositor code. not in the plugin
>>>> itself.
>>>> Since it is kind of hardcode, I thought it doesn't look good. I think
>>>> that
>>>> plugin should have such information of itself and compositor should load
>>>> such information from plugin file.
>>>>
>>>> (similar case: In case of NPAPI, Web browser can show plugin's
>>>> information
>>>> by getting/calling "NP_GetMIMEDescription()" from each plugin .so file.
>>>> e.g
>>>> - about:config in Mozilla)
>>>>
>>>> So, I created this patch for better (weston specific) backend plugin
>>>> management structure.
>>>>
>>>>>
>>>>> AFAIK the Weston SDK (the installed headers) for external plugins never
>>>>> supported external backends, so I'm curious.
>>>>>
>>>>
>>>> Since this kind of plugin just need header files for building and
>>>> weston.pc
>>>> is also already supported, I thought that building external backend
>>>> plugin
>>>> is supported (and ideally possible in current version of weston)... but
>>>> wasn't it??
>>>> If it can be supported, it would be good for like my case. Developer can
>>>> create the backend plugin without build all weston source.. (like other
>>>> '-dev' pkg supported program)
>>>>
>>>>
>>>>> We are going in the direction of backends becoming libweston internal
>>>>> details, not something you can plug and switch arbitrarily, at least
>>>>> for the middle-term.
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> Thanks,
>>>>> pq
>>>>
>>>>
>>
>>
> ___
> wayland-devel mailing list
> wayland-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel
>
--
Jon A. Cruz - Senior Open Source Developer
Samsung Open Source Group
j...@osg.samsung.com
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/wayland-devel
_rectangle(
> + ivisurf, 20, 30, 200, 300) == IVI_SUCCEEDED);
> +
> + prop = ctl->get_properties_of_surface(ivisurf);
> + runner_assert_or_return(prop);
> + runner_assert(prop->source_width == 0);
> + runner_assert(prop->source_height == 0);
> +
Signed-off-by: Jon A. Cruz
---
tools/zunitc/src/main.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/tools/zunitc/src/main.c b/tools/zunitc/src/main.c
index cc86185..8179807 100644
--- a/tools/zunitc/src/main.c
+++ b/tools/zunitc/src/main.c
@@ -41,7 +41,16
Signed-off-by: Jon A. Cruz
---
Makefile.am| 9 +-
tests/config-parser-test.c | 368 +
2 files changed, 310 insertions(+), 67 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index f0ed4d2..8234d2a 100644
--- a/Makefile.am
+++ b
Adds basic support for optionally outputting in the Test Anything
Protocol (TAP) format.
This format is a bit older and simplistic, but certain tools
handle it well.
https://testanything.org/
Signed-off-by: Jon A. Cruz
---
Makefile.am | 2 +
tools/zunitc/inc/zunitc
Doxygen config files to non-defaults only.
- Relocated Doxygen specific input files to match Wayland structure.
Jon A. Cruz (6):
Added simple unit/integration test framework and corresponding
test program.
By default, stop test execution if unrecognized parameters are
encountered
Signed-off-by: Jon A. Cruz
---
.gitignore| 2 +
doc/doxygen/devtools.dox | 55
doc/doxygen/tooldev.doxygen | 11 ++
doc/doxygen/tools.dox | 32
doc/doxygen/tools.doxygen | 11 ++
doc/doxygen
: Jon A. Cruz
---
Makefile.am | 10 +
configure.ac | 6 +
tools/zunitc/inc/zunitc/zunitc.h | 10 +
tools/zunitc/src/zuc_junit_reporter.c | 464 ++
tools/zunitc/src/zuc_junit_reporter.h | 38 +++
tools
currently state they require DEBUG to be enabled in order to
work, it is still very good to avoid modification from assert() wrapped
code. Moving to a different framework could fail immediately due to this.
Looks good.
Reviewed-by: Jon A. Cruz
--
Jon A. Cruz - Senior Open Source Develope
\
> -I$(top_srcdir)/src \
> -DICONDIR=\"$(ICONDIR)\"
>
Looks good. As I mentioned to Derek earlier I had just hit this in the
documentation when checking for some other things I was addi
)
> +ivi_layout_internal_test_la_CFLAGS = $(AM_CFLAGS) $(COMPOSITOR_CFLAGS)
> ivi_layout_internal_test_la_SOURCES =\
> tests/ivi_layout-internal-test.c
>
> ivi_layout_test_la_LIBADD = $(COMPOSITOR_LIBS)
> ivi_layout_test_la_LDFLAGS = $(test_module_ldflags
> TFD_CLOEXEC | TFD_NONBLOCK);
> + TFD_CLOEXEC | TFD_NONBLOCK);
> source->func = func;
>
> return add_source(loop, &source->base, WL_EVENT_READABLE, data);
>
Looks good. (Seems like someone had tabs
ommitted version doesn't match what we want to use, can someone
point me to the preferred version?
(I had used the text from one of the recent license change patches, but
guess I might have missed the final form)
--
Jon A. Cruz - Senior Open Source Developer
Samsung Open Sour
Signed-off-by: Jon A. Cruz
---
Makefile.am | 129
1 file changed, 95 insertions(+), 34 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index 261798c..1cfc982 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -86,6 +86,7
This covers a couple of follow-up items Pekka spotted in the
patchset moving a few common macros into the new helpers.h header.
Jon A. Cruz (2):
Added new include file to all SOURCES variables with files that
use it.
Do not install the new helpers macro header file.
Makefile.am
Signed-off-by: Jon A. Cruz
---
Makefile.am | 1 -
1 file changed, 1 deletion(-)
diff --git a/Makefile.am b/Makefile.am
index 1cfc982..125d8c3 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -190,7 +190,6 @@ westoninclude_HEADERS = \
src/timeline-object.h
On 06/16/2015 06:21 AM, Pekka Paalanen wrote:
> On Tue, 9 Jun 2015 15:15:52 +1000
> Peter Hutterer wrote:
>
>> On Thu, Jun 04, 2015 at 12:50:47AM -0700, Jon A. Cruz wrote:
>>> On 06/03/2015 10:15 PM, Peter Hutterer wrote:
>>>> On Tue, May 26, 2015 at
On 06/16/2015 02:48 AM, Pekka Paalanen wrote:
> On Mon, 15 Jun 2015 15:37:08 -0700
> "Jon A. Cruz" wrote:
>
>> To help reduce code duplication and also 'kitchen-sink' includes
>> the ARRAY_LENGTH macro was moved to a stand-alone file and
>> referen
Using the parent '../' path component in #include statements makes
the codebase more rigid and is redundant due to proper -I use.
Signed-off-by: Jon A. Cruz
---
clients/calibrator.c | 2 +-
clients/desktop-shell.c| 4 ++--
clients/dnd.c
Removed multiple definitions of the MIN() macro from existing
locations and unified with a single definition. Updated sources
to use the shared version.
Signed-off-by: Jon A. Cruz
---
clients/nested.c | 2 --
clients/weston-info.c | 2 --
clients/window.c | 2 --
desktop-shell
Removed duplicate definitions of the container_of() macro and
refactored sources to use the single implementation.
Signed-off-by: Jon A. Cruz
---
clients/clickdot.c | 1 +
clients/desktop-shell.c | 1 +
clients/window.h| 4
desktop-shell
To help reduce code duplication and also 'kitchen-sink' includes
the ARRAY_LENGTH macro was moved to a stand-alone file and
referenced from the sources consuming it. Other macros will be
added in subsequent passes.
Signed-off-by: Jon A. Cruz
---
Makefile.am
As a follow-up to review feedback from Peter Hutterer this
set moves a few duplicated macros into a common header,
including ARRAY_LENGTH.
Changes since v1:
- Added example to container_of() doc comment.
Jon A. Cruz (4):
Remove redundant #include path component.
Moved helper macro to a
To help reduce code duplication and also 'kitchen-sink' includes
the ARRAY_LENGTH macro was moved to a stand-alone file and
referenced from the sources consuming it. Other macros will be
added in subsequent passes.
Signed-off-by: Jon A. Cruz
---
Makefile.am
As a follow-up to review feedback from Peter Hutterer this
set moves a few duplicated macros into a common header,
including ARRAY_LENGTH.
Jon A. Cruz (4):
Remove redundant #include path component.
Moved helper macro to a discrete include file.
Moved the MIN() macro to the helper include
Removed multiple definitions of the MIN() macro from existing
locations and unified with a single definition. Updated sources
to use the shared version.
Signed-off-by: Jon A. Cruz
---
clients/nested.c | 2 --
clients/weston-info.c | 2 --
clients/window.c | 2 --
desktop-shell
Using the parent '../' path component in #include statements makes
the codebase more rigid and is redundant due to proper -I use.
Signed-off-by: Jon A. Cruz
---
clients/calibrator.c | 2 +-
clients/desktop-shell.c| 4 ++--
clients/dnd.c
Removed duplicate definitions of the container_of() macro and
refactored sources to use the single implementation.
Signed-off-by: Jon A. Cruz
---
clients/clickdot.c | 1 +
clients/desktop-shell.c | 1 +
clients/window.h| 4
desktop-shell
Signed-off-by: Jon A. Cruz
---
Makefile.am| 9 +-
tests/config-parser-test.c | 368 +
2 files changed, 310 insertions(+), 67 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index 9bd4b29..81f0f41 100644
--- a/Makefile.am
+++ b
Adds basic support for optionally outputting in the Test Anything
Protocol (TAP) format.
This format is a bit older and simplistic, but certain tools
handle it well.
https://testanything.org/
Signed-off-by: Jon A. Cruz
---
Makefile.am | 2 +
tools/zunitc/inc/zunitc
Signed-off-by: Jon A. Cruz
---
.gitignore| 2 ++
doc/doxygen/devtools.dox | 52 +++
doc/doxygen/tooldev.doxygen | 11 ++
doc/doxygen/tools.dox | 29 +++
doc/doxygen/tools.doxygen | 11 ++
doc/doxygen
.
- Reduced Doxygen config files to non-defaults only.
- Relocated Doxygen specific input files to match Wayland structure.
Jon A. Cruz (6):
Added simple unit/integration test framework and corresponding
test program.
By default, stop test execution if unrecognized parameters are
: Jon A. Cruz
---
Makefile.am | 2 +
tools/zunitc/inc/zunitc/zunitc.h | 8 +
tools/zunitc/src/zuc_junit_reporter.c | 473 ++
tools/zunitc/src/zuc_junit_reporter.h | 35 +++
tools/zunitc/src/zunitc_impl.c| 12 +
5 files
Signed-off-by: Jon A. Cruz
---
tools/zunitc/src/main.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/tools/zunitc/src/main.c b/tools/zunitc/src/main.c
index 3e155d8..9a110d4 100644
--- a/tools/zunitc/src/main.c
+++ b/tools/zunitc/src/main.c
@@ -38,7 +38,16
cking a link to Patchwork from the website, not to
> mention an explanation on how to use Patchwork...
Plus I think Patchwork is missing a password reset.
Currently that's what is blocking me from updating.
--
Jon A. Cruz - Senior Open Source Developer
Samsung Open Source Group
j...@o
On 06/09/2015 04:55 PM, Derek Foreman wrote:
> On 09/06/15 06:24 PM, Jon A. Cruz wrote:
>> On 06/08/2015 09:46 AM, Derek Foreman wrote:
>>> We were loading modules out of the system dirs unconditionally, so
>>> tests that loaded modules would use the system ones,
}
>
> module = dlopen(path, RTLD_NOW | RTLD_NOLOAD);
> if (module) {
After the calls to snprintf, for safety the last byte of the 'path'
buffer should be explicitly zeroed as technically null-termination is
not guaranteed.
--
Jon A. Cruz - Senior Open Source Developer
Sam
t_method(struct text_backend *text_backend)
> if (!text_backend->input_method.path)
> return;
>
> + if (strcmp(text_backend->input_method.path, "") == 0)
> + return;
> +
> if (text_backend->input_method.process.pid !=
1 - 100 of 176 matches
Mail list logo
