Re: [PATCH v6 03/44] drm/vkms: Add kunit tests for VKMS LUT handling

2024-10-08 Thread Jeff Johnson
On 10/3/24 13:00, Harry Wentland wrote: > Debugging LUT math is much easier when we can unit test ... > diff --git a/drivers/gpu/drm/vkms/tests/vkms_color_test.c > b/drivers/gpu/drm/vkms/tests/vkms_color_test.c > new file mode 100644 > index ..efe139978860 > --- /dev/null > +++ b/drive

Re: [PATCH v5 03/44] drm/vkms: Add kunit tests for VKMS LUT handling

2024-08-21 Thread Jeff Johnson
On 8/19/24 13:56, Harry Wentland wrote: > Debugging LUT math is much easier when we can unit test > it. Add kunit functionality to VKMS and add tests for > - get_lut_index > - lerp_u16 > > v5: > - Bring back static for lerp_u16 and get_lut_index (Arthur) > > v4: > - Test the critical points o

Re: [PATCH v5 20/44] drm/tests: Add a few tests around drm_fixed.h

2024-08-21 Thread Jeff Johnson
On 8/19/24 13:56, Harry Wentland wrote: > While working on the CTM implementation of VKMS I had to ascertain > myself of a few assumptions. One of those is whether drm_fixed.h > treats its numbers using signed-magnitude or twos-complement. It is > twos-complement. > > In order to make someone else