Re: [PATCH_v2] virtual-keyboard: Add new virtual keyboard protocol

2018-05-30 Thread Jan Arne Petersen
end non-text from a virtual keyboard to an application it makes more sense to have some protocol to send keysyms for example. Regards Jan Arne Petersen ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH wayland-protocols v7] text: Create second version of text input protocol

2016-10-14 Thread Jan Arne Petersen
Hi, On Wed, 2016-10-12 at 15:50 -0700, Bryce Harrington wrote: > On Wed, Jul 06, 2016 at 12:26:28AM +0200, Jan Arne Petersen wrote: > > > > On Thu, Jun 9, 2016 at 1:01 PM Carlos Garnacho > > wrote: > > > > Hi Carlos, > > > > Thanks for the feedb

Re: [PATCH weston 3/3] simple-im: Rename source file to be consistent with other client tools

2016-10-12 Thread Jan Arne Petersen
>    keyboard->serial, > - >    "", ""); > - zwp_input_method_context_v1_cursor_p > osition(keyboard->context, > - > 0, 0); > - zwp_input_method_context_v1_commit_s > tring(keyboard->context, > - >   keyboard->serial, > - >   cs->text); > - keyboard->compose_state = > state_normal; > - } else { > - uint32_t j = 0, idx = 0; > - > - for (; j <= i; j++) { > - idx += > xkb_keysym_to_utf8(cs->keys[j], text + idx, sizeof(text) - idx); > - } > - > - zwp_input_method_context_v1_preedit_ > cursor(keyboard->context, > - >    strlen(text)); > - zwp_input_method_context_v1_preedit_ > string(keyboard->context, > - >    keyboard->serial, > - >    text, > - >    text); > - } > - } else { > - uint32_t j = 0, idx = 0; > - > - for (; j <= i; j++) { > - idx += xkb_keysym_to_utf8(keyboard- > >compose_seq.keys[j], text + idx, sizeof(text) - idx); > - } > - zwp_input_method_context_v1_preedit_cursor(k > eyboard->context, > -    0 > ); > - zwp_input_method_context_v1_preedit_string(k > eyboard->context, > -    k > eyboard->serial, > -    " > ", ""); > - zwp_input_method_context_v1_cursor_position( > keyboard->context, > - > 0, 0); > - zwp_input_method_context_v1_commit_string(ke > yboard->context, > -   ke > yboard->serial, > -   te > xt); > - keyboard->compose_state = state_normal; > - } > - return; > - } > - > - if (xkb_keysym_to_utf8(sym, text, sizeof(text)) <= 0) { > - zwp_input_method_context_v1_key(context, serial, > time, key, state); > - return; > - } > - > - if (state == WL_KEYBOARD_KEY_STATE_PRESSED) > - return; > - > - zwp_input_method_context_v1_cursor_position(keyboard- > >context, > - 0, 0); > - zwp_input_method_context_v1_commit_string(keyboard->context, > -   keyboard->serial, > -   text); > -} > - > -int > -main(int argc, char *argv[]) > -{ > - struct simple_im simple_im; > - int ret = 0; > - > - memset(&simple_im, 0, sizeof(simple_im)); > - > - simple_im.display = wl_display_connect(NULL); > - if (simple_im.display == NULL) { > - fprintf(stderr, "Failed to connect to server: > %m\n"); > - return -1; > - } > - > - simple_im.registry = > wl_display_get_registry(simple_im.display); > - wl_registry_add_listener(simple_im.registry, > -  ®istry_listener, &simple_im); > - wl_display_roundtrip(simple_im.display); > - if (simple_im.input_method == NULL) { > - fprintf(stderr, "No input_method global\n"); > - return -1; > - } > - > - simple_im.xkb_context = > xkb_context_new(XKB_CONTEXT_NO_FLAGS); > - if (simple_im.xkb_context == NULL) { > - fprintf(stderr, "Failed to create XKB context\n"); > - return -1; > - } > - > - simple_im.context = NULL; > - simple_im.key_handler =  simple_im_key_handler; > - > - while (ret != -1) > - ret = wl_display_dispatch(simple_im.display); > - > - if (ret == -1) { > - fprintf(stderr, "Dispatch error: %m\n"); > - return -1; > - } > - > - return 0; > -} This series looks good: Reviewed-by: Jan Arne Petersen ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH wayland-protocols v7] text: Create second version of text input protocol

2016-07-06 Thread Jan Arne Petersen
On Wed, Jul 6, 2016, 01:44 Jonas Ådahl wrote: > On Wed, Jul 06, 2016 at 12:26:28AM +0200, Jan Arne Petersen wrote: > > On Thu, Jun 9, 2016 at 1:01 PM Carlos Garnacho > wrote: > > > > Hi Carlos, > > > > Thanks for the feedback. > > > > > &g

Re: [PATCH 5/5] text-backend: update to version 2 of text input protocol

2016-07-05 Thread Jan Arne Petersen
On Tue, Jul 5, 2016 at 10:46 PM Arnaud Vrac wrote: > > > On 5 juil. 2016, at 22:11, Jan Arne Petersen wrote: > > > > > > On Wed, Jun 8, 2016 at 5:40 PM Arnaud Vrac wrote: > > The input method protocol should be updated next: > > * we need the input m

Re: [PATCH wayland-protocols v7] text: Create second version of text input protocol

2016-07-05 Thread Jan Arne Petersen
and v2, so please bear with me, I > hope the feedback is useful. Sure that is perfectly fine, I think that is the idea of the unstable protocols anyways that we can still change everything and adapt them with real world experience. > > On Mon, May 30, 2016 at 11:41 AM, Jan Arne

Re: [PATCH 5/5] text-backend: update to version 2 of text input protocol

2016-07-05 Thread Jan Arne Petersen
83,7 +591,7 @@ input_method_context_modifiers_map(struct wl_client > *client, > wl_resource_get_user_data(resource); > > if (context->input) > - > zwp_text_input_v1_send_modifiers_map(context->input->resource, > + > zwp_text_input_v2_send_modifiers_map(context->

Re: [PATCH 3/5] text-backend: implement keyboard release

2016-07-05 Thread Jan Arne Petersen
mp;keyboard_interface, > + context, unbind_keyboard); > > context->keyboard = cr; > > -- > 2.7.4 > > In an update to the input-method protocol we need to remove the wl_keyboard from the protocol anyways ( https://bugs.freedesktop.

Re: [PATCH 2/5] text-backend: track shown panel

2016-07-05 Thread Jan Arne Petersen
nal, >&text_input->cursor_rectangle); > + if (text_input->manager->current_panel == NULL) > + text_input->manager->current_panel = text_input; > } > } > > -- > 2.7.4 > > Looks go

Re: [PATCH 1/5] text-backend: send event when the input panel visiblity changes

2016-07-05 Thread Jan Arne Petersen
de_input_panel(struct wl_client *client, > struct text_input *text_input = > wl_resource_get_user_data(resource); > struct weston_compositor *ec = text_input->ec; > > - text_input->input_panel_visible = false; > + text_input_set_input_panel_visible(t

[PATCH wayland-protocols v7] text: Create second version of text input protocol

2016-05-30 Thread Jan Arne Petersen
@@ + + + + +Copyright © 2012, 2013 Intel Corporation +Copyright © 2015, 2016 Jan Arne Petersen + +Permission to use, copy, modify, distribute, and sell this +software and its documentation for any purpose is hereby granted +without fee, provided that the above copyright notice appear in +all

[PATCH wayland-protocols v6] text: Create second version of text input protocol

2016-04-03 Thread Jan Arne Petersen
wp_text_input per wl_seat (client side should be handled by client toolkit) * Allow focus tracking without wl_keyboard present * Improve update state handling and better define state handling Signed-off-by: Jan Arne Petersen --- Changes to v5: * Remove client side created serial for synchronisation * Make

Re: [PATCH wayland-protocols v5] text: Create second version of text input protocol

2016-03-26 Thread Jan Arne Petersen
On Fri, Mar 25, 2016 at 8:16 AM Daiki Ueno wrote: > Hello, > > Jan Arne Petersen writes: > > > There is a reference implementation of this version of the protocol in > QtWayland > > https://codereview.qt-project.org/#/c/153711/ where the text-input > protocol is

Re: [PATCH wayland-protocols v5] text: Create second version of text input protocol

2016-03-26 Thread Jan Arne Petersen
urface), is that planned to be improved in the future? > Yes, I first want to get the text protocol ready. But yes the input-method protocol will be completely redesigned also. > See my other comments below. > > On Monday, 14 March 2016 12:58:27 PDT Jan Arne Petersen wrote: > > +

Re: [PATCH wayland-protocols v5] text: Create second version of text input protocol

2016-03-23 Thread Jan Arne Petersen
qtvirtualkeyboard (which plugs in the Qt input method system) in the Qt compositor and use that to input text in all clients. Jan Arne Petersen On Mon, Mar 14, 2016 at 12:58 PM Jan Arne Petersen wrote: > There were some shortcomings in the first version of the protocol which > makes it not

[PATCH wayland-protocols v5] text: Create second version of text input protocol

2016-03-14 Thread Jan Arne Petersen
wp_text_input per wl_seat (client side should be handled by client toolkit) * Allow focus tracking without wl_keyboard present * Improve update state handling and better define state handling Signed-off-by: Jan Arne Petersen --- Chnages to v4: * Improved descriptions * Remove invoke_action request

Re: [PATCH v4 wayland-protocols] text: Create second version of text input protocol

2016-02-19 Thread Jan Arne Petersen
Hi, On 18/02/16 20:36, Rui Tiago Cação Matos wrote: > On Wed, Feb 17, 2016 at 6:13 AM, Jan Arne Petersen wrote: >>>> + > ... >>>> + >>>> + >>>> + >>>> + >>> >>> These arguments could

Re: [PATCH v4 wayland-protocols] text: Create second version of text input protocol

2016-02-16 Thread Jan Arne Petersen
Hi, On 08/02/16 16:38, Rui Tiago Cação Matos wrote: > Hi, > > Thanks for the update. I'm replying to both v4 and your reply to my > previous mail. Inline: > > On Tue, Feb 2, 2016 at 2:33 PM, Jan Arne Petersen wrote: >> + >> + >> + D

Re: [PATCH v3 wayland-protocols] text: Create second version of text input protocol

2016-02-02 Thread Jan Arne Petersen
ext-input/text-input-unstable-v2.xml >> @@ -0,0 +1,481 @@ >> + >> + >> + >> + >> +Copyright © 2012, 2013 Intel Corporation >> +Copyright © 2015, 2016 Jan Arne Petersen >> + >> +Permission to use, copy, modify, distribute, and sell

[PATCH v4 wayland-protocols] text: Create second version of text input protocol

2016-02-02 Thread Jan Arne Petersen
@@ + + + + +Copyright © 2012, 2013 Intel Corporation +Copyright © 2015, 2016 Jan Arne Petersen + +Permission to use, copy, modify, distribute, and sell this +software and its documentation for any purpose is hereby granted +without fee, provided that the above copyright notice

Re: [PATCH wayland-protocols] text: Create second version of text input protocol

2016-02-02 Thread Jan Arne Petersen
On 29/01/16 21:43, Bill Spitzak wrote: > > > On Wed, Jan 27, 2016 at 11:52 PM, Jan Arne Petersen <mailto:jana...@gmail.com>> wrote: > > > + > + > + Notify when a new composing text (pre-edit) should be set > around the &

Re: [PATCH wayland-protocols] text: Create second version of text input protocol

2016-02-02 Thread Jan Arne Petersen
On 29/01/16 00:33, Bill Spitzak wrote: > > > On Wed, Jan 27, 2016 at 11:52 PM, Jan Arne Petersen <mailto:jana...@gmail.com>> wrote: > > > + Text is generally UTF-8 encoded, indices and lengths are in > bytes. > > > Remove the word "

Re: [PATCH wayland-protocols] text: Create second version of text input protocol

2016-02-02 Thread Jan Arne Petersen
per wl_suface via enable/disable (renamed in v3). So there is only text input happening when the surface which has text focus is also enabled. > Not having a destroy request isn't so bad if that's the intended scope > but I think we should still have one. Added them. &

Re: [PATCH wayland-protocols] text: Create second version of text input protocol

2016-02-02 Thread Jan Arne Petersen
Hi, On 28/01/16 13:05, Daiki Ueno wrote: > Hello, > > Jan Arne Petersen writes: > >> Fixes some shortcomings of the first version: >> >> * Use only one wp_text_input per wl_seat (client side should be >> handled by client toolkit) >> * Allow

Re: [PATCH wayland-protocols] text: Create second version of text input protocol

2016-02-02 Thread Jan Arne Petersen
On 28/01/16 11:05, Jonas Ådahl wrote: > On Thu, Jan 28, 2016 at 08:52:40AM +0100, Jan Arne Petersen wrote: >> There were some shortcomings in the first version of the protocol which >> makes it not really useful in real world applications. It is not really >> possible to fix

[PATCH v3 wayland-protocols] text: Create second version of text input protocol

2016-02-02 Thread Jan Arne Petersen
@@ + + + + +Copyright © 2012, 2013 Intel Corporation +Copyright © 2015, 2016 Jan Arne Petersen + +Permission to use, copy, modify, distribute, and sell this +software and its documentation for any purpose is hereby granted +without fee, provided that the above copyright notice

[PATCH v2 wayland-protocols] text: Create second version of text input protocol

2016-02-02 Thread Jan Arne Petersen
@@ + + + + +Copyright © 2012, 2013 Intel Corporation +Copyright © 2015, 2016 Jan Arne Petersen + +Permission to use, copy, modify, distribute, and sell this +software and its documentation for any purpose is hereby granted +without fee, provided that the above copyright notice

Re: [PATCH wayland-protocols] text: Create second version of text input protocol

2016-01-28 Thread Jan Arne Petersen
still add another request with a fd to a later protocol version. Regards Jan Arne -- Jan Arne Petersen | jan.peter...@kdab.com | Senior Software Engineer KDAB (Deutschland) GmbH&Co KG, a KDAB Group company Tel: +49-30-521325470 KDAB - The Qt Experts __

[PATCH wayland-protocols] text: Create second version of text input protocol

2016-01-27 Thread Jan Arne Petersen
@@ + + + + +Copyright © 2012, 2013 Intel Corporation +Copyright © 2015, 2016 Jan Arne Petersen + +Permission to use, copy, modify, distribute, and sell this +software and its documentation for any purpose is hereby granted +without fee, provided that the above copyright notice

Re: [PATCH weston 05/10] Use input method protocol from wayland-protocols

2015-11-04 Thread Jan Arne Petersen
On 04/11/15 09:49, Jonas Ådahl wrote: > Signed-off-by: Jonas Ådahl Reviewed-by: Jan Arne Petersen > --- > Makefile.am | 17 ++- > clients/keyboard.c | 174 +- > clients/weston-simple-im.c | 122 +-- > d

Re: [PATCH weston 04/10] Use text input protocol from wayland-protocols

2015-11-04 Thread Jan Arne Petersen
On 04/11/15 09:49, Jonas Ådahl wrote: > Signed-off-by: Jonas Ådahl Reviewed-by: Jan Arne Petersen > --- > Makefile.am| 21 ++- > clients/editor.c | 119 + > clients/keyboard.c | 12 +- > protoc

Re: Unstable protocol name breakage

2015-10-20 Thread Jan Arne Petersen
o use a different stable name for them (they both need to be fixed in a non backward compatible way anyways). Regards Jan Arne -- Jan Arne Petersen | jan.peter...@kdab.com | Senior Software Engineer KDAB (Deutschland) GmbH&Co KG, a KDAB Group company Tel: +49-3

Re: [PATCH weston] Add config option to disable input method

2015-06-09 Thread Jan Arne Petersen
(optional) fix empty "path" to not even try launching the input method client Thanks, pq ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel -- Jan Arne Petersen

Re: EFL/Wayland and xdg-shell

2015-04-16 Thread Jan Arne Petersen
relocation instead of resizing (see http://www.jonnor.com/files/maliit/maliit-lmt-technical-overview-widget-reloc.pdf) I will add an event to the text protocol to support that. Regards Jan Arne -- Jan Arne Petersen | jan.peter...@kdab.com | Senior Software Engineer KDAB (Deutschland) GmbH&

Re: EFL/Wayland and xdg-shell

2015-04-14 Thread Jan Arne Petersen
d make it fit to become a core Wayland protocol. Note this is all about the text protocol which should be used between applications and compositor I do not really care about a protocol between compositor and virtual keyboard (input-method protocol in weston). Regards Jan Arne -- Jan Arne Petersen |

Re: [PATCH weston] text-input: Replace model with input

2015-01-12 Thread Jan Arne Petersen
On Mon Jan 12 2015 at 5:34:40 PM Derek Foreman wrote: > commit 78d00e45cc renamed text_model to text_input > > This cleans up remaining uses of the word "model" > > Signed-off-by: Derek Foreman > --- > > Please note that this applies on top of my earlier "test-input fix-ups" > patch set, not dir

Re: [PATCH weston 7/7] text: Fix text-input for multi-seat

2015-01-10 Thread Jan Arne Petersen
On Fri Dec 05 2014 at 10:47:05 PM Derek Foreman wrote: > Multi-seat configurations currently break the text-backend, crashing > weston. This is an attempt to clean up any crashes and have somewhat > sensible input panel behavior with multi-seat. > > Signed-off-by: Derek Foreman > --- > src/tex

Re: [PATCH v2 weston] editor: Make editor multi-seat aware

2014-12-18 Thread Jan Arne Petersen
Hey, On Wed Dec 17 2014 at 4:53:24 PM Derek Foreman wrote: > With multi-seat, multiple entries can occur on the text inputs in the > editor. Also, the panel shouldn't be hidden by the editor if either > text entry is still active. > > Signed-off-by: Derek Foreman > --- > Removed the "sibling"

Re: [PATCH weston v2 6/7] text: Don't crash if a seat has no keyboard

2014-12-15 Thread Jan Arne Petersen
Hey, On Mon Dec 08 2014 at 5:57:04 PM Derek Foreman wrote: > A keyboard might not be present in a seat, so check that before > dereferencing keyboard related pointers. > > Also, use the keyboard pointer we set to shorten the code a little bit. > > Signed-off-by: Derek Foreman > --- > Made the c

Re: [PATCH weston 1/7] editor: Make editor multi-seat aware

2014-12-15 Thread Jan Arne Petersen
On Fri Dec 05 2014 at 10:47:03 PM Derek Foreman wrote: > With multi-seat, multiple entries can occur on the text inputs in the > editor. Also, the panel shouldn't be hidden by the editor if either > text entry is still active. > > Signed-off-by: Derek Foreman > --- > clients/editor.c | 12

Re: [Take 2][PATCH] Add touch support for wl_shell_surface_move

2013-08-15 Thread Jan Arne Petersen
On 08/15/2013 12:49 AM, Rusty Lynch wrote: > From 3c68e0e2aa98250c65a5d5e9658299904ccf34f1 Mon Sep 17 00:00:00 2001 > From: Rusty Lynch > Date: Wed, 14 Aug 2013 09:27:44 -0700 > Subject: [PATCH] Add touch support for wl_shell_surface_move > > --- > clients/calibrator.c| 4 +- > clients/des

[PATCH 1/5] editor: Fix text selection

2013-05-30 Thread Jan Arne Petersen
From: Jan Arne Petersen Signed-off-by: Jan Arne Petersen --- clients/editor.c | 76 1 file changed, 44 insertions(+), 32 deletions(-) diff --git a/clients/editor.c b/clients/editor.c index 7c90ed9..03cdc12 100644 --- a/clients/editor.c

[PATCH 5/5] editor: Do not commit/preedit after invalid delete

2013-05-30 Thread Jan Arne Petersen
From: Jan Arne Petersen Ignore the whole commit-string or preedit_string transaction when the delete_surrounding event was invalid. Signed-off-by: Jan Arne Petersen --- clients/editor.c | 55 +-- 1 file changed, 41 insertions(+), 14

[PATCH 2/5] editor: Support deleting text in preedit_string

2013-05-30 Thread Jan Arne Petersen
From: Jan Arne Petersen Delete text marked with wl_text_input::delete_surrounding_text on preedit_string event. When text is explicitly marked with delete_surrounding_text do not delete selected text. Signed-off-by: Jan Arne Petersen --- clients/editor.c | 13 +++-- 1 file changed, 11

[PATCH 4/5] editor: Improve checks on delete add asserts

2013-05-30 Thread Jan Arne Petersen
From: Jan Arne Petersen Signed-off-by: Jan Arne Petersen --- clients/editor.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/clients/editor.c b/clients/editor.c index 35f6d08..cd24f6a 100644 --- a/clients/editor.c +++ b/clients/editor.c @@ -214,7 +214,8

[PATCH 0/5] Fix some bugs in editor example

2013-05-30 Thread Jan Arne Petersen
From: Jan Arne Petersen Fix some bugs I noticed when testing the editor example with latest Wayland enabled Maliit. Jan Arne Petersen (5): editor: Fix text selection editor: Support deleting text in preedit_string editor: Properly adjust cursor on delete editor: Improve checks on delete

[PATCH 3/5] editor: Properly adjust cursor on delete

2013-05-30 Thread Jan Arne Petersen
From: Jan Arne Petersen Signed-off-by: Jan Arne Petersen --- clients/editor.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/clients/editor.c b/clients/editor.c index 16ede4f..35f6d08 100644 --- a/clients/editor.c +++ b/clients/editor.c @@ -837,16 +837,19

Re: [PATCH 0/5] Improve text protocol

2013-05-02 Thread Jan Arne Petersen
On 05/02/2013 09:56 PM, Kristian Høgsberg wrote: > On Tue, Apr 16, 2013 at 06:19:47PM -0700, Bill Spitzak wrote: >> Jan Arne Petersen wrote: >> >>> I completely agree that editing UTF-8 text as UTF-8 is fine. >>> >>> I am just wondering if we should have

[PATCH v2 25/28] text: Rename input_method to wl_input_method

2013-04-18 Thread Jan Arne Petersen
From: Jan Arne Petersen Also rename input_method_context to wl_input_method_context, input_panel to wl_input_panel and input_panel_surface to wl_input_panel_surface. Signed-off-by: Jan Arne Petersen --- clients/keyboard.c | 162 ++--- clients

[PATCH v2 28/28] editor: Fix some offsets for multi-byte characters

2013-04-18 Thread Jan Arne Petersen
From: Jan Arne Petersen Signed-off-by: Jan Arne Petersen --- clients/editor.c | 100 ++- 1 file changed, 48 insertions(+), 52 deletions(-) diff --git a/clients/editor.c b/clients/editor.c index f6e6084..7c90ed9 100644 --- a/clients/editor.c

[PATCH v2 27/28] keyboard: Fix offsets when deleting text

2013-04-18 Thread Jan Arne Petersen
From: Jan Arne Petersen Signed-off-by: Jan Arne Petersen --- clients/keyboard.c | 90 +++--- 1 file changed, 85 insertions(+), 5 deletions(-) diff --git a/clients/keyboard.c b/clients/keyboard.c index d83ca3c..a2fbded 100644 --- a/clients

[PATCH v2 24/28] text: Improve protocol documentation.

2013-04-18 Thread Jan Arne Petersen
From: Jan Arne Petersen Signed-off-by: Jan Arne Petersen --- protocol/input-method.xml | 98 +++ protocol/text.xml | 52 - 2 files changed, 106 insertions(+), 44 deletions(-) diff --git a/protocol/input-method.xml b

[PATCH v2 26/28] text: add cursor_rectangle event to input_panel_surface

2013-04-18 Thread Jan Arne Petersen
From: Jan Arne Petersen Signed-off-by: Jan Arne Petersen --- protocol/input-method.xml | 10 ++ src/input-panel.c | 37 - 2 files changed, 34 insertions(+), 13 deletions(-) diff --git a/protocol/input-method.xml b/protocol/input-method.xml

[PATCH v2 22/28] text: Rename text_input to wl_text_input

2013-04-18 Thread Jan Arne Petersen
From: Jan Arne Petersen Signed-off-by: Jan Arne Petersen --- clients/editor.c | 118 ++--- clients/keyboard.c | 10 ++--- protocol/text.xml | 8 ++-- src/control.c | 2 +- src/text-backend.c | 34 +++ tests/text-test.c

[PATCH v2 23/28] text: Rename ::set_panel to ::set_overlay_panel

2013-04-18 Thread Jan Arne Petersen
From: Jan Arne Petersen Also add documentation to input_panel_surface::set_overlay_panel. Signed-off-by: Jan Arne Petersen --- protocol/input-method.xml | 8 ++-- src/input-panel.c | 6 +++--- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/protocol/input-method.xml

[PATCH v2 21/28] keyboard: Remove unneded calls

2013-04-18 Thread Jan Arne Petersen
From: Jan Arne Petersen Signed-off-by: Jan Arne Petersen --- clients/keyboard.c | 16 1 file changed, 16 deletions(-) diff --git a/clients/keyboard.c b/clients/keyboard.c index bd88207..4fc8e73 100644 --- a/clients/keyboard.c +++ b/clients/keyboard.c @@ -387,13 +387,6

[PATCH v2 19/28] text: Fix serial handling

2013-04-18 Thread Jan Arne Petersen
From: Jan Arne Petersen Signed-off-by: Jan Arne Petersen --- clients/editor.c | 24 ++-- clients/keyboard.c | 23 +-- clients/weston-simple-im.c | 28 +++- protocol/input-method.xml | 17

[PATCH v2 18/28] Add weston-control to allow reloading the config file

2013-04-18 Thread Jan Arne Petersen
From: Jan Arne Petersen Signed-off-by: Jan Arne Petersen --- clients/.gitignore | 3 ++ clients/Makefile.am | 9 + clients/weston-control.c | 101 +++ protocol/Makefile.am | 1 + protocol/control.xml | 35

[PATCH v2 16/28] text: Move input panel into an own file

2013-04-18 Thread Jan Arne Petersen
From: Jan Arne Petersen Signed-off-by: Jan Arne Petersen --- src/Makefile.am | 3 +- src/compositor.c | 1 + src/compositor.h | 13 ++ src/input-panel.c | 461 ++ src/shell.c | 350 + 5

[PATCH v2 20/28] text: delete text on commit_string

2013-04-18 Thread Jan Arne Petersen
From: Jan Arne Petersen Signed-off-by: Jan Arne Petersen --- clients/editor.c | 33 +++-- clients/keyboard.c | 3 +++ 2 files changed, 22 insertions(+), 14 deletions(-) diff --git a/clients/editor.c b/clients/editor.c index c40815a..56205af 100644 --- a/clients

[PATCH v2 17/28] text: Only allow input-method started by weston to bind

2013-04-18 Thread Jan Arne Petersen
From: Jan Arne Petersen Signed-off-by: Jan Arne Petersen --- src/text-backend.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/src/text-backend.c b/src/text-backend.c index 07a066c..53aa92c 100644 --- a/src/text-backend.c +++ b/src/text-backend.c

[PATCH v2 15/28] text: Add output argument to set_toplevel

2013-04-18 Thread Jan Arne Petersen
From: Jan Arne Petersen Allow to specify an output for a toplevel input panel surface. Signed-off-by: Jan Arne Petersen --- clients/keyboard.c| 26 ++ protocol/input-method.xml | 1 + src/shell.c | 28 3 files

[PATCH v2 14/28] text: Add support for panels following the cursor

2013-04-18 Thread Jan Arne Petersen
From: Jan Arne Petersen Add input_panel_surface::set_panel to specify input panel surfaces which are overlaying the application and are following the input cursor. Signed-off-by: Jan Arne Petersen --- protocol/input-method.xml | 3 ++ src/compositor.c | 1 + src/compositor.h

[PATCH v2 10/28] text: Rename text_model to text_input

2013-04-18 Thread Jan Arne Petersen
From: Jan Arne Petersen Also rename text_model_factory to text_input_manager. Signed-off-by: Jan Arne Petersen --- clients/editor.c | 142 +++ clients/keyboard.c | 10 +-- protocol/text.xml | 61 +++--- src/text-backend.c | 242

[PATCH v2 12/28] editor: Only delete on backspace key released

2013-04-18 Thread Jan Arne Petersen
From: Jan Arne Petersen Do not delete two characters when key is pressed and released. Signed-off-by: Jan Arne Petersen --- clients/editor.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/clients/editor.c b/clients/editor.c index 027b562..e686248 100644 --- a/clients/editor.c +++ b

[PATCH v2 11/28] text: Add "none" preedit-style

2013-04-18 Thread Jan Arne Petersen
From: Jan Arne Petersen Use "default" preedit style as default. "None" is used when the composing text should look like non-composing text. Signed-off-by: Jan Arne Petersen --- clients/keyboard.c | 2 +- protocol/text.xml | 3 ++- 2 files changed, 3 insertions(+), 2 dele

[PATCH v2 09/28] text: Order requests and events in a nice way

2013-04-18 Thread Jan Arne Petersen
From: Jan Arne Petersen Signed-off-by: Jan Arne Petersen --- clients/editor.c | 14 ++--- protocol/text.xml | 172 ++--- src/text-backend.c | 24 tests/text-test.c | 14 ++--- 4 files changed, 112 insertions(+), 112 deletions

[PATCH v2 13/28] editor: Send cursor position to the input method

2013-04-18 Thread Jan Arne Petersen
From: Jan Arne Petersen Signed-off-by: Jan Arne Petersen --- clients/editor.c | 38 ++ 1 file changed, 38 insertions(+) diff --git a/clients/editor.c b/clients/editor.c index e686248..e61eda0 100644 --- a/clients/editor.c +++ b/clients/editor.c @@ -127,6

[PATCH v2 05/28] text: Fix password content hint value

2013-04-18 Thread Jan Arne Petersen
From: Krzesimir Nowak 0xc in this case was a combination of "autocapitalization" (0x4) and "lowercase" (0x8) instead of "hidden_text" (0x40) and "sensitive_data" (0x80). Signed-off-by: Jan Arne Petersen --- protocol/text.xml | 2 +- 1 file changed, 1 i

[PATCH v2 06/28] text: Fix some text and input-method docs

2013-04-18 Thread Jan Arne Petersen
From: Krzesimir Nowak Signed-off-by: Jan Arne Petersen --- protocol/input-method.xml | 40 +++- protocol/text.xml | 36 +++- 2 files changed, 46 insertions(+), 30 deletions(-) diff --git a/protocol/input-method.xml b

[PATCH v2 08/28] text: rename text_model::commit to commit_state

2013-04-18 Thread Jan Arne Petersen
From: Jan Arne Petersen Use ::commit_state as a request name to make clear what is commited. Signed-off-by: Jan Arne Petersen --- clients/editor.c | 2 +- protocol/text.xml | 2 +- src/text-backend.c | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/clients

[PATCH v2 07/28] view: g_type_init() is deprecated in glib >= 2.35

2013-04-18 Thread Jan Arne Petersen
From: Jan Arne Petersen Signed-off-by: Jan Arne Petersen --- clients/view.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/clients/view.c b/clients/view.c index c8ced15..110a829 100644 --- a/clients/view.c +++ b/clients/view.c @@ -293,7 +293,9 @@ main(int argc, char *argv[]) int

[PATCH v2 01/28] text: Add language and text-direction to protocol

2013-04-18 Thread Jan Arne Petersen
From: Jan Arne Petersen Signed-off-by: Jan Arne Petersen --- clients/editor.c | 20 - clients/keyboard.c | 54 ++ clients/weston-simple-im.c | 54 ++ protocol/input

[PATCH v2 00/28] Improve Text protocol

2013-04-18 Thread Jan Arne Petersen
From: Jan Arne Petersen This patch series replaces the previous "Extend text protocol for IBus support" and "Improve text protocol". All changes include: * Some cleanups from the previous text input patch series (required by the new patches) * Add support for overl

[PATCH v2 03/28] keyboard: Reset state on activate

2013-04-18 Thread Jan Arne Petersen
From: Jan Arne Petersen Signed-off-by: Jan Arne Petersen --- clients/keyboard.c | 34 -- 1 file changed, 28 insertions(+), 6 deletions(-) diff --git a/clients/keyboard.c b/clients/keyboard.c index e792eba..1394d70 100644 --- a/clients/keyboard.c +++ b/clients

[PATCH v2 02/28] text: Add example for language/text direction

2013-04-18 Thread Jan Arne Petersen
From: Jan Arne Petersen Signed-off-by: Jan Arne Petersen --- clients/editor.c | 36 +- clients/keyboard.c | 89 -- 2 files changed, 121 insertions(+), 4 deletions(-) diff --git a/clients/editor.c b/clients/editor.c

[PATCH v2 04/28] editor: Reset text model on reset

2013-04-18 Thread Jan Arne Petersen
From: Jan Arne Petersen There were some reset calls missing, which resulted in wrong preedit state on input method side. Signed-off-by: Jan Arne Petersen --- clients/editor.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/clients/editor.c b/clients/editor.c index

Re: [PATCH 0/5] Improve text protocol

2013-04-16 Thread Jan Arne Petersen
On 04/16/2013 06:06 PM, Bill Spitzak wrote: > On 04/16/2013 01:16 AM, Jan Arne Petersen wrote: > >> But we still need to think about how to handle invalid byte sequences >> anyways. What do we expect a toolkit to do when text with invalid byte >> sequences is inserted wi

Re: [PATCH 0/5] Improve text protocol

2013-04-16 Thread Jan Arne Petersen
Hi, On 04/15/2013 09:14 PM, Bill Spitzak wrote: > Jan Arne Petersen wrote: > >> * Changes offsets to be Unicode character instead of byte based > > No, PLEASE DON'T DO THIS!!! > > You think you are making things "easier" but you are making it much much

[PATCH 5/5] text: Rename input_method to wl_input_method

2013-04-15 Thread Jan Arne Petersen
From: Jan Arne Petersen Also rename input_method_context to wl_input_method_context, input_panel to wl_input_panel and input_panel_surface to wl_input_panel_surface. Signed-off-by: Jan Arne Petersen --- clients/keyboard.c | 162 ++--- clients

[PATCH 4/5] text: Improve protocol documentation.

2013-04-15 Thread Jan Arne Petersen
From: Jan Arne Petersen Signed-off-by: Jan Arne Petersen --- protocol/input-method.xml | 87 +++ protocol/text.xml | 6 ++-- 2 files changed, 70 insertions(+), 23 deletions(-) diff --git a/protocol/input-method.xml b/protocol/input

[PATCH 2/5] text: Rename text_input to wl_text_input

2013-04-15 Thread Jan Arne Petersen
From: Jan Arne Petersen Signed-off-by: Jan Arne Petersen --- clients/editor.c | 118 ++--- clients/keyboard.c | 10 ++--- protocol/text.xml | 8 ++-- src/control.c | 2 +- src/text-backend.c | 34 +++ tests/text-test.c

[PATCH 3/5] text: Rename ::set_panel to ::set_overlay_panel

2013-04-15 Thread Jan Arne Petersen
From: Jan Arne Petersen Also add documentation to input_panel_surface::set_overlay_panel. Signed-off-by: Jan Arne Petersen --- protocol/input-method.xml | 8 ++-- src/input-panel.c | 6 +++--- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/protocol/input-method.xml

[PATCH 0/5] Improve text protocol

2013-04-15 Thread Jan Arne Petersen
From: Jan Arne Petersen This patch series: * Fixes serials handling in text protocol * Changes offsets to be Unicode character instead of byte based * Adds documentation to the protocols * Adds wl_ prefixes to the interfaces. It is based on the previous "Extend text protocol for IBus su

Re: [PATCH 17/18] text: Only allow input-method started by weston to bind

2013-04-08 Thread Jan Arne Petersen
On 04/08/2013 01:51 AM, Yichao Yu wrote: > Does this mean it is not possible to start a stand alone input method??? No. It just means that the compositor (weston) starts the stand alone input method. > On Sun, Apr 7, 2013 at 6:12 PM, Jan Arne Petersen > mailto:jpeter...@openismus.co

[PATCH 18/18] Add weston-control to allow reloading the config file

2013-04-07 Thread Jan Arne Petersen
From: Jan Arne Petersen Signed-off-by: Jan Arne Petersen --- clients/.gitignore | 3 ++ clients/Makefile.am | 9 + clients/weston-control.c | 101 +++ protocol/Makefile.am | 1 + protocol/control.xml | 35

[PATCH 17/18] text: Only allow input-method started by weston to bind

2013-04-07 Thread Jan Arne Petersen
From: Jan Arne Petersen Signed-off-by: Jan Arne Petersen --- src/text-backend.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/src/text-backend.c b/src/text-backend.c index 07a066c..53aa92c 100644 --- a/src/text-backend.c +++ b/src/text-backend.c

[PATCH 16/18] text: Move input panel into an own file

2013-04-07 Thread Jan Arne Petersen
From: Jan Arne Petersen Signed-off-by: Jan Arne Petersen --- src/Makefile.am | 3 +- src/compositor.c | 1 + src/compositor.h | 13 ++ src/input-panel.c | 470 ++ src/shell.c | 350 +--- 5

[PATCH 15/18] text: Add output argument to set_toplevel

2013-04-07 Thread Jan Arne Petersen
From: Jan Arne Petersen Allow to specify an output for a toplevel input panel surface. Signed-off-by: Jan Arne Petersen --- clients/keyboard.c| 26 ++ protocol/input-method.xml | 1 + src/shell.c | 28 3 files

[PATCH 14/18] text: Add support for panels following the cursor

2013-04-07 Thread Jan Arne Petersen
From: Jan Arne Petersen Add input_panel_surface::set_panel to specify input panel surfaces which are overlaying the application and are following the input cursor. Signed-off-by: Jan Arne Petersen --- protocol/input-method.xml | 3 ++ src/compositor.c | 1 + src/compositor.h

[PATCH 13/18] editor: Send cursor position to the input method

2013-04-07 Thread Jan Arne Petersen
From: Jan Arne Petersen Signed-off-by: Jan Arne Petersen --- clients/editor.c | 38 ++ 1 file changed, 38 insertions(+) diff --git a/clients/editor.c b/clients/editor.c index e686248..e61eda0 100644 --- a/clients/editor.c +++ b/clients/editor.c @@ -127,6

[PATCH 12/18] editor: Only delete on backspace key released

2013-04-07 Thread Jan Arne Petersen
From: Jan Arne Petersen Do not delete two characters when key is pressed and released. Signed-off-by: Jan Arne Petersen --- clients/editor.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/clients/editor.c b/clients/editor.c index 027b562..e686248 100644 --- a/clients/editor.c +++ b

[PATCH 11/18] text: Add "none" preedit-style

2013-04-07 Thread Jan Arne Petersen
From: Jan Arne Petersen Use "default" preedit style as default. "None" is used when the composing text should look like non-composing text. Signed-off-by: Jan Arne Petersen --- clients/keyboard.c | 2 +- protocol/text.xml | 3 ++- 2 files changed, 3 insertions(+), 2 dele

[PATCH 10/18] text: Rename text_model to text_input

2013-04-07 Thread Jan Arne Petersen
From: Jan Arne Petersen Also rename text_model_factory to text_input_manager. Signed-off-by: Jan Arne Petersen --- clients/editor.c | 142 +++ clients/keyboard.c | 10 +-- protocol/text.xml | 61 +++--- src/text-backend.c | 242

[PATCH 09/18] text: Order requests and events in a nice way

2013-04-07 Thread Jan Arne Petersen
From: Jan Arne Petersen Signed-off-by: Jan Arne Petersen --- clients/editor.c | 14 ++--- protocol/text.xml | 172 ++--- src/text-backend.c | 24 tests/text-test.c | 14 ++--- 4 files changed, 112 insertions(+), 112 deletions

[PATCH 08/18] text: rename text_model::commit to commit_state

2013-04-07 Thread Jan Arne Petersen
From: Jan Arne Petersen Use ::commit_state as a request name to make clear what is commited. Signed-off-by: Jan Arne Petersen --- clients/editor.c | 2 +- protocol/text.xml | 2 +- src/text-backend.c | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/clients

[PATCH 07/18] view: g_type_init() is deprecated in glib >= 2.35

2013-04-07 Thread Jan Arne Petersen
From: Jan Arne Petersen Signed-off-by: Jan Arne Petersen --- clients/view.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/clients/view.c b/clients/view.c index c8ced15..110a829 100644 --- a/clients/view.c +++ b/clients/view.c @@ -293,7 +293,9 @@ main(int argc, char *argv[]) int

[PATCH 06/18] text: Fix some text and input-method docs

2013-04-07 Thread Jan Arne Petersen
From: Krzesimir Nowak Signed-off-by: Jan Arne Petersen --- protocol/input-method.xml | 40 +++- protocol/text.xml | 36 +++- 2 files changed, 46 insertions(+), 30 deletions(-) diff --git a/protocol/input-method.xml b

[PATCH 05/18] text: Fix password content hint value

2013-04-07 Thread Jan Arne Petersen
From: Krzesimir Nowak 0xc in this case was a combination of "autocapitalization" (0x4) and "lowercase" (0x8) instead of "hidden_text" (0x40) and "sensitive_data" (0x80). Signed-off-by: Jan Arne Petersen --- protocol/text.xml | 2 +- 1 file changed, 1 i

[PATCH 04/18] editor: Reset text model on reset

2013-04-07 Thread Jan Arne Petersen
From: Jan Arne Petersen There were some reset calls missing, which resulted in wrong preedit state on input method side. Signed-off-by: Jan Arne Petersen --- clients/editor.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/clients/editor.c b/clients/editor.c index

  1   2   3   4   >