Re: [PATCH 0/6] drm: Add mouse cursor hotspot support to atomic KMS

2022-06-10 Thread Gerd Hoffmann
Hi, > > As Pekka mentionned, I'd also like to have a conversation of how far we > > want to > > push virtualized driver features. I think KMS support is a good feature to > > have > > to spin up a VM and have all of the basics working. However I don't think > > it's > > a good idea to try to

Re: [PATCH 0/6] drm: Add mouse cursor hotspot support to atomic KMS

2022-06-10 Thread Gerd Hoffmann
Hi, > > 4. make sure the hotspot property is only set on VIRTUAL_CURSOR planes > > and nothing else in the rebased patch series > > Simon also mentioned on irc that these special planes must not expose the > CRTC_X/Y property, since that doesn't really do much at all. Or is our > understand

Re: [PATCH 0/6] drm: Add mouse cursor hotspot support to atomic KMS

2022-06-09 Thread Gerd Hoffmann
Hi, > > Typically there is a communication path from guest to host for pointer > > movements (i.e. crtc_x + crtc_y updates), so the host knows where the > > guest wants the cursor plane being placed. So in case the pointer is > > moved by other means (different input device, some application wa

Re: [PATCH 0/6] drm: Add mouse cursor hotspot support to atomic KMS

2022-06-09 Thread Gerd Hoffmann
Hi, > I don’t think I see how that fixes anything. In particular I don’t see > a way of fixing the old user space at all. We require hotspot info, > old user space doesn’t set it because there’s no way of setting it on > atomic kms. Whether we expose cursor plane or not doesn’t change the > fact

Re: [PATCH 0/6] drm: Add mouse cursor hotspot support to atomic KMS

2022-06-09 Thread Gerd Hoffmann
> Why are pointer cursors misplaced on paravirtualized drivers? > > It is because the paravirtualized drivers or VM viewers do *not* place > the cursor plane at the CRTC_X, CRTC_Y position in the guest CRTC area. > This is obvious: if CRTC_X, CRTC_Y were honoured, there would be no > misplacement.