[PATCH libinput] test: check if tapping that happens after a moving thumb works

--- test/test-touchpad.c | 40 1 file changed, 40 insertions(+) diff --git a/test/test-touchpad.c b/test/test-touchpad.c index b73d9e58..8341e209 100644 --- a/test/test-touchpad.c +++ b/test/test-touchpad.c @@ -4974,6 +4974,45 @@ START_TEST(touchpad_thumb_

Re: [PATCH libinput] touchpad: fix tapping that happens after a moving thumb

On 09.05.2018 06:34, Peter Hutterer wrote: On Sat, May 05, 2018 at 03:49:32AM +0200, Friedrich Schöller wrote: thanks, patch looks good and is merged locally. Any chance I can convince you to write a test case for this? :) Would make sure that we're not breaking this again. Nice to he

[PATCH libinput] touchpad: fix tapping that happens after a moving thumb

When finger movement exceeded the motion threshold before the finger was recognized as a thumb, it would never be regarded as a thumb by the tap system. This prohibited tapping until the thumb was lifted. This is fixed by moving the check for the thumb state up such that it happens before the moti

Re: [PATCH libinput] touchpad: fix tapping that happens after a moving thumb

I have attached an evemu recording that illustrates the issue. In the recording a thumb touches the touchpad, gets state THUMB_STATE_MAYBE, then THUMB_STATE_YES. After that, a tap is performed, but it is ignored without the patch. Best, Friedrich On 05.05.2018 03:49, Friedrich Schöller wrote

[PATCH libinput] touchpad: fix clickfinger behavior with a thumb being present

With a thumb on the touchpad, a two-finger click was always treated as a middle-click. This patch takes the thumb into account and treats the click as a right-click, if the touchpad supports tracking of at least three fingers. --- src/evdev-mt-touchpad-buttons.c | 90 +-

Re: [PATCH libinput] touchpad: fix clickfinger behavior with a thumb being present

Hi Peter, Thanks for the comments. On 18.05.2017 03:17, Peter Hutterer wrote: Hi Friedrich, On Tue, May 16, 2017 at 10:44:22PM +0200, Friedrich Schöller wrote: With a thumb on the touchpad, a two-finger click was incorrectly treated as a middle-click. This patch takes the thumb into account

libinput: Thumb detection based on ABS_MT_WIDTH

Dear all, dear Peter, As you know, bcm5974 touchpads do not report ABS_MT_PRESSURE, but ABS_MT_WIDTH instead. Since libinput does not currently use ABS_MT_WIDTH, thumb detection is inaccurate on those devices. When I switched from Mac OS to Linux, I stopped using the Magic Trackpad solely for

[PATCH libinput] touchpad: fix clickfinger behavior with a thumb being present

With a thumb on the touchpad, a two-finger click was incorrectly treated as a middle-click. This patch takes the thumb into account and treats the click as a right-click. --- src/evdev-mt-touchpad-buttons.c | 44 ++--- 1 file changed, 19 insertions(+), 25 deleti