RE: [PATCH v2] server: add log message when client connection is destroyed due to an error

2018-01-18 Thread Fiedler, Mathias
Hi, > -Original Message- > From: Derek Foreman [mailto:der...@osg.samsung.com] > Sent: Mittwoch, 17. Januar 2018 21:41 > To: Fiedler, Mathias; wayland-devel@lists.freedesktop.org > Subject: Re: [PATCH v2] server: add log message when client connection is > destroy

Re: [PATCH 2/2] server: add log message when client connection is destroyed due to an error

2017-12-05 Thread Fiedler, Mathias
Hi Daniel, thanks for your review. I will drop the storing and forwarding of the errno code. Regards, Mathias From: Daniel Stone Sent: Monday, December 4, 2017 10:06 PM To: Fiedler, Mathias Cc: wayland-devel@lists.freedesktop.org Subject: Re: [PATCH 2/2

Patches for resource id allocation

2012-07-18 Thread Fiedler, Mathias
thias Von: Kristian Høgsberg [hoegsb...@gmail.com] Gesendet: Dienstag, 17. Juli 2012 22:49 An: Fiedler, Mathias Cc: wayland-devel@lists.freedesktop.org Betreff: Re: Resource id allocation on server side On Tue, Jul 17, 2012 at 11:52:02AM +0000, Fiedler, Mathias wrote: > Hi, > > I'm f

Resource id allocation on server side

2012-07-17 Thread Fiedler, Mathias
Hi, I'm facing an issue when the client tries to create a new object with an id bigger than the current maximum id on server-side +1. Is it correct that those ids will be silently ignored? E.g. wl_client_add_resource() would call wl_map_insert_at() return -1 which isn't checked. For example, t

[PATCH] connection: fixing cmsg buffer overflow

2011-10-07 Thread Fiedler, Mathias
Hi, the attachment is a patch for fixing a possible overflow of the local cmsg buffer in wl_connection_data. This error might happen when the number of pending file descriptors to be send exceeds 32. The condition i added in wl_connection_write for flushing the buffer is a bit too restrict,

[PATCH] wayland-server: fix resource destroy

2011-10-07 Thread Fiedler, Mathias
Hi, object id was read from freed memory. In rare cases i got errors where compositor was complaining about wrong or still used object ids. diff --git a/wayland/src/wayland-server.c b/wayland/src/wayland-server.c index a6cd88d..5eb7906 100644 --- a/wayland/src/wayland-server.c +++ b/wayland/src/

[PATCH] wayland-server: fix crash on invalid resource

2011-10-05 Thread Fiedler, Mathias
Using display_resource to post error about invalid resource. --- src/wayland-server.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/wayland-server.c b/src/wayland-server.c index 4ee7796..a6cd88d 100644 --- a/src/wayland-server.c +++ b/src/wayland-server.c @@ -158,7

Recursive call of wl_display_iterate via frame callback

2011-06-21 Thread Fiedler, Mathias
Hi, while playing around with wayland and the simple-client demo (using EGL) i ran into issues where simple-client were caught in an endless loop in wl_display_iterate. The issue seems to be a recursive call of wl_display_iterate. The simple-client registers redraw() as a callback function to