[PATCH weston 1/2 v5] simple-dmabuf-drm: nv12: properly fill Y plane

2018-07-19 Thread Emilio Pozuelo Monfort
We want 0..255 values, not 0..254. Signed-off-by: Emilio Pozuelo Monfort --- No changes in this version. clients/simple-dmabuf-drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clients/simple-dmabuf-drm.c b/clients/simple-dmabuf-drm.c index bd0f9224..5bc5323e 100644

[PATCH weston 2/2] simple-dmabuf-drm: use GBM generic calls

2018-07-19 Thread Emilio Pozuelo Monfort
No need to write libdrm driver specific code for each supported driver, we can just let GBM call the right one for us now. Signed-off-by: Emilio Pozuelo Monfort --- Some improvements from Daniel (thanks!). I also added missing error messages, formatting fixes and a logic error in your

Re: [PATCH weston 3/4] simple-dmabuf-drm: use GBM generic calls

2018-07-12 Thread Emilio Pozuelo Monfort
On 11/07/18 13:55, Daniel Stone wrote: > Hi Emilio, > > On Wed, 11 Jul 2018 at 12:53, Emilio Pozuelo Monfort > wrote: >> As for NV12 support: I tried to make gbm support that in >> backends/dri/gbm_dri.c by adding a mapping to gbm_dri_visuals_table &g

[PATCH weston 3/3 v4] simple-dmabuf-drm: use GBM generic calls

2018-07-12 Thread Emilio Pozuelo Monfort
No need to write libdrm driver specific code for each supported driver, we can just let GBM call the right one for us now. Signed-off-by: Emilio Pozuelo Monfort --- v4: now with working NV12, (thanks Daniel!). clients/simple-dmabuf-drm.c | 411 configure.ac

[PATCH weston v4] simple-dmabuf-drm: nv12: properly fill Y plane

2018-07-12 Thread Emilio Pozuelo Monfort
We want 0..255 values, not 0..254. Signed-off-by: Emilio Pozuelo Monfort --- New patch. clients/simple-dmabuf-drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clients/simple-dmabuf-drm.c b/clients/simple-dmabuf-drm.c index 4f88f12e..198d88e8 100644 --- a/clients/simple

[PATCH weston 2/3 v4] simple-dmabuf-drm: fix build with --disable-egl

2018-07-12 Thread Emilio Pozuelo Monfort
Just rely on getting the supported formats through the dmabuf extension. Signed-off-by: Emilio Pozuelo Monfort --- v4: no changes. clients/simple-dmabuf-drm.c | 11 --- configure.ac| 2 +- 2 files changed, 1 insertion(+), 12 deletions(-) diff --git a/clients/simple

[PATCH weston 1/3 v4] simple-dmabuf-drm: require zwp_linux_dmabuf_v1 v3

2018-07-12 Thread Emilio Pozuelo Monfort
We effectively require it as we don't react to dmabuf_format, only to dmabuf_modifiers, so there's a chance we may not get the supported formats information at all. Signed-off-by: Emilio Pozuelo Monfort --- v4: No changes here. clients/simple-dmabuf-drm.c | 12 +--- 1 file

[PATCH weston 2/4 v3] simple-dmabuf-drm: fix build with --disable-egl

2018-07-11 Thread Emilio Pozuelo Monfort
Just rely on getting the supported formats through the dmabuf extension. Signed-off-by: Emilio Pozuelo Monfort --- v3: this now drops the dependency on libEGL clients/simple-dmabuf-drm.c | 11 --- configure.ac| 2 +- 2 files changed, 1 insertion(+), 12 deletions

[PATCH weston] simple-dmabuf-drm: drop dependency on libdrm

2018-07-11 Thread Emilio Pozuelo Monfort
Signed-off-by: Emilio Pozuelo Monfort --- clients/simple-dmabuf-drm.c | 32 +++- configure.ac| 2 +- 2 files changed, 12 insertions(+), 22 deletions(-) diff --git a/clients/simple-dmabuf-drm.c b/clients/simple-dmabuf-drm.c index 1d452183..a6c3b16d

[PATCH weston 1/4] simple-dmabuf-drm: require zwp_linux_dmabuf_v1 v3

2018-07-11 Thread Emilio Pozuelo Monfort
We effectively require it as we don't react to dmabuf_format, only to dmabuf_modifiers, so there's a chance we may not get the supported formats information at all. Signed-off-by: Emilio Pozuelo Monfort --- clients/simple-dmabuf-drm.c | 12 +--- 1 file changed, 1 insert

[PATCH weston 3/4] simple-dmabuf-drm: use GBM generic calls

2018-07-11 Thread Emilio Pozuelo Monfort
No need to write libdrm driver specific code for each supported driver, we can just let GBM call the right one for us now. Signed-off-by: Emilio Pozuelo Monfort --- v2: we now pass the correct modifier to fill_content and zwp_linux_buffer_params_v1_add(). Added a new note since I'm not su

[PATCH weston 0/4] simple-dmabuf-drm improvements

2018-07-11 Thread Emilio Pozuelo Monfort
ck of DRM_FORMAT_MOD_SAMSUNG_64_32_TILE, so we can't apply this yet. Anyway we have a bigger problem with the lack of NV12 support in the GBM patch... Emilio Pozuelo Monfort (4): simple-dmabuf-drm: require zwp_linux_dmabuf_v1 v3 simple-dmabuf-drm: fix build with --disable-egl simple-dmabu

[PATCH weston] simple-dmabuf-drm: use GBM generic calls

2018-07-10 Thread Emilio Pozuelo Monfort
No need to write libdrm driver specific code for each supported driver, we can just let GBM call the right one for us now. Signed-off-by: Emilio Pozuelo Monfort --- Hi, This simplifies the code a lot, using gbm_bo as Emil suggested. Some problems I still see: - NV12 doesn't work, it

Re: [PATCH weston v2] simple-dmabuf-drm: fix build with --disable-egl

2018-07-10 Thread Emilio Pozuelo Monfort
On 10/07/18 15:16, Pekka Paalanen wrote: > On Mon, 9 Jul 2018 17:38:49 +0200 > Emilio Pozuelo Monfort wrote: > >> This code calls into EGL to see if the dmabuf import modifiers >> extension is available, and if not it assumes XRGB is supported. >> >>

Re: [PATCH weston] simple-dmabuf-drm: fix build with --disable-egl

2018-07-10 Thread Emilio Pozuelo Monfort
On 10/07/18 14:52, Pekka Paalanen wrote: > On Tue, 3 Jul 2018 16:46:29 +0100 > Emil Velikov wrote: > >> Hi Emilio, >> >> On 2 July 2018 at 16:22, Emilio Pozuelo Monfort wrote: >>> Signed-off-by: Emilio Pozuelo Monfort >>> --- >>> I tried a

[PATCH weston v2] simple-dmabuf-drm: fix build with --disable-egl

2018-07-09 Thread Emilio Pozuelo Monfort
This code calls into EGL to see if the dmabuf import modifiers extension is available, and if not it assumes XRGB is supported. Rather than disabling this client doesn't get build if one disables EGL, we can just remove this and stop lying to ourselves. Signed-off-by: Emilio Pozuelo Mo

[PATCH weston 1/2] shot: add test for sub-surface with unmapped parent

2018-07-09 Thread Emilio Pozuelo Monfort
This reproduces https://bugs.freedesktop.org/show_bug.cgi?id=94735. Signed-off-by: Emilio Pozuelo Monfort --- tests/reference/subsurface_mapped-00.png | Bin 0 -> 799 bytes tests/reference/subsurface_mapped-01.png | Bin 0 -> 841 bytes tests/subsurface-shot-test.c

[PATCH weston 2/2] weston-test: don't map surfaces that have no content

2018-07-09 Thread Emilio Pozuelo Monfort
If a surface has no content (e.g. no buffer), then it shouldn't be mapped, so that its subsurfaces don't get mapped either. This works fine in the desktop-shell, but is currently broken on the weston-test module. https://bugs.freedesktop.org/show_bug.cgi?id Signed-off-by: Emilio Pozue

[PATCH weston 0/2 v3] sub-surface with unmapped parent

2018-07-09 Thread Emilio Pozuelo Monfort
I forgot to git add the test ref images. That's the only change here. Emilio Pozuelo Monfort (2): shot: add test for sub-surface with unmapped parent weston-test: don't map surfaces that have no content tests/reference/subsurface_mapped-00.png | Bin 0 -> 799 bytes te

[PATCH weston 0/2] add test for sub-surface with unmapped parent

2018-07-06 Thread Emilio Pozuelo Monfort
ts to surface_has_content() to check other variables in addition or instead of width and height, but hopefully the approach is better this time. Emilio Pozuelo Monfort (2): shot: add test for sub-surface with unmapped parent weston-test: don't map surfaces that have no content tests

[PATCH weston 1/2] shot: add test for sub-surface with unmapped parent

2018-07-06 Thread Emilio Pozuelo Monfort
This reproduces https://bugs.freedesktop.org/show_bug.cgi?id=94735. Signed-off-by: Emilio Pozuelo Monfort --- tests/reference/subsurface_mapped-00.png | Bin 0 -> 5294 bytes tests/reference/subsurface_mapped-01.png | Bin 0 -> 5612 bytes tests/subsurface-shot-test.c

[PATCH weston 2/2] weston-test: don't map surfaces that have no content

2018-07-06 Thread Emilio Pozuelo Monfort
If a surface has no content (e.g. no buffer), then it shouldn't be mapped, so that its subsurfaces don't get mapped either. This works fine in the desktop-shell, but is currently broken on the weston-test module. https://bugs.freedesktop.org/show_bug.cgi?id Signed-off-by: Emilio Pozue

Re: [PATCH weston] simple-dmabuf-drm: fix build with --disable-egl

2018-07-03 Thread Emilio Pozuelo Monfort
On 03/07/18 11:00, Pekka Paalanen wrote: > On Mon, 2 Jul 2018 17:22:30 +0200 > Emilio Pozuelo Monfort wrote: > >> Signed-off-by: Emilio Pozuelo Monfort >> --- >> I tried a build with --disable-egl as I didn't have the headers >> installed, and it broke he

[PATCH weston] simple-dmabuf-drm: fix build with --disable-egl

2018-07-02 Thread Emilio Pozuelo Monfort
Signed-off-by: Emilio Pozuelo Monfort --- I tried a build with --disable-egl as I didn't have the headers installed, and it broke here. The EGL usage here seemed optional so I did that, but I didn't run-test the result. If it would make more sense to disable the client if EGL support i

Re: [PATCH weston 2/2] Add .gitlab-ci.yml

2018-06-06 Thread Emilio Pozuelo Monfort
On 06/06/18 10:12, Daniel Stone wrote: > Hi, > > On 6 June 2018 at 09:03, Pekka Paalanen wrote: >> On Tue, 5 Jun 2018 23:06:59 +0100 >> Daniel Stone wrote: >>> + - export XDG_RUNTIME_DIR="$(mktemp -p $(pwd) -d xdg-runtime-XX)" >>> + - export BUILD_ID="weston-$CI_JOB_NAME_$CI_COMMIT_SHA-$C

Re: [ANNOUNCE] wayland-protocols 1.12

2017-12-03 Thread Emilio Pozuelo Monfort
Hi Jonas, On 02/12/17 03:41, Jonas Ådahl wrote: > wayland-protocols 1.12 is now available. > > This version includes the new stable version of the XDG Shell protocol. In > short, the difference between the XDG Shell stable and the last unstable > version include (among other things): > > * The

Re: [PATCH weston] configure: bump libweston to 3.0.0

2017-03-14 Thread Emilio Pozuelo Monfort
e > there will be more changes that make the bump obviously necessary. > > Cc: Bryce Harrington > Cc: Daniel Stone > Signed-off-by: Pekka Paalanen Reviewed-by: Emilio Pozuelo Monfort > --- > configure.ac | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(

Re: [PATCH weston 2/2] launcher: Add sysmacros.h include for major()

2017-03-13 Thread Emilio Pozuelo Monfort
s: Reviewed-by: Emilio Pozuelo Monfort > --- > libweston/launcher-direct.c| 1 + > libweston/launcher-logind.c| 1 + > libweston/launcher-weston-launch.c | 1 + > 3 files changed, 3 insertions(+) > > diff --git a/libweston/launcher-direct.c b/libweston/launcher

Re: [PATCH weston 1/3] tests: add a create_test_surface function

2017-02-14 Thread Emilio Pozuelo Monfort
BTW note this series depends on this other one: https://patchwork.freedesktop.org/series/18695/ https://lists.freedesktop.org/archives/wayland-devel/2017-January/032890.html Cheers, Emilio On 03/02/17 16:10, Emilio Pozuelo Monfort wrote: > This doesn't attach a buffer to the surface.

Re: [PATCH weston 3/3] compositor: don't map surfaces without a buffer

2017-02-03 Thread Emilio Pozuelo Monfort
On 03/02/17 16:27, Derek Foreman wrote: > On 03/02/17 09:10 AM, Emilio Pozuelo Monfort wrote: >> We were calling weston_surface::committed on surfaces with >> no buffer attached. Stop doing that, since surface::committed >> will map the surfaces and put them in a visible laye

[PATCH weston 3/3] compositor: don't map surfaces without a buffer

2017-02-03 Thread Emilio Pozuelo Monfort
ut it is a problem if the surface has subsurfaces. This fixes the subsurface_mapped test, so mark it as expected to succeed. https://bugs.freedesktop.org/show_bug.cgi?id=94735 Signed-off-by: Emilio Pozuelo Monfort --- libweston/compositor.c | 10 +- tests/subsurface-shot-test.c

[PATCH weston 2/3] shot: add test for sub-surface with unmapped parent

2017-02-03 Thread Emilio Pozuelo Monfort
This reproduces https://bugs.freedesktop.org/show_bug.cgi?id=94735. The test currently fails, so mark it as expected to fail. Signed-off-by: Emilio Pozuelo Monfort --- tests/reference/subsurface_mapped-00.png | Bin 0 -> 799 bytes tests/reference/subsurface_mapped-01.png | Bin 0 -> 841

[PATCH weston 1/3] tests: add a create_test_surface function

2017-02-03 Thread Emilio Pozuelo Monfort
This doesn't attach a buffer to the surface. This is needed for the next commit, where we have a test case with a surface that doesn't have a buffer attached. Signed-off-by: Emilio Pozuelo Monfort --- tests/weston-test-client-helper.c | 29 - tests/weston-t

[PATCH weston 7/7] compositor: damage pending subsurfaces when committing them

2017-01-27 Thread Emilio Pozuelo Monfort
allows the client to atomically schedule several changes. This fixes the subsurface_z_order test, which is now marked as expected to succeed. Signed-off-by: Emilio Pozuelo Monfort Reviewed-by: Pekka Paalanen --- libweston/compositor.c | 31 +++ libweston

[PATCH weston 5/7] tests: put screenshots to ./logs by default

2017-01-27 Thread Emilio Pozuelo Monfort
From: Pekka Paalanen Logs is where we write all our custom test logs, let's also put the screenshots in the same place by default from cluttering the base directory. Signed-off-by: Pekka Paalanen Reviewed-by: Emilio Pozuelo Monfort --- tests/weston-test-client-helper.c | 5 +++-- 1

[PATCH weston 6/7] tests: add subsurface-shot test

2017-01-27 Thread Emilio Pozuelo Monfort
From: Pekka Paalanen This is marked as a FAIL_TEST, because the last image comparison fails due to a bug in Weston. Jointly authored by Pekka and Emilio. Signed-off-by: Pekka Paalanen Signed-off-by: Emilio Pozuelo Monfort --- Makefile.am | 12 +- tests

[PATCH weston 2/7] tests/shell: get rid of static variables

2017-01-27 Thread Emilio Pozuelo Monfort
From: Pekka Paalanen Stop using static variables and clean up when we're done. [Emilio: update to latest weston_layer API] Signed-off-by: Pekka Paalanen Signed-off-by: Emilio Pozuelo Monfort --- tests/weston-test-desktop-shell.c | 128 -- 1 file ch

[PATCH weston 3/7] tests/shell: change background color

2017-01-27 Thread Emilio Pozuelo Monfort
From: Pekka Paalanen Pick the color 0xCC336699 as AARRGGBB, as if blended on black. This is the color used with developing the sub-surface shot tests. No other big reason than it should not be black to have better chances of catching blending problems. Signed-off-by: Pekka Paalanen --- tests/

[PATCH weston 1/7] tests: add test-desktop-shell

2017-01-27 Thread Emilio Pozuelo Monfort
milio: update to latest weston_layer and shell_init API] Signed-off-by: Quentin Glidic Signed-off-by: Emilio Pozuelo Monfort Signed-off-by: Pekka Paalanen --- Makefile.am | 8 ++ tests/weston-test-desktop-shell.c | 198 ++ 2 files changed

[PATCH weston 4/7] tests: implement get_test_name()

2017-01-27 Thread Emilio Pozuelo Monfort
From: Pekka Paalanen Screenshot tests often want to use the test name for writing out images. This is a helper to get the test name without writing it multiple times in the source. Signed-off-by: Pekka Paalanen Reviewed-by: Emilio Pozuelo Monfort --- tests/weston-test-runner.c | 21

Re: [PATCH weston] compositor-rdp: Fix build with freerdp2

2017-01-20 Thread Emilio Pozuelo Monfort
On 19/01/17 11:26, Daniel Stone wrote: > Hi Emilio, > > On 18 January 2017 at 17:43, Emilio Pozuelo Monfort wrote: >> Based on a patch from John Moser >> >> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=850658 >> >> Signed-off-by: Emilio Pozuelo M

Re: [PATCH weston] clients: fix errno handling

2017-01-19 Thread Emilio Pozuelo Monfort
On 18/01/17 23:58, Emilio Pozuelo Monfort wrote: > On 18/01/17 23:21, Peter Hutterer wrote: >> clients/editor.c: In function ‘read_file’: >> clients/editor.c:1578:16: warning: logical ‘or’ applied to non-boolean >> constant [-Wlogical-op] >> errno = errsv || EINVAL; &g

Re: [PATCH weston] clients: fix errno handling

2017-01-18 Thread Emilio Pozuelo Monfort
On 18/01/17 23:21, Peter Hutterer wrote: > clients/editor.c: In function ‘read_file’: > clients/editor.c:1578:16: warning: logical ‘or’ applied to non-boolean > constant [-Wlogical-op] > errno = errsv || EINVAL; > > This works in the shell, but not in C. Introduced in 411ffabbb56b > > Signed-of

[PATCH weston] compositor-rdp: Fix build with freerdp2

2017-01-18 Thread Emilio Pozuelo Monfort
Based on a patch from John Moser https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=850658 Signed-off-by: Emilio Pozuelo Monfort --- libweston/compositor-rdp.c | 8 1 file changed, 8 insertions(+) diff --git a/libweston/compositor-rdp.c b/libweston/compositor-rdp.c index 223382ce

Re: [PATCH weston] compositor-rdp: Fix build with freerdp2

2017-01-18 Thread Emilio Pozuelo Monfort
On 18/01/17 14:09, Daniel Stone wrote: > Hi Emilio, > > On 17 January 2017 at 19:58, Emilio Pozuelo Monfort wrote: >> index 223382ce..94b4bfa9 100644 >> --- a/libweston/compositor-rdp.c >> +++ b/libweston/compositor-rdp.c >> @@ -664,13 +664,21 @@ rdp_peer

Re: [PATCH weston] clients: fix errno handling

2017-01-18 Thread Emilio Pozuelo Monfort
On 18/01/17 01:53, Peter Hutterer wrote: > clients/editor.c: In function ‘read_file’: > clients/editor.c:1578:16: warning: logical ‘or’ applied to non-boolean > constant [-Wlogical-op] > errno = errsv || EINVAL; > > This works in the shell, but not in C. Introduced in 411ffabbb56b > > Signed-of

[PATCH weston] compositor-rdp: Fix build with freerdp2

2017-01-17 Thread Emilio Pozuelo Monfort
Based on a patch from John Moser https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=850658 Signed-off-by: Emilio Pozuelo Monfort --- libweston/compositor-rdp.c | 8 1 file changed, 8 insertions(+) diff --git a/libweston/compositor-rdp.c b/libweston/compositor-rdp.c index 223382ce

Re: [PATCH wayland 3/3] tests: add scanner tests

2016-11-15 Thread Emilio Pozuelo Monfort
On 11/11/16 15:56, Pekka Paalanen wrote: > On Thu, 10 Nov 2016 12:18:55 +0200 > Pekka Paalanen wrote: > >> On Thu, 10 Nov 2016 11:11:51 +0100 >> Emilio Pozuelo Monfort wrote: >> >>> On 10/11/16 10:57, Pekka Paalanen wrote: >>>> From: Pekk

Re: [PATCH wayland 3/3] tests: add scanner tests

2016-11-10 Thread Emilio Pozuelo Monfort
> + $(top_srcdir)/tests/data/small-client-core.h\ > + $(top_srcdir)/tests/data/small-server-core.h > + > +tests/scanner-test.sh: \ > + $(top_builddir)/wayland-scanner \ > + $(scanner_test_data_files) Dependen

Re: [PATCH libinput 1/2] udev: fix ALPS firmware detection

2016-02-09 Thread Emilio Pozuelo Monfort
On 09/02/16 03:12, Peter Hutterer wrote: > The firmware version is in id.version, not id.model which is always > PSMOUSE_ALPS for ALPS devices. > > The various fw versions are listed in /drivers/input/mouse/alps.h and > are all hex numbers. Version 8 is actually 0x800, change the match > according

Re: [PATCH weston] compositor: fix return code from main()

2015-03-20 Thread Emilio Pozuelo Monfort
g_socket(display, socket_name)) { - ret = EXIT_FAILURE; goto out; } Reviewed-by: Emilio Pozuelo Monfort Cheers, Emilio ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH] cursor: free the array from which images are linked

2015-03-18 Thread Emilio Pozuelo Monfort
@@ wl_cursor_destroy(struct wl_cursor *cursor) for (i = 0; i < cursor->image_count; i++) wl_cursor_image_destroy(cursor->images[i]); + free(cursor->images); free(cursor->name); free(cursor); } Looks good. Reviewed-by: Emilio Pozuelo Monfort

Re: [PATCH weston] desktop-shell: Don't assume there is a pointer when resizing

2014-06-23 Thread Emilio Pozuelo Monfort
Hi Kristian, On 19/06/14 07:37, Kristian Høgsberg wrote: > On Wed, Jun 18, 2014 at 05:48:58PM +0200, Emilio Pozuelo Monfort wrote: >> From: Emilio Pozuelo Monfort >> >> Fixes a crash on touch devices without a pointer, when touching >> the window frame of a client. >

[PATCH weston] desktop-shell: Don't assume there is a pointer when resizing

2014-06-18 Thread Emilio Pozuelo Monfort
From: Emilio Pozuelo Monfort Fixes a crash on touch devices without a pointer, when touching the window frame of a client. Signed-off-by: Emilio Pozuelo Monfort --- desktop-shell/shell.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/desktop-shell/shell.c b/desktop

Re: [PATCH weston 1/5] animation: fix move scale animation

2014-05-23 Thread Emilio Pozuelo Monfort
On 22/05/14 22:41, Jonny Lamb wrote: > Both weston_move_scale_run() and weston_slide_run() were broken in > commit 3a869019. Commit a4a6f161 fixed and explained the problem for > weston_slide_run() but weston_move_scale_run() remained broken. > > To fix weston_move_scale_run(), weston_view_animati

[PATCH weston] exposay: fix crash when navigating with the keyboard

2014-05-23 Thread Emilio Pozuelo Monfort
From: Emilio Pozuelo Monfort Commit a7592019 introduced an optimization that caused some exposay struct members to not be properly initialized, particularly cur_output, leading to crashes in some circumstances (e.g. pressing the down arrow key after going to exposay). Signed-off-by: Emilio

Re: Wayland and Weston 1.5.0 is released

2014-05-21 Thread Emilio Pozuelo Monfort
On 20/05/14 22:12, Kristian Høgsberg wrote: > Hi, > > I tagged 1.5.0 of Wayland and Weston and uploaded tar balls last > night. Tarballs available from > http://wayland.freedesktop.org/releases.html as usual. Magic SHA1 > number for the tags and tar balls: > > bace08b4a531ea4b80b4cf4e953320bc

Re: [PATCH weston] exposay: don't crash if a view goes away

2014-02-19 Thread Emilio Pozuelo Monfort
On 10/02/14 21:17, Daniel Stone wrote: > Hi, > > On 10 February 2014 13:23, Emilio Pozuelo Monfort wrote: >> When a view was destroyed while we were on exposay, we didn't >> remove it from the list of views, and so when leaving exposay >> we were trying to an

Re: [PATCH weston 1/2] toytoolkit: avoid unnecessary redraws when focus changes

2014-02-17 Thread Emilio Pozuelo Monfort
On 12/02/14 15:55, Jasper St. Pierre wrote: > What reschedules the frame being drawn when focused is gained / lost, then? I'm not sure what reschedules it, but it does happen: twice when the window is focused, twice when it is unfocused (maybe something to optimize, why are we redrawing twice?).

Re: [PATCH weston 1/2] toytoolkit: avoid unnecessary redraws when focus changes

2014-02-12 Thread Emilio Pozuelo Monfort
On 12/02/14 01:04, Bryce W. Harrington wrote: > (For full disclosure - On one test run against master, I noticed the > flower changed shape every time it received or lost focus, however I was > never able to reproduce that behavior even after doing clean rebuilds.) That's precisely what made me fi

[PATCH weston] Popup stacking

2014-02-11 Thread Emilio Pozuelo Monfort
From: Emilio Pozuelo Monfort Hi, These two patches fix bug #74831 in two different ways. One of them, originally written by Philip, positions the popup on top of all other surfaces in the layer. That means that you can still end up with the parent surface behind a second parent (as the comment

[PATCH weston] shell: Change stacking order calculation for popup surfaces

2014-02-11 Thread Emilio Pozuelo Monfort
stacking order. [ Emilio: handle popups with non-shell-surface parents ] https://bugs.freedesktop.org/show_bug.cgi?id=74831 Signed-off-by: Philip Withnall Co-authored-by: Emilio Pozuelo Monfort --- desktop-shell/shell.c | 47 +-- 1 file changed, 41

[PATCH weston] shell: activate windows upon a right click

2014-02-11 Thread Emilio Pozuelo Monfort
From: Emilio Pozuelo Monfort This fixes the bug that commit da704d was trying to fix, where a popup would appear on top of its parent but behind other windows. https://bugs.freedesktop.org/show_bug.cgi?id=74831 Signed-off-by: Emilio Pozuelo Monfort --- desktop-shell/shell.c | 3 +++ 1 file

[PATCH weston 2/2] exposay: avoid needlessly activating the active view

2014-02-10 Thread Emilio Pozuelo Monfort
From: Emilio Pozuelo Monfort Signed-off-by: Emilio Pozuelo Monfort --- desktop-shell/exposay.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/desktop-shell/exposay.c b/desktop-shell/exposay.c index fe7a3a7..feadfdc 100644 --- a/desktop-shell/exposay.c +++ b/desktop-shell/exposay.c

[PATCH weston 1/2] toytoolkit: avoid unnecessary redraws when focus changes

2014-02-10 Thread Emilio Pozuelo Monfort
From: Emilio Pozuelo Monfort Clients that need to be redrawn when the focus changes do that by listening to focus_changed and scheduling a redraw. This was causing unnecessary redraws in the clients, as could be easily seen by changing focus on weston-flower. Signed-off-by: Emilio Pozuelo

[PATCH weston] exposay: don't crash if a view goes away

2014-02-10 Thread Emilio Pozuelo Monfort
From: Emilio Pozuelo Monfort When a view was destroyed while we were on exposay, we didn't remove it from the list of views, and so when leaving exposay we were trying to animate (and sometimes activate) a non-existent view, causing a crash. Signed-off-by: Emilio Pozuelo Monfort --- de

[PATCH weston] exposay: arrange views per-output

2014-02-10 Thread Emilio Pozuelo Monfort
From: Emilio Pozuelo Monfort https://bugs.freedesktop.org/show_bug.cgi?id=73173 --- desktop-shell/exposay.c | 108 desktop-shell/shell.c | 7 desktop-shell/shell.h | 74 +++-- 3 files changed, 107

Re: [PATCH weston 3/6] noop-renderer: Read the shm buffer contents on attach

2014-02-07 Thread Emilio Pozuelo Monfort
On 06/02/14 14:45, Pekka Paalanen wrote: > On Thu, 6 Feb 2014 12:30:33 +0100 > Emilio Pozuelo Monfort wrote: > >> From: Emilio Pozuelo Monfort >> >> The noop-renderer doesn't read buffer contents, which means bad >> buffers go undetected. Thus, read the b

Re: [PATCH weston 2/6] noop-renderer: Set the buffer size on attach requests

2014-02-07 Thread Emilio Pozuelo Monfort
On 06/02/14 14:37, Pekka Paalanen wrote: > On Thu, 6 Feb 2014 12:30:32 +0100 > Emilio Pozuelo Monfort wrote: > >> From: Emilio Pozuelo Monfort >> >> This lets the compositor know the size of the surface as calculated >> in weston_surface_set_size_from_buffer(

[PATCH weston v2 5/6] tests: use the headless backend to run the test suite

2014-02-07 Thread Emilio Pozuelo Monfort
From: Emilio Pozuelo Monfort Other backends can be used by passing BACKEND=some-backend.so, e.g. $ make check BACKEND=x11-backend.so Signed-off-by: Emilio Pozuelo Monfort --- tests/weston-tests-env | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/tests

[PATCH weston v2 4/6] tests: Skip buffer-count if EGL initialization fails

2014-02-07 Thread Emilio Pozuelo Monfort
From: Emilio Pozuelo Monfort That is the case when using the headless backend. In the future we may be able to use the mesa null egl platform but for now let's just skip it. Signed-off-by: Emilio Pozuelo Monfort --- tests/buffer-count-test.c | 29 +++-- 1 file ch

[PATCH weston v2 1/6] compositor-headless: create input devices

2014-02-07 Thread Emilio Pozuelo Monfort
From: Emilio Pozuelo Monfort Fixes a segfault when using compositor-headless for the test suite as many tests assume there are input devices and try to use them through the wl_test interface. Signed-off-by: Emilio Pozuelo Monfort --- src/compositor-headless.c | 30

[PATCH weston v2 6/6] tests: Properly report skipped tests

2014-02-07 Thread Emilio Pozuelo Monfort
From: Emilio Pozuelo Monfort We were calling exit(0) when tests were skipped, which counted them as passed instead of skipped. Fix this by properly exiting with 77 (which is what automake expects for skipped tests) from the tests themselves, then returning 77 again from weston-test-runner if all

[PATCH weston v2 3/6] noop-renderer: Read the shm buffer contents on attach

2014-02-07 Thread Emilio Pozuelo Monfort
From: Emilio Pozuelo Monfort The noop-renderer doesn't read buffer contents, which means bad buffers go undetected. Thus, read the buffer contents just for the purpose of triggering SIGBUS (and having the client killed). Fixes the bad-buffer test when run against the headless backend. S

[PATCH weston v2 2/6] noop-renderer: Set the buffer size on attach requests

2014-02-07 Thread Emilio Pozuelo Monfort
From: Emilio Pozuelo Monfort This lets the compositor know the size of the surface as calculated in weston_surface_set_size_from_buffer(), and fixes a couple of tests when using the headless backend. Signed-off-by: Emilio Pozuelo Monfort --- src/noop-renderer.c | 15 +++ 1 file

Re: [PATCH weston 6/6] tests: Properly report skipped tests

2014-02-06 Thread Emilio Pozuelo Monfort
On 06/02/14 12:30, Emilio Pozuelo Monfort wrote: > From: Emilio Pozuelo Monfort > > We were calling exit(0) when tests were skipped, which counted > them as passed instead of skipped. Fix this by properly exiting > with 77 (which is what automake expects for skipped tests) f

[PATCH weston 6/6] tests: Properly report skipped tests

2014-02-06 Thread Emilio Pozuelo Monfort
From: Emilio Pozuelo Monfort We were calling exit(0) when tests were skipped, which counted them as passed instead of skipped. Fix this by properly exiting with 77 (which is what automake expects for skipped tests) from the tests themselves, then returning 77 again from weston-test-runner if all

[PATCH weston 0/6] Make the headless backend useful again

2014-02-06 Thread Emilio Pozuelo Monfort
From: Emilio Pozuelo Monfort This fixes a few bugs in the headless backend, to the point where it can run the test suite, except for two issues: - the buffer-count is skipped because mesa initialization fails, more details in the patch commit message - I haven't been able to properly tes

[PATCH weston 4/6] tests: Skip buffer-count if EGL initialization fails

2014-02-06 Thread Emilio Pozuelo Monfort
From: Emilio Pozuelo Monfort That is the case when using the headless backend. In the future we may be able to use the mesa null egl platform but for now let's just skip it. Signed-off-by: Emilio Pozuelo Monfort --- tests/buffer-count-test.c | 29 +++-- 1 file ch

[PATCH weston 1/6] compositor-headless: create input devices

2014-02-06 Thread Emilio Pozuelo Monfort
From: Emilio Pozuelo Monfort Fixes a segfault when using compositor-headless for the test suite as many tests assume there are input devices and try to use them through the wl_test interface. Signed-off-by: Emilio Pozuelo Monfort --- src/compositor-headless.c | 30

[PATCH weston 2/6] noop-renderer: Set the buffer size on attach requests

2014-02-06 Thread Emilio Pozuelo Monfort
From: Emilio Pozuelo Monfort This lets the compositor know the size of the surface as calculated in weston_surface_set_size_from_buffer(), and fixes a couple of tests when using the headless backend. Signed-off-by: Emilio Pozuelo Monfort --- src/noop-renderer.c | 10 ++ 1 file changed

[PATCH weston 5/6] tests: use the headless backend to run the test suite

2014-02-06 Thread Emilio Pozuelo Monfort
From: Emilio Pozuelo Monfort Other backends can be used by passing BACKEND=some-backend.so, e.g. $ make check BACKEND=x11-backend.so Signed-off-by: Emilio Pozuelo Monfort --- tests/weston-tests-env | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/tests

[PATCH weston 3/6] noop-renderer: Read the shm buffer contents on attach

2014-02-06 Thread Emilio Pozuelo Monfort
From: Emilio Pozuelo Monfort The noop-renderer doesn't read buffer contents, which means bad buffers go undetected. Thus, read the buffer contents just for the purpose of triggering SIGBUS (and having the client killed). Fixed bad-buffer test when run against the headless backend. Signe

Re: [PATCH weston] compositor-rpi: Fix input initialization

2014-02-03 Thread Emilio Pozuelo Monfort
On 03/02/14 20:00, Pekka Paalanen wrote: > On Mon, 3 Feb 2014 16:57:27 +0100 > poch...@gmail.com wrote: > >> From: Emilio Pozuelo Monfort >> >> The input initialization code assumes the outputs have already >> been initialized; thus create the outputs fir

Re: [PATCH weston] Fullscreen surfaces

2014-02-03 Thread Emilio Pozuelo Monfort
On 03/02/14 17:14, Emilio Pozuelo Monfort wrote: > Hi Bill, > > On 30/01/14 23:33, Bill Spitzak wrote: >> There really should not be a "fullscreen layer" which is what is causing this >> problem. "layers" are imho a mistake except for the desttop and the m

Re: [PATCH weston] Fullscreen surfaces

2014-02-03 Thread Emilio Pozuelo Monfort
Hi Bill, On 30/01/14 23:33, Bill Spitzak wrote: > There really should not be a "fullscreen layer" which is what is causing this > problem. "layers" are imho a mistake except for the desttop and the mouse > cursor. > > What I think needs to happen: > > Fullscreen, normal windows, and "panels" ca

Re: weston-1.4.0: rpi-backend is broken

2014-02-03 Thread Emilio Pozuelo Monfort
On 28/01/14 12:00, Pekka Paalanen wrote: > On Tue, 28 Jan 2014 00:49:06 +0100 > "Yann E. MORIN" wrote: > >> Pekka, All, >> >> On 2014-01-26 21:15 +0100, Yann E. MORIN spake thusly: >>> On 2014-01-26 21:51 +0200, Pekka Paalanen spake thusly: On Sun, 26 Jan 2014 19:08:47 +0100 "Yann E. MO

Re: [PATCH weston] build: Set a default aux dir

2014-02-01 Thread Emilio Pozuelo Monfort
Looks good to me. Reviewed-by: Emilio Pozuelo Monfort On 01/02/14 18:48, Guillem Jover wrote: > This moves all the auxiliary build scripts into a build-aux directory, > and fixes an issue with configure being unable to find scripts because > it tries to change to an empty directory t

Re: [PATCH] dim-layer: fix dimming for unfocused surfaces

2014-01-30 Thread Emilio Pozuelo Monfort
Hi Ander, On 29/01/14 16:09, Ander Conselvan de Oliveira wrote: > On 01/15/2014 10:30 AM, Emilio Pozuelo Monfort wrote: >> bump >> >> On 07/01/14 17:23, poch...@gmail.com wrote: >>> From: Emilio Pozuelo Monfort >>> >>> Unfocusing a surface shoul

Re: [PATCH] dim-layer: fix dimming for unfocused surfaces

2014-01-15 Thread Emilio Pozuelo Monfort
bump On 07/01/14 17:23, poch...@gmail.com wrote: > From: Emilio Pozuelo Monfort > > Unfocusing a surface should dim it when dim-layer is enabled, > but this got broken in commit 83ffd9. > --- > desktop-shell/shell.c | 13 - > 1 file changed, 12 inse

wl_display_connect() falling back to wayland-0

2013-12-09 Thread Emilio Pozuelo Monfort
Hi, I was looking at making gtk+ try the wayland backend before the x11 one [1]. This would solve the problem where every gtk+ app uses the x11 backend through XWayland when the latter is available. As you can read on comment #3 and in the patch from comment #1, wl_display_connect() currently fal

Re: Arrgggh Wayland is not compiling again (xcb-composite)

2013-12-08 Thread Emilio Pozuelo Monfort
On 08/12/13 16:48, Bill Spitzak wrote: > Make of weston is not working: > > ~/swdevl/wayland/weston$ make > /dev/nullconfigure: error: Package > requirements > (xcb xcb-xfixes xcb-composite xcursor cairo-xcb) were not met: > > No package 'xcb-composite' found > > I have the .pc file: > > ls /u

Re: [PATCH 0/9] exposay & alt-tab

2013-11-19 Thread Emilio Pozuelo Monfort
On 19/11/13 22:37, Kristian Høgsberg wrote: > On Tue, Nov 19, 2013 at 11:37:10AM +0100, Emilio Pozuelo Monfort wrote: >> Rebased on master and fixed a couple of conflicts with Giulio's recent >> input changes. Fixed the typo spotted by Bryce. > > I'm pushing thes

Re: [PATCH] tests: only build vertex-clip if egl support is enabled

2013-11-19 Thread Emilio Pozuelo Monfort
On 19/11/13 22:21, Kristian Høgsberg wrote: > On Tue, Nov 19, 2013 at 06:09:00PM +0100, Emilio Pozuelo Monfort wrote: >> And pass the right flags to build it. > > This test case only uses GLfloat, we should be able to figure out a > way to compile the test with typedef float GL

[PATCH] tests: only build vertex-clip if egl support is enabled

2013-11-19 Thread Emilio Pozuelo Monfort
And pass the right flags to build it. --- tests/Makefile.am | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 8e08375..e123c18 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -2,7 +2,7 @@ TESTS = $(shared_tests) $(modu

Re: [PATCH v2 wayland] pkg-config: scanner isn't arch-independent

2013-11-19 Thread Emilio Pozuelo Monfort
On 19/11/13 14:15, Arnaud Vrac wrote: > I'm wondering how you are supposed to use the .pc file when cross-compiling > weston for example. Typically you would have the following directory layout: > > wayland build for host: > > host/usr/bin/wayland-scanner > host/usr/lib/pkgconfig/wayland-scanner.

Re: [PATCH v2 wayland] pkg-config: scanner isn't arch-independent

2013-11-19 Thread Emilio Pozuelo Monfort
Ping? wayland-scanner hasn't been dropped and the .pc location is still bogus. On 20/08/13 00:58, Kristian Høgsberg wrote: > On Fri, Aug 16, 2013 at 03:55:52PM +0100, Daniel Stone wrote: >> Hi, >> >> On 16 August 2013 15:50, David Herrmann wrote: >>> On Fri, Aug 16, 2013 at 2:26 PM, Daniel Stone

[PATCH] exposay: move the pointer in our motion handler

2013-11-19 Thread Emilio Pozuelo Monfort
This is necessary since commit 1959ab. --- src/shell.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/shell.c b/src/shell.c index bf5c704..82c3cd8 100644 --- a/src/shell.c +++ b/src/shell.c @@ -5232,11 +5232,14 @@ exposay_layout(struct desktop_shell *shell) } stati

[PATCH 3/9] Add move/scale animation

2013-11-19 Thread Emilio Pozuelo Monfort
From: Daniel Stone Add an animation which moves a surface to a new location, at the same time as also rescaling it to a different size from the origin, rather than the existing scale animation which resizes from the centre. [pochu: rebased, ported to weston_view] --- src/animation.c | 62 +

[PATCH 4/9] Add Exposay

2013-11-19 Thread Emilio Pozuelo Monfort
From: Daniel Stone Exposay provides window overview functions which, when a key which produces the binding modifier is pressed on its own, scales all currently-open windows down to be shown overlaid on the desktop, providing keyboard and mouse navigation to be able to switch window focus. [pochu

  1   2   >