[PATCH] rdp-compositor: fix compilation with FreeRDP 2.0-rc4

Some members have been removed from FreeRDP structs, so let's use local variables. --- libweston/compositor-rdp.c | 86 +++--- 1 file changed, 43 insertions(+), 43 deletions(-) diff --git a/libweston/compositor-rdp.c b/libweston/compositor-rdp.c index 134e7298..871

[PATCH] rdp-compositor: fix compilation against last FreeRDP 2.0

The SURFACE_BITS_COMMAND struct has changed and some members have been moved in the bmp field. --- configure.ac | 9 - libweston/compositor-rdp.c | 69 -- 2 files changed, 52 insertions(+), 26 deletions(-) diff --git a/configure.ac b/configu

[PATCH] rdp-compositor: fix compilation against last FreeRDP 2.0

The SURFACE_BITS_COMMAND struct has changed and some members have been moved in the bmp field. --- configure.ac | 5 ++- libweston/compositor-rdp.c | 69 -- 2 files changed, 48 insertions(+), 26 deletions(-) diff --git a/configure.ac b/configure

[PATCH] rdp compositor: add a man page and add links to that page

--- Makefile.am| 5 +++ man/weston-rdp.man | 92 ++ man/weston.man | 13 3 files changed, 110 insertions(+) create mode 100644 man/weston-rdp.man diff --git a/Makefile.am b/Makefile.am index 7adc625..f67e693 100644 --- a/M

[PATCH] rdp compositor: add a man page

--- Makefile.am| 5 +++ man/weston-rdp.man | 92 ++ 2 files changed, 97 insertions(+) create mode 100644 man/weston-rdp.man diff --git a/Makefile.am b/Makefile.am index 7adc625..f67e693 100644 --- a/Makefile.am +++ b/Makefile.am @@ -15

[PATCH] Fix API troubles with FreeRDP 2.0 v2

With FreeRDP 2.0 the crypto needs to be initialized or we fail as soon as we try to compute a md5. The API also changed for the suppress output callback. --- libweston/compositor-rdp.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/libweston/compositor-rdp.c b

[PATCH] Fix API troubles with FreeRDP 2.0

With FreeRDP 2.0 the crypto needs to be initialized or we fail as soon as we try to compute a md5. The API also changed for the suppress output callback. --- libweston/compositor-rdp.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/libweston/compositor-rdp.c b

[PATCH] desktop-shell: resize background and panel surfaces on output resize v4

When an output is resized (permanent mode switch), we should also notify the shell client so that the panel and background fits to the new screen dimensions. Signed-off-by: David Fort --- desktop-shell/shell.c | 80 +++ desktop-shell/shell.h | 7

[PATCH 3/3] desktop-shell: resize background and panel surfaces on output resize

When an output is resized (permanent mode switch), we should also notify the shell client so that the panel and background fits to the new screen dimensions. Signed-off-by: David Fort --- desktop-shell/shell.c | 93 +++ desktop-shell/shell.h | 8

[PATCH 2/3] compositor: recompute output position on mode switch

When an output permanently changes its resolution, the output on the right should be moved accordingly. We also add an event for output resizing so that plugins can react when an output is resized. Signed-off-by: David Fort Reviewed-by: Pekka Paalanen --- src/compositor.c | 35

[PATCH 0/3] RDP compositor needs love v3

So, the RDP compositor were given some love (2 patches integrated). I have made the changes for seat releasing. And I have also modified the handling of output resize and it should be better now. David Fort (3): rdp: don't release the seat until it is safe v2 compositor: recompute o

[PATCH 1/3] rdp: don't release the seat until it is safe v2

Releasing a seat is not safe, so let's just announce it without keyboard and mouse until this is fixed. Without this patch we just can't reconnect on the RDP compositor as it crashes. v2: fixed the leak of the xkb_keymap Signed-off-by: David Fort Acked-by: Pekka Paalanen Review

[PATCH] rdp: don't release the seat until it is safe v2

Releasing a seat is not safe, so let's just announce it without keyboard and mouse until this is fixed. Without this patch we just can't reconnect on the RDP compositor as it crashes. v2: fixed the leak of the xkb_keymap Signed-off-by: David Fort --- src/compositor-

[PATCH 1/6] rdp: allow to compile against FreeRDP 2.0

FreeRDP 2.0 is about to be released, this allows to compile against this version. The detection is adjusted to prefer FreeRDP 2 against version 1.x. Signed-off-by: David Fort --- configure.ac | 5 - src/compositor-rdp.c | 23 --- 2 files changed, 20 insertions

[PATCH 5/6] compositor: recompute output position on mode switch

When an output permanently changes its resolution, the output on the right should be moved accordingly. We also add an event for output resizing so that plugins can react when an output is resized. Signed-off-by: David Fort --- src/compositor.c | 34 -- src

[PATCH 6/6] desktop-shell: resize background, panel and lock surface on output resize

When an output is resized (permanent mode switch), we should also notify the shell client so that the panel, background and the lock screen fits to the new screen dimensions. Signed-off-by: David Fort --- desktop-shell/shell.c | 60 +++ desktop

[PATCH 4/6] compositor: use generated constant instead of hardcoded value

Use SINCE macros instead of the hardcoded version value. Signed-off-by: David Fort --- src/compositor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compositor.c b/src/compositor.c index 5500197..b88936b 100644 --- a/src/compositor.c +++ b/src/compositor.c @@ -4236,7

[PATCH 3/6] rdp: Fix the ContextNew callback with recent FreeRDP versions

Since a quite long time FreeRDP expect the ContextNew callback to return TRUE when it succeeds. Without this we have some arbitrary failures (most probably when eax is 0 at the end of the function). Signed-off-by: David Fort --- src/compositor-rdp.c | 19 ++- 1 file changed, 18

[PATCH 2/6] rdp: don't release the seat until it is safe

Releasing a seat is not safe, so let's just announce it without keyboard and mouse until this is fixed. Without this patch we just can't reconnect on the RDP compositor as it crashes. Signed-off-by: David Fort --- src/compositor-rdp.c | 32 +++- 1 file c

[PATCH 1/6] rdp: allow to compile against FreeRDP 2.0

FreeRDP 2.0 is about to be released, this allows to compile against this version. The detection is adjusted to prefer FreeRDP 2 against version 1.x. Signed-off-by: David Fort --- configure.ac | 8 +++- src/compositor-rdp.c | 23 --- 2 files changed, 23

[PATCH 0/6] RDP compositor needs love v2

so that only the right surface is reconfigured; * I've dropped the presentation fix hack. David Fort (6): rdp: allow to compile against FreeRDP 2.0 rdp: don't release the seat until it is safe rdp: Fix the ContextNew callback with recent FreeRDP versions compositor: use generate

[PATCH 3/5] rdp: fix presentation for the RDP compositor

Set an update delay that is a multiple of the output frequency, or we may do incorrect weston_output_finish_frame calls. --- src/compositor-rdp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compositor-rdp.c b/src/compositor-rdp.c index 9274674..4cbc1c3 100644 --- a/src/

[PATCH 2/5] rdp: don't release the seat until it is safe

Releasing a seat is not safe, so let's just announce it without keyboard and mouse until this is fixed. Without this patch we just can't reconnect on the RDP compositor as it crashes. Signed-off-by: David Fort --- src/compositor-rdp.c | 32 +++- 1 file c

[PATCH 5/5] desktop shell: resize background and panel when an output switches mode

When an output permanently switches mode, the desktop shell must be notified so that the misc components can resize to the new size of the output. This patch also fixes the coodinates of "other" outputs when the resize occurs. Signed-off-by: David Fort --- desktop-shell/sh

[PATCH 1/5] rdp: allow to compile against FreeRDP 2.0

FreeRDP 2.0 is about to be released, this allows to compile against this version. Signed-off-by: David Fort --- configure.ac | 8 +++- src/compositor-rdp.c | 23 --- 2 files changed, 23 insertions(+), 8 deletions(-) diff --git a/configure.ac b/configure.ac

[PATCH 0/5] RDP compositor needs love

t the cost of leaking the seat). And finally there's a fix for output mode switching, and the panel and background not resizing when it happens. This bug is there since the beginning of the RDP compositor (looks like it's the only one that actually changes output modes). David Fort (5

[PATCH 4/5] rdp: Fix the ContextNew callback with recent FreeRDP versions

Since a quite long time FreeRDP expect the ContextNew callback to return TRUE when it succeeds. Without this we have some arbitrary failures (most probably when eax is 0 at the end of the function). Signed-off-by: David Fort --- src/compositor-rdp.c | 19 ++- 1 file changed, 18

[RFC] weston: implement inert objects for keyboard/pointer/touch

we want the same kind of behaviour for other input devices (saving locks state for keyboard device for example) ? David FORT (1): weston: implement inert objects for keyboard/pointer/touch desktop-shell/exposay.c | 16 ++-- desktop-shell/shell.c| 21 ++-- src/compositor-wayland.c | 10

[PATCH] weston: implement inert objects for keyboard/pointer/touch

This patch implements inert objects for wl_keyboard, wl_pointer and wl_touch. The target case is when the server has just send a capability event about a disappearing object, and the client binds the corresponding object. We bind an inert object: an object does nothing when it is requested. If the

[RFC] weston: implement inert objects for keyboard/pointer/touch

This patch implements inert objects for wl_keyboard, wl_pointer and wl_touch. The target case is when the server has just send a capability event about a disappearing object, and the client binds the corresponding object. We bind an inert object: an object does nothing when it is requested. If the

[PATCH wayland] scanner: server-side also emit SINCE macros for requests

Server-side we need to know the versions for destructor requests. Signed-off-by: David FORT --- src/scanner.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/scanner.c b/src/scanner.c index f456aa5..406ba82 100644 --- a/src/scanner.c +++ b/src/scanner.c @@ -1266,6 +1266,7 @@ emit_header

[PATCH] weston: release keyboard/touch/pointer objects

This patch adds the missing calls to release when the seat has capabilities changes. It also fixes a missing release of the touch object and a leak with old clients. Signed-off-by: David FORT --- clients/window.c | 26 ++ 1 file changed, 22 insertions(+), 4 deletions

[PATCH] weston: release keyboard/touch/pointer objects

This patch adds the missing calls to release when the seat has capabilities changes. It also fixes a missing release of the touch object. --- clients/window.c | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/clients/window.c b/clients/window.c index 47a7

[PATCH] wayland: add a release request on wl_seat v3

This version takes in account last Jonas Ådahl's remarks. David FORT (1): wayland: add a release request on wl_seat protocol/wayland.xml | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) -- 1.9.1 ___ wayland-devel mailing

[PATCH] wayland: add a release request on wl_seat

This is required if we want to correctly remove a wl_seat compositor-side. A wl_seat is announced as a global object, then it is bound by the client. When the compositor wants to remove the seat, it shall announce the global removal of the object. The client can then call the release request on the

[PATCH] wayland: add release request on wl_seat v2

Compared to the first version, I changed the description according to Jonas's comment. No real consensus have emerged on IRC or on the mailing list about version numbering. So I choosed to keep them as it is done now. David FORT (1): Add a release request on wl_seat protocol/wayland.xml

[PATCH] wayland: add a release request on wl_seat

This is required if we want to correctly remove a wl_seat compositor-side. A wl_seat is announced as a global object, then it is bound by the client. When the compositor wants to remove the seat, it shall announce the global removal of the object. The client can then call the release request on the

[PATCH] wayland: add release request on wl_seat

This is required if we want to correctly remove a wl_seat compositor-side. A wl_seat is announced as a global object, then it is bound by the client. When the compositor wants to remove the seat, it shall announce the global removal of the object. The client can then call the release request on the

[PATCH weston] RDP compositor: make the seat dynamic and don't destroy it on removal

This patch makes the seat dynamic and leak it on purpose during seat removal to prevent the ghost object case. --- src/compositor-rdp.c | 39 +++ 1 file changed, 27 insertions(+), 12 deletions(-) diff --git a/src/compositor-rdp.c b/src/compositor-rdp.c index c2

[PATCH weston] RDP compositor: dynamic seat v2

announce is done the right way(TM) in this patch. If you disagree, comments are more than welcome. David FORT (1): RDP compositor: make the seat dynamic and don't destroy it on removal src/compositor-rdp.c | 39 +++ 1 file changed, 27 insertions(+

[PATCH] [RDP compositor] don't crash when the key file doesn't exist

This allows to close the remaining issue in https://bugs.freedesktop.org/show_bug.cgi?id=91390 --- src/compositor-rdp.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/compositor-rdp.c b/src/compositor-rdp.c index 4ef0dd1..c76af61 100644 --- a/src/compositor

[PATCH 2/2] [rdp compositor] Fix crash when using RDP4 security

The initialization of the freerdp_peer was done too early. This fixes https://bugs.freedesktop.org/show_bug.cgi?id=91390. --- src/compositor-rdp.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/compositor-rdp.c b/src/compositor-rdp.c index 70d290b..4ef0dd1 100644 ---

[PATCH 1/2] [rdp compositor] remove a warning during compilation

backend_init now returns an int not a pointer. --- src/compositor-rdp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compositor-rdp.c b/src/compositor-rdp.c index 86c5b2a..70d290b 100644 --- a/src/compositor-rdp.c +++ b/src/compositor-rdp.c @@ -1270,7 +1270,7 @@ backend_

[PATCH 0/2] Misc fixes for the RDP compositor

Misc things fixed in the RDP compositor: * bad return value in backend_init, introduced by the libweston refactoring; * an initialization that was done too early and was crashing when using RDP4 security David FORT (2): [rdp compositor] remove a warning during compilation [rdp compositor] Fix

[PATCH 1/2] RDP compositor: make the seat dynamic and don't destroy it on removal

This patch makes the seat dynamic and leak it on purpose during seat removal to prevent the ghost object case. --- src/compositor-rdp.c | 39 +++ 1 file changed, 27 insertions(+), 12 deletions(-) diff --git a/src/compositor-rdp.c b/src/compositor-rdp.c index 31

[PATCH 0/2] Misc fixes for the RDP compositor

seat). David FORT (2): RDP compositor: make the seat dynamic and don't destroy it on removal RDP compositor: enforce certificate and key src/compositor-rdp.c | 45 + 1 file changed, 33 insertions(+), 12 deletions(-)

[PATCH 2/2] RDP compositor: enforce certificate and key

The RDP compositor is usable without certificates and key in a very limited number of cases (local usage using xfreerdp), so let's force the presence of keys and certificates. --- src/compositor-rdp.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/compositor-rdp.c b/src/compositor-r

[PATCH RDP compositor] v3 fixes for multiple connections and mstsc

This v3 should fix the detection of nsc_context_reset(). It also allows to compile against FreeRDP master, with the callbacks that now return BOOLs. Hardening (1): RDP compositor: fixes for multiple connections, mstsc and FreeRDP master compilation src/compositor-rdp.c | 127

[PATCH] RDP compositor: fixes for multiple connections, mstsc and FreeRDP master compilation

From: Hardening This patch fixes the problem reported on the mailing list (http://lists.freedesktop.org/archives/wayland-devel/2015-January/019575.html). All certificate and key paths were not copied when given to FreeRDP, so they were freed when the peer was disconnecting. And so the next connec

[PATCH 0/3][RFC] introducing inert objects to allow to release server-side objects

, and only return inert objects. This is a preliminary work and comments are more than welcome. David FORT (3): Modify wayland-scanner to generate inert objects Add a release request on wl_seat wayland.xml: fixed a typo protocol/wayland.xml | 8 ++- src/scanner.c| 173

[PATCH 2/3] Modify wayland-scanner to generate inert objects

As stated in the very good blog post[1] of Pekka Paalanen, server-side we can have sometime troubles with object that the server has deleted but that the client is still requesting. This patch complements the scanner to create some code that will return inert objects, ie objects that will do nothi

[PATCH 3/3] Add a release request on wl_seat

This is required if we want to correctly remove a wl_seat server-side. --- protocol/wayland.xml | 6 ++ 1 file changed, 6 insertions(+) diff --git a/protocol/wayland.xml b/protocol/wayland.xml index 4fb8035..8f63ebf 100644 --- a/protocol/wayland.xml +++ b/protocol/wayland.xml @@ -1400,6 +1400

[PATCH 1/3] wayland.xml: fixed a typo

From: Hardening --- protocol/wayland.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/protocol/wayland.xml b/protocol/wayland.xml index 2a49805..4fb8035 100644 --- a/protocol/wayland.xml +++ b/protocol/wayland.xml @@ -1389,7 +1389,7 @@ - +

Re: [RDP compositor] peer's output is enabled at connexion The peer's flags were badly set when the peer had just connect, this patch sets the output as enable at connection.

On 10/08/2013 22:53, Hardening wrote: --- src/compositor-rdp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) [...] Sorry for the bad header formatting. I forgot to precise it was for stable-1.2 and for master and to say that all credits goes to Marek Romanowicz who does all the i

Re: Possible bug in compositor-rdp.c (Marek Romanowicz)

On 06/08/2013 17:28, Marek Romanowicz wrote: Hi all, I am not sure if compositor-rdp.c acts as authors intended it to. I managed to make it running after several attempts together with wayland and connect to it over RDP protocol using xfreerdp from another machine running Ubuntu 13.10. Xfree