Re: [PATCH] wayland: use wl_log instead of printf

2013-09-22 Thread Chang Liu
If we > did add such a function it might want to have it's own log handler. > > Kristian, > Do you have any thoughts? > > Thanks, > --Jason Ekstrand > On Sep 12, 2013 9:36 PM, "Chang Liu" wrote: > >> use wl_log instead of printf and fprintf in

[PATCH] client: fix an inconsistency in documentation

2013-09-17 Thread Chang Liu
The errno is set to EAGAIN when there are undispatched events, according to L1066 of wayland-client.c. --- src/wayland-client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wayland-client.c b/src/wayland-client.c index 04d988b..d043459 100644 --- a/src/wayland-client.c +

[PATCH] client: fix an inconsistency in documentation

2013-09-17 Thread Chang Liu
The errno is set to EAGAIN when there are undispatched events, according to L1066 of wayland-client.c. --- src/wayland-client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wayland-client.c b/src/wayland-client.c index 04d988b..d043459 100644 --- a/src/wayland-client.c +

[PATCH] protocol: fix an extra underscore

2013-09-14 Thread Chang Liu
remove the unnecessary extra underscore in the name of the argument of wl_shell_surface::set_class --- The identifier class_ only appears in the generated code, in function declarations. Changing it shouldn't cause any backward incompatibilities. protocol/wayland.xml | 2 +- 1 file changed, 1 ins

[PATCH] wayland: use wl_log instead of printf

2013-09-12 Thread Chang Liu
use wl_log instead of printf and fprintf in core library --- I'm pretty sure these printf usages should be avoided since libraries should not print to stdout. But I'm not sure if there is any reason for favoring a fprintf to stderr over wl_log. Please enlighten me if there is any. src/connection.

[PATCH] gitignore: add ./compile

2013-09-07 Thread Chang Liu
./compile is a GNU autotools helper script and should be ignored by git --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 99b7089..f243100 100644 --- a/.gitignore +++ b/.gitignore @@ -15,6 +15,7 @@ ctags /aclocal.m4 /wayland-scanner.m4 /autom4te.ca

[PATCH] wayland-util: merge {client, server}_entries in wl_map into one variable

2013-09-07 Thread Chang Liu
Since a wl_map can be either client side or server side (but not both) and we have the side field to indicate this, we can merge client_entries and server_entries into one variable to reduce clutter. --- src/wayland-private.h | 3 +-- src/wayland-util.c| 43 +++

[PATCH] wayland-util: fix wrap-back of wl_map->free_list when client id >= 0x80000000

2013-09-07 Thread Chang Liu
The current implementation of wl_map uses uint32_t for free_list. When removing client id >= 0x8000, shifting said id by 1 bit left will cause free_list to wrap back to 0x0. Bump both wl_map->free_list and union_entry->next to uint64_t to fix this problem. --- The relavent lines are: In wl_map_

Re: Midori browser should now work on Wayland

2013-04-25 Thread Chang Liu
Sorry I CC'ed wayland-devel-request. I have to resend the mail. I tried this morning. Midori crashed on start. Both midori and libunique are latest git version. Backtrace: Launching command: '/usr/bin/gdb' --batch -ex 'set print thread-events off' -ex run -ex 'set logging on /run/user/1000/midori