Requesting feedback on disallowing handle attribute values in EGLint attribute lists

2013-10-09 Thread Chad Versace
Khronos is proposing a change affecting EGL attribute lists, and they are requesting feedback on this forum thread [1]. They have specifically requested feedback from the opensource community. [1] http://www.khronos.org/message_boards/showthread.php/9138-Requesting-feedback-on-disallowing-handl

Re: [PATCH 2/2] wayland-util: Rename ARRAY_LENGTH -> __WL_ARRAY_LENGTH

2012-10-18 Thread Chad Versace
On 10/18/2012 01:48 PM, Kristian Høgsberg wrote: > On Thu, Oct 18, 2012 at 4:27 PM, David Herrmann > wrote: >> Hi Chad >> >> On Thu, Oct 18, 2012 at 9:45 PM, Chad Versace >> wrote: >>> On 10/18/2012 12:35 PM, Chad Versace wrote: >>>> On 10/18/20

Re: [PATCH 2/2] wayland-util: Rename ARRAY_LENGTH -> __WL_ARRAY_LENGTH

2012-10-18 Thread Chad Versace
On 10/18/2012 12:35 PM, Chad Versace wrote: > On 10/18/2012 10:23 AM, Pekka Paalanen wrote: >> On Thu, 18 Oct 2012 09:15:08 -0700 >> Chad Versace wrote: >> >>> wayland-util.h defined an unprefixed macro, ARRAY_LENGTH, which polluted >>> the global name

Re: [PATCH 2/2] wayland-util: Rename ARRAY_LENGTH -> __WL_ARRAY_LENGTH

2012-10-18 Thread Chad Versace
On 10/18/2012 10:23 AM, Pekka Paalanen wrote: > On Thu, 18 Oct 2012 09:15:08 -0700 > Chad Versace wrote: > >> wayland-util.h defined an unprefixed macro, ARRAY_LENGTH, which polluted >> the global namespace. This caused symbol collisions in projects that >> de

[PATCH 2/2] wayland-util: Rename ARRAY_LENGTH -> __WL_ARRAY_LENGTH

2012-10-18 Thread Chad Versace
wayland-util.h defined an unprefixed macro, ARRAY_LENGTH, which polluted the global namespace. This caused symbol collisions in projects that defined ARRAY_LENGTH slightly differently. Signed-off-by: Chad Versace --- cursor/wayland-cursor.c | 2 +- src/connection.c| 6 +++--- src

[PATCH 1/2] wayland-util: Remove container_of()

2012-10-18 Thread Chad Versace
definition of container_of() and replaces each call to it with a call to __wl_container_of(). Signed-off-by: Chad Versace --- src/data-device.c| 25 - src/event-loop.c | 4 ++-- src/wayland-client.c | 8 src/wayland-server.c | 6 +++--- src/wayland-shm.c

Removal of unprefixed container_of()

2012-10-17 Thread Chad Versace
wayland-util.h defines __wl_container_of() as well as an unprefixed version, container_of(). The unprefixed version, of course, pollutes the global namespace and causes symbol collisions in projects that define container_of() slightly differently. Is there any chance that the unprefixed container_

Re: [PATCH] compositor: Fix buggy snprintf that sets module path

2012-05-29 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/25/2012 08:04 PM, Kristian Høgsberg wrote: > On Wed, May 23, 2012 at 11:32:24PM -0700, Chad Versace wrote: >> If the MODULEDIR string contains '%', then >> snprintf(path, sizeof(path), MODULEDIR "/%s",

[PATCH v2] compositor: Fix buggy snprintf that sets module path

2012-05-23 Thread Chad Versace
If the MODULEDIR string contains '%', then snprintf(path, sizeof(path), MODULEDIR "/%s", name); does not do what you want. Signed-off-by: Chad Versace --- src/compositor.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compositor.c b/sr

Re: [PATCH] compositor: Fix buggy snprintf that sets module path

2012-05-23 Thread Chad Versace
; On Wed, May 23, 2012 at 11:32 PM, Chad Versace <mailto:chad.vers...@linux.intel.com>> wrote: > > If the MODULEDIR string contains '%', then >snprintf(path, sizeof(path), MODULEDIR "/%s", name); > does not do what you want. > > Fix t

[PATCH] compositor: Fix buggy snprintf that sets module path

2012-05-23 Thread Chad Versace
If the MODULEDIR string contains '%', then snprintf(path, sizeof(path), MODULEDIR "/%s", name); does not do what you want. Fix this by replacing snprintf with stncpy followed by strncat. Signed-off-by: Chad Versace --- src/compositor.c |8 +--- 1 file changed

Proof-of-concept: Running Piglit on Wayland and X11/EGL

2012-04-13 Thread Chad Versace
st archive. [3] http://lists.freedesktop.org/archives/piglit/2012-April/002193.html ---- Chad Versace chad.vers...@linux.intel.com ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel