[PATCH] doc: Fix link to wl_list_remove()

Use function linking syntax instead of variable linking, to resolve two warnings: wayland-server.h:167: warning: explicit link request to 'wl_list_remove' could not be resolved wayland-server.h:188: warning: explicit link request to 'wl_list_remove' could not be resolved Signed-off-by:

[PATCH] doc: Quell warnings about missing man3 directory before its been built

The shell command for dist_man3_MANS gets invoked several times during the make process but before the man pages have been generated, which causes the following warnings when running `make`: find: `man/man3': No such file or directory find: `man/man3': No such file or directory find: `

[PATCH] gitignore: Add another test-suite file

Signed-off-by: Bryce Harrington --- .gitignore |1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index c146bac..d9d26ed 100644 --- a/.gitignore +++ b/.gitignore @@ -47,6 +47,7 @@ fixed-benchmark fixed-test list-test map-test +message-test os-wrappers-test queue-

Re: [PATCH 1/3] tests: add expect_protocol_error function

On Mon, Jul 07, 2014 at 05:47:41PM +0300, Pekka Paalanen wrote: > On Thu, 19 Jun 2014 02:37:40 + > "Bryce W. Harrington" wrote: > > > On Mon, May 26, 2014 at 04:58:05PM +0200, Marek Chalupa wrote: > > > This function checks if a particular protocol error c

Re: [PATCH 1/3] tests: add expect_protocol_error function

On Mon, May 26, 2014 at 04:58:05PM +0200, Marek Chalupa wrote: > This function checks if a particular protocol error came in wire. > It's usefull in the cases where we hitherto used FAIL_TEST. > The problem with FAIL_TEST is that *any* assert will pass the test, > but we want only some asserts to p

Re: [PATCH] client: extend error handling

On Mon, May 26, 2014 at 04:57:23PM +0200, Marek Chalupa wrote: > When an error occurs, wl_display_get_error() does not > provide any way of getting know if it was a local error or if it was > an error event, respectively what object caused the error and what > the error was. > > This patch introdu

Re: Suggestions on implementing Wayland Protocol Dumper.

On Mon, Jun 09, 2014 at 11:17:20AM +0530, Srivardhan wrote: > Hi, > > The following are the ways in which a Protocol Dumper can be implemented: > 1. Just before sending a message or when a message is received, the message > can be written to a file. This change can be done in libwayland under #ifd

Re: [PATCH weston] Clients: Fix memleak issues in various clients of weston

On Thu, May 15, 2014 at 06:58:16PM +0530, vivek wrote: > In many clients of weston, Display was not being destroyed so added it. > Also destroy windows, widgets which were not being destroyed. > > Signed-off-by: vivek LGTM Reviewed-by: Bryce Harrington > --- > clients/cliptest.c| 13 ++

Re: [PATCH wayland-web 0/7] Version 5 of build instructions patch

On Fri, May 30, 2014 at 02:12:28PM -0700, Bill Spitzak wrote: > This is a duplicate posting but I removed the in-reply-to because that seems > to have hidden it, as there have been no comments. > > Changes are to incorporate the patches from Pekka Paalanen, removing > incorrect changes I made, a

Re: [PATCH wayland-web 4/7] Added page of Ubuntu12.04 specific directions

On Fri, May 30, 2014 at 02:12:32PM -0700, Bill Spitzak wrote: > From: Bill Spitzak > > --- > building.html| 19 +++- > ubuntu12.04.html | 291 > ++ > 2 files changed, 307 insertions(+), 3 deletions(-) > create mode 100644 ubuntu12.04.h

Re: [PATCH V2] event: assert wl_event_source pointer is NULL.

On Mon, May 12, 2014 at 11:26:01AM +0530, Srivardhan Hebbar wrote: > Signed-off-by: Srivardhan Hebbar > --- > src/event-loop.c |6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/src/event-loop.c b/src/event-loop.c > index 9790cde..57e3fed 100644 > --- a/src/event-lo

Re: [PATCH weston 2/2] build: let 'make clean' remove logs/ again

Yep, I ran into this myself but wasn't sure if it was intentional or not. Reviewed-by: Bryce Harrington On Mon, May 12, 2014 at 10:08:57AM +0300, Pekka Paalanen wrote: > From: Pekka Paalanen > > Before in the recursive automake setting, we had tests/logs/ for > explicitly created test log file

[PATCH 2/5] clients: Use x*alloc routines for memory allocation

Since these are all demo client programs, program termination is an appropriate response to an out-of-memory situation. Using these routines keeps the client code more concise. Signed-off-by: Bryce Harrington --- clients/calibrator.c|5 + clients/desktop-shell.c |5 +

[PATCH 4/5] clients: Use xzalloc instead of xcalloc when allocating single element

Signed-off-by: Bryce Harrington --- clients/desktop-shell.c |2 +- clients/editor.c|2 +- clients/fullscreen.c|2 +- clients/subsurfaces.c |6 +++--- clients/window.c|4 ++-- clients/wscreensaver.c |2 +- 6 files changed, 9 insertions(+), 9 deletion

[PATCH 5/5] clients: Use xstrdup instead of strdup

Signed-off-by: Bryce Harrington --- clients/editor.c | 12 ++-- clients/image.c|4 ++-- clients/keyboard.c | 12 ++-- clients/terminal.c |2 +- 4 files changed, 15 insertions(+), 15 deletions(-) diff --git a/clients/editor.c b/clients/editor.c index bda3e91..ec

[PATCH 1/5] clients: Add xcalloc

Signed-off-by: Bryce Harrington --- clients/window.c |8 clients/window.h |2 ++ 2 files changed, 10 insertions(+) diff --git a/clients/window.c b/clients/window.c index f12ce39..cfc1260 100644 --- a/clients/window.c +++ b/clients/window.c @@ -5647,3 +5647,11 @@ xrealloc(char *

[PATCH 3/5] clients: Use calloc instead of malloc/memset=0

Signed-off-by: Bryce Harrington --- clients/editor.c |4 +--- clients/subsurfaces.c |8 ++-- clients/window.c | 13 ++--- 3 files changed, 5 insertions(+), 20 deletions(-) diff --git a/clients/editor.c b/clients/editor.c index 6ed76d4..b439d9e 100644 --- a/client

[PATCH 0/5] clients: Use the x*alloc routines

As per our discussion last week, here's patches to convert client code to using xmalloc, xzalloc, xcalloc, and xstrdup where appropriate. I opted not to change nested.c, because it looked like errors were being propagated to a higher level for handling, and bombing out on OOM might not be desired?

[PATCH] clients: Initialize label in keyboard handling code

Quells warning: clients/keyboard.c: In function ‘keyboard_handle_key.isra.5’: clients/keyboard.c:556:11: warning: ‘label’ may be used uninitialized in this function [-Wuninitialized] Signed-off-by: Bryce Harrington --- clients/keyboard.c |2 +- 1 file changed, 1 insertion(+), 1 deletio

Re: [PATCH 3/6] cairo-util: Kill a duplicate test

On Mon, Apr 28, 2014 at 11:19:29AM -0400, Jasper St. Pierre wrote: > If !(x < margin), then clearly margin <= x. No need to test for it again. Yep, this looks correct, and clearer logic. Reviewed-by: Bryce Harrington > --- > shared/cairo-util.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 del

Re: [PATCH 1/6] compositor: Fix the documentation for surface->configure

On Mon, Apr 28, 2014 at 11:19:27AM -0400, Jasper St. Pierre wrote: > It's called on commit, not on attach. Additionally, correct the > interface name to be wl_surface, not surface. > --- > src/compositor.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/compositor

[PATCH] terminal: Convert all *alloc's to x*alloc's.

This ensures the allocation results are checked for NULL (out of memory), and terminates the program in such a case. Signed-off-by: Bryce Harrington --- clients/terminal.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/clients/terminal.c b/clients/terminal.c index 5

Re: [PATCH 3/3] clients: Check zalloc return for out of memory situation

On Thu, Apr 24, 2014 at 04:26:20PM +0300, Pekka Paalanen wrote: > On Mon, 21 Apr 2014 23:51:03 + > "Bryce W. Harrington" wrote: > > terminal = xzalloc(sizeof *terminal); > > + if (terminal == NULL) > > + return NULL; > > No need to ch

Re: [PATCH 1/3 v2] Check zalloc return for out of memory situation

Most zalloc calls in weston are checked, this fixes a handful that were being ignored. As found by `grep -EIsr "[^x]zalloc\(" . -A1` Update: Drop the chunk in screen-share.c; Hardening already fixed the zalloc check in commit e57d1f21. Signed-off-by: Bryce Harrington --- src/compositor-wayland

[PATCH 1/3] Check zalloc return for out of memory situation

Most zalloc calls in weston are checked, this fixes a handful that were being ignored. As found by `grep -EIsr "[^x]zalloc\(" . -A1` Signed-off-by: Bryce Harrington --- src/compositor-wayland.c |6 ++ src/libinput-seat.c |2 +- src/screen-share.c |8 +++- src/scre

[PATCH 3/3] clients: Check zalloc return for out of memory situation

Checking for these errors in the clients is perhaps a bit gratuitous but can't hurt. Signed-off-by: Bryce Harrington --- clients/gears.c|3 +++ clients/terminal.c | 20 2 files changed, 23 insertions(+) diff --git a/clients/gears.c b/clients/gears.c index 93a86b4.

[PATCH 2/3] xwayland: Check zalloc return for out of memory situation

Signed-off-by: Bryce Harrington --- xwayland/launcher.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/xwayland/launcher.c b/xwayland/launcher.c index ac692de..70703a4 100644 --- a/xwayland/launcher.c +++ b/xwayland/launcher.c @@ -348,6 +348,8 @@ module_init(struct weston_compositor *c

Re: New to wayland, need help pls.

On Wed, Apr 16, 2014 at 08:51:21AM +0300, Pekka Paalanen wrote: > On Tue, 15 Apr 2014 19:08:12 + > "Bryce W. Harrington" wrote: > > > On Tue, Apr 15, 2014 at 10:13:15AM +0300, Pekka Paalanen wrote: > > > On Mon, 14 Apr 2014 12:11:11 +0530 > > &g

Re: New to wayland, need help pls.

On Tue, Apr 15, 2014 at 10:13:15AM +0300, Pekka Paalanen wrote: > On Mon, 14 Apr 2014 12:11:11 +0530 > Srivardhan M S wrote: > > > Hi, > > > > I am new to Wayland, and I would like to contribute to it. I have already, > > downloaded the source code and have built it. Now reading the documentatio

Re: Question about multi-display on wayland protocol

On Mon, Apr 14, 2014 at 11:08:00AM -0700, Bill Spitzak wrote: > I think he is asking how to run Wayland so that it controls more > than one monitor. This has nothing to do with how windows act once > Wayland is running. That's how I read it too. @Yang, there have been various patch proposals for

Re: [PATCH] Check malloc result

Much better error checking. In the out_pixman_error finalizer should it also destroy the zalloc'd sb object, since we're going to return NULL in this case? Also see one more comment below. But these are just nit picks; LGTM even without those changes. Reviewed-by: Bryce Harrington On Fri, Apr

[PATCH] protocol: Correct typo 'suppot'

Signed-off-by: Bryce Harrington --- protocol/fullscreen-shell.xml |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/protocol/fullscreen-shell.xml b/protocol/fullscreen-shell.xml index 3c2cf3c..939c2ba 100644 --- a/protocol/fullscreen-shell.xml +++ b/protocol/fullscreen-shell

Re: [PATCH fullscreen-shell v6 09/19] toytoolkit: Don't crash if wl_data_device_manager is not present

On Wed, Apr 02, 2014 at 07:53:51PM -0500, Jason Ekstrand wrote: > This is primaraly to get weston-fullscreen to run on compositors that lack primarily > copy-paste support. > > Signed-off-by: Jason Ekstrand > --- > clients/window.c | 24 > 1 file changed, 16 insertions

Re: [PATCH fullscreen-shell v6 01/19] Add a fullscreen shell protocol

Looks good, spotted one typo though. On Wed, Apr 02, 2014 at 07:53:43PM -0500, Jason Ekstrand wrote: > Signed-off-by: Jason Ekstrand > --- > protocol/fullscreen-shell.xml | 206 > ++ > 1 file changed, 206 insertions(+) > create mode 100644 protocol/fulls

Re: [PATCH V2 0/8] Add weston randr protocol

On Wed, Apr 02, 2014 at 07:34:11AM +, Wang, Quanxian wrote: > Thanks Bryce's information and suggestion. Your suggestion and randr history > are really appreciated. > > >As GUI interfaces came into being, they > >had to reinvent the user-oriented logic already in the xrandr tool, and > >besi

Re: [PATCH V2 0/8] Add weston randr protocol

On Mon, Mar 24, 2014 at 07:39:12PM +0800, Quanxian Wang wrote: > By the way, currently we are focus on the protocol design. The implemented > code is just > a reference. However it will be helpful for reviewer to have a test and get > the clear > idea of protocol. I like your comment to make thi

make check hangs on xwayland when xwayland not present

I've built weston via the standard directions (http://wayland.freedesktop.org/building.html), with a few modifications (see my prior email today for details). But I haven't done the XWayland setup steps (http://wayland.freedesktop.org/xserver.html) so don't have functional XWayland support. Runni

Re: Not able to build Weston.

On Tue, Apr 01, 2014 at 12:14:17PM +0530, Srivardhan M S wrote: > Hi, > > I followed the instruction from > http://wayland.freedesktop.org/building.html and was able to build > Wayland, Mesa, libxkbcommon, cairo-gl, libunwind. But got struck while > building Weston. When I do a make, I get the fol

[PATCH] compositor: Use weston_log rather than perror for error messages

weston_log() seems to be the standard elsewhere in the codebase for errors. These are the only two instances where perror() is used instead, and their error messages aren't that informative anyway. Signed-off-by: Bryce Harrington --- src/compositor-wayland.c |4 ++-- 1 file changed, 2 inser

Re: [PATCH] compositor: Use weston_log rather than perror for error messages

On Wed, Mar 19, 2014 at 09:19:03AM +0200, Pekka Paalanen wrote: > On Wed, 19 Mar 2014 00:21:20 +0100 > Hardening wrote: > > > Le 18/03/2014 20:34, Bryce W. Harrington a écrit : > > > weston_log() seems to be the standard elsewhere in the codebase for > > >

Re: [PATCH 1/3] wayland: Add wl_output name event

On Wed, Mar 19, 2014 at 01:54:13AM +, Wang, Quanxian wrote: > [Wang, Quanxian] Thanks Bryce. > >I glanced at the other patches and they look technically correct, but I > >think what > >might be missing here is a stronger justification about why this is needed? > [Wang, Quanxian] name is one p

[PATCH] compositor: Use weston_log rather than perror for error messages

weston_log() seems to be the standard elsewhere in the codebase for errors. These are the only two instances where perror() is used instead, and their error messages aren't that informative anyway. Signed-off-by: Bryce Harrington --- src/compositor-wayland.c |4 ++-- 1 file changed, 2 inser

Re: [PATCH 0/3] Add wl_output name event

Apart from my phrasing suggestions on the first patch, the series looks good now, so feel free to add: Reviewed-by: Bryce Harrington On Mon, Mar 17, 2014 at 11:34:49AM +0800, Quanxian Wang wrote: > This event contains name of output. It may be sent after > binding the output object. It is intend

Re: [PATCH 1/3] wayland: Add wl_output name event

On Mon, Mar 17, 2014 at 11:34:50AM +0800, Quanxian Wang wrote: > This event contains name of output. It may be sent after > binding the output object. It is intended that client could > input a character output name as a parameter or for log output. > > Signed-off-by: Quanxian Wang > --- > proto

Re: [PATCH] Add error handling for wl_cursors

LGTM Reviewed-by: Bryce Harrington On Tue, Mar 18, 2014 at 11:29:00AM +0100, Hardening wrote: > This patch adds some error management in wayland cursors > --- > cursor/wayland-cursor.c | 20 +--- > 1 file changed, 13 insertions(+), 7 deletions(-) > > diff --git a/cursor/wayland

Re: [PATCH 2/3] weston:Add wl_output name event

On Fri, Mar 14, 2014 at 10:27:05AM +0800, Quanxian Wang wrote: > Signed-off-by: Quanxian Wang > --- > src/compositor.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/compositor.c b/src/compositor.c > index 98a4f6f..8e8964b 100644 > --- a/src/compositor.c > +++ b/src/compositor.c

Re: [PATCH] weston: Send done event with version 2 of wl_output

On Fri, Mar 14, 2014 at 09:16:25AM +0800, Quanxian Wang wrote: > With protocol of wl_output version 2, after the output change, > it should send done event to all clients bount with it. bound? > > Signed-off-by: Quanxian Wang > --- > src/compositor.c | 6 +- > 1 file changed, 5 insertions(

[PATCH] gitignore log files, now in root directory

Signed-off-by: Bryce Harrington --- .gitignore |2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index e0a73c0..d3044a2 100644 --- a/.gitignore +++ b/.gitignore @@ -2,6 +2,7 @@ *.jpg *.la *.lo +*.log *.o *.pc *.so @@ -21,6 +22,7 @@ cscope.out /config.status

[PATCH] Link only against rt, as fixed-benchmark isn't runnable by test suite

Thanks to feedback from Pekka Paalanen. Using -lrt instead of libtest-runner.la still results in successful compilation and no change in test behavior, and fixed-benchmark still appears to run properly. Signed-off-by: Bryce Harrington --- Makefile.am |2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH weston v4 15/15] Add a screen sharing plugin

On Mon, Mar 10, 2014 at 08:42:41PM -0500, Jason Ekstrand wrote: > > > +static void > > > +ss_seat_handle_pointer_enter(void *data, struct wl_pointer *pointer, > > > + uint32_t serial, struct wl_surface *surface, > > > + wl_fixed_t x, wl_fixed_t y) >

Re: [PATCH] x11-backend: Add a --scale option

LGTM Reviewed-by: Bryce Harrington On Fri, Mar 07, 2014 at 03:29:14PM -0600, Jason Ekstrand wrote: > From: Jason Ekstrand > > --- > man/weston.man | 4 > src/compositor-x11.c | 11 +++ > 2 files changed, 11 insertions(+), 4 deletions(-) > > diff --git a/man/weston.man b/m

Re: [PATCH weston] Fix the pixman renderer with respect to output transforms

On Tue, Feb 25, 2014 at 09:54:59PM -0600, Jason Ekstrand wrote: > Commit fa1b3055 introducted a regression in the pixman renderer. In > particular, it would not draw properly with any output transform other > than normal, 180, 180-flipped, or 270-flipped. This patch fixes this > regression. The

Re: [PATCH weston v4 15/15] Add a screen sharing plugin

Mostly just some spell checks. Reviewed-by: Bryce Harrington On Tue, Feb 25, 2014 at 07:26:47PM -0600, Jason Ekstrand wrote: > This adds a plugin called screen-share.so. If the screen-share.so module > is imported, it will add the CTRL+ALT+s keybinding to start a screen > sharing session. If y

[PATCH] tests: Fix build of noinst fixed-benchmark test

Solves this build error: tests/fixed-benchmark.o: In function `benchmark': ./wayland/tests/fixed-benchmark.c:82: undefined reference to `clock_gettime' ./wayland/tests/fixed-benchmark.c:84: undefined reference to `clock_gettime' Signed-off-by: Bryce Harrington --- Makefile.am |1 + 1

Re: [PATCH weston v4 01/15] Add a fullscreen shell protocol

On Fri, Mar 07, 2014 at 11:31:16AM -0600, Jason Ekstrand wrote: > > > + If the size of the presented surface changes, the resulting output > > > + is undefined. The compositor may attempt to change the output > mode > > > + to compensate. However, there is no guarantee that a suitable

Re: [PATCH weston v4 01/15] Add a fullscreen shell protocol

On Tue, Feb 25, 2014 at 07:26:33PM -0600, Jason Ekstrand wrote: > Signed-off-by: Jason Ekstrand > --- > protocol/fullscreen-shell.xml | 158 > ++ > 1 file changed, 158 insertions(+) > create mode 100644 protocol/fullscreen-shell.xml > > diff --git a/prot

Re: [PATCH weston 1/2] toytoolkit: avoid unnecessary redraws when focus changes

On Wed, Feb 12, 2014 at 09:08:51AM +0100, Emilio Pozuelo Monfort wrote: > On 12/02/14 01:04, Bryce W. Harrington wrote: > > (For full disclosure - On one test run against master, I noticed the > > flower changed shape every time it received or lost focus, however I was > > ne

Re: [PATCH weston 1/2] toytoolkit: avoid unnecessary redraws when focus changes

On Mon, Feb 10, 2014 at 04:52:32PM +0100, Emilio Pozuelo Monfort wrote: > From: Emilio Pozuelo Monfort > > Clients that need to be redrawn when the focus changes do that by > listening to focus_changed and scheduling a redraw. > > This was causing unnecessary redraws in the clients, as could be

Re: [PATCH weston.ini.man v3] Improvement of weston.ini.man. Add key:shell and remove tablet-shell

On Mon, Feb 10, 2014 at 12:15:11PM +0900, Nobuhiko Tanibata wrote: > Add description of key:shell to CORE SECTION and move a example of > desktop-shell from key:modules to key:shell. > Add cms-colord.so to key:modules of CORE SECTION. > > Signed-off-by: Nobuhiko Tanibata LGTM Reviewed-by: Bryce

[PATCH] README: Fix typo; add link to testing docs

Signed-off-by: Bryce Harrington --- README |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/README b/README index b3be4c9..3821e5d 100644 --- a/README +++ b/README @@ -11,5 +11,8 @@ shell. Finally, weston also provides integration with the Xorg server and can pull X

Re: [PATCH weston] build: Fix build when Wayland headers are not in standard prefix

On Mon, Feb 03, 2014 at 05:55:39PM +0200, Ander Conselvan de Oliveira wrote: > The move to a single Makefile.am missed to set a few _CFLAGS variables, > causing the build to fail if the Wayland headers are not installed in > the standard prefix. Looks like Pekka caught these already with commits 5

Re: [PATCH weston] desktop-shell: initialize children link

On Tue, Jan 28, 2014 at 01:54:16PM +0100, poch...@gmail.com wrote: > From: Emilio Pozuelo Monfort > > Since commit 9046d2, when destroying a surface, we remove all the > links from its children. But when the child surfaces are destroyed, > those links will be removed again, but since they were no

Re: [PATCH 1/2] compositor: keep track of the weston_layer a weston_view is in

On Mon, Jan 27, 2014 at 09:46:49PM +0200, Giulio Camuffo wrote: > This introduces a new struct, weston_layer_entry, which is now used > in place of wl_list to keep the link for the layer list in weston_view > and the head of the list in weston_layer. > weston_layer_entry also has a weston_layer*, w

[PATCH] web: Fix typo and grammar in testing documentation

Signed-off-by: Bryce Harrington --- testing.html |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/testing.html b/testing.html index a65d8f4..21c0b7b 100644 --- a/testing.html +++ b/testing.html @@ -19,8 +19,8 @@ the tests directory. It leverages automake's specify

[PATCH 2/2] protocol: Reformat xdg-shell and desktop protocol text to 72 chars

Signed-off-by: Bryce Harrington --- protocol/desktop-shell.xml | 36 +- protocol/xdg-shell.xml | 157 ++-- 2 files changed, 97 insertions(+), 96 deletions(-) diff --git a/protocol/desktop-shell.xml b/protocol/desktop-shell.xml index 7b34213

[PATCH 1/2] protocol: Grammar copyedits of the xdg-shell and desktop protocol docs

Signed-off-by: Bryce Harrington --- protocol/desktop-shell.xml | 10 ++--- protocol/xdg-shell.xml | 89 ++-- 2 files changed, 49 insertions(+), 50 deletions(-) diff --git a/protocol/desktop-shell.xml b/protocol/desktop-shell.xml index 65e44a7..7b3

Re: 1.4 Beta (1.3.92) Test Results

On Mon, Jan 20, 2014 at 07:58:18PM +, Eoff, Ullysses A wrote: > ::Automated Test Results:: > > Passed: 99% (1254/1272) > Failed: 1% (18/1272) > > ::Issues Encountered (new and pre-existing):: > > SIGSEGV in ping_timeout_handler: > >

[PATCH] gitignore: Generated files text-client-protocol.h, text-protocol.c

Signed-off-by: Bryce Harrington --- tests/.gitignore |2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/.gitignore b/tests/.gitignore index 32a6492..dc4a71a 100644 --- a/tests/.gitignore +++ b/tests/.gitignore @@ -7,6 +7,8 @@ matrix-test setbacklight test-client test-text-client +

Re: [PATCH] client: Include poll.h instead of sys/poll.h

On Tue, Jan 14, 2014 at 06:38:59PM +0100, Jonas 'Sortie' Termansen wrote: > POSIX mandates the poll.h header as the standard location of poll(2). A casual googling indicates this is true. Reviewed-by: Bryce Harrington > --- > src/wayland-client.c |2 +- > 1 file changed, 1 insertion(+), 1 d

[PATCH 2/2] Cleanup stray newline in a return statement

Signed-off-by: Bryce Harrington --- src/libbacklight.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/libbacklight.c b/src/libbacklight.c index b3acc63..a9d7ef1 100644 --- a/src/libbacklight.c +++ b/src/libbacklight.c @@ -51,8 +51,7 @@ static long backlight_get(stru

[PATCH 1/2] terminal: Only set title if asprintf succeeded

Handles potential out of memory situation by skipping the title update. This fixes the following warning: terminal.c: In function ‘resize_handler’: terminal.c:851:11: warning: ignoring return value of ‘asprintf’, declared with attribute warn_unused_result [-Wunused-result] Signed-off-by: Br

Re: [PATCH 1/2] Fix XWayland transient window location.

LGTM. For both patches: Reviewed-by: Bryce Harrington On Sun, Jan 12, 2014 at 03:06:04PM +0100, Axel Davy wrote: > This fixes: https://bugs.freedesktop.org/show_bug.cgi?id=73517 > > Signed-off-by: Axel Davy > --- > xwayland/window-manager.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 dele

Re: [PATCH] weston.ini.man: Fix some grammar

Reviewed-by: Bryce Harrington On Fri, Jan 10, 2014 at 10:23:12PM +0100, Wieland Hoffmann wrote: > --- > man/weston.ini.man | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/man/weston.ini.man b/man/weston.ini.man > index 6be90bf..ce3f928 100644 > --- a/man/weston.ini.man

Re: [PATCH weston 2/2] input: Unlink saved kbd focus listener when releasing seat

For both patches: Reviewed-by: Bryce Harrington On Fri, Jan 03, 2014 at 07:46:51PM +0100, Jonas Ådahl wrote: > Not doing this would leave a invalid list item in the view's destroy > signal listener list if destroying a seat that had previously lost > keyboard focus. > > Signed-off-by: Jonas Åda

Re: [PATCH 1/2] drm: prepend stamp space to output mode logging

LGTM on both patches. Reviewed-by: Bryce Harrington On Fri, Jan 10, 2014 at 10:15:17AM -0800, U. Artie Eoff wrote: > Use the STAMP_SPACE to make the output mode logging > a little nicer looking. > > Signed-off-by: U. Artie Eoff > --- > src/compositor-drm.c | 2 +- > 1 file changed, 1 insertio

Re: [PATCH] weston: Send xdg_surface_send_focused_[un]set when focusing surfaces

I'm not sure how to exercise this keyboard functionality, but I ran weston with this and moused between a few windows. So, LGTM: Reviewed-by: Bryce Harrington On Mon, Dec 16, 2013 at 01:39:39PM -0500, Jasper St. Pierre wrote: > --- > desktop-shell/shell.c | 57 > ++

Re: Wayland design and source code documentation

On Tue, Dec 17, 2013 at 11:32:09PM +0300, Artsiom Anikeyenka wrote: > Hi guys, > > Is there a detailed documentation of wayland source code. Any good > visualization of the design? Are there any plans on adding/creating those? > > Thanks and be good. http://wayland.freedesktop.org/architecture.h

Re: [PATCH] compositor-drm: free drm_mode in drm_output_destroy

On Mon, Dec 16, 2013 at 03:23:43PM +0800, Xiong Zhang wrote: > When drm_output is destroyed, we should free drm_mode to avoid > memoey leakage. ^ 'memory' > Signed-off-by: Xiong Zhang Reviewed-by: Bryce Harrington > --- > src/compositor-drm.c | 7 +++ > 1 file changed, 7 insertions(+) >

Re: [PATCH] compositor-drm: consider the best mode of the mode_list as an option

On Thu, Dec 12, 2013 at 05:13:56PM +0100, Fabien DESSENNE wrote: > This patch fixes an issue where Weston using the DRM backend, cannot start > the display. This happens in the following context: > - no video mode is set before weston starts (eg no "/dev/fb" set up) > - weston is not configured wit

Re: [PATCH] Add a weston_surface_set_size function

On Mon, Dec 09, 2013 at 09:16:07PM +0100, Giulio Camuffo wrote: > 2013/12/9 Bryce W. Harrington : > > On Wed, Dec 04, 2013 at 08:32:03PM -0600, Jason Ekstrand wrote: > >> Surfaces that are created by clients get their size automatically updated > >> by the attach/commit.

Re: [PATCH weston] introduces a setting to give permission to any client to do screenshots

On Wed, Dec 04, 2013 at 05:38:23PM +0100, Sebastian Wick wrote: > This patch adds a screenshooter section with the "restrict-access" > setting which is on by default and is the current behavior of weston. > When turning it off, all clients can use the screenshooter protocol. > This makes screen cap

Re: [PATCH wayland 2/2] doc: Fix spelling of parameters

On Mon, Dec 09, 2013 at 10:35:22PM +0100, Jonas Ådahl wrote: > Signed-off-by: Jonas Ådahl Reviewed-by: Bryce Harrington > --- > src/wayland-client.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/wayland-client.c b/src/wayland-client.c > index ab79b7b..7503ca

Re: [PATCH 0/3] Test static functions

On Thu, Dec 05, 2013 at 04:38:19PM +0100, Marek Ch wrote: > Hi, > > I did similar thing like is in Weston for testing static functions. Also, I > wrote > few wl_buffer unit tests. > I appreaciate any comments :) > > P. S.: based on mailing here: > http://lists.freedesktop.org/archives/wayland-de

Re: [PATCH] Add a weston_surface_set_size function

On Wed, Dec 04, 2013 at 08:32:03PM -0600, Jason Ekstrand wrote: > Surfaces that are created by clients get their size automatically updated > by the attach/commit. Surfaces created directly by shells (such as black > surfaces) sometimes need to be manually resized. This function allows you > to d

Re: [RESEND PATCH weston v3] pixman: Destroy pixman images when underlying buffer is destroyed

On Sat, Nov 30, 2013 at 03:41:00PM +0100, Lubomir Rintel wrote: > While the pixman image might be attached, the underlying buffer might be > already gone under certain circumstances. This is easily reproduced by > attempting to resize gnome-terminal on a fbdev backend. > > $ WAYLAND_DEBUG=1 strace

Re: [PATCH] rpi: Support opaque regions

On Mon, Dec 02, 2013 at 05:18:58PM +0100, Tomeu Vizoso wrote: > This is needed for XWayland surfaces with alpha channel, as X will be > sending crap in there that should be discarded. > > This is currently done with a copy in the compositor, while we wait for > support in the VideoCore side. > ---

Re: [PATCH] Make the default desktop shell client configurable

Looks good to me Reviewed-by: Bryce Harrington On Mon, Dec 02, 2013 at 12:53:32PM +0100, poch...@gmail.com wrote: > From: Emilio Pozuelo Monfort > > The default can be set by passing WESTON_SHELL_CLIENT as an argument > to configure, similarly to WESTON_NATIVE_BACKEND. > --- > configure.ac

Re: [PATCH/RFC] Scanner for tests

On Fri, Nov 29, 2013 at 04:36:56PM +0200, Pekka Paalanen wrote: > On Fri, 29 Nov 2013 14:52:30 +0100 > Marek Ch wrote: > > > > > Hi! > > > > I was looking into wayland's code and I saw static wl_buffer_* > > functions and I thought: These would use a test.. But how to do it > > when they are st

Re: [PATCH] tests: fix compiler warnings and remove trailing whitespace

On Wed, Nov 20, 2013 at 04:25:39PM +0100, Marek Ch wrote: > Fix 'unused variable' and 'missing initializer' warnings and > remove trailing whitespaces in connection-test > @@ -517,6 +523,7 @@ suu_handler(void *data, struct wl_object *object, > { > int *done = data; > > + assert(object

Re: [PATCH weston 2/2] compositor: set weston_surface:resource to NULL when destroyed

On Fri, Nov 15, 2013 at 10:06:15PM +0100, Giulio Camuffo wrote: > with the previous patch the resource isn't used inside > weston_surface_destroy() > anymore (aside sending events unuseful for a closing client), so we can safely > reset it. > > Reviewed-by: Jason Ekstrand > --- > src/compositor

Re: [PATCH] client: Introduce functions to allocate and marshal proxies atomically

On Fri, Nov 15, 2013 at 08:51:50PM -0800, Kristian Høgsberg wrote: > The server requires clients to only allocate one ID ahead of the previously > highest ID in order to keep the ID range tight. Failure to do so will > make the server close the client connection. However, the way we allocate > ne

Re: [PATCH 1/9] animation, shell: add kbd focus change animation

On Fri, Nov 15, 2013 at 05:53:30PM +0100, Emilio Pozuelo Monfort wrote: > From: Louis-Francis Ratté-Boulianne > > When enabled, this will make all but the keyboard-focused window dim. > Also the background gets dimmed, if there are any windows open. The > panel is not dimmed. > > When the keyboa

Re: [PATCH 4/4] utils: tweak wl_list for better doxygen output

On Wed, Aug 28, 2013 at 06:02:02PM -0500, Aaron Faanes wrote: > --- > src/wayland-util.h | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/src/wayland-util.h b/src/wayland-util.h > index 02d9458..fd735f7 100644 > --- a/src/wayland-util.h > +++ b/src/wayland-util.h > @@

Re: [PATCH wayland-web] building: Recommend disabling setuid for non-root installs

On Sun, Aug 25, 2013 at 10:57:59AM +0300, Pekka Paalanen wrote: > On Fri, 23 Aug 2013 19:54:17 + > "Bryce W. Harrington" wrote: > > diff --git a/building.html b/building.html > > index b7a1158..a47744e 100644 > > --- a/building.html > > +++ b/build

Re: [PATCH] .gitignore: Reflect recent client binary rename

> Bryce W. Harrington wrote: > >Commit 77ab1721 renamed the client binaries; this change updates > >.gitignore to follow this change. > > > >Signed-off-by: Bryce Harrington > >--- > > clients/.gitignore | 37 +++-- >

[PATCH] .gitignore: Reflect recent client binary rename

Commit 77ab1721 renamed the client binaries; this change updates .gitignore to follow this change. Signed-off-by: Bryce Harrington --- clients/.gitignore | 37 +++-- 1 file changed, 19 insertions(+), 18 deletions(-) diff --git a/clients/.gitignore b/clients/.gi

[PATCH wayland-web] building: Recommend disabling setuid for non-root installs

The build directions guide the user to build and install Wayland in a user directory without using superuser privs. However, the weston build process includes a `chown root` on weston-launcher done by default, which results in a failed build when running make install as non-superuser, unless we pa

[PATCH wayland-web] building: copyedits

Add a space between two words and a missing 's'. Signed-off-by: Bryce Harrington --- building.html |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/building.html b/building.html index a47744e..9a1e9e8 100644 --- a/building.html +++ b/building.html @@ -170,7 +170,7 @@ It

[PATCH wayland-web] building: Update renamed client names

These were renamed mid-July to add a weston- prefix. Signed-off-by: Bryce Harrington --- building.html | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/building.html b/building.html index 771c659..b7a1158 100644 --- a/building.html +++ b/building.html @@ -

Re: [RFC PATCH v2] protocol: Extend wayland seat with interfaces for sensor inputs.

On Thu, Aug 22, 2013 at 09:46:28AM +0100, Stefan Schmidt wrote: > Treating some specific sensors as input devices. In particular > adding support for wl_compass, wl_gyroscope and wl_accelerometer here. > > Using these sensor as input for apps and games. Not covering any > background apps or servic

  1   2   >