[PATCH] src/Makefile.am: Fix git-version.h for out of tree builds

2013-03-01 Thread Andre Heider
Use --git-dir instead of --work-tree, see http://marc.info/?l=git&m=120390208721287&w=2 Signed-off-by: Andre Heider --- src/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Makefile.am b/src/Makefile.am index 2c93a7b..d56daa0 100644 --- a/src/Makefile.

Re: [PATCH 3/3] wayland-cursor: Adapt to new shm pool helper functions

2012-08-07 Thread Andre Heider
On Tue, Aug 7, 2012 at 2:15 PM, Ander Conselvan de Oliveira wrote: > void > wl_shm_mapping_set_resize_behavior(struct wl_shm_mapping *mapping, >enum wl_shm_mapping_resize_behavior > behavior); > > Or maybe have that as flags for wl_shm_mapping_create(). But the

Re: [PATCH 3/3] wayland-cursor: Adapt to new shm pool helper functions

2012-08-07 Thread Andre Heider
On Tue, Aug 7, 2012 at 2:15 PM, Ander Conselvan de Oliveira wrote: > I like to have the allocate function try to resize the pool if needed. All > users except wayland-cursor allocate a pool large enough, so they should > never reach and on the other hand its convenient not to have to write the > r

Re: [PATCH 2/3] wayland-client: Introduce shm pool helper function

2012-08-07 Thread Andre Heider
On Tue, Aug 7, 2012 at 2:03 PM, Ander Conselvan de Oliveira wrote: >> +#include "../shared/os-compatibility.h" > > You should have the Makefile set -I$(top_srcdir)/shared so you can do just > > #include "os-compatibility.h", > > but I think we don't need a libshared in this particular case. Wil

Re: [PATCH 0/3] Introduce shm pool helper functions

2012-08-07 Thread Andre Heider
On Tue, Aug 7, 2012 at 1:43 PM, Ander Conselvan de Oliveira wrote: > I think this could be called wl_shm_mapping and we get rid of the unmap > parameter to wl_shm_pool_helper_destroy(). In terms of a public API I think > it is bad idea to let the user leak the mapping. In simple-shm.c, > simple-to

[PATCH 4/4] window.c: Adapt to new shm pool helper functions

2012-08-04 Thread Andre Heider
--- clients/window.c | 115 -- 1 file changed, 16 insertions(+), 99 deletions(-) diff --git a/clients/window.c b/clients/window.c index d0b7a7d..17b373e 100644 --- a/clients/window.c +++ b/clients/window.c @@ -66,8 +66,6 @@ #include "window.

[PATCH 3/4] simple-touch.c: Adapt to new shm pool helper functions

2012-08-04 Thread Andre Heider
--- clients/simple-touch.c | 26 -- 1 file changed, 8 insertions(+), 18 deletions(-) diff --git a/clients/simple-touch.c b/clients/simple-touch.c index 6087fe4..91b0e0b 100644 --- a/clients/simple-touch.c +++ b/clients/simple-touch.c @@ -26,8 +26,6 @@ #include #includ

[PATCH 2/4] simple-shm.c: Adapt to new shm pool helper functions

2012-08-04 Thread Andre Heider
--- clients/simple-shm.c | 24 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/clients/simple-shm.c b/clients/simple-shm.c index 252e040..0e5a32e 100644 --- a/clients/simple-shm.c +++ b/clients/simple-shm.c @@ -26,8 +26,6 @@ #include #include #include

[PATCH 1/4] screenshot.c: Adapt to new shm pool helper functions

2012-08-04 Thread Andre Heider
--- clients/screenshot.c | 24 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/clients/screenshot.c b/clients/screenshot.c index 7395bf3..b8b866a 100644 --- a/clients/screenshot.c +++ b/clients/screenshot.c @@ -25,10 +25,8 @@ #include #include #includ

[PATCH 3/3] wayland-cursor: Adapt to new shm pool helper functions

2012-08-04 Thread Andre Heider
--- cursor/wayland-cursor.c | 115 ++- 1 file changed, 24 insertions(+), 91 deletions(-) diff --git a/cursor/wayland-cursor.c b/cursor/wayland-cursor.c index 10e8f62..8e467f6 100644 --- a/cursor/wayland-cursor.c +++ b/cursor/wayland-cursor.c @@ -31,93

[PATCH 2/3] wayland-client: Introduce shm pool helper function

2012-08-04 Thread Andre Heider
Every client dealing with shm buffers requires code to set up pools. Wayland already implements this platform independent, so make public helper function available instead of putting the burden on every client. --- src/Makefile.am |6 ++- src/wayland-client.c | 110 ++

[PATCH 1/3] Introduce a static lib for shared code

2012-08-04 Thread Andre Heider
As with weston, link a static, non-installable library with shared code. This currently only contains os-compability.c, moved from cursor/. --- configure.ac |1 + cursor/Makefile.am| 12 ++--- cursor/os-compatibility.c | 128 -

[PATCH 0/3] Introduce shm pool helper functions

2012-08-04 Thread Andre Heider
more thoughts before declaring it public, but I wanted to get some comments about this first. Similar to wayland-cursor, this could also be shoved into its own library. Also see the follow up patch set for weston. Andre Heider (3): Introduce a static lib for shared code wayland-client: Intr

[PATCH] terminal: Don't crash on non-ascii chars

2012-08-02 Thread Andre Heider
isalpha() and isdigit() don't like huge values. Noticed with ascii-art in the shell prompt. --- clients/terminal.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/clients/terminal.c b/clients/terminal.c index dd35ceb..cbcd1ec 100644 --- a/clients/terminal.c +++ b/clients/terminal.c @@ -2

Re: [PATCH weston] configure: link image libs with libshared

2012-07-31 Thread Andre Heider
On Tue, Jul 31, 2012 at 2:47 PM, Tiago Vignatti wrote: > This fix xwayland.so that was complaining about jpeg symbols from the > libshared. > > Note that xwayland is not using the jpeg ones, but now that symbols are read > up front we need to link anyway.. or break apart that library. What about

[PATCH] protocol: Remove "repeat" from "key_state"

2012-07-31 Thread Andre Heider
This is unused and apparently was never implemented. --- While this might qualify as api breakage, the occurence of the repeat enum in public headers might confuse users (read: me). As I understood on irc, this will never be implemented, so it can be argued that its even nice to point users at non-

Re: [PATCH weston 5/8] simple-touch: respond to ping protocol

2012-07-31 Thread Andre Heider
On Tue, Jul 31, 2012 at 3:00 PM, Pekka Paalanen wrote: > Which (non-existing) code are you referring to? > > The unresponsive busy cursor thing is triggered in the desktop-shell > plugin, and the actual busy cursor is set in the desktop-shell client. > It does not require any setup from the client

Re: [PATCH weston 5/8] simple-touch: respond to ping protocol

2012-07-31 Thread Andre Heider
On Tue, Jul 31, 2012 at 2:32 PM, Pekka Paalanen wrote: > Hi, > > it would be hard to spot in the log. Weston already changes the pointer > to a busy cursor, when over an unresponsive surface. > Did that not work for you, or did you just miss the connection? There wasn't yet any code to handle poi

Re: [PATCH weston 5/8] simple-touch: respond to ping protocol

2012-07-31 Thread Andre Heider
On Tue, Jul 31, 2012 at 12:21 PM, Pekka Paalanen wrote: > Without this, it won't get any input anymore. I noticed this too while fixing up SDL for 0.95. It wasn't obvious why input events were not delivered anymore. Maybe weston should log something about non-responsive client? __

[PATCH] window.c: Remove xkb leftovers

2012-07-25 Thread Andre Heider
--- clients/window.c | 13 - 1 file changed, 13 deletions(-) diff --git a/clients/window.c b/clients/window.c index 186eed9..c55ec77 100644 --- a/clients/window.c +++ b/clients/window.c @@ -323,16 +323,6 @@ enum window_location { WINDOW_CLIENT_AREA = 18, }; -const char *o