Re: [PATCH V2] Do not assume 64x64 cursor, added support for other sizes (like in AMD Kaveri, 128x128).

2014-07-04 Thread Ander Conselvan de Oliveira
On 07/04/2014 04:13 AM, Michel Dänzer wrote: On 03.07.2014 21:27, Ander Conselvan de Oliveira wrote: On 06/25/2014 05:09 PM, Alvaro Fernando García wrote: Init cursor size to 64x64 if drmGetCap() fails. Use Mesa GBM_BO_USE_CURSOR define (which removes 64x64 restriction) Signed-off-by: Alvaro

Re: [PATCH V2] Do not assume 64x64 cursor, added support for other sizes (like in AMD Kaveri, 128x128).

2014-07-03 Thread Ander Conselvan de Oliveira
On 06/25/2014 05:09 PM, Alvaro Fernando García wrote: Init cursor size to 64x64 if drmGetCap() fails. Use Mesa GBM_BO_USE_CURSOR define (which removes 64x64 restriction) Signed-off-by: Alvaro Fernando García --- src/compositor-drm.c | 43 --- 1 file c

Re: How do I get started?

2014-06-30 Thread Ander Conselvan de Oliveira
On 06/29/2014 05:45 PM, Ayan Shafqat wrote: Thanks for your prompt reply, Armin. I am familiar with git scm and have used it for a few projects. What I am interested in are the points below: (1) Coding style guidelines for Wayland. (2) Where to submit patches. The following document covers the

Re: Simple SHM Wayland Client

2014-05-30 Thread Ander Conselvan de Oliveira
On 05/30/2014 09:57 AM, Marek Chalupa wrote: Hi, On 29 May 2014 13:59, Philip Rushik mailto:prus...@gmail.com>> wrote: On Thu, May 29, 2014 at 8:02 PM, Marek Chalupa mailto:mchqwe...@gmail.com>> wrote: [...] xdg_surface stuff is not part of libwayland-client and I don't

[PATCH weston] vaapi-recorder: Don't loop trying to write on out of space condition

2014-05-09 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira The error handling for the function that writes the encoded frame on the disk was bogus, always assuming the buffer supplied to the encoder was too small. That would cause a bigger buffer to be allocated and another attempt to encode the frame was done. In the

[PATCH weston] editor: Fix cursor positioning with pointer and touch

2014-05-08 Thread Ander Conselvan de Oliveira
The calculation off the vertical offset between the widget coordinates and where the text was rendered was wrong. It was using the constant for horizontal offset for that too. --- clients/editor.c | 33 +++-- 1 file changed, 23 insertions(+), 10 deletions(-) diff --git

Re: [PATCH weston] simple-touch: Handle multiple seats

2014-05-07 Thread Ander Conselvan de Oliveira
On 05/07/2014 05:13 PM, Jasper St. Pierre wrote: Looks mostly the same as Ander's patch here: My patch didn't handle global remove properly, so I'd say we should go with this one. Ander http://lists.freedesktop.org/archives/wayland-devel/2014-May/014658.html Same review applies :) On W

Re: [PATCH weston 2/3] simple-touch: Handle multiple seats properly

2014-05-07 Thread Ander Conselvan de Oliveira
eport if you post a patch to reduce that chance that I'll waste time looking at the same bug. Sorry about that. It seems you wrote a better patch than mine anyway, so no harm. :) I'll add comments to the bugs from now on. Cheers, Ander Regards, - Neil Ander Conselvan de Oliveira

Re: [PATCH weston 1/3] shell: Fix artifacts caused by workspace change animation

2014-05-07 Thread Ander Conselvan de Oliveira
weston_layer_show() function, which would be a natural place to handle this, but it didn't get traction. http://lists.freedesktop.org/archives/wayland-devel/2014-January/012969.html Cheers, Ander On Wed, May 7, 2014 at 4:57 AM, Ander Conselvan de Oliveira mailto:conselv...@gmail.com>

[PATCH weston] shell: Don't allow maximized surfaces to be moved with touch

2014-05-07 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira Moving a maximized surface with the pointer is already not possible, so make the behavior with touch consistent. https://bugs.freedesktop.org/show_bug.cgi?id=78208 --- desktop-shell/shell.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH weston 2/3] simple-touch: Handle multiple seats properly

2014-05-07 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira If simple-touch ran on a compositor with multiple seats, and the first one happened to have the touch capability while the second one didn't, the handler for seat capabilities would destroy the wl_touch device it created on the first call for the first seat

[PATCH weston 3/3] shell: Fix crash when restoring focus state during workspace change

2014-05-07 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira The check to avoid calling weston_keyboard_set_focus() for a seat that didn't have a keyboard in restore_focus_state() was cheking the wrong seat (the one from the previous loop). That caused a crash when switching workspaces if there was an extra seat

[PATCH weston 1/3] shell: Fix artifacts caused by workspace change animation

2014-05-07 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira Views that extend past the bottom of the output are still visible after the workspace animation ends but before its layer is hidden. When the layer was hidden, nothing would cause those regions to be repainted, leading to artifacts. https://bugs.freedesktop.org

[PATCH weston] compositor-drm: Don't use vaapi recorder with unsupported formats

2014-05-06 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira We only support recording with GBM_FORMAT_XRGB888 format, so don't try to record if the output has a differnt format. https://bugs.freedesktop.org/show_bug.cgi?id=78199 --- src/compositor-drm.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

Re: [PATCH] doc: Added API documentation for wl_display_create function.

2014-05-06 Thread Ander Conselvan de Oliveira
On 05/06/2014 04:17 PM, Ander Conselvan de Oliveira wrote: On 05/06/2014 01:22 PM, Srivardhan Hebbar wrote: Signed-off-by: Srivardhan Hebbar --- src/wayland-server.c |9 + 1 file changed, 9 insertions(+) diff --git a/src/wayland-server.c b/src/wayland-server.c index f2b1b42

Re: [PATCH] doc: Added API documentation for wl_display_create function.

2014-05-06 Thread Ander Conselvan de Oliveira
On 05/06/2014 01:22 PM, Srivardhan Hebbar wrote: Signed-off-by: Srivardhan Hebbar --- src/wayland-server.c |9 + 1 file changed, 9 insertions(+) diff --git a/src/wayland-server.c b/src/wayland-server.c index f2b1b42..7b32848 100644 --- a/src/wayland-server.c +++ b/src/wayland-ser

Re: [PATCH weston] window: Ignore input events from subsurfaces

2014-05-06 Thread Ander Conselvan de Oliveira
On 05/06/2014 03:40 PM, Pekka Paalanen wrote: On Tue, 6 May 2014 15:25:40 +0300 Ander Conselvan de Oliveira wrote: From: Ander Conselvan de Oliveira Toytoolkit was not designed to handle input from subsurfaces and instead it expects subsurfaces to have an empty input region. That way input

[PATCH weston] window: Ignore input events from subsurfaces

2014-05-06 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira Toytoolkit was not designed to handle input from subsurfaces and instead it expects subsurfaces to have an empty input region. That way input events for subsurfaces are generated on the main surface and there is no need to convert coordinates before reporting

[PATCH weston] window.c: Set the input region of the tooltip to empty

2014-05-05 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira Otherwise it might receive touch events. https://bugs.freedesktop.org/show_bug.cgi?id=78207 --- clients/window.c | 1 + 1 file changed, 1 insertion(+) diff --git a/clients/window.c b/clients/window.c index b7febed..f667cdf 100644 --- a/clients/window.c +++ b

[PATCH weston] shell: Don't map surfaces of type SHELL_SURFACE_NONE

2014-04-30 Thread Ander Conselvan de Oliveira
When commit 07926d90 factored out the code that chooses in which layer a surface is added to, it changed the behavior for surfaces with no type. Instead of not adding it to any layer, the surface is added to the current workspace. This patch restores the old behavior. https://bugs.freedesktop.org

[PATCH weston 2/2] shell: Fix crash when a client is destroyed during the resize grab

2014-04-29 Thread Ander Conselvan de Oliveira
If a client exists during a resize grab, the resource for the shell surface being resized is destroyed. The shell surface is not destroyed immediately, however, because of the window close animation. In that case, the compositor would crash trying to send configure events to the surface being resiz

[PATCH weston 1/2] shell: Fix memory leaks caused by the window close animation

2014-04-29 Thread Ander Conselvan de Oliveira
In order to do the window close animation, a reference for a destroyed surface is kept. However, the reference count was also increased for unmapped surfaces, in which case the animation wouldn't run. Since the reference count was decremented in the animation done function, it would never be decrea

[PATCH weston 3/4] evdev: Fix assertion error for unplugged output with paired touchscreen

2014-04-24 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira If the output a touchscreen is paired to is unplugged, events coming from it should be ignored. Commit 17bccaed introduced logic for that in evdev_flush_pending_damage(). However, the break statements it introduced would cause the assertion after the switch

[PATCH weston 4/4] input: Fix errors due to initializing input before creating outputs

2014-04-24 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira Make sure that we don't map a device to an invalid output pointer and intead remap devices when an output is created. v2: fix the error with libinput too. --- src/evdev.c | 2 +- src/libinput-device.c | 2 +- src/libinput-seat.c | 8 ++--

[PATCH weston 2/4] evdev: Discard events from a touchscreen paired with an unplugged output

2014-04-24 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira Commit 17bccaed intended to make the events coming from a touchscreen paired with an unplugged output to be discarded, while an unpaired one would just choose a different output. However, the logic was inverted causing the opposite to happen. Later in commit

[PATCH weston 1/4] libinput: Don't process touch events for devices without a valid output

2014-04-24 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira That would be the case of a touch screen mapped to an output that was unplugged. --- src/libinput-device.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/libinput-device.c b/src/libinput-device.c index 0ca6c4b..a67c119 100644 --- a/src/libinput

Re: [PATCH weston 4/4] input: Fix errors due to initializing input before creating outputs

2014-04-24 Thread Ander Conselvan de Oliveira
the libinput-seat.c version of device_added so that will still maintain the behaviour of resorting to a default output from this commit: Shoot, I forgot libinput-seat again. /o\ I'm sending fixed patches now. Thanks, Ander http://cgit.freedesktop.org/wayland/weston/commit/?id=161c6c56944cdfbda

[PATCH weston v3 0/4] Input fixes

2014-04-24 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira Resend of the fixes update to cover libinput usage too. Ander Conselvan de Oliveira (4): libinput: Don't process touch events for devices without a valid output evdev: Discard events from a touchscreen paired with an unplugged output evdev

[PATCH weston 4/4] input: Fix errors due to initializing input before creating outputs

2014-04-23 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira Make sure that we don't map a device to an invalid output pointer and intead remap devices when an output is created. --- src/evdev.c | 2 +- src/libinput-device.c | 2 +- src/libinput-seat.c | 6 +- src/udev-seat.c | 8 ++-- 4

[PATCH weston 3/4] evdev: Fix assertion error for unplugged output with paired touchscreen

2014-04-23 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira If the output a touchscreen is paired to is unplugged, events coming from it should be ignored. Commit 17bccaed introduced logic for that in evdev_flush_pending_damage(). However, the break statements it introduced would cause the assertion after the switch

[PATCH weston v2 2/4] evdev: Discard events from a touchscreen paired with an unplugged output

2014-04-23 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira Commit 17bccaed intended to make the events coming from a touchscreen paired with an unplugged output to be discarded, while an unpaired one would just choose a different output. However, the logic was inverted causing the opposite to happen. Later in commit

[PATCH weston 1/4] libinput: Don't process touch events for devices without a valid output

2014-04-23 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira That would be the case of a touch screen mapped to an output that was unplugged. --- src/libinput-device.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/libinput-device.c b/src/libinput-device.c index 0ca6c4b..a67c119 100644 --- a/src/libinput

[PATCH weston 0/4] Input fixes

2014-04-23 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira Here's a second version of the input fixes I sent before, which new patches and some changes. The first patch makes libinput able to handle touch events on a device without a paired output. The second one inverts the logic for pairing a device on o

Re: [PATCH weston] compositor-drm: Fix crash when setting up seat constrained by an output

2014-04-23 Thread Ander Conselvan de Oliveira
ed. I'll send a patch to do this. Thanks, Ander I haven't looked any further to decide what's the best thing to do. - Neil Ander Conselvan de Oliveira writes: From: Ander Conselvan de Oliveira Commit 58e15865 changed the parameters for udev_get_seat_by_name() to rece

Re: [PATCH weston 1/2] evdev: Discard events from a touchscreen paired with an unplugged output

2014-04-23 Thread Ander Conselvan de Oliveira
gged the paired device's output needs to be reconciled (which is currently the case). U. Artie -Original Message- From: wayland-devel [mailto:wayland-devel-boun...@lists.freedesktop.org] On Behalf Of Ander Conselvan de Oliveira Sent: Tuesday, April 22, 2014 8:02 AM To: wayland-d

[PATCH weston 1/2] evdev: Discard events from a touchscreen paired with an unplugged output

2014-04-22 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira Commit 17bccaed intended to make the events coming from a touchscreen paired with an unplugged output to be discarded, while an unpaired one would just choose a different output. However, the logic was inverted causing the opposite to happen. --- src/evdev.c

[PATCH weston 2/2] evdev: Fix assertion error for unplugged output with paired touchscreen

2014-04-22 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira If the output a touchscreen is paired to is unplugged, events coming from it should be ignored. Commit 17bccaed introduced logic for that in evdev_flush_pending_damage(). However, the break statements it introduced would cause the assertion after the switch

[PATCH wayland] connection: Don't write past the end of the connection buffer

2014-04-17 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira If a message was too big to fit in the connection buffer, the code in wl_buffer_put would just write past the end of it. I haven't seen any real world use case that would trigger this bug, but it was possible to trigger it by sending a long enough string t

[PATCH weston] compositor-drm: Fix crash when setting up seat constrained by an output

2014-04-17 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira Commit 58e15865 changed the parameters for udev_get_seat_by_name() to receive a struct udev_input. However, when this gets called from create_output_from_connector() during initialization, the input struct is not yet initialized, leading to a crash. Previously

[PATCH weston] compositor-drm: Pass the right stride to the vaapi recorder

2014-04-16 Thread Ander Conselvan de Oliveira
It takes the stride in bytes, not pixels. The bug was hidden when using va intel-driver 1.2.1 because it would ignore the stride from user and set the surface state in a wrong way. https://bugs.freedesktop.org/show_bug.cgi?id=77495 --- src/compositor-drm.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH weston 1/3] animation: Split spring setup out of weston_view_animation_run()

2014-04-14 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira All the animations override at least one parameter of the spring that is set during the creation of the animation. Some need to do the whole setup again. This patch changes the initialization of a view animation to a three step process. First, the animation is

[PATCH weston 2/3] animation: Fix input panel slide animation

2014-04-14 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira The position for the slide animation was calculated assuming the value of the spring was always between 0.0 and 1.0. Commit 3a869019 broke that assumption, and the result was that the panel would be positioned at an invisible part of screen. Since there would be

[PATCH weston 3/3] shell: Destroy a previous input panel animation when showing it again

2014-04-14 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira It is possible that an input panel will be shown quickly, hidden and shown again, before the animation for the first appeareance finished. In that case, another animation would be created and the effect of the two combined could cause the panel to not appear in

[PATCH weston] shell: Fix view repositioning logic for output move and destroy

2014-04-11 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira Previously, the repositioning logic would iterate the compositor's list of layers and move the views on those layers. However, that failed in two different ways: it didn't cover hidden workspaces and crashed when the display was locked. This patch c

[PATCH weston] shell: Keep shsurf->fullscreen_output set after unset_fullscreen()

2014-04-10 Thread Ander Conselvan de Oliveira
When a fullscreen surface gets the maximized state, the function reset_surface_type() is called and that causes unset_fullscreen() to be called. That function would set the value of shsurf->fullscreen_output to NULL. However, since the surface still has the fullscreen state, it will be configured a

[PATCH] shell: Damage below child surfaces on move to different workspace

2014-04-10 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira When moving from a surface from visible workspace to an invisible one via a popup menu, the area below the menu wouldn't be repainted. https://bugs.freedesktop.org/show_bug.cgi?id=76973 --- desktop-shell/shell.c | 1 + 1 file changed, 1 insertion(+)

[PATCH weston] shell: Disarm the screensaver timeout timer on terminate_screensaver()

2014-04-10 Thread Ander Conselvan de Oliveira
The timer was left running after the screensaver was terminated. When it triggered, a fade out that would in turn cause the screen to be locked was started. Since that could happen without the compositor emitting the idle signal, there would be no wake signal to make the shell show the lock screen,

[PATCH] shell: Allow unresponsive surfaces to be moved again

2014-04-09 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira Commit c85f1d45 caused the move of an unresponsive surface to be no longer possible, since the grabbed flag would prevent the move grab to start while the busy grab was still active. --- desktop-shell/shell.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [PATCH 02/12] shell.c: Restore maximized and fullscreen window on destroyed output

2014-03-18 Thread Ander Conselvan de Oliveira
On 03/18/2014 07:39 AM, Zhang, Xiong Y wrote: On Mon, 2014-03-17 at 19:17 +0200, Ander Conselvan de Oliveira wrote: On 03/07/2014 10:27 AM, Xiong Zhang wrote: > When maximized or fullscreen window is on destroyed output, compositor > can't change these windows to normal window wit

Re: [PATCH 06/12] compositor-drm: Abstract drm_output_set_mode()

2014-03-17 Thread Ander Conselvan de Oliveira
That's a good clean up. Cheers, Ander On 03/07/2014 10:27 AM, Xiong Zhang wrote: Signed-off-by: Xiong Zhang --- src/compositor-drm.c | 45 +++-- 1 file changed, 23 insertions(+), 22 deletions(-) diff --git a/src/compositor-drm.c b/src/compositor-drm.

Re: [PATCH 02/12] shell.c: Restore maximized and fullscreen window on destroyed output

2014-03-17 Thread Ander Conselvan de Oliveira
On 03/07/2014 10:27 AM, Xiong Zhang wrote: When maximized or fullscreen window is on destroyed output, compositor can't change these windows to normal window without notify client, otherwise maximize icon or F11 buttion lose its effect after output unplug. Instead we keep these window as maximiz

Re: [PATCH 01/12] shell.c: Set dirty for visible views on destroyed output

2014-03-17 Thread Ander Conselvan de Oliveira
On 03/07/2014 10:27 AM, Xiong Zhang wrote: The geometry for visible views will keep unchanged, weston_view_set_position() doesn't mark these views as dirty. So there is no chance for them to reassign output, then these views will disappear. Signed-off-by: Xiong Zhang --- desktop-shell/shell.c

Re: [PATCH weston] input: Empty the current input region when configuring pointer surfaces

2014-02-03 Thread Ander Conselvan de Oliveira
On 02/01/2014 10:00 AM, Pekka Paalanen wrote: On Fri, 31 Jan 2014 16:07:51 +0200 Ander Conselvan de Oliveira wrote: The input region of the cursor surface is set to empty in pointer_cursor_surface_configure(). Since during the commit process this function is called before the pending input

[PATCH weston] build: Fix build when Wayland headers are not in standard prefix

2014-02-03 Thread Ander Conselvan de Oliveira
The move to a single Makefile.am missed to set a few _CFLAGS variables, causing the build to fail if the Wayland headers are not installed in the standard prefix. --- Makefile.am | 8 1 file changed, 8 insertions(+) diff --git a/Makefile.am b/Makefile.am index 753ff83..06d2434 100644 ---

[PATCH weston] input: Fix weston_seat_init_keyboard() error path

2014-01-31 Thread Ander Conselvan de Oliveira
The pointer seat->keyboard was set before some possible error returns. That pointer was left unchanged in case of failure, pointing to an uninitialized keyboard struct (that was also leaked). If a client sent a wl_seat::get_keyboard request, that would cause Weston to crash. Fix this by setting th

[PATCH weston] input: Empty the current input region when configuring pointer surfaces

2014-01-31 Thread Ander Conselvan de Oliveira
The input region of the cursor surface is set to empty in pointer_cursor_surface_configure(). Since during the commit process this function is called before the pending input region is made current, it empties surface->pending.input instead of surface->input. But pointer_cursor_surface_configure()

[PATCH weston 3/4] compositor: Add a visibility switch to weston_layers

2014-01-29 Thread Ander Conselvan de Oliveira
Different parts of the shell, such as the workspace implementation, rely on making layers invisible to hide surfaces without discarding the order in which they appear. However, the layers are made invisible by removing them from the compositor's layers list. Instead, add the function weston_layer_

[PATCH weston 2/4] compositor: Remove weston_output::move_signal

2014-01-29 Thread Ander Conselvan de Oliveira
Since that signal is per output, it is necessary to track in which output a view is in so that the signal is handled properly. Instead, add a compositor wide output moved signal, that is handled by the shell. The shell iterates over the layers it owns to move views appropriately. --- desktop-shel

[PATCH weston 4/4] compositor: Move view repositioning logic into shell

2014-01-29 Thread Ander Conselvan de Oliveira
Remove the listener for output destroy from weston_view and instead iterate views owned by the shell in its own output destroy listener. This simplifies the code a bit since keeping the view listening for the destroy on the right output was a bit complicated. This also removes the function pointer

[PATCH weston 1/4] input: Remove exported function weston_pointer_verify()

2014-01-29 Thread Ander Conselvan de Oliveira
Instead, add a compositor signal that an output has been destroyed and handle that case locally in input.c. --- src/compositor.c | 17 ++--- src/compositor.h | 5 +++-- src/input.c | 20 +--- 3 files changed, 22 insertions(+), 20 deletions(-) diff --git a/src/com

Re: [PATCH] dim-layer: fix dimming for unfocused surfaces

2014-01-29 Thread Ander Conselvan de Oliveira
On 01/15/2014 10:30 AM, Emilio Pozuelo Monfort wrote: bump On 07/01/14 17:23, poch...@gmail.com wrote: From: Emilio Pozuelo Monfort Unfocusing a surface should dim it when dim-layer is enabled, but this got broken in commit 83ffd9. --- desktop-shell/shell.c | 13 - 1 file chang

Re: [PATCH 2/2] compositor: add a masking mechanism to weston_layer

2014-01-29 Thread Ander Conselvan de Oliveira
On 01/28/2014 06:36 PM, Giulio Camuffo wrote: 2014-01-28 Ander Conselvan de Oliveira : On 01/27/2014 09:46 PM, Giulio Camuffo wrote: this adds a mechanism to mask the views belonging to a layer to an arbitrary rect, in the global space. The parts that don't fit in that rect will be cl

Re: [PATCH 2/2] compositor: add a masking mechanism to weston_layer

2014-01-28 Thread Ander Conselvan de Oliveira
On 01/27/2014 09:46 PM, Giulio Camuffo wrote: this adds a mechanism to mask the views belonging to a layer to an arbitrary rect, in the global space. The parts that don't fit in that rect will be clipped away. Implemented in the gl and pixman renderers only for now. --- src/compositor.c |

Re: [PATCH] compositor: Ensure views on hiden workspace are listening correct output

2013-12-20 Thread Ander Conselvan de Oliveira
On 12/19/2013 11:26 AM, Xiong Zhang wrote: The views on hiden workspace can't restored correctly when their output was unplugged. There are two reasons: First: the views on hiden workspace is restored through animation which will change y coordinate continually, if the y coordinate of invisible

[PATCH 1/2] compositor: Destroy renderer in weston_compositor_shutdown()

2013-12-20 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira Currently we destroy the renderer before the outputs are destroyed, but that sometimes leads to an error since a reference to the renderer is necessary in order to destroy a gl_renderer_output. Since destroying the renderer is common among all backends, just

[PATCH 2/2] shell: Handle the desktop shell client destroy signal

2013-12-20 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira Set the internal pointer for the client to NULL. This fixes a segmentation fault at shutdown, where the shell would hang up before and cause libwayland to call wl_client_destroy(). When the shell was destroyed later, another call to wl_client_destroy() would

[PATCH] compositor: Clean up view output move and destroy listeners

2013-12-19 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira Remove those listeners when the output is destroyed, otherwise they'll point to invalid data that may lead to corruption when assigning a new output for the view. -- This is possibly related to bug 72845. I didn't have enough equipment to try and re

[PATCH 1/2] screenshooter: Choose output to record from based on keyboard focus

2013-12-18 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira Record from the output of the surface that has keyboard focus for the seat used to activate the recorder key binding. If there is no focused surface, record from the first one. Also, use the weston_transformed_region() to transform the damage region of the

[PATCH 2/2] compositor-x11: Set the name field on weston_outputs

2013-12-18 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira That way log messages referencing the output are more informative. --- src/compositor-x11.c |4 1 file changed, 4 insertions(+) diff --git a/src/compositor-x11.c b/src/compositor-x11.c index 2ef1b5d..1b178b8 100644 --- a/src/compositor-x11.c +++ b/src

[PATCH] screenshooter: Record one extra frame when recording stops

2013-12-17 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira If the compositor hasn't been rendering for a while when the recording stops, the time difference between the last rendered frame and that moment won't be in the encoded video. Fix that by forcing one extra frame to be recorded when the user presses th

[PATCH 04/10] compositor-headless, compositor-rdp: Don't call weston_output_move()

2013-12-13 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira The call to weston_output_move() when creating the output is unnecessary. That is already called by wesotn_output_init(). --- src/compositor-headless.c |2 -- src/compositor-rdp.c |2 -- 2 files changed, 4 deletions(-) diff --git a/src/compositor

[PATCH 07/10] compositor; Don't repaint outputs being destroyed

2013-12-13 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira Set a flag when an output is being destroyed and use that to avoid repainting. This allows functions that schedule an output repaint to be called when the output is being destroyed without causing the compositor to crash. --- src/compositor.c |5 + src

[PATCH 05/10] compositor: Move views when outputs are moved

2013-12-13 Thread Ander Conselvan de Oliveira
g. Signed-off-by: Zhang, Xiong Y Signed-off-by: Ander Conselvan de Oliveira --- src/compositor.c | 74 +++--- src/compositor.h |4 +++ 2 files changed, 75 insertions(+), 3 deletions(-) diff --git a/src/compositor.c b/src/compositor.c ind

[PATCH 09/10] desktop-shell: Invalidate saved position when output is destroyed

2013-12-13 Thread Ander Conselvan de Oliveira
te. Signed-off-by: Zhang, Xiong Y Signed-off-by: Ander Conselvan de Oliveira --- desktop-shell/shell.c | 32 +++- src/compositor.c |3 +++ src/compositor.h |6 ++ 3 files changed, 36 insertions(+), 5 deletions(-) diff --git a/desktop-shell/sh

[PATCH 06/10] compositor: Ensure views are visible if their output was unplugged

2013-12-13 Thread Ander Conselvan de Oliveira
From: "Zhang, Xiong Y" Use the output destroy signal to move the views in the event the output was unplugged. Signed-off-by: Zhang, Xiong Y Signed-off-by: Ander Conselvan de Oliveira --- src/compositor.c | 59 -- src/composito

[PATCH 10/10] shell: Reset fullscreen and maximized state on output unplug

2013-12-13 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira When a view is moved to another output because its current output was unplugged, remove the fullscreen and maximized state. --- desktop-shell/shell.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index

[PATCH 03/10] compositor: Move the logic of moving outputs into the core

2013-12-13 Thread Ander Conselvan de Oliveira
From: "Zhang, Xiong Y" Instead of having the backends move the remaining outputs when one is destroyed, let the core compositor deal with that. Signed-off-by: Zhang, Xiong Y Signed-off-by: Ander Conselvan de Oliveira --- src/compositor-drm.c |8 src/compositor-x1

[PATCH 08/10] compositor: Make pointers visible when an output is unplugged

2013-12-13 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira Previously, if a pointer was inside an output that was unplugged, it could potentialy end up outside any valid output forever. With this patch, the pointer is moved to the "closest" output to the pointer. --- src/compositor.c | 15 ++

[PATCH 01/10] compositor-x11: Only destroy one output when the close button is pressed

2013-12-13 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira Instead of terminating the compositor, destroy the output whose close button was clicked and move the other outputs, as is done in the drm backend. --- src/compositor-x11.c | 32 +++- 1 file changed, 31 insertions(+), 1 deletion

[PATCH 02/10] compositor: Remove output from list in weston_output_destroy()

2013-12-13 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira When destroying ouputs, they would sometimes be removed before the call to weston_output_destory() and sometimes after, depending on the backend. Now the output is remove withing that function so the behavior is standard across all backends. --- src/compositor

Re: [PATCH weston 03/11] configure.ac: Correctly check for functions and libraries

2013-12-10 Thread Ander Conselvan de Oliveira
On 12/09/2013 12:44 PM, Quentin Glidic wrote: On 09/12/2013 11:28, Ander Conselvan de Oliveira wrote: On 12/08/2013 08:45 PM, Quentin Glidic wrote: From: Quentin Glidic AC_SEARCH_LIBS is preferred over AC_CHECK_FUNC and AC_CHECK_LIB Why is it preferred? I am trusting the Autoconf manual

Re: [PATCH weston 03/11] configure.ac: Correctly check for functions and libraries

2013-12-09 Thread Ander Conselvan de Oliveira
On 12/08/2013 08:45 PM, Quentin Glidic wrote: From: Quentin Glidic AC_SEARCH_LIBS is preferred over AC_CHECK_FUNC and AC_CHECK_LIB Why is it preferred? Signed-off-by: Quentin Glidic --- configure.ac | 37 + 1 file changed, 21 insertions(+), 16 delet

Re: RFC: surface crop and scale protocol extension

2013-12-04 Thread Ander Conselvan de Oliveira
On 12/04/2013 09:20 AM, Pekka Paalanen wrote: On Thu, 28 Nov 2013 12:52:15 +0100 Jonny Lamb wrote: Il giorno mar, 26/11/2013 alle 18.19 +0100, Jonny Lamb ha scritto: This is the initial version of the weston implementation of the wl_scaler protocol extension for surface cropping and scaling.

Re: [PATCH 1/3] shell: restore app on non default and unplugged output

2013-12-03 Thread Ander Conselvan de Oliveira
Ander Thanks. -Original Message----- From: Ander Conselvan de Oliveira [mailto:conselv...@gmail.com] Sent: Tuesday, December 03, 2013 11:06 PM To: Zhang, Xiong Y Cc: wayland-devel@lists.freedesktop.org Subject: Re: [PATCH 1/3] shell: restore app on non default and unplugged output Hi Xiong, I

Re: [PATCH 2/3] shell: restore app on default and unplugged output

2013-12-03 Thread Ander Conselvan de Oliveira
On 12/03/2013 05:25 AM, Xiong Zhang wrote: if the unplugged output is the first default output, the second output will move to the first working as default output. Mark the surface on unplaugged output as dirty, so on the next output repaint, these views will reassign output and get the right out

Re: [PATCH 1/3] shell: restore app on non default and unplugged output

2013-12-03 Thread Ander Conselvan de Oliveira
Hi Xiong, It seems that we need different logic for moving the views depending on the surface role, so I'm thinking this code should actually be part of a surface role implementation. For instance, instead of implementing the logic of moving the pointer surface in the shell, that would go in

[PATCH] gl-renderer: Fix support for Y_XUXV buffers

2013-11-27 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira Due to a copy and paste error, the pointer to the vertex shader source was NULL and the program failed to link. --- src/gl-renderer.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gl-renderer.c b/src/gl-renderer.c index 7a535c7

[PATCH 1/2] compositor-drm: Add key binding to switch from pixman to GL renderer

2013-11-19 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira When running with the pixman renderer, the debug binding 'W' (mod-shift-space W) will cause the compositor to load gl-renderer.so and start using it instead of the pixman renderer. --- src/compositor-dr

[PATCH 2/2] gl-renderer: Attach buffer during surface state creation if possible

2013-11-19 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira When a renderer switch happens, it is possible that when the surface state is created, a buffer for the given surface is already available. In that case, run the attach routine so that the pixel contents are properly set. Otherwise, it would only be set when a

[PATCH 0/2 v2] Renderer switch

2013-11-19 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira V2 of the series I sent earlier today, changed to not require an extra option to allow for seamless switch. Thanks, Ander Ander Conselvan de Oliveira (2): compositor-drm: Add key binding to switch from pixman to GL renderer gl-renderer: Attach buffer

Re: [PATCH 2/3] compositor-drm: Add option to disable early buffer release

2013-11-19 Thread Ander Conselvan de Oliveira
On 11/19/2013 01:05 PM, Pekka Paalanen wrote: On Tue, 19 Nov 2013 11:30:11 +0200 Ander Conselvan de Oliveira wrote: From: Ander Conselvan de Oliveira This together with a follow up patch should make it possible to do a runtime renderer switch without causing artifact on the screen

[PATCH 3/3] gl-renderer: Attach buffer during surface state creation if possible

2013-11-19 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira When a renderer switch happens, it is possible that when the surface state is created, a buffer for the given surface is already available. In that case, run the attach routine so that the pixel contents are properly set. Otherwise, it would only be set when a

[PATCH 2/3] compositor-drm: Add option to disable early buffer release

2013-11-19 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira This together with a follow up patch should make it possible to do a runtime renderer switch without causing artifact on the screen. --- man/weston-drm.man |6 ++ src/compositor-drm.c | 27 +-- src/compositor.c |1

[PATCH 1/3] compositor-drm: Add key binding to switch from pixman to GL renderer

2013-11-19 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira When running with the pixman renderer, the debug binding 'W' (mod-shift-space W) will cause the compositor to load gl-renderer.so and start using it instead of the pixman renderer. --- src/compositor-dr

Re: [PATCH] Do not release buffer when it is going to be used again.

2013-11-07 Thread Ander Conselvan de Oliveira
Em 06-11-2013 21:47, Axel Davy escreveu: Solve a bug for some fullscreen clients which wouldn't show up. Signed-off-by: Axel Davy --- src/compositor-drm.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/compositor-drm.c b/src/compositor-drm.c index 4f015d1..6a25

[PATCH 3/3] gbm: Add entry points for mapping and unmapping bos

2013-11-05 Thread Ander Conselvan de Oliveira
Add gbm_bo_map() and gbm_bo_unmap(). This lets a user access the contents of a bo using the CPU. --- I'm not sure about the extra flags. We do have GBM_BO_USE_WRITE but that is defined to always work with GBM_BO_USE_CURSOR_64X64. Reusing that would imply that these buffers are always mappable or

[PATCH 1/3] gbm: Add intel backend

2013-11-05 Thread Ander Conselvan de Oliveira
SHALL THE AUTHORS OR COPYRIGHT + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER + * DEALINGS IN THE SOFTWARE. + * + * Authors: + * Ander Conselvan

[PATCH 2/3] egl/dri: Add gbm platform

2013-11-05 Thread Ander Conselvan de Oliveira
LUDING BUT NOT LIMITED TO THE WARRANTIES OF + * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, A

[RFC] [PATCH 0/3] gbm: Add support for mapping bos

2013-11-05 Thread Ander Conselvan de Oliveira
hat it would be able to do the converse. That ability together with an entry point for creating a gbm_device for a given wl_display would be enough for making this available for any wayland client. Any comments on this will be highly appreciated. Thanks, Ander Ander Conselvan de Oliveira (3):

Re: [PATCH] Shutdown the compositor before removing graphics

2013-11-05 Thread Ander Conselvan de Oliveira
On 11/04/2013 10:39 AM, Cameron Stewart wrote: Otherwise the outputs are removed when they have already been freed. However don't clean up the debug listeners in gl_renderer as these would be cleaned up by the compositor previously. I'm not sure why I didn't notice the error when I wrote the pa

  1   2   3   4   5   6   >