Re: [PATCH V8 06/43] drm/colorop: Add 1D Curve subtype

2025-04-01 Thread Harry Wentland
On 2025-04-01 15:53, Simon Ser wrote: > > > > > > On Tuesday, April 1st, 2025 at 17:14, Daniel Stone > wrote: > >> >> >> Hi Alex, >> >> On Wed, 26 Mar 2025 at 23:50, Alex Hung alex.h...@amd.com wrote: >> >>> +static int drm_colorop_init(struct drm_device *dev, struct drm_colorop >>> *co

Re: [PATCH V8 06/43] drm/colorop: Add 1D Curve subtype

2025-04-01 Thread Simon Ser
On Tuesday, April 1st, 2025 at 17:14, Daniel Stone wrote: > > > Hi Alex, > > On Wed, 26 Mar 2025 at 23:50, Alex Hung alex.h...@amd.com wrote: > > > +static int drm_colorop_init(struct drm_device *dev, struct drm_colorop > > *colorop, > > + struct drm_plane *plane, enum drm_colorop_type

Re: [PATCH V8 03/43] drm/doc/rfc: Describe why prescriptive color pipeline is needed

2025-04-01 Thread Shengyu Qu
You are right. Sorry for the noise. 在 2025/4/1 0:41, Alex Hung 写道: On 3/31/25 10:24, Shengyu Qu wrote: 在 2025/3/27 7:46, Alex Hung 写道: From: Harry Wentland Add documentation for color pipeline API. Signed-off-by: Alex Hung Signed-off-by: Harry Wentland --- v8:   - Fix typo "definint"

Re: [PATCH V8 24/43] drm/amd/display: Skip color pipeline initialization for cursor plane

2025-04-01 Thread Harry Wentland
On 2025-04-01 11:45, Melissa Wen wrote: > On 03/31, Xaver Hugl wrote: >>> Cursor plane has no color pipeline and thus it has no colorop either. It >>> inherits color processing from its parent plane. >> >> Just to be sure: That means amdgpu will reject atomic commits that try >> to set a color p

Re: [PATCH V8 24/43] drm/amd/display: Skip color pipeline initialization for cursor plane

2025-04-01 Thread Harry Wentland
On 2025-04-01 11:45, Shengyu Qu wrote: > > > 在 2025/4/1 22:11, Michel Dänzer 写道: >> On 2025-04-01 14:32, Shengyu Qu wrote: >>> 在 2025/4/1 17:56, Michel Dänzer 写道: On 2025-03-31 19:42, Alex Hung wrote: > On 3/31/25 11:04, Shengyu Qu wrote: >> Or we can add some kind of "linked with

Re: [PATCH V8 24/43] drm/amd/display: Skip color pipeline initialization for cursor plane

2025-04-01 Thread Shengyu Qu
在 2025/4/1 1:42, Alex Hung 写道: On 3/31/25 11:04, Shengyu Qu wrote: Or we can add some kind of "linked with" info to plane's COLOR_PIPELINE property, to let userspace know that cursor plane and background plane share the same colorop config. So that userspace could do extra conversion on cu

Re: [PATCH V8 24/43] drm/amd/display: Skip color pipeline initialization for cursor plane

2025-04-01 Thread Shengyu Qu
在 2025/4/1 22:11, Michel Dänzer 写道: On 2025-04-01 14:32, Shengyu Qu wrote: 在 2025/4/1 17:56, Michel Dänzer 写道: On 2025-03-31 19:42, Alex Hung wrote: On 3/31/25 11:04, Shengyu Qu wrote: Or we can add some kind of "linked with" info to plane's COLOR_PIPELINE property, to let userspace know t

Re: [PATCH V8 24/43] drm/amd/display: Skip color pipeline initialization for cursor plane

2025-04-01 Thread Melissa Wen
On 03/31, Xaver Hugl wrote: > > Cursor plane has no color pipeline and thus it has no colorop either. It > > inherits color processing from its parent plane. > > Just to be sure: That means amdgpu will reject atomic commits that try > to set a color pipeline on the primary plane while showing the

Re: [PATCH V8 24/43] drm/amd/display: Skip color pipeline initialization for cursor plane

2025-04-01 Thread Shengyu Qu
在 2025/4/1 22:11, Michel Dänzer 写道: On 2025-04-01 14:32, Shengyu Qu wrote: 在 2025/4/1 17:56, Michel Dänzer 写道: On 2025-03-31 19:42, Alex Hung wrote: On 3/31/25 11:04, Shengyu Qu wrote: Or we can add some kind of "linked with" info to plane's COLOR_PIPELINE property, to let userspace know t

Re: [PATCH V8 06/43] drm/colorop: Add 1D Curve subtype

2025-04-01 Thread Daniel Stone
Hi Alex, On Wed, 26 Mar 2025 at 23:50, Alex Hung wrote: > +static int drm_colorop_init(struct drm_device *dev, struct drm_colorop > *colorop, > + struct drm_plane *plane, enum drm_colorop_type > type) > +{ > + struct drm_mode_config *config = &dev->mode_config; >

Re: [PATCH V8 24/43] drm/amd/display: Skip color pipeline initialization for cursor plane

2025-04-01 Thread Xaver Hugl
Am Di., 1. Apr. 2025 um 02:29 Uhr schrieb Alex Hung : > > > > On 3/31/25 12:53, Xaver Hugl wrote: > >> Cursor plane has no color pipeline and thus it has no colorop either. It > >> inherits color processing from its parent plane. > > > > Just to be sure: That means amdgpu will reject atomic commits

Re: [PATCH V8 24/43] drm/amd/display: Skip color pipeline initialization for cursor plane

2025-04-01 Thread Michel Dänzer
On 2025-04-01 14:32, Shengyu Qu wrote: > 在 2025/4/1 17:56, Michel Dänzer 写道: >> On 2025-03-31 19:42, Alex Hung wrote: >>> On 3/31/25 11:04, Shengyu Qu wrote: Or we can add some kind of "linked with" info to plane's COLOR_PIPELINE property, to let userspace know that cursor plane and back

Re: [PATCH V8 24/43] drm/amd/display: Skip color pipeline initialization for cursor plane

2025-04-01 Thread Shengyu Qu
Btw what's your opinion about this, Xaver? 在 2025/4/1 17:56, Michel Dänzer 写道: On 2025-03-31 19:42, Alex Hung wrote: On 3/31/25 11:04, Shengyu Qu wrote: Or we can add some kind of "linked with" info to plane's COLOR_PIPELINE property, to let userspace know that cursor plane and background pla

Re: [PATCH V8 24/43] drm/amd/display: Skip color pipeline initialization for cursor plane

2025-04-01 Thread Shengyu Qu
So currently we have to hope the compositor won't use DRM_PLANE_TYPE_CURSOR planes at all Why do we still register DRM_PLANE_TYPE_CURSOR in the driver? 在 2025/4/1 0:06, Alex Hung 写道: On 3/31/25 09:43, Shengyu Qu wrote: Hi, Thanks for reply. So currently we have to apply color conversio

Re: [PATCH V8 11/43] drm/colorop: Introduce DRM_CLIENT_CAP_PLANE_COLOR_PIPELINE

2025-04-01 Thread Shengyu Qu
在 2025/3/27 7:46, Alex Hung 写道: From: Harry Wentland With the introduction of the pre-blending color pipeline we can no longer have color operations that don't have a clear position in the color pipeline. We deprecate all existing plane properties. For upstream drivers those are: - COLOR_EN

Re: [PATCH V8 24/43] drm/amd/display: Skip color pipeline initialization for cursor plane

2025-04-01 Thread Shengyu Qu
Sorry for vague expression. I mean that I think we shouldn't register DRM_PLANE_TYPE_CURSOR in the driver, as we don't have actual hardware support. 在 2025/4/1 0:26, Alex Hung 写道: On 3/31/25 10:12, Shengyu Qu wrote: So currently we have to hope the compositor won't use DRM_PLANE_TYPE_CURSOR

Re: [PATCH V8 24/43] drm/amd/display: Skip color pipeline initialization for cursor plane

2025-04-01 Thread Shengyu Qu
Hi, Thanks for reply. So currently we have to apply color conversion on the background plane of the cursor to do some color space conversion. What would happen if cursor and background plane needs different conversion config? Or we just give the cursor a dedicated plane? Best regards, Shengy

Re: [PATCH V8 24/43] drm/amd/display: Skip color pipeline initialization for cursor plane

2025-04-01 Thread Shengyu Qu
Thanks, I mistook about the MPO document. Maybe we should also disable colorop on the background plane of the cursor plane? So that compositors would do sw color convertion on both cursor plane and background plane, which should keep cursor display correctly. 在 2025/4/1 0:34, Alex Hung 写道:

Re: [PATCH V8 24/43] drm/amd/display: Skip color pipeline initialization for cursor plane

2025-04-01 Thread Michel Dänzer
On 2025-03-31 19:42, Alex Hung wrote: > On 3/31/25 11:04, Shengyu Qu wrote: >> Or we can add some kind of "linked with" info to plane's COLOR_PIPELINE >> property, to let userspace know that cursor plane and background plane share >> the same colorop config. So that userspace could do extra conve