Re: [PATCH v6 42/44] drm/colorop: Add 3D LUT supports to color pipeline

2024-10-13 Thread Simon Ser
On Thursday, October 3rd, 2024 at 22:01, Harry Wentland wrote: > From: Alex Hung > > It is to be used to enable HDR by allowing userpace to create and pass > 3D LUTs to kernel and hardware. > > 1. new drm_colorop_type: DRM_COLOROP_3D_LUT. > 2. 3D LUT modes define hardware capabilities to user

Re: [PATCH v6 05/44] drm/colorop: Introduce new drm_colorop mode object

2024-10-13 Thread Simon Ser
On Sunday, October 13th, 2024 at 17:19, Simon Ser wrote: > Would be nice to have user-space uAPI docs for the colorop properties. > Just like we have for other KMS object types: > https://dri.freedesktop.org/docs/drm/gpu/drm-kms.html#standard-connector-properties Ah, I suppose subsequent patches

Re: [PATCH v6 05/44] drm/colorop: Introduce new drm_colorop mode object

2024-10-13 Thread Simon Ser
Would be nice to have user-space uAPI docs for the colorop properties. Just like we have for other KMS object types: https://dri.freedesktop.org/docs/drm/gpu/drm-kms.html#standard-connector-properties Internal kernel docs aren't great for user-space developers, because user-space developers have n

Re: [PATCH v6 13/44] drm/colorop: Add NEXT to colorop state print

2024-10-13 Thread Simon Ser
I think this can be folded into "drm/colorop: Add atomic state print for drm_colorop".

Re: [PATCH v6 16/44] drm/colorop: Introduce DRM_CLIENT_CAP_PLANE_COLOR_PIPELINE

2024-10-13 Thread Simon Ser
Shouldn't this patch come before the others, otherwise we're exposing unconditionally color OP uAPI to user-space in-between the first patch and this one? Usually we try to not have a broken kernel in intermediate commits. It's important for bisecting.