Re: Issues with cursors (cursor-shape-v1)

2023-12-06 Thread Campbell Barton
On Wed, Dec 6, 2023 at 10:18 AM Simon Ser wrote: > > For wlroots-based compositors this is passed down via XCURSOR_THEME and > XCURSOR_SIZE just like on X11 although env vars aren't a good fit for > configuration. Yes, I'm using these already, in practice though - even with these variables set -

Re: [RFC PATCH v3 05/23] drm/vkms: Avoid reading beyond LUT array

2023-12-06 Thread Melissa Wen
On 12/06, Melissa Wen wrote: > On 11/10, Arthur Grillo wrote: > > > > > > On 08/11/23 13:36, Harry Wentland wrote: > > > When the floor LUT index (drm_fixp2int(lut_index) is the last > > > index of the array the ceil LUT index will point to an entry > > > beyond the array. Make sure we guard agai

Re: [RFC PATCH v3 05/23] drm/vkms: Avoid reading beyond LUT array

2023-12-06 Thread Melissa Wen
On 11/10, Arthur Grillo wrote: > > > On 08/11/23 13:36, Harry Wentland wrote: > > When the floor LUT index (drm_fixp2int(lut_index) is the last > > index of the array the ceil LUT index will point to an entry > > beyond the array. Make sure we guard against it and use the > > value of the floor L

Re: [RFC PATCH v3 03/23] drm/vkms: Create separate Kconfig file for VKMS

2023-12-06 Thread Melissa Wen
On 11/08, Harry Wentland wrote: > This aligns with most other DRM drivers and will allow > us to add new VKMS config options without polluting > the DRM Kconfig. > > v3: > - Change SPDX to GPL-2.0-only to match DRM KConfig >SPDX (Simon) LGTM. I plan to apply this one to drm-misc-next. Cc'in

Re: [RFC PATCH v3 01/23] drm: Don't treat 0 as -1 in drm_fixp2int_ceil

2023-12-06 Thread Melissa Wen
On 11/08, Harry Wentland wrote: > Unit testing this in VKMS shows that passing 0 into > this function returns -1, which is highly counter- > intuitive. Fix it by checking whether the input is > >= 0 instead of > 0. > Nice finding. Thanks! Could you add the fixes tag? AFAIU, this one: Fixes: 6456