Re: [PATCH RFC v6 08/10] drm/msm/dpu: Allow NULL FBs in atomic commit

2023-09-24 Thread Dmitry Baryshkov
On 29/08/2023 03:05, Jessica Zhang wrote: Since solid fill planes allow for a NULL framebuffer in a valid commit, add NULL framebuffer checks to atomic commit calls within DPU. Reviewed-by: Dmitry Baryshkov Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 9 +

Re: [Freedreno] [PATCH RFC v6 07/10] drm/atomic: Loosen FB atomic checks

2023-09-24 Thread Dmitry Baryshkov
On 22/09/2023 20:49, Jessica Zhang wrote: On 8/29/2023 1:22 AM, Pekka Paalanen wrote: On Mon, 28 Aug 2023 17:05:13 -0700 Jessica Zhang wrote: Loosen the requirements for atomic and legacy commit so that, in cases where pixel_source != FB, the commit can still go through. This includes addi

Re: [PATCH RFC v6 07/10] drm/atomic: Loosen FB atomic checks

2023-09-24 Thread Dmitry Baryshkov
On 29/08/2023 03:05, Jessica Zhang wrote: Loosen the requirements for atomic and legacy commit so that, in cases where pixel_source != FB, the commit can still go through. This includes adding framebuffer NULL checks in other areas to account for FB being NULL when non-FB pixel sources are enabl

Re: [PATCH RFC v6 05/10] drm/atomic: Add solid fill data to plane state dump

2023-09-24 Thread Dmitry Baryshkov
On 29/08/2023 03:05, Jessica Zhang wrote: Add solid_fill property data to the atomic plane state dump. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/drm_atomic.c | 4 drivers/gpu/drm/drm_plane.c | 8 include/drm/drm_plane.h | 3 +++ 3 files changed, 15 insertions(+)

Re: [PATCH RFC v6 04/10] drm/atomic: Add pixel source to plane state dump

2023-09-24 Thread Dmitry Baryshkov
On 29/08/2023 03:05, Jessica Zhang wrote: Add pixel source to the atomic plane state dump Signed-off-by: Jessica Zhang --- drivers/gpu/drm/drm_atomic.c| 1 + drivers/gpu/drm/drm_blend.c | 1 + drivers/gpu/drm/drm_crtc_internal.h | 1 + 3 files changed, 3 insertions(+) Rev

Re: [PATCH RFC v6 01/10] drm: Introduce pixel_source DRM plane property

2023-09-24 Thread Dmitry Baryshkov
On 29/08/2023 03:05, Jessica Zhang wrote: Add support for pixel_source property to drm_plane and related documentation. In addition, force pixel_source to DRM_PLANE_PIXEL_SOURCE_FB in DRM_IOCTL_MODE_SETPLANE as to not break legacy userspace. This enum property will allow user to specify a pixel