Re: [PATCH RFC v5 09/10] drm/msm/dpu: Use DRM solid_fill property

2023-07-30 Thread Dmitry Baryshkov
On 28/07/2023 20:02, Jessica Zhang wrote: Drop DPU_PLANE_COLOR_FILL_FLAG and check the DRM solid_fill property to determine if the plane is solid fill. In addition drop the DPU plane color_fill field as we can now use drm_plane_state.solid_fill instead, and pass in drm_plane_state.alpha to _dpu_p

Re: [PATCH RFC v5 08/10] drm/msm/dpu: Allow NULL FBs in atomic commit

2023-07-30 Thread Dmitry Baryshkov
On 28/07/2023 20:02, Jessica Zhang wrote: Since solid fill planes allow for a NULL framebuffer in a valid commit, add NULL framebuffer checks to atomic commit calls within DPU. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 9 ++- drivers/gpu/drm/msm/disp/d

Re: [PATCH RFC v5 07/10] drm/atomic: Loosen FB atomic checks

2023-07-30 Thread Dmitry Baryshkov
On 28/07/2023 20:02, Jessica Zhang wrote: Loosen the requirements for atomic and legacy commit so that, in cases where pixel_source != FB, the commit can still go through. This includes adding framebuffer NULL checks in other areas to account for FB being NULL when non-FB pixel sources are enabl

Re: [PATCH RFC v5 06/10] drm/atomic: Move framebuffer checks to helper

2023-07-30 Thread Dmitry Baryshkov
On 28/07/2023 20:02, Jessica Zhang wrote: Currently framebuffer checks happen directly in drm_atomic_plane_check(). Move these checks into their own helper method. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/drm_atomic.c | 130 --- 1 file changed,

Re: [PATCH RFC v5 03/10] drm: Add solid fill pixel source

2023-07-30 Thread Dmitry Baryshkov
On 28/07/2023 20:02, Jessica Zhang wrote: Add "SOLID_FILL" as a valid pixel source. If the pixel_source property is set to "SOLID_FILL", it will display data from the drm_plane "solid_fill" blob property. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/drm_blend.c | 10 +- include/d

Re: [PATCH RFC v5 02/10] drm: Introduce solid fill DRM plane property

2023-07-30 Thread Dmitry Baryshkov
On 28/07/2023 20:02, Jessica Zhang wrote: Document and add support for solid_fill property to drm_plane. In addition, add support for setting and getting the values for solid_fill. To enable solid fill planes, userspace must assign a property blob to the "solid_fill" plane property containing th

Re: [PATCH v5 6/6] drm/doc: Define KMS atomic state set

2023-07-30 Thread André Almeida
Em 13/07/2023 04:51, Pekka Paalanen escreveu: On Tue, 11 Jul 2023 10:57:57 +0200 Daniel Vetter wrote: On Fri, Jul 07, 2023 at 07:40:59PM -0300, André Almeida wrote: From: Pekka Paalanen Specify how the atomic state is maintained between userspace and kernel, plus the special case for async