Re: [RFC] drm/kms: control display brightness through drm_connector properties

2022-04-08 Thread Alex Deucher
On Fri, Apr 8, 2022 at 10:56 AM Hans de Goede wrote: > > Hi, > > On 4/8/22 16:08, Alex Deucher wrote: > > On Fri, Apr 8, 2022 at 4:07 AM Daniel Vetter wrote: > >> > >> On Thu, Apr 07, 2022 at 05:05:52PM -0400, Alex Deucher wrote: > >>> On Thu, Apr 7, 2022 at 1:43 PM Hans de Goede wrote: > >

Re: [RFC] drm/kms: control display brightness through drm_connector properties

2022-04-08 Thread Hans de Goede
Hi Simon, On 4/8/22 10:22, Simon Ser wrote: > Hi Hans, > > Thanks for your details replies! > > On Thursday, April 7th, 2022 at 19:43, Hans de Goede > wrote: > >>> On Thursday, April 7th, 2022 at 17:38, Hans de Goede >>> wrote: >>> The drm_connector brightness properties =

Re: [RFC] drm/kms: control display brightness through drm_connector properties

2022-04-08 Thread Hans de Goede
Hi, On 4/8/22 16:08, Alex Deucher wrote: > On Fri, Apr 8, 2022 at 4:07 AM Daniel Vetter wrote: >> >> On Thu, Apr 07, 2022 at 05:05:52PM -0400, Alex Deucher wrote: >>> On Thu, Apr 7, 2022 at 1:43 PM Hans de Goede wrote: Hi Simon, On 4/7/22 18:51, Simon Ser wrote: > Very ni

Re: [RFC] drm/kms: control display brightness through drm_connector properties

2022-04-08 Thread Alex Deucher
On Fri, Apr 8, 2022 at 4:07 AM Daniel Vetter wrote: > > On Thu, Apr 07, 2022 at 05:05:52PM -0400, Alex Deucher wrote: > > On Thu, Apr 7, 2022 at 1:43 PM Hans de Goede wrote: > > > > > > Hi Simon, > > > > > > On 4/7/22 18:51, Simon Ser wrote: > > > > Very nice plan! Big +1 for the overall approach

Re: Touchscreen calibration matrix changes

2022-04-08 Thread Teemu K
Persistent storage was never the problem. Issue was getting the non-default values in use, but it has now been sorted. -TeemuK On Wed, Apr 6, 2022 at 7:58 AM Peter Hutterer wrote: > > On Wed, Apr 06, 2022 at 06:02:22AM +0300, Teemu K wrote: > > On Tue, Apr 5, 2022 at 5:21 PM Pekka Paalanen wrot

Re: [RFC] drm/kms: control display brightness through drm_connector properties

2022-04-08 Thread Hans de Goede
Hi, On 4/8/22 12:16, Simon Ser wrote: > Would it be an option to only support the KMS prop for Good devices, > and continue using the suboptimal existing sysfs API for Bad devices? > > (I'm just throwing ideas around to see what sticks, feel free to ignore.) Currently suid-root or pkexec helpers

Re: [RFC] drm/kms: control display brightness through drm_connector properties

2022-04-08 Thread Hans de Goede
Hi, On 4/8/22 11:58, Hans de Goede wrote: > Hi Daniel, > > On 4/8/22 10:07, Daniel Vetter wrote: >> On Thu, Apr 07, 2022 at 05:05:52PM -0400, Alex Deucher wrote: >>> On Thu, Apr 7, 2022 at 1:43 PM Hans de Goede wrote: Hi Simon, On 4/7/22 18:51, Simon Ser wrote: > Very nic

Re: [RFC] drm/kms: control display brightness through drm_connector properties

2022-04-08 Thread Simon Ser
Would it be an option to only support the KMS prop for Good devices, and continue using the suboptimal existing sysfs API for Bad devices? (I'm just throwing ideas around to see what sticks, feel free to ignore.)

Re: [RFC] drm/kms: control display brightness through drm_connector properties

2022-04-08 Thread Hans de Goede
Hi, On 4/8/22 11:58, Hans de Goede wrote: > Hi Daniel, > > On 4/8/22 10:07, Daniel Vetter wrote: >> On Thu, Apr 07, 2022 at 05:05:52PM -0400, Alex Deucher wrote: >>> On Thu, Apr 7, 2022 at 1:43 PM Hans de Goede wrote: Hi Simon, On 4/7/22 18:51, Simon Ser wrote: > Very nic

Re: [RFC] drm/kms: control display brightness through drm_connector properties

2022-04-08 Thread Hans de Goede
Hi Daniel, On 4/8/22 10:07, Daniel Vetter wrote: > On Thu, Apr 07, 2022 at 05:05:52PM -0400, Alex Deucher wrote: >> On Thu, Apr 7, 2022 at 1:43 PM Hans de Goede wrote: >>> >>> Hi Simon, >>> >>> On 4/7/22 18:51, Simon Ser wrote: Very nice plan! Big +1 for the overall approach. >>> >>> Thanks.

Re: [RFC] drm/kms: control display brightness through drm_connector properties

2022-04-08 Thread Simon Ser
Hi Hans, Thanks for your details replies! On Thursday, April 7th, 2022 at 19:43, Hans de Goede wrote: > > On Thursday, April 7th, 2022 at 17:38, Hans de Goede > > wrote: > > > >> The drm_connector brightness properties > >> === > >> > >> bl_brightness: rw

Re: [RFC] drm/kms: control display brightness through drm_connector properties

2022-04-08 Thread Daniel Vetter
On Thu, Apr 07, 2022 at 05:05:52PM -0400, Alex Deucher wrote: > On Thu, Apr 7, 2022 at 1:43 PM Hans de Goede wrote: > > > > Hi Simon, > > > > On 4/7/22 18:51, Simon Ser wrote: > > > Very nice plan! Big +1 for the overall approach. > > > > Thanks. > > > > > On Thursday, April 7th, 2022 at 17:38, Ha