Re: [PATCH weston 3/3 v4] simple-dmabuf-drm: use GBM generic calls

2018-07-20 Thread Guido Günther
Hi, On Fri, Jul 13, 2018 at 05:43:50PM +0200, Guido Günther wrote: > Hi, > On Thu, Jul 12, 2018 at 01:46:25PM +0200, Emilio Pozuelo Monfort wrote: > > No need to write libdrm driver specific code for each supported > > driver, we can just let GBM call the right one for us now. > > This one breaks

Re: [PATCH weston 2/2] simple-dmabuf-drm: use GBM generic calls

2018-07-20 Thread Guido Günther
Hi, On Thu, Jul 19, 2018 at 04:45:02PM +0200, Emilio Pozuelo Monfort wrote: > No need to write libdrm driver specific code for each supported > driver, we can just let GBM call the right one for us now. > > Signed-off-by: Emilio Pozuelo Monfort > --- > Some improvements from Daniel (thanks!). I a

[PATCH weston v5 10/14] compositor: protocol logger

2018-07-20 Thread Daniel Stone
From: Pekka Paalanen This is better than running Weston with WAYLAND_DEBUG=server: - It is enabled on demand, no unnecessary flooding and no need to restart the compositor if debug was enabled. - It prints client pointers so that messages with different clients can be seen apart. Signed-off-

[PATCH weston v5 13/14] compositor-drm: Calculate atomic-commit flags earlier

2018-07-20 Thread Daniel Stone
Shift up our calculation of the flags we use for atomic commits. We will later use this to differentiate between test-only and full commits when printing debug information inside drm_output_state_apply_atomic. Signed-off-by: Daniel Stone --- libweston/compositor-drm.c | 25 +-

[PATCH weston v5 07/14] xwm: dump_property() to use FILE internally

2018-07-20 Thread Daniel Stone
From: Pekka Paalanen Write the output of dump_property() out in one log call. When multiple processes (weston and Xwayland) are writing to the same file, this will keep the property dump uninterrupted by Xwayland debug prints. This is also preparation for more development in the same direction.

[PATCH weston v5 11/14] compositor: Add weston_layer_mask_is_infinite

2018-07-20 Thread Daniel Stone
As a counterpart to weston_layer_set_mask_infinite(), returning if the mask is the same as what is set. Signed-off-by: Daniel Stone --- libweston/compositor.c | 9 + libweston/compositor.h | 3 +++ 2 files changed, 12 insertions(+) diff --git a/libweston/compositor.c b/libweston/composi

[PATCH weston v5 04/14] compositor: add option to enable weston_debug

2018-07-20 Thread Daniel Stone
From: Pekka Paalanen Let users enable the compositor debug protocol on the compositor command line. This allows weston-debug tool to work. Signed-off-by: Pekka Paalanen Signed-off-by: Maniraj Devadoss Reviewed-by: Pekka Paalanen --- compositor/main.c | 7 +++ man/weston.man| 11

[PATCH weston v5 06/14] compositor: offer logs via weston-debug

2018-07-20 Thread Daniel Stone
From: Pekka Paalanen This registers a new weston-debug scope "log" through which one can get live log output interspersed with possible other debugging prints. Signed-off-by: Pekka Paalanen pass the log_scope to weston_debug_scope_timestamp API to append the scope name to the timestamp Signed

[PATCH weston v5 14/14] compositor-drm: Add drm-backend log debug scope

2018-07-20 Thread Daniel Stone
Add a 'drm-debug' scope which prints verbose information about the DRM backend's repaint cycle, including the decision tree on how views are assigned (or not) to planes. Signed-off-by: Daniel Stone --- libweston/compositor-drm.c | 233 - 1 file changed, 206 in

[PATCH weston v5 05/14] clients: add weston-debug

2018-07-20 Thread Daniel Stone
From: Pekka Paalanen A tool for accessing the zcompositor_debug_v1 interface features. Installed along weston-info, because it should be potentially useful for people running libweston-based compositors. Signed-off-by: Pekka Paalanen Added a man page for weston-debug client Signed-off-by: Ma

[PATCH weston v5 12/14] compositor: Add scene-graph debug scope

2018-07-20 Thread Daniel Stone
Add a 'scene-graph' debug scope which will dump out the current set of outputs, layers, and views and as much information as possible about how they are rendered and composited. Signed-off-by: Daniel Stone --- libweston/compositor.c | 219 + libweston/comp

[PATCH weston v5 08/14] xwm: move FILE to the callers of dump_property()

2018-07-20 Thread Daniel Stone
From: Pekka Paalanen This is preparation for using the weston-debug infrastructure for WM_DEBUG. dump_property() may be called from different debugging contexts and often needs to be prefixed with more information. An alternative to this patch would be to pass in the weston_debug_scope as an arg

[PATCH weston v5 09/14] xwm: convert WM_DEBUG into a weston-debug scope

2018-07-20 Thread Daniel Stone
From: Pekka Paalanen Instead of a compile time choice, offer the XWM debugging messages through the weston-debug protocol and tool on demand. Users will not need to recompile weston to get XWM debugging, and it won't flood the weston log. The debug scope needs to be initialized in launcher.c for

[PATCH weston v5 03/14] libweston: add weston_debug API and implementation

2018-07-20 Thread Daniel Stone
From: Pekka Paalanen weston_debug is both a libweston API for relaying debugging messages, and the compositor-debug wayland protocol implementation for accessing those debug messages from a Wayland client. weston_debug_compositor_{create,destroy}() are private API, hence not exported. Signed-of

[PATCH weston v5 00/14] weston-debug API and tool

2018-07-20 Thread Daniel Stone
Hi, This patch series implements the weston-debug interface and tool, as previously worked on by Pekka, Maniraj and Emre. The xwm changes are unchanged from the previous series, and additionally reviewed by myself. The core protocol has seen the addition of a registry-like advertising interface:

[PATCH weston v5 01/14] compositor-drm: Add backend pointer to drm_output

2018-07-20 Thread Daniel Stone
Add this for convenience, so it's easier to access when we add the DRM backend debug scope. Signed-off-by: Daniel Stone --- libweston/compositor-drm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libweston/compositor-drm.c b/libweston/compositor-drm.c index 704ac32c7..e27671437 100644

[PATCH weston v5 02/14] protocol: add weston-debug.xml

2018-07-20 Thread Daniel Stone
From: Pekka Paalanen This is a new debugging extension for non-production environments. The aim is to replace all build-time choosable debug prints in the compositor with runtime subscribable debug streams. Signed-off-by: Pekka Paalanen Added new libweston-$MAJOR-protocols.pc file and install

[PATCH] compositor-drm: Don't test render-only atomic configuration

2018-07-20 Thread Daniel Stone
In the RENDERER_ONLY state proposal mode, we don't actually have a viable configuration to test, because we won't get a renderer buffer until after assign_planes - where we're called from - has completed. This can result in us trying to test a configuration with the CRTC and connectors active, but

Re: DRM page-flip with damage for weston

2018-07-20 Thread Daniel Stone
Hi Deepak, On Fri, 20 Jul 2018 at 12:21, Deepak Singh Rawat wrote: > In brief the damage is in frame-buffer coordinate of attached fb to the plane. > Unlike plane src coordinates, damage clips are not in 16.16 fixed point. > Damage > during page flip is helpful for some drivers like vmwgfx where

DRM page-flip with damage for weston

2018-07-20 Thread Deepak Singh Rawat
Hi List, A while back I submitted RFC for page flip with damage interface in DRM (https://lists.freedesktop.org/archives/dri-devel/2018-April/171900.html) In brief the damage is in frame-buffer coordinate of attached fb to the plane. Unlike plane src coordinates, damage clips are not in 16.16 fi

Re: [PATCH weston 3/4] README: Move to Markdown, rewrite introduction

2018-07-20 Thread Quentin Glidic
On 7/14/18 3:09 PM, Daniel Stone wrote: Move the README file to Markdown, and update it to attempt to explain the current status and use of Weston. From patch 1: > The patch is a single logical change. If the commit message addresses > multiple points, it is a hint that the commit might need sp

[PATCH] compositor-drm: Remove unnecessary libdrm defines

2018-07-20 Thread Daniel Stone
The backend begins with a series of #defines of libdrm tokens, in case the libdrm we build against is too old. Commit efdebbc4e82b ("configure.ac: bump libdrm requirement to 2.4.68") did what it said on the box; since we now depend on a relatively modern libdrm, we can get rid of most of our compa

Re: [PATCH v3 2/3] xdg-shell: Make sure wording reflects expectations

2018-07-20 Thread Simon Ser
On July 20, 2018 10:09 AM, wrote: > From: Markus Ongyerth > > The wording in xdg-shell's `set_*` requests implies the compositor > *will* honour the client's request. > This would give clients the control over their actual state, while the > general expectation is that clients kindly ask for stat

Re: [PATCH v3 1/3] xdg-shell: move maximized state definition together

2018-07-20 Thread Simon Ser
On July 20, 2018 10:09 AM, wrote: > From: Markus Ongyerth > > The xdg-shell documentation had part of the maximized state render > implications in the `set_maximized` request documentation, not the > actual state. > This moves the relevant lines into the state description. > > Signed-off-by: Mark

[PATCH v3 3/3] xdg-shell: Give compositor control over configure

2018-07-20 Thread wl
From: Markus Ongyerth The `[un]set_(fullscreen/maximized)` requests text requires compositors to respon to the request with a configure event. with the asynchronous nature of wayland protocols, this provides essentially no benefit and might entice consumers to rely on details that are not guaran

[PATCH v3 0/3] Change wording in xdg-shell stable

2018-07-20 Thread wl
From: Markus Ongyerth v2 was https://lists.freedesktop.org/archives/wayland-devel/2018-June/038734.html Changes from v2: Moved the word wrapping change into the first commit, as pointed out by Simon. Markus Ongyerth (3): xdg-shell: move maximized state definition together xdg-shell: Make s

[PATCH v3 1/3] xdg-shell: move maximized state definition together

2018-07-20 Thread wl
From: Markus Ongyerth The xdg-shell documentation had part of the maximized state render implications in the `set_maximized` request documentation, not the actual state. This moves the relevant lines into the state description. Signed-off-by: Markus Ongyerth Reviewed-By: Mike Blumenkrantz ---

[PATCH v3 2/3] xdg-shell: Make sure wording reflects expectations

2018-07-20 Thread wl
From: Markus Ongyerth The wording in xdg-shell's `set_*` requests implies the compositor *will* honour the client's request. This would give clients the control over their actual state, while the general expectation is that clients kindly ask for state changes which the compositor may follow. Thi