Re: [PATCH] server: add wl_signal_emit_safe

2018-07-13 Thread Markus Ongyerth
On 2018/July/13 05:40, Simon Ser wrote: > This new function allows listeners to remove themselves or any > other listener when called. This version only works if listeners > are properly cleaned up when the wl_signal is free'd. This is about free()ing the wl_listener in the actual handler, not the

[PATCH] server: add wl_signal_emit_safe

2018-07-13 Thread Simon Ser
This new function allows listeners to remove themselves or any other listener when called. This version only works if listeners are properly cleaned up when the wl_signal is free'd. Signed-off-by: Simon Ser --- This is a [1] follow-up. Since we noticed the previous version is not a drop-in replac

[ANNOUNCE] wayland 1.15.91

2018-07-13 Thread Derek Foreman
This is the alpha for wayland 1.16. It's not so large as the weston release, but still some notable changes here: The client definition of wl_global is removed - this really shouldn't hurt anyone since it's been deprecated for a very long time. Some long standing oddness has been fixed with destr

[ANNOUNCE] weston 4.0.91

2018-07-13 Thread Derek Foreman
This is the alpha for weston 5.0. Lots of changes from lots of people - highlights include, but certainly aren't limited to: The use of hardware planes in atomic mode setting Clone mode, and all the infrastructure changes to make it possible A new touchscreen calibrator Full change history: Anki

Re: [PATCH weston 3/3 v4] simple-dmabuf-drm: use GBM generic calls

2018-07-13 Thread Daniel Stone
Hi Emilio, On Thu, 12 Jul 2018 at 12:46, Emilio Pozuelo Monfort wrote: > @@ -343,17 +143,16 @@ fill_content(struct buffer *my_buf, uint64_t modifier) > } > else if (modifier == DRM_FORMAT_MOD_LINEAR) { > uint8_t *pix8; > -

Re: [PATCH weston 3/3 v4] simple-dmabuf-drm: use GBM generic calls

2018-07-13 Thread Guido Günther
Hi, On Thu, Jul 12, 2018 at 01:46:25PM +0200, Emilio Pozuelo Monfort wrote: > No need to write libdrm driver specific code for each supported > driver, we can just let GBM call the right one for us now. This one breaks NV12 on intel when using rootston as compositor for me. $ ./weston-simple-dmab

Re: [PATCH wayland 1/4] contributing: how to read the review rules

2018-07-13 Thread Derek Foreman
On 2018-07-13 09:52 AM, Daniel Stone wrote: > Hi, > > On Tue, 3 Jul 2018 at 11:32, Pekka Paalanen wrote: >> This is to avoid fighting around the letter of the guidelines. This is >> not a protocol spec. > > Seems entirely sensible to me; thanks for writing this up! > > Series is: > Reviewed-by:

Re: [PATCH weston v4] simple-dmabuf-drm: nv12: properly fill Y plane

2018-07-13 Thread Daniel Stone
Hi Emilio, On Thu, 12 Jul 2018 at 12:46, Emilio Pozuelo Monfort wrote: > @@ -147,7 +147,7 @@ fill_content(struct buffer *my_buf, uint64_t modifier) > for (y = 0; y < my_buf->height; y++) { > pix8 = my_buf->mmap + y * my_buf->stride; >

Re: [PATCH weston 1/3 v4] simple-dmabuf-drm: require zwp_linux_dmabuf_v1 v3

2018-07-13 Thread Daniel Stone
Hi Emilio, On Thu, 12 Jul 2018 at 12:47, Emilio Pozuelo Monfort wrote: > @@ -821,16 +820,8 @@ registry_handle_global(void *data, struct wl_registry > *registry, > d->fshell = wl_registry_bind(registry, > id, > &zwp_fullscreen_shell_v1

Re: [PATCH wayland 1/4] contributing: how to read the review rules

2018-07-13 Thread Daniel Stone
Hi, On Tue, 3 Jul 2018 at 11:32, Pekka Paalanen wrote: > This is to avoid fighting around the letter of the guidelines. This is > not a protocol spec. Seems entirely sensible to me; thanks for writing this up! Series is: Reviewed-by: Daniel Stone Cheers, Daniel ___

Re: [PATCH] protocol: allow to send a zero physical output size

2018-07-13 Thread Daniel Stone
Hi, On Tue, 3 Jul 2018 at 12:27, Simon Ser wrote: > Physical size doesn't always make sense for all outputs. In case > it's not available or not relevant, allow compositors to send zero. > --- > In practice this doesn't seem to break any client toolkit. We've been > doing that for a long time in

Re: [PATCH] protocol: allow to send a zero physical output size

2018-07-13 Thread Simon Ser
Hi all, I'd like to bump this, because it seems that's how they do it on the X11 side [1]. So adding this would allow to have better Wayland behaviour _and_ correct X11 screen data via Xwayland. Thanks, [1]: https://lists.x.org/archives/xorg-devel/2018-July/057301.html On July 3, 2018 12:27 PM,