[PATCH weston 0/2] add test for sub-surface with unmapped parent

2018-07-06 Thread Emilio Pozuelo Monfort
Nothing to fix in weston itself, a similar test works fine with the desktop shell. However the test doesn't work in the test shell, so fix it there. Pekka, I see what you meant when you said that we needed to call committed() and that my previous fix was wrong. This may need some improvements to s

[PATCH weston 1/2] shot: add test for sub-surface with unmapped parent

2018-07-06 Thread Emilio Pozuelo Monfort
This reproduces https://bugs.freedesktop.org/show_bug.cgi?id=94735. Signed-off-by: Emilio Pozuelo Monfort --- tests/reference/subsurface_mapped-00.png | Bin 0 -> 5294 bytes tests/reference/subsurface_mapped-01.png | Bin 0 -> 5612 bytes tests/subsurface-shot-test.c | 76 +++

[PATCH weston 2/2] weston-test: don't map surfaces that have no content

2018-07-06 Thread Emilio Pozuelo Monfort
If a surface has no content (e.g. no buffer), then it shouldn't be mapped, so that its subsurfaces don't get mapped either. This works fine in the desktop-shell, but is currently broken on the weston-test module. https://bugs.freedesktop.org/show_bug.cgi?id Signed-off-by: Emilio Pozuelo Monfort

Re: [PATCH v16 08/23] compositor-drm: Use plane_coords_for_view for cursor

2018-07-06 Thread Daniel Stone
Hi Pekka, On Fri, 6 Jul 2018 at 14:14, Pekka Paalanen wrote: > On Thu, 5 Jul 2018 18:16:35 +0100 Daniel Stone wrote: > > Use the new helper to populate the cursor state as well, with some > > special-case handling to account for how we always upload a full-size > > BO. > > > > As this now fully

Re: [PATCH v16 08/23] compositor-drm: Use plane_coords_for_view for cursor

2018-07-06 Thread Pekka Paalanen
On Thu, 5 Jul 2018 18:16:35 +0100 Daniel Stone wrote: > Use the new helper to populate the cursor state as well, with some > special-case handling to account for how we always upload a full-size > BO. > > As this now fully takes care of buffer transformations, HiDPI client > cursors work, and w

Re: [PATCH v16 15/23] compositor-drm: Support modifiers with GBM

2018-07-06 Thread Daniel Stone
Hey Emil, On Fri, 6 Jul 2018 at 11:02, Emil Velikov wrote: > On 5 July 2018 at 18:16, Daniel Stone wrote: > > Use the extended GBM allocator interface to support modifiers and > > multi-planar BOs. > > Instead of such lovely checks and multiple #ifdef blocks through in > the code, one can use wea

Re: [PATCH v16 07/23] compositor-drm: Use plane_state_coords_for_view for scanout

2018-07-06 Thread Daniel Stone
Hi Pekka, On Fri, 6 Jul 2018 at 13:48, Pekka Paalanen wrote: > > On Thu, 5 Jul 2018 18:16:34 +0100 > Daniel Stone wrote: > > + /* Check the view spans exactly the output size, calculated in the > > + * logical co-ordinate space. */ > > + extents = pixman_region32_extents(&ev->transf

Re: [PATCH v16 07/23] compositor-drm: Use plane_state_coords_for_view for scanout

2018-07-06 Thread Pekka Paalanen
On Thu, 5 Jul 2018 18:16:34 +0100 Daniel Stone wrote: > Now that we have a helper to fill the plane state co-ordinates from a > view, use this for the scanout plane. > > We now explicitly check that the view fills exactly the fullscreen area > and nothing else. We then use the new helper to fil

Re: [PATCH v16 06/23] compositor-drm: Centralise more transform checks

2018-07-06 Thread Pekka Paalanen
On Thu, 5 Jul 2018 18:16:33 +0100 Daniel Stone wrote: > Put some more transformation checks in drm_view_transform_supported. > Please mention that this patch removes the requirement of identical scales for overlays and the reason why. It seems to have been replaced with a less strict check tha

Re: [PATCH v16 05/23] compositor-drm: Fully account for buffer transformation

2018-07-06 Thread Pekka Paalanen
On Thu, 5 Jul 2018 18:16:32 +0100 Daniel Stone wrote: > In our new and improved helper to determine the src/dest values for a > buffer on a given plane, make sure we account for all buffer > transformations, including viewport clipping. > > Rather than badly open-coding it ourselves, just use t

[PATCH] man: Remove description of DRM specific mode-options from weston.ini.man

2018-07-06 Thread Nautiyal, Ankit K
From: Ankit Nautiyal The weston.ini.man describes the mode-formats that a user can specify for selecting a video mode. The DRM specific examples are already provided in weston-drm.man, so this inofrmation is redundant and can be removed. This patch removes the DRM specific mode option details fr

Re: [PATCH v16 03/23] compositor-drm: Make alpha-to-opaque handling common

2018-07-06 Thread Pekka Paalanen
On Thu, 5 Jul 2018 18:16:30 +0100 Daniel Stone wrote: > Rather than a hardcoded ARGB -> XRGB translation inside a > GBM-specific helper, just determine whether or not the view is opaque, > and use the generic helpers to implement the format translation. > > As a consequence of reorderin

[PATCH] compositor-drm: Define DPMS property as an enum

2018-07-06 Thread Daniel Stone
The DPMS connector property is an enum property in KMS, which made our property handling complain at startup as we weren't defining its enums. Fix our definition so we parse the enum values. The only user of the property is the legacy path, which can continue using fixed values as those values are

Re: [PATCH 1/2] man: add description for specifying modes with aspect-ratio in weston.ini

2018-07-06 Thread Nautiyal, Ankit K
On 7/6/2018 2:44 PM, Pekka Paalanen wrote: On Tue, 19 Mar 2097 00:24:56 +0530 "Nautiyal, Ankit K" wrote: From: Ankit Nautiyal This patch adds information about the new resolution-format that can be specified by a user in weston.ini to select a CEA mode. CEA defines timing of a video mode,

Re: [PATCH v16 15/23] compositor-drm: Support modifiers with GBM

2018-07-06 Thread Emil Velikov
Hi Dan, On 5 July 2018 at 18:16, Daniel Stone wrote: > Use the extended GBM allocator interface to support modifiers and > multi-planar BOs. > > Signed-off-by: Daniel Stone > Tested-by: Emre Ucan > --- > configure.ac | 3 ++ > libweston/compositor-drm.c | 61

Re: [PATCH 0/2] Add support for parsing aspect-ratio from DRM layer

2018-07-06 Thread Nautiyal, Ankit K
Hi Pekka, Sorry for the goof up :) I would certainly take care of this next time. Thanks a lot for all the considerations. Regards, Ankit On 7/6/2018 2:44 PM, Pekka Paalanen wrote: On Tue, 19 Mar 2097 00:24:55 +0530 "Nautiyal, Ankit K" wrote: From: Ankit Nautiyal This patch series adds

Re: [PATCH v16 02/23] compositor-drm: Remove unnecessary picked_scanout variable

2018-07-06 Thread Pekka Paalanen
On Thu, 5 Jul 2018 18:16:29 +0100 Daniel Stone wrote: > e2e80136334f fixed the same issue as df573031d0ba in a different way. > The latter commit (applied earlier in the upstream tree) adds a variable > to assign_planes to keep track of when we successfully assign a view to > the scanout plane,

Re: [PATCH v16 01/23] compositor-drm: Property accessor can be const

2018-07-06 Thread Pekka Paalanen
On Thu, 5 Jul 2018 18:16:28 +0100 Daniel Stone wrote: > Since it doesn't write to the parameter, we can make it const. > > Signed-off-by: Daniel Stone > --- > libweston/compositor-drm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libweston/compositor-drm.c b/libw

Re: [PATCH 0/2] Add support for parsing aspect-ratio from DRM layer

2018-07-06 Thread Pekka Paalanen
On Tue, 19 Mar 2097 00:24:55 +0530 "Nautiyal, Ankit K" wrote: > From: Ankit Nautiyal > > This patch series adds support for parsing aspect-ratio information > for a connector vidoe mode, provided by the DRM layer. > The aspect ratio is stored in the flags bit of the connector modes, > which can

Re: [PATCH 1/2] man: add description for specifying modes with aspect-ratio in weston.ini

2018-07-06 Thread Pekka Paalanen
On Tue, 19 Mar 2097 00:24:56 +0530 "Nautiyal, Ankit K" wrote: > From: Ankit Nautiyal > > This patch adds information about the new resolution-format that can > be specified by a user in weston.ini to select a CEA mode. CEA defines > timing of a video mode, which is considered as a standard for