[PATCH libinput 4/4] touchpad: don't turn on the hysteresis on wobbly touchpads, just log it

2018-04-29 Thread Peter Hutterer
Touchpad hardware is terrible enough that trying to figure out when to enable the hysteresis is a cat-and-mouse game of "hey, why did it enable on my perfect touchpad" vs "hey, why is my pointer wobbly again". Which is fun but gets boring after a while, especially when you're on the receiving end o

[PATCH libinput 1/4] touchpad: reset the wobble detection history for y-only changes

2018-04-29 Thread Peter Hutterer
Otherwise we may detect wobble despite having a series of valid y movements, e.g. the following sequence was detected as wobble: x: 1 y: 0 x: 0 y: 1 x: 0 y: 2 x: 0 y: 2 x: 0 y: 1 x: -1 y: 0 x: 1 y: 0 Avoid this by resetting the history when w

[PATCH libinput 3/4] touchpad: only try to detect touchpad wobbling with one finger down

2018-04-29 Thread Peter Hutterer
Too many touches are unreliable with 2+ fingers down and we should error on the side of not detecting wobbling. Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad.c | 4 1 file changed, 4 insertions(+) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index 704d238a..ce30

[PATCH libinput 0/4] touchpad: don't auto-enable the hysteresis

2018-04-29 Thread Peter Hutterer
The hysteresis code is a pendulum between people complaining that the hysteresis switched on, followed by people complaining that it didn't switch on. So this is the next attempt - using the kernel fuzz for what it was theoretically intended. Except we can't (see 0/3 and commit 1523d8bb2e06) but

[PATCH libinput 2/4] touchpad: reset the wobble detection for non-pointer events

2018-04-29 Thread Peter Hutterer
If we get an event other than a motion event we're not wobbling so we need to reset and restart. Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index dc2ed8dc..7