[PATCH] compositor-headless: Report a more realistic physical size

2018-04-12 Thread Johan Klokkhammer Helsing
Some clients rely on the physical size to determine the physical DPI. With the previous implementation, we would report 1px==1mm, which is a DPI of 25.4, which is incredibly low. The problem is solved by setting a physical size so the DPI is close to 72 instead. If the output is scaled, the DPI is

Re: [PATCH weston 21/25] protocol: add weston_touch_calibration

2018-04-12 Thread Peter Hutterer
On Wed, Apr 11, 2018 at 02:00:49PM +0300, Pekka Paalanen wrote: > On Wed, 11 Apr 2018 10:16:46 +1000 > Peter Hutterer wrote: > > > > > + An event carries the touch device identification and the > > > > > associated > > > > > + output or head (display connector) name. > > > > > + > > > > >

Re: [PATCHv2] text-input: Add v3 of the text-input protocol

2018-04-12 Thread Dorota Czaplejewicz
On Thu, 12 Apr 2018 21:26:08 +0200 Silvan Jegen wrote: > Hi Dorota > > On Wed, Apr 11, 2018 at 03:03:58PM +0200, Dorota Czaplejewicz wrote: > > This new protocol description is a simplification over v2. > > > > - All pre-edit text styling is gone. > > - No events regarding input panel (OSK) sta

Re: [PATCHv2] text-input: Add v3 of the text-input protocol

2018-04-12 Thread Silvan Jegen
Hi Dorota On Wed, Apr 11, 2018 at 03:03:58PM +0200, Dorota Czaplejewicz wrote: > This new protocol description is a simplification over v2. > > - All pre-edit text styling is gone. > - No events regarding input panel (OSK) state nor covered rectangle. > Compositors are still free to handle situ

Re: [PATCH weston v6 65/73] compositor-drm: no need to clear inherited_mode

2018-04-12 Thread Daniel Stone
Hi Pekka, On 16 February 2018 at 15:57, Pekka Paalanen wrote: > The head was just zalloc()'d, there is no need to memset it to zero. > > If a function fails, it is preferable it leaves the output arguments > untouched. Everything to this point is: Reviewed-by: Daniel Stone and I'm happy for yo

Re: [PATCH weston v6 56/73] compositor-drm: remove unused_connectors array

2018-04-12 Thread Daniel Stone
On 12 April 2018 at 14:48, Pekka Paalanen wrote: > On Thu, 12 Apr 2018 14:38:01 +0200 Daniel Stone wrote: >> > + wl_list_for_each(head_base, >> > +&b->compositor->head_list, >> > compositor_link) { >> >> wl_list_for_each(head, &b->compositor->head_li

Re: [PATCH weston v6 49/73] compositor-drm: move connector fields into drm_head

2018-04-12 Thread Daniel Stone
Hi Pekka, On 12 April 2018 at 14:53, Pekka Paalanen wrote: > On Thu, 12 Apr 2018 15:37:43 +0300 Pekka Paalanen wrote: >> On Thu, 12 Apr 2018 14:03:32 +0200 Daniel Stone wrote: >> > One thing I'm missing (possibly post-lunch tiredness, but): when >> > exactly would we replace a connector? Is it

Re: [PATCH weston v6 69/73] compositor-drm: head attach requires a modeset

2018-04-12 Thread Daniel Stone
On 16 February 2018 at 15:57, Pekka Paalanen wrote: > For the attach on an enabled output to have an effect, we need to go > through drmModeSetCrtc or ATOMIC_ALLOW_MODESET. > > Signed-off-by: Pekka Paalanen > --- > libweston/compositor-drm.c | 15 +++ > 1 file changed, 15 insertions(

Re: [PATCH weston v6 49/73] compositor-drm: move connector fields into drm_head

2018-04-12 Thread Pekka Paalanen
On Thu, 12 Apr 2018 15:37:43 +0300 Pekka Paalanen wrote: > On Thu, 12 Apr 2018 14:03:32 +0200 > Daniel Stone wrote: > > > Hi Pekka, > > I've reviewed up to this point (the first half as discussed before, > > second half from this submission), and it all looks good so far. One > > question: > >

Re: [PATCH weston v6 56/73] compositor-drm: remove unused_connectors array

2018-04-12 Thread Pekka Paalanen
On Thu, 12 Apr 2018 14:38:01 +0200 Daniel Stone wrote: > Hi Pekka, > > On 16 February 2018 at 15:57, Pekka Paalanen wrote: > > Replace the unused_connectors array by iterating through the head list > > instead. A head that is not enabled (attached to an enabled output) is > > basically an unuse

Re: [PATCH weston v6 57/73] compositor-drm: drm_output_apply_state_legacy heads

2018-04-12 Thread Daniel Stone
On 16 February 2018 at 15:57, Pekka Paalanen wrote: > @@ -1863,7 +1869,7 @@ drm_output_apply_state_legacy(struct drm_output_state > *state) > } > > ret = drmModeSetCrtc(backend->drm.fd, output->crtc_id, 0, 0, > 0, > -&head->conn

Re: [PATCH weston v6 56/73] compositor-drm: remove unused_connectors array

2018-04-12 Thread Daniel Stone
Hi Pekka, On 16 February 2018 at 15:57, Pekka Paalanen wrote: > Replace the unused_connectors array by iterating through the head list > instead. A head that is not enabled (attached to an enabled output) is > basically an unused connector. > > All connectors regardless of their status have a drm

Re: [PATCH weston v6 49/73] compositor-drm: move connector fields into drm_head

2018-04-12 Thread Pekka Paalanen
On Thu, 12 Apr 2018 14:03:32 +0200 Daniel Stone wrote: > Hi Pekka, > I've reviewed up to this point (the first half as discussed before, > second half from this submission), and it all looks good so far. One > question: > > On 16 February 2018 at 15:57, Pekka Paalanen wrote: > > +/** Replace co

Re: [PATCH weston v6 49/73] compositor-drm: move connector fields into drm_head

2018-04-12 Thread Daniel Stone
Hi Pekka, I've reviewed up to this point (the first half as discussed before, second half from this submission), and it all looks good so far. One question: On 16 February 2018 at 15:57, Pekka Paalanen wrote: > +/** Replace connector data and monitor information > + * > + * @param head The head t

Re: [PATCH weston v6 00/73] Head-based output configuration API a.k.a clone mode infrastructure

2018-04-12 Thread Daniel Stone
Hi Pekka, On 16 February 2018 at 15:56, Pekka Paalanen wrote: > here is the v6 of the shared-CRTC clone mode series. Since v5, quite > many patches have been extracted from this series, sent out and merged > upstream. However, now the series is bigger than ever, because here I am > posting the co

Re: [wayland-protocols] text-input: Add v3 of the text-input protocol

2018-04-12 Thread Dorota Czaplejewicz
On Thu, 12 Apr 2018 10:35:04 +0200 Jonas Ådahl wrote: > On Thu, Apr 12, 2018 at 12:13:49AM +0200, Carlos Garnacho wrote: > > Hi!, > > > > On Wed, Apr 11, 2018 at 8:52 PM, Weng Xuetian wrote: > > > (forgot to reply to the list) > > > > > > On Wednesday, 11 April 2018 11:35:58 PDT Dorota Czaple

Re: [wayland-protocols] text-input: Add v3 of the text-input protocol

2018-04-12 Thread Jonas Ådahl
On Thu, Apr 12, 2018 at 12:13:49AM +0200, Carlos Garnacho wrote: > Hi!, > > On Wed, Apr 11, 2018 at 8:52 PM, Weng Xuetian wrote: > > (forgot to reply to the list) > > > > On Wednesday, 11 April 2018 11:35:58 PDT Dorota Czaplejewicz wrote: > >> On Wed, 11 Apr 2018 11:26:22 -0700 > >> > >> Weng Xue