Re: [PATCH weston] Revert "xwm: Add icon support to the frame" and friends

Hi, On 29 March 2018 at 15:53, Derek Foreman wrote: > On 2018-03-29 09:10 AM, Derek Foreman wrote: >> Perhaps I should've been more clear as to what "incomplete" means in >> this commit log. >> >> The current code will pick the first available icon unconditionally, >> regardless as to whether thi

Re: [PATCH weston] Revert "xwm: Add icon support to the frame" and friends

On 2018-03-29 09:10 AM, Derek Foreman wrote: > On 2018-03-29 08:59 AM, Derek Foreman wrote: >> This reverts commit bef761796c2ada6344d227142af4a0f40b9760dd. >> This (partially) reverts commit 4d1cd36c9ea041688f92cd8981e43b5fe3b52409. >> - the frame_destroy in weston_wm_window_destroy() remains >>

Re: [PATCH weston] Revert "xwm: Add icon support to the frame" and friends

On 2018-03-29 08:59 AM, Derek Foreman wrote: > This reverts commit bef761796c2ada6344d227142af4a0f40b9760dd. > This (partially) reverts commit 4d1cd36c9ea041688f92cd8981e43b5fe3b52409. > - the frame_destroy in weston_wm_window_destroy() remains > This reverts commit 44fc1be913ab2faad0414f50e51d583

[PATCH weston] Revert "xwm: Add icon support to the frame" and friends

This reverts commit bef761796c2ada6344d227142af4a0f40b9760dd. This (partially) reverts commit 4d1cd36c9ea041688f92cd8981e43b5fe3b52409. - the frame_destroy in weston_wm_window_destroy() remains This reverts commit 44fc1be913ab2faad0414f50e51d58310302d065. This (partially) reverts commit e277276b85

Re: [PATCH v5 weston] xwm: Choose icon closest to target size

Since this is a little further from landing than I thought, as is the scaling patch, I think the best move for the short term is to revert the icon stuff entirely and move forward after the release. Thanks, Derek On 2018-03-29 04:17 AM, Pekka Paalanen wrote: > On Tue, 27 Mar 2018 12:43:36 -0500 >

Re: [PATCH] xwm: Fix wrong input offset for certain clients

On Sun, 18 Mar 2018 12:22:17 -0600 Scott Moreau wrote: > Some windows might get a create_notify event without the > override redirect flag set and then get a confiure_notify > event before map_request is received. This means that when > weston_wm_window_get_child_position is called in response >

Re: [PATCH] xwm: Send configure event when moving

On Sun, 18 Mar 2018 12:22:16 -0600 Scott Moreau wrote: > Send a synthetic configure notify event to the reparented window to > update the position in Xwayland. This fixes menu positioning in clients > like VLC after moving the window. Hi, Signed-off-by missing, I would strongly recommend to add

Re: [PATCH] xwm: Handle changing override redirect flag

On Sun, 18 Mar 2018 12:22:15 -0600 Scott Moreau wrote: > Xwayland windows might be created with a different override redirect > flag than is given on map or configure notify. This causes confusion > about whether a window should be treated as override redirect or not. > Here we handle the changin

Re: [PATCH v4 2/2] xwm: Scale icon if size is not the target size

On Fri, 23 Mar 2018 13:47:33 -0600 Scott Moreau wrote: > This scales the icon cairo surface for the titlebar if it isn't the > target size. > > shared/cairo-util: Add surface resizing function to be used for this > case and other potential cases. > --- > > Changed in v2: > > - Rebase to [PATCH

Re: [PATCH v5 weston] xwm: Choose icon closest to target size

On Thu, 29 Mar 2018 12:17:46 +0300 Pekka Paalanen wrote: > On Tue, 27 Mar 2018 12:43:36 -0500 > Derek Foreman wrote: > > > Xwayland clients can offer multiple icon sizes in no particular order. > > Previously xwm was selecting the first one unconditionally. This patch > > selects the icon that

Re: [PATCH v5 weston] xwm: Choose icon closest to target size

On Tue, 27 Mar 2018 12:43:36 -0500 Derek Foreman wrote: > Xwayland clients can offer multiple icon sizes in no particular order. > Previously xwm was selecting the first one unconditionally. This patch > selects the icon that matches the size closest to the target size. The > target size is hard