Re: [PATCH weston 6/6] libweston: Implement touch timestamps for input_timestamps_unstable_v1

2018-01-26 Thread Alexandros Frantzis
On Fri, Jan 19, 2018 at 12:18:38PM +0200, Pekka Paalanen wrote: > On Wed, 20 Dec 2017 16:18:01 +0200 > Alexandros Frantzis wrote: > > > Implement the zwp_input_timestamps_v1.get_touch_timestamps request to > > subscribe to timestamp events for wl_touch resources. > > > > Signed-off-by: Alexandro

[PATCH weston 6/8] tests: Support weston_test request for adding a test seat

2018-01-26 Thread Alexandros Frantzis
Support adding a test seat using the weston_test.device_add request. This will be used in tests in upcoming commits where we will need to re-add the seat after having it removed. We only support one test seat at the moment, so this commit also introduces checks to ensure the client doesn't try to

[PATCH weston 8/8] tests: Add test for seat destruction and creation

2018-01-26 Thread Alexandros Frantzis
Add a test to check that we can destroy and create the test seat. Since after test seat destruction the test client releases any associated input resources, this test also checks that libweston properly handles release requests for inert input resources. The test is placed in its own file for the

[PATCH weston 7/8] tests: Handle removal of seat global in test clients

2018-01-26 Thread Alexandros Frantzis
The current test client code completely ignores removal of globals. This commit updates the code to properly handle removal of globals in general, and of seat globals in particular. This ensures that the test client objects are in sync with the server and any relevant resources are released accordi

[PATCH weston 0/8] libweston: Make input object destruction safe

2018-01-26 Thread Alexandros Frantzis
When an weston seat or input object is destroyed, any associated client resources should become inert and put in a state in which they can safely handle client requests. Currently, client requests to such resources may lead to crashes and/or memory errors in the server. This patchset aims to fix (

[PATCH weston 5/8] tests: Support setting the test client input dynamically

2018-01-26 Thread Alexandros Frantzis
The current test client code waits for all wl_seat globals to arrive before checking them and deciding which one is the test seat global to use for the input object. This method doesn't support dynamic addition of the test seat global (i.e., after client start-up), which will be needed in upcoming

[PATCH weston 1/8] libweston: Make weston_pointer destruction safe

2018-01-26 Thread Alexandros Frantzis
Properly clean up all sub-objects (e.g., weston_pointer_client objects) when a weston_pointer object is destroyed. The clean-up ensures that the server is able to safely handle client requests to any associated pointer resources, which, as a consenquence of a weston_pointer destruction, have now be

[PATCH weston 3/8] libweston: Make weston_touch destruction safe

2018-01-26 Thread Alexandros Frantzis
Ensure the server can safely handle client requests for wl_touch resources that have become inert due to a weston_touch object destruction. This change involves, among other things, setting the weston_touch object, instead of the weston_seat object, as the user data for wl_touch resources. Althoug

[PATCH weston 4/8] libweston: Make weston_seat release safe

2018-01-26 Thread Alexandros Frantzis
Ensure the server can safely handle client requests for wl_seat resource that have become inert due to weston_seat object release and subsequent destruction. The clean-up involves, among other things, unsetting the destroyed weston_seat object from the user data of wl_seat resources, and handling

[PATCH weston 2/8] libweston: Make weston_keyboard destruction safe

2018-01-26 Thread Alexandros Frantzis
Ensure the server can safely handle client requests for wl_keyboard resources that have become inert due to a weston_keyboard object destruction. This change involves, among other things, setting the weston_keyboard object, instead of the weston_seat object, as the user data for wl_keyboard resour

Re: [PATCH 3/5] scanner: introduce --object-type option

2018-01-26 Thread Emil Velikov
On 26 January 2018 at 02:44, Jonas Ådahl wrote: > On Thu, Jan 25, 2018 at 05:56:45PM +, Emil Velikov wrote: >> On 25 January 2018 at 02:01, Jonas Ådahl wrote: >> > On Wed, Jan 24, 2018 at 07:15:09PM +, Emil Velikov wrote: >> >> On 24 January 2018 at 18:20, Derek Foreman wrote: >> >> > On

[PATCH weston 4/4] ivi-shell: fix the layer assignment change from one screen to another

2018-01-26 Thread Emre Ucan
if the layer is in order of some screen we need to remove it from there and mark the screen order as dirty so it will be removed in commit_screen_list call later layer should only be assigned to one screen at a time Signed-off-by: Eugen Friedrich Signed-off-by: Emre Ucan --- ivi-shell/ivi-layou

[PATCH weston 3/4] ivi-shell: don't expilicitly assign outputs to views

2018-01-26 Thread Emre Ucan
it is assigned in weston_view_assign_outputs Signed-off-by: Emre Ucan --- ivi-shell/ivi-layout.c | 4 1 file changed, 4 deletions(-) diff --git a/ivi-shell/ivi-layout.c b/ivi-shell/ivi-layout.c index 3c52ce1..4799c25 100644 --- a/ivi-shell/ivi-layout.c +++ b/ivi-shell/ivi-layout.c @@ -821,

[PATCH weston 2/4] ivi-shell: don't schedule compositor repaint

2018-01-26 Thread Emre Ucan
it is not necessary to repaint all outputs after each commit_changes. Only outputs with modified views has to be repainted. We need to call weston_view_update_transform for assigning views to outputs first. Then, We can call weston_view_schedule_repaint to trigger repaint for outputs. Signed-off-

[PATCH weston 1/4] ivi-shell: change layer visibility to bool

2018-01-26 Thread Emre Ucan
ivi_layout_layer_set_visibility has bool as argument. Signed-off-by: Emre Ucan --- ivi-shell/ivi-layout-export.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ivi-shell/ivi-layout-export.h b/ivi-shell/ivi-layout-export.h index 277ac59..f656602 100644 --- a/ivi-shell/ivi-lay

Re: [PATCH v14 35/41] compositor-drm: Add modes to drm_output_propose_state

2018-01-26 Thread Pekka Paalanen
On Wed, 20 Dec 2017 12:26:52 + Daniel Stone wrote: > Add support for multiple modes: toggling whether or not the renderer > and/or planes are acceptable. This will be used to implement a smarter > plane-placement heuristic when we have support for testing output > states. > > Signed-off-by:

Re: [PATCH v14 34/41] compositor-drm: Ignore occluded views

2018-01-26 Thread Pekka Paalanen
On Wed, 20 Dec 2017 12:26:51 + Daniel Stone wrote: > When trying to assign planes, keep track of the areas which are > already occluded, and ignore views which are completely occluded. This > allows us to build a state using planes only, when there are occluded > views which cannot go into a

Re: [PATCH v14 33/41] compositor-drm: Ignore views on other outputs

2018-01-26 Thread Pekka Paalanen
On Wed, 20 Dec 2017 12:26:50 + Daniel Stone wrote: > When we come to assign_planes, try very hard to ignore views which are > only visible on other outputs, rather than forcibly moving them to the > primary plane, which causes damage all round and unnecessary repaints. > > Signed-off-by: Dan

Re: [PATCH v14 32/41] compositor-drm: Split drm_assign_planes in two

2018-01-26 Thread Pekka Paalanen
On Wed, 20 Dec 2017 12:26:49 + Daniel Stone wrote: > Move drm_assign_planes into two functions: one which proposes a plane > configuration, and another which applies that state to the Weston > internal structures. This will be used to try multiple configurations > and see which is supported.

Re: [PATCH v14 31/41] compositor-drm: Rename region variable

2018-01-26 Thread Pekka Paalanen
On Wed, 20 Dec 2017 12:26:48 + Daniel Stone wrote: > Make it a bit more clear what the purpose of the variable is. > > Signed-off-by: Daniel Stone > --- > libweston/compositor-drm.c | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/libweston/compositor-d

Re: [PATCH v14 30/41] compositor-drm: Don't need safe view-list traversal

2018-01-26 Thread Pekka Paalanen
On Wed, 20 Dec 2017 12:26:47 + Daniel Stone wrote: > Nothing in this loop reorders views within the compositor's view_list. > > Signed-off-by: Daniel Stone > --- > libweston/compositor-drm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libweston/compositor-

Re: [PATCH v14 29/41] compositor-drm: Add modifiers to GBM dmabuf import

2018-01-26 Thread Pekka Paalanen
On Wed, 20 Dec 2017 12:26:46 + Daniel Stone wrote: > Add support for the GBM_BO_IMPORT_FD_MODIFIER path, which allows us to > import multi-plane dmabufs, as well as format modifiers. > > Signed-off-by: Daniel Stone > --- > configure.ac | 6 +- > libweston/compositor-drm.c |

Re: [PATCH v14 28/41] compositor-drm: Support modifiers for drm_fb

2018-01-26 Thread Pekka Paalanen
On Wed, 20 Dec 2017 12:26:45 + Daniel Stone wrote: > Use the new drmModeAddFB2WithModifiers interface to import buffers with > modifiers. > > Signed-off-by: Daniel Stone > --- > configure.ac | 3 +++ > libweston/compositor-drm.c | 26 +- > 2 files cha

Re: [PATCH v14 27/41] compositor-drm: Extract drm_fb_addfb into a helper

2018-01-26 Thread Pekka Paalanen
On Wed, 20 Dec 2017 12:26:44 + Daniel Stone wrote: > We currently do the same thing in two places, and will soon have a > third. > > Signed-off-by: Daniel Stone > --- > libweston/compositor-drm.c | 93 > -- > 1 file changed, 48 insertions(+), 45

Re: [PATCH weston] RFC: libweston/compositor-drm: Add support for drm-lease.

2018-01-26 Thread Pekka Paalanen
On Thu, 25 Jan 2018 19:07:43 + Marius-cristian Vlad wrote: > -Original Message- > From: Pekka Paalanen [mailto:pekka.paala...@collabora.co.uk] > Sent: Thursday, January 25, 2018 2:06 PM > To: Daniel Stone > Cc: Marius-cristian Vlad ; Keith Packard > ; wayland-devel@lists.freedeskto