[PATCH wayland] connection: Clear correct args when clearing fds to -1

2018-01-19 Thread Derek Foreman
commit 52609ddf79a96fee0465006e2c6339a3a5d23a87 was intended to set fds to -1 in the arg list, however it failed to account for version information at the start of signatures. Most noticably, this broke mesa's create_prime_buffer by setting width to -1 instead of the fd, as the width was the argum

Re: [PATCH] xdg-shell: remove harmless typo

2018-01-19 Thread Derek Foreman
On 2018-01-19 12:55 PM, Mike Blumenkrantz wrote: Signed-off-by: Mike Blumenkrantz Reviewed-by: Derek Foreman and pushed Thanks, Derek --- stable/xdg-shell/xdg-shell.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stable/xdg-shell/xdg-shell.xml b/stable/xdg-shell

[PATCH] xdg-shell: remove harmless typo

2018-01-19 Thread Mike Blumenkrantz
Signed-off-by: Mike Blumenkrantz --- stable/xdg-shell/xdg-shell.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stable/xdg-shell/xdg-shell.xml b/stable/xdg-shell/xdg-shell.xml index dc70c7a..d524ea9 100644 --- a/stable/xdg-shell/xdg-shell.xml +++ b/stable/xdg-shell/xdg-she

Re: [PATCH wayland v2] tests: Add missing file to distribution

2018-01-19 Thread Derek Foreman
On 2018-01-19 11:51 AM, Derek Foreman wrote: In f74c9b98db49ce16e037c3012590c4a24a4fc32e I added tests.xml to the repository, but not to the distribution tarball. Signed-off-by: Derek Foreman Reviewed-by: Daniel Stone Pushed with Quentin's review from irc. Thanks --- Changes from v1: test

[PATCH wayland v2] tests: Add missing file to distribution

2018-01-19 Thread Derek Foreman
In f74c9b98db49ce16e037c3012590c4a24a4fc32e I added tests.xml to the repository, but not to the distribution tarball. Signed-off-by: Derek Foreman Reviewed-by: Daniel Stone --- Changes from v1: tests.xml belongs in the tarball only, not installed, so it is now in EXTRA_DIST Makefile.am | 1 +

Re: [PATCH wayland] tests: Add missing file to distribution

2018-01-19 Thread Daniel Stone
On 19 January 2018 at 17:37, Derek Foreman wrote: > In f74c9b98db49ce16e037c3012590c4a24a4fc32e I added tests.xml to the > repository, but not to the distribution. Oops. :( Reviewed-by: Daniel Stone Cheers, Daniel ___ wayland-devel mailing list wayla

[PATCH wayland] tests: Add missing file to distribution

2018-01-19 Thread Derek Foreman
In f74c9b98db49ce16e037c3012590c4a24a4fc32e I added tests.xml to the repository, but not to the distribution. Signed-off-by: Derek Foreman --- Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile.am b/Makefile.am index bceca2a..01ad805 100644 --- a/Makefile.am +++ b/Makefile.

Re: [PATCH v2] server: add log message when client connection is destroyed due to an error

2018-01-19 Thread Derek Foreman
On 2018-01-18 02:20 AM, Fiedler, Mathias wrote: Hi, -Original Message- From: Derek Foreman [mailto:der...@osg.samsung.com] Sent: Mittwoch, 17. Januar 2018 21:41 To: Fiedler, Mathias; wayland-devel@lists.freedesktop.org Subject: Re: [PATCH v2] server: add log message when client connecti

Re: Future of xdg-shell v5 support in weston

2018-01-19 Thread Daniel Stone
Hi, On 19 January 2018 at 16:21, Derek Foreman wrote: > It's my opinion that supporting xdg-shell final is rather important for the > wayland reference compositor. > > So, I think we need to consider removing xdg-shell v5 from weston and its > included clients as soon as is reasonable. > > It sho

Re: Future of xdg-shell v5 support in weston

2018-01-19 Thread Mike Blumenkrantz
I think that keeping it only promotes using it and further propagating its use, so I'm in favor of removal. On Fri, Jan 19, 2018 at 11:22 AM Derek Foreman wrote: > Hello, > > As you all may know, xdg-shell v5 and xdg-shell stable can't currently > co-exist in the same compositor, as both define

Future of xdg-shell v5 support in weston

2018-01-19 Thread Derek Foreman
Hello, As you all may know, xdg-shell v5 and xdg-shell stable can't currently co-exist in the same compositor, as both define structures with the same name (such as struct xdg_surface_interface). A solid effort was made to add functionality to wayland-scanner to resolve this, but turned out

Re: [PATCH wayland 2/3] scanner: Allow adding a prefix to exported symbols

2018-01-19 Thread Derek Foreman
On 2018-01-19 01:22 AM, Jonas Ã…dahl wrote: On Thu, Jan 18, 2018 at 10:48:14AM +0200, Pekka Paalanen wrote: On Wed, 17 Jan 2018 15:43:07 -0600 Derek Foreman wrote: On 2017-08-18 07:41 AM, Pekka Paalanen wrote: On Fri, 28 Jul 2017 14:06:23 +0100 Emil Velikov wrote: On 27 July 2017 at 14:

Re: [PATCH v5 4/7] libweston: fbdev: set fb device info upon the first run.

2018-01-19 Thread Pekka Paalanen
On Fri, 29 Dec 2017 13:31:50 -0500 nerdopolis wrote: > This attempts to wake up secondary framebuffer devices > (/dev/fb1 and up) as usually these devices start powered off, and > the FBIOPUT_VSCREENINFO ioctl turns it on. This was tested on a > qemu system with the options: > > -vga none -devic

Re: [PATCH v5 3/7] launcher-logind: only get a VT on seat0, as only seat0 supports VTs

2018-01-19 Thread Pekka Paalanen
On Fri, 29 Dec 2017 13:31:49 -0500 nerdopolis wrote: > As only seat0 supports TTYs, this changes the logind launcher where > it detects a TTY, only if the seat is seat0. This has only been > tested for logind > --- > libweston/launcher-logind.c | 22 -- > libweston/launcher-u

Re: [PATCH v5 2/7] libweston: fbdev: support the --seat option, (and XDG_SEAT variable)

2018-01-19 Thread Pekka Paalanen
On Fri, 29 Dec 2017 13:31:48 -0500 nerdopolis wrote: > This allows the fbdev backend to run on, and use devices from the > specified seat, similar to the drm backend. > --- > compositor/main.c| 2 ++ > libweston/compositor-fbdev.c | 10 +- > libweston/compositor-fbdev.h | 1

Re: [PATCH v5 1/7] libweston: set the seat automatically based on the XDG_SEAT environment variable

2018-01-19 Thread Pekka Paalanen
On Fri, 29 Dec 2017 13:31:47 -0500 nerdopolis wrote: > This will allow the seat to be set by the environment as pam_systemd typically > sets the XDG_SEAT variable > --- > compositor/main.c | 2 +- > libweston/compositor-drm.c | 5 + > man/weston-drm.man | 7 +-- > 3 file

Re: Weston stuff: fractional HiDPI, FreeBSD, Rust

2018-01-19 Thread Simon McVittie
On Thu, 18 Jan 2018 at 18:25:02 +, Daniel Stone wrote: > I do have another suggestion though: can you please change the platform > checks (#ifdef __linux__ and #ifdef FreeBSD) to instead be feature > checks? For example, CLOCK_MONOTONIC_RAW is behind a Linux ifdef and > CLOCK_MONOTONIC_FAST is

Re: [PATCH weston 6/6] libweston: Implement touch timestamps for input_timestamps_unstable_v1

2018-01-19 Thread Pekka Paalanen
On Wed, 20 Dec 2017 16:18:01 +0200 Alexandros Frantzis wrote: > Implement the zwp_input_timestamps_v1.get_touch_timestamps request to > subscribe to timestamp events for wl_touch resources. > > Signed-off-by: Alexandros Frantzis > --- > libweston/compositor.h | 2 ++ > libweston/input.c

Re: [PATCH weston 5/6] libweston: Implement pointer timestamps for input_timestamps_unstable_v1

2018-01-19 Thread Pekka Paalanen
On Wed, 20 Dec 2017 16:18:00 +0200 Alexandros Frantzis wrote: > Implement the zwp_input_timestamps_v1.get_pointer_timestamps request to > subscribe to timestamp events for wl_pointer resources. > > Signed-off-by: Alexandros Frantzis > --- > libweston/compositor.h | 2 ++ > libweston/input.c

Re: [PATCH weston 3/6] libweston: Introduce input-timestamps support code

2018-01-19 Thread Pekka Paalanen
On Wed, 20 Dec 2017 16:17:58 +0200 Alexandros Frantzis wrote: > Introduce code to support the implementation of the > input_timestamps_unstable_v1 protocol in libweston. This commit does not > implement the actual timestamp subscriptions, but lays the foundation so > timestamp subscriptions for k

Re: [PATCH wayland-protocols v2] unstable: Add input-timestamps protocol

2018-01-19 Thread Pekka Paalanen
On Thu, 18 Jan 2018 15:13:53 + Daniel Stone wrote: > Hi, > > On 18 January 2018 at 14:37, Pekka Paalanen wrote: > > On Wed, 20 Dec 2017 16:21:32 +0200 > > Alexandros Frantzis wrote: > >> a heads-up that I have posted the libweston input-timestamps patchset > >> for review at: > >> > >> h