Re: [PATCH wayland 2/3] scanner: Allow adding a prefix to exported symbols

2018-01-18 Thread Jonas Ådahl
On Thu, Jan 18, 2018 at 10:48:14AM +0200, Pekka Paalanen wrote: > On Wed, 17 Jan 2018 15:43:07 -0600 > Derek Foreman wrote: > > > On 2017-08-18 07:41 AM, Pekka Paalanen wrote: > > > On Fri, 28 Jul 2017 14:06:23 +0100 > > > Emil Velikov wrote: > > > > > >> On 27 July 2017 at 14:01, Pekka Paala

Re: Weston stuff: fractional HiDPI, FreeBSD, Rust

2018-01-18 Thread Daniel Stone
Hi Greg, On 14 December 2017 at 08:21, Pekka Paalanen wrote: > On Thu, 14 Dec 2017 03:05:59 +0300 > Greg V wrote: >> - FreeBSD support: https://github.com/myfreeweb/weston/commit/5827840c8 >> 2b9d0a302d5c54c514ca6f4238e12de > > In theory I'd support this, but I'm sure we'll have some bikesheddin

Re: [PATCH wayland-protocols v2] unstable: Add input-timestamps protocol

2018-01-18 Thread Daniel Stone
Hi, On 18 January 2018 at 14:37, Pekka Paalanen wrote: > On Wed, 20 Dec 2017 16:21:32 +0200 > Alexandros Frantzis wrote: >> a heads-up that I have posted the libweston input-timestamps patchset >> for review at: >> >> https://lists.freedesktop.org/archives/wayland-devel/2017-December/036392.html

Re: [PATCH wayland-protocols v2] unstable: Add input-timestamps protocol

2018-01-18 Thread Pekka Paalanen
On Wed, 20 Dec 2017 16:21:32 +0200 Alexandros Frantzis wrote: > On Tue, Dec 19, 2017 at 01:06:11PM +0200, Alexandros Frantzis wrote: > > On Tue, Dec 19, 2017 at 10:15:06AM +0200, Pekka Paalanen wrote: > > > On Mon, 18 Dec 2017 14:55:00 +0200 > > > Alexandros Frantzis wrote: > > > > > > > wl

Re: [PATCH weston 4/6] libweston: Implement keyboard timestamps for input_timestamps_unstable_v1

2018-01-18 Thread Pekka Paalanen
On Wed, 20 Dec 2017 16:17:59 +0200 Alexandros Frantzis wrote: > Implement the zwp_input_timestamps_v1.get_keyboard_timestamps request to > subscribe to timestamp events for wl_keyboard resources. > > Signed-off-by: Alexandros Frantzis > --- > libweston/compositor.h | 2 ++ > libweston/input.c

Re: [PATCH] xwayland: Explicitly link with xcb-shape

2018-01-18 Thread Daniel Stone
On 18 January 2018 at 12:34, Daniel Stone wrote: > XWM uses xcb-shape as of 332d1892bb, to exclude the shadow from the > input region. However, it does not explicitly link xcb-shape for the new > symbols; on one of my machines this is pulled in as a transient > dependency (masking the issue), but

[PATCH] xwayland: Explicitly link with xcb-shape

2018-01-18 Thread Daniel Stone
XWM uses xcb-shape as of 332d1892bb, to exclude the shadow from the input region. However, it does not explicitly link xcb-shape for the new symbols; on one of my machines this is pulled in as a transient dependency (masking the issue), but apparently not the other. Solve it by explicitly linking

Re: [PATCH weston v4] xwm: Add icon support to the frame

2018-01-18 Thread Daniel Stone
Hi, On 3 December 2017 at 13:32, Emmanuel Gil Peyrot wrote: > On Fri, Dec 01, 2017 at 09:47:57PM +0100, Quentin Glidic wrote: >> I can’t find "width * 4" in the EWMH spec[1], I guess it’s well-known enough >> in this case. Maybe we need to check the Cairo stride matches "width * 4", >> just in ca

Re: [PATCH v14 07/41] compositor-drm: Remove NULL checks in switch_mode

2018-01-18 Thread Daniel Stone
Hi, On 16 January 2018 at 14:34, Pekka Paalanen wrote: > On Wed, 20 Dec 2017 12:26:24 + > Daniel Stone wrote: >> Calling switch_mode with no output or mode never makes any sense. Drop >> the NULL checks. >> >> Signed-off-by: Daniel Stone >> --- >> libweston/compositor-drm.c | 23 +-

Re: [PATCH weston 2/6] tests: Introduce input timestamps helper

2018-01-18 Thread Pekka Paalanen
On Wed, 20 Dec 2017 16:17:57 +0200 Alexandros Frantzis wrote: > Introduce helper test code to implement the client side of the > input_timestamps_unstable_v1 protocol. This helper will be used in > upcoming commits to test the server side implementation of the protocol > in libweston. > > Signed

Re: [PATCH xserver] xwayland: avoid a crash with empty window pixmaps

2018-01-18 Thread Olivier Fourdan
Hi Daniel, On Thu, Jan 18, 2018 at 12:22 PM, Daniel Stone wrote: > Odd; how could we have a realized 0x0 window which also has damage? I > Hehe, yeap, I had the same question, but didn't find the answer... :) > wonder if this isn't actually a UAF where the xwl_window has since > been unrealiz

Re: [PATCH weston 1/6] shared: Add timespec_eq helper function

2018-01-18 Thread Pekka Paalanen
On Wed, 20 Dec 2017 16:17:56 +0200 Alexandros Frantzis wrote: > Add a helper function to check if two struct timespec values are equal. > This helper function will be used in upcoming commits that implement the > input_timestamps_unstable_v1 protocol. > > Signed-off-by: Alexandros Frantzis > --

Re: [PATCH v14 08/41] compositor-drm: Don't repaint if no damage

2018-01-18 Thread Daniel Stone
Hi, On 20 December 2017 at 12:26, Daniel Stone wrote: > If we don't have any damage for the primary plane, then don't force a > repaint; simply reuse the old buffer we already have. Thanks very much to Pekka and Philipp (in particular) for the review, and to those testing as well! I've pushed up

Re: [PATCH weston 1/1] xwayland - input size calculation correction

2018-01-18 Thread Daniel Stone
Hi all, On 23 December 2017 at 01:13, Scott Moreau wrote: > I tested the initial patch and verified it does not fix the scenario I'm > trying, which is with two partially overlapping xcalc windows and hovering > the mouse over the buttons of the one below. > > Ian: > > The patch you submitted fix

Re: [PATCH wayland v4 08/11] client: Replace the singleton zombie with bespoke zombies

2018-01-18 Thread Daniel Stone
Hi all, On 11 January 2018 at 15:44, Daniel Stone wrote: > On 10 January 2018 at 17:47, Simon McVittie wrote: >> I ask because the original authors of libdbus wrote it thinking that >> they had handled OOM conditions, at significant complexity cost, >> then later added infrastructure to simulate

Re: [RFC weston] compositor: Implement runtime output transform changes

2018-01-18 Thread Daniel Stone
Hi Derek, On 17 January 2018 at 20:25, Derek Foreman wrote: > Some of the above looks like it could maybe be refactored and shared with > weston_output_move? > > Otherwise this looks fine to me: > > Reviewed-by: Derek Foreman Thanks for checking this out! > Daniel, you singled this out for rev

Re: [PATCH] linux-dmabuf: send deprecated format events

2018-01-18 Thread Daniel Stone
Hi Philipp, On 16 January 2018 at 10:09, Philipp Zabel wrote: > On Fri, 2017-12-15 at 09:46 +, Daniel Stone wrote: >> Thanks for this! Could I please persuade you to take on one additional >> change though? > > Pending review of the additional change, could we merge the first patch > independ

Re: [PATCH xserver] xwayland: avoid a crash with empty window pixmaps

2018-01-18 Thread Daniel Stone
Hi Olivier, On 18 January 2018 at 10:41, Olivier Fourdan wrote: > This is a rare occurrence of a crash in Xwayland for which I don't have > the reproducing steps, just a core file. > > The backtrace looks as follow: > > [...] > #6 > #7 xwl_glamor_pixmap_get_wl_buffer () at xwayland-glamo

Re: [PATCH v4] compositor-drm: Add the aspect ratio parsing support

2018-01-18 Thread ankit.k.nauti...@intel.com
Hi Pekka, Apologize for the late reply, as I was on vacation. Thanks for reviewing the patch and ACK by tag. Trying to get the necessary changes in DRM layer, patches are under review. I'll keep the style comments in mind while sending the next patch-set. Please find my comments in-line: On

Re: [PATCH v3 weston 0/4] GLES3 context support

2018-01-18 Thread Daniel Stone
Hi Derek, On 17 January 2018 at 19:59, Derek Foreman wrote: > On 2018-01-17 12:36 PM, Arnaud Vrac wrote: >> Here's the latest version of the patches to support a GLES3 context. >> >> Changes since v2 include: >> * add warning: prefix in the log message when GLES version cannot be >> determined

[PATCH xserver] xwayland: avoid a crash with empty window pixmaps

2018-01-18 Thread Olivier Fourdan
This is a rare occurrence of a crash in Xwayland for which I don't have the reproducing steps, just a core file. The backtrace looks as follow: #0 raise () from /usr/lib64/libc.so.6 #1 abort () from /usr/lib64/libc.so.6 #2 OsAbort () at utils.c:1361 #3 AbortServer () at log.c:877 #4

Re: [PATCH wayland 2/3] scanner: Allow adding a prefix to exported symbols

2018-01-18 Thread Pekka Paalanen
On Wed, 17 Jan 2018 15:43:07 -0600 Derek Foreman wrote: > On 2017-08-18 07:41 AM, Pekka Paalanen wrote: > > On Fri, 28 Jul 2017 14:06:23 +0100 > > Emil Velikov wrote: > > > >> On 27 July 2017 at 14:01, Pekka Paalanen wrote: > >>> On Wed, 26 Jul 2017 16:09:32 +0100 > >>> Emil Velikov wrote

RE: [PATCH v2] server: add log message when client connection is destroyed due to an error

2018-01-18 Thread Fiedler, Mathias
Hi, > -Original Message- > From: Derek Foreman [mailto:der...@osg.samsung.com] > Sent: Mittwoch, 17. Januar 2018 21:41 > To: Fiedler, Mathias; wayland-devel@lists.freedesktop.org > Subject: Re: [PATCH v2] server: add log message when client connection is > destroyed due to an error > > On

Re: [PATCH wayland 2/3] scanner: Allow adding a prefix to exported symbols

2018-01-18 Thread Derek Foreman
On 2017-08-18 07:41 AM, Pekka Paalanen wrote: On Fri, 28 Jul 2017 14:06:23 +0100 Emil Velikov wrote: On 27 July 2017 at 14:01, Pekka Paalanen wrote: On Wed, 26 Jul 2017 16:09:32 +0100 Emil Velikov wrote: On 25 July 2017 at 10:24, Pekka Paalanen wrote: On Tue, 25 Jul 2017 15:25:58 +080

Re: [PATCH libinput 1/2] touchpad: make the edge-scroll edge 7mm wide

2018-01-18 Thread Peter Hutterer
On Wed, Jan 17, 2018 at 01:21:52PM +0100, Alexander Karlstad wrote: > On 17. jan. 2018 13:02, Peter Hutterer wrote: > > there's no configuration option for it, it's hard-coded. 7mm should be > > enough for the average finger - why do you need to change it? > > If I'm not mistaken, it what sets the

Re: [PATCH v2] server: add log message when client connection is destroyed due to an error

2018-01-18 Thread Derek Foreman
On 2017-12-05 02:49 AM, Mathias Fiedler wrote: The client connection is destroyed by the server in several circumstances. This patch adds log messages in case the connection is destroyed due to an error other than normal hangup. Signed-off-by: Mathias Fiedler This looks good to me. I can see

Re: [RFC weston] compositor: Implement runtime output transform changes

2018-01-18 Thread Derek Foreman
On 2017-06-26 06:23 AM, Ilia Bozhinov wrote: From: Ilia Bozhinov Up to now we could set the transform only on output initialization. However, on certain situations(like tablets and convertible laptops), screen orientation can change while the compositor is running and thus the need for change o

Re: Planning for another Wayland release

2018-01-18 Thread Derek Foreman
On 2018-01-16 04:10 PM, Daniel Stone wrote: Hey Bryce, On 12 January 2018 at 22:51, Derek Foreman wrote: On 2018-01-12 04:00 AM, Daniel Stone wrote: I did a clearout of the review queue last month, but that's not yet complete, and I'd like someone to have a more structured look at the queue (

Re: [PATCH v3 weston 0/4] GLES3 context support

2018-01-18 Thread Derek Foreman
On 2018-01-17 12:36 PM, Arnaud Vrac wrote: Hi all, Here's the latest version of the patches to support a GLES3 context. Changes since v2 include: * add warning: prefix in the log message when GLES version cannot be determined * split patch 3 in two, first moving the GL_EXT_texture_rg exten

Re: Planning for another Wayland release

2018-01-18 Thread Arnaud Vrac
On Wed, Jan 17, 2018 at 4:57 PM, Emil Velikov wrote: > On 16 January 2018 at 22:10, Daniel Stone wrote: >> Hey Bryce, >> >> On 12 January 2018 at 22:51, Derek Foreman wrote: >>> On 2018-01-12 04:00 AM, Daniel Stone wrote: I did a clearout of the review queue last month, but that's not yet >