Re: [PATCH v14 09/41] compositor-drm: Track unused connectors and CRTCs

2018-01-16 Thread Pekka Paalanen
On Tue, 16 Jan 2018 16:40:47 + Daniel Stone wrote: > Hi Pekka, > > On 16 January 2018 at 15:19, Pekka Paalanen wrote: > > On Wed, 20 Dec 2017 12:26:26 + > > Daniel Stone wrote: > >> Rather than a more piecemeal approach at backend creation, explicitly > >> track connectors and CRTCs

Re: [PATCH v14 06/41] compositor-drm: Use drm_plane for scanout plane

2018-01-16 Thread Pekka Paalanen
On Tue, 16 Jan 2018 15:42:25 + Daniel Stone wrote: > Hi, > > On 16 January 2018 at 14:30, Pekka Paalanen wrote: > > On Wed, 20 Dec 2017 12:26:23 + > > Daniel Stone wrote: > >> @@ -3355,6 +3398,19 @@ drm_output_init_egl(struct drm_output *output, > >> struct drm_backend *b) > >> sta

Re: [PATCH v14 05/41] compositor-drm: Use drm_plane for cursor plane

2018-01-16 Thread Pekka Paalanen
On Tue, 16 Jan 2018 15:39:00 + Daniel Stone wrote: > Hi, > > On 16 January 2018 at 08:25, Pekka Paalanen wrote: > > On Wed, 20 Dec 2017 12:26:22 + > > Daniel Stone wrote: > >> + switch (type) { > >> + case WDRM_PLANE_TYPE_CURSOR: > >> + for

Re: Planning for another Wayland release

2018-01-16 Thread Daniel Stone
Hey Bryce, On 12 January 2018 at 22:51, Derek Foreman wrote: > On 2018-01-12 04:00 AM, Daniel Stone wrote: >> I did a clearout of the review queue last month, but that's not yet >> complete, and I'd like someone to have a more structured look at the >> queue (or just to look at all ...) to find s

Re: Planning for another Wayland release

2018-01-16 Thread Daniel Stone
Hi Bryce, On 12 January 2018 at 18:26, Bryce Harrington wrote: > On Fri, Jan 12, 2018 at 10:00:57AM +, Daniel Stone wrote: >> Given how much we could potentially be landing, I think we would need >> someone more actively involved (patch-herding, review, testing, >> list/IRC discussion) to han

Re: [PATCH v14 09/41] compositor-drm: Track unused connectors and CRTCs

2018-01-16 Thread Daniel Stone
Hi Pekka, On 16 January 2018 at 15:19, Pekka Paalanen wrote: > On Wed, 20 Dec 2017 12:26:26 + > Daniel Stone wrote: >> Rather than a more piecemeal approach at backend creation, explicitly >> track connectors and CRTCs we do not intend to use, so we can ensure >> they are disabled where appr

Re: [PATCH v14 06/41] compositor-drm: Use drm_plane for scanout plane

2018-01-16 Thread Daniel Stone
Hi, On 16 January 2018 at 14:30, Pekka Paalanen wrote: > On Wed, 20 Dec 2017 12:26:23 + > Daniel Stone wrote: >> @@ -3355,6 +3398,19 @@ drm_output_init_egl(struct drm_output *output, struct >> drm_backend *b) >> static void >> drm_output_fini_egl(struct drm_output *output) >> { >> +

Re: [PATCH v14 05/41] compositor-drm: Use drm_plane for cursor plane

2018-01-16 Thread Daniel Stone
Hi, On 16 January 2018 at 08:25, Pekka Paalanen wrote: > On Wed, 20 Dec 2017 12:26:22 + > Daniel Stone wrote: >> + switch (type) { >> + case WDRM_PLANE_TYPE_CURSOR: >> + format = GBM_FORMAT_ARGB; >> + break; >> +

Re: [PATCH v14 01/41] compositor-drm: Add shutting_down flag

2018-01-16 Thread Pekka Paalanen
On Tue, 16 Jan 2018 15:18:28 + Daniel Stone wrote: > Hi Pekka, > > On 15 January 2018 at 15:05, Pekka Paalanen wrote: > > this patch is both trivial and lacking any rationale on why it was > > written, with obviously no impact on its own. Would be nice for > > posterity to have some explana

Re: [PATCH v14 01/41] compositor-drm: Add shutting_down flag

2018-01-16 Thread Daniel Stone
Hi Pekka, On 15 January 2018 at 15:05, Pekka Paalanen wrote: > this patch is both trivial and lacking any rationale on why it was > written, with obviously no impact on its own. Would be nice for > posterity to have some explanation on the why. I assume it was > something subtle or annoying. > >

Re: [PATCH v14 09/41] compositor-drm: Track unused connectors and CRTCs

2018-01-16 Thread Pekka Paalanen
On Wed, 20 Dec 2017 12:26:26 + Daniel Stone wrote: > Rather than a more piecemeal approach at backend creation, explicitly > track connectors and CRTCs we do not intend to use, so we can ensure > they are disabled where appropriate. > > Signed-off-by: Daniel Stone > --- > libweston/composi

Re: [PATCH v14 07/41] compositor-drm: Remove NULL checks in switch_mode

2018-01-16 Thread Pekka Paalanen
On Wed, 20 Dec 2017 12:26:24 + Daniel Stone wrote: > Calling switch_mode with no output or mode never makes any sense. Drop > the NULL checks. > > Signed-off-by: Daniel Stone > --- > libweston/compositor-drm.c | 23 +-- > 1 file changed, 5 insertions(+), 18 deletions(-)

Re: [PATCH v14 06/41] compositor-drm: Use drm_plane for scanout plane

2018-01-16 Thread Pekka Paalanen
On Wed, 20 Dec 2017 12:26:23 + Daniel Stone wrote: > Use a real drm_plane to back the scanout plane, displacing > output->fb_{last,cur,pending} to their plane-tracked equivalents. > > Signed-off-by: Daniel Stone > --- > libweston/compositor-drm.c | 222 > ++

Re: [PATCH] linux-dmabuf: send deprecated format events

2018-01-16 Thread Philipp Zabel
On Fri, 2017-12-15 at 09:46 +, Daniel Stone wrote: > Hi Michael and Philipp, > > On 15 December 2017 at 09:25, Philipp Zabel wrote: > > Although the format event is deprecated, some clients, especially the > > GStreamer waylandsink, only support zwp_linux_dmabuf_v1 version 1 and > > require t

Re: [PATCH v14 05/41] compositor-drm: Use drm_plane for cursor plane

2018-01-16 Thread Pekka Paalanen
On Wed, 20 Dec 2017 12:26:22 + Daniel Stone wrote: > Change the type of cursor_plane from a weston_plane (base tracking > structure) to a drm_plane (wrapper containing additional DRM-specific > details), and make it a dynamically-allocated pointer. > > Using the standard drm_plane allows us