Re: [PATCH wayland-protocols v2] unstable: Add input-timestamps protocol

2017-12-19 Thread Alexandros Frantzis
On Tue, Dec 19, 2017 at 10:15:06AM +0200, Pekka Paalanen wrote: > On Mon, 18 Dec 2017 14:55:00 +0200 > Alexandros Frantzis wrote: > > > wl_pointer, wl_keyboard and wl_touch events currently use a 32-bit > > timestamp with millisecond resolution. In some cases, notably latency > > measurements, th

[PATCH weston v3 13/17] tablet: Remove tablet-specific tools on disconnect

2017-12-19 Thread Maniraj Devadoss
From: Lyude Paul Store all tablets that a tool was used on in a list. When the tablet is removed, remove all tools only seen on this tablet. Tools without a serial number are only ever bound to one tablet. Co-authored-by: Peter Hutterer Signed-off-by: Lyude Paul Signed-off-by: Peter Hutterer

[PATCH weston v3 16/17] tablet: reordered changes in weston_seat struct to not break ABI compatibility

2017-12-19 Thread Maniraj Devadoss
From: Bastian Farkas Signed-off-by: Bastian Farkas --- libweston/compositor.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libweston/compositor.h b/libweston/compositor.h index fb59615..3246ff4 100644 --- a/libweston/compositor.h +++ b/libweston/compositor.h @@ -721,8

[PATCH weston v3 14/17] tablet: Fixed compilation errors resulting from tablet patches.

2017-12-19 Thread Maniraj Devadoss
From: Bastian Farkas Member names of struct weston_surfece were changed from configure to committed. Signed-off-by: Bastian Farkas --- libweston/input.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libweston/input.c b/libweston/input.c index d8251b1..778aabd

[PATCH weston v3 17/17] tablet: set the tablet tool surface and view as mapped

2017-12-19 Thread Maniraj Devadoss
The tablet tool's surface and view has to be set as mapped in tablet_tool_cursor_surface_configure API otherwise the same view can be added more than once to the cursor layer list when set_cursor is called by the client. This will lead to corruption of cursor layer list. And the tablet tool's surf

[PATCH weston v3 15/17] tablet: Fixing compilation issues in weston desktop-shell related to tablet support patches.

2017-12-19 Thread Maniraj Devadoss
From: Bastian Farkas Function names and structs changed. Signed-off-by: Bastian Farkas --- desktop-shell/shell.c | 28 ++-- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index 54ee4a2..1dae736 100644 --- a/

[PATCH weston v3 06/17] clients: add support for handling tablets

2017-12-19 Thread Maniraj Devadoss
From: Lyude Paul Co-authored-by: Peter Hutterer Signed-off-by: Lyude Paul Signed-off-by: Peter Hutterer Reviewed-by: Jonas Ådahl with one comment inlined Signed-off-by: Bastian Farkas --- clients/window.c | 498 +++ clients/window.h | 88

[PATCH weston v3 12/17] tablet: Add demo application for tablets

2017-12-19 Thread Maniraj Devadoss
From: Lyude Paul Note that this application does not follow best practices for handling tablet events. The events are grouped by frame, all processing should be done in the frame instead of the respective handler. A good toolkit would accumulate the data in the events and provide them as one eve

[PATCH weston v3 08/17] client: Add support for tablet cursor motion to window frames in libtoytoolkit

2017-12-19 Thread Maniraj Devadoss
From: Lyude Paul When it comes to a window frame, a tablet tool and cursor act almost identical; they click things, drag things, etc. The tool type and extra axes don't serve any use in the context of a window frame, so tablet pointers share the frame_pointer structures used for the mouse pointer

[PATCH weston v3 10/17] tablet: Add tablet support to the top panel of the desktop shell

2017-12-19 Thread Maniraj Devadoss
From: Lyude Paul Co-authored-by: Peter Hutterer Signed-off-by: Lyude Paul Signed-off-by: Peter Hutterer Signed-off-by: Bastian Farkas --- clients/desktop-shell.c | 56 + 1 file changed, 56 insertions(+) diff --git a/clients/desktop-shell.c b/c

[PATCH weston v3 11/17] tablet: Add binding to activate surfaces using the tablet tool

2017-12-19 Thread Maniraj Devadoss
From: Lyude Paul Co-authored-by: Peter Hutterer Signed-off-by: Lyude Paul Signed-off-by: Peter Hutterer Signed-off-by: Bastian Farkas --- desktop-shell/shell.c | 14 ++ libweston/bindings.c | 39 ++- libweston/compositor.c | 1 + libweston/

[PATCH weston v3 07/17] client: Add tablet cursor support into libtoytoolkit

2017-12-19 Thread Maniraj Devadoss
From: Lyude Paul Again, a lot of this is code that has been reused from the cursor code for pointers. Co-authored-by: Peter Hutterer Signed-off-by: Lyude Paul Signed-off-by: Peter Hutterer Reviewed-by: Jonas Ådahl Signed-off-by: Bastian Farkas --- clients/window.c | 138 +++

[PATCH weston v3 09/17] tablet: Add support for moving windows around using the stylus

2017-12-19 Thread Maniraj Devadoss
From: Lyude Paul Changing the pointer to the appropriate image while moving the stylus around isn't supported yet. Co-authored-by: Peter Hutterer Signed-off-by: Lyude Paul Signed-off-by: Peter Hutterer Signed-off-by: Bastian Farkas --- clients/window.c | 33 ++ desktop-shell/shel

[PATCH weston v3 05/17] tablet: handle tablet cursors in the compositor

2017-12-19 Thread Maniraj Devadoss
From: Lyude Paul The tablet is given a separate cursor. Most tablet interaction is an absolute interaction and shouldn't need a cursor at all, but usually the cursor is used to indicate the type of virtual tool currently assigned. Co-authored-by: Peter Hutterer Signed-off-by: Lyude Paul Signed

[PATCH weston v3 03/17] tablet: add weston grab interfaces for tablet tools

2017-12-19 Thread Maniraj Devadoss
From: Lyude Paul Co-authored-by: Peter Hutterer Signed-off-by: Lyude Paul Signed-off-by: Peter Hutterer Signed-off-by: Bastian Farkas --- libweston/compositor.h | 53 +++ libweston/input.c | 253 + 2 files changed, 306 insertions(

[PATCH weston v3 01/17] tablet: Add initial tablet support to weston

2017-12-19 Thread Maniraj Devadoss
From: Lyude Paul Introduces two new structs, weston_tablet and weston_tablet_tool with the respective information as it's used on the protocol. Note that tools are independent of tablets, many tools can be used across multiple tablets. The nesting on the protocol level requires a global tablet

[PATCH weston v3 04/17] tablet: hook up libinput tablet events

2017-12-19 Thread Maniraj Devadoss
From: Lyude Paul Co-authored-by: Peter Hutterer Signed-off-by: Lyude Paul Signed-off-by: Peter Hutterer Reviewed-by: Jonas Ådahl with one nit below. Signed-off-by: Bastian Farkas --- libweston/libinput-device.c | 120 1 file changed, 120 insertio

[PATCH weston v3 00/17] Tablet device support for weston

2017-12-19 Thread Maniraj Devadoss
Hi Jason, I found the root cause for the backtrace you shared https://lists.freedesktop.org/archives/wayland-devel/2017-November/035964.html The issue is that the tablet tool's surface and view is not set as mapped in tablet_tool_cursor_surface_configure API, so the same view can be added more th

[PATCH weston v3 02/17] tablet: add handling of tablet focus

2017-12-19 Thread Maniraj Devadoss
From: Lyude Paul Closely modelled after the pointer focus handling Co-authored-by: Peter Hutterer Signed-off-by: Lyude Paul Signed-off-by: Peter Hutterer Signed-off-by: Bastian Farkas --- libweston/compositor.h | 10 ++ libweston/input.c | 92 +++

Re: [PATCH wayland-protocols v2] unstable: Add input-timestamps protocol

2017-12-19 Thread Pekka Paalanen
On Mon, 18 Dec 2017 14:55:00 +0200 Alexandros Frantzis wrote: > wl_pointer, wl_keyboard and wl_touch events currently use a 32-bit > timestamp with millisecond resolution. In some cases, notably latency > measurements, this resolution is too coarse to be useful. > > This protocol provides additi

Re: [PATCH weston] configure: fix sys/sysmacros.h check

2017-12-19 Thread Pekka Paalanen
On Mon, 18 Dec 2017 14:11:48 + Daniel Stone wrote: > Hi, > > On 18 December 2017 at 08:24, Pekka Paalanen wrote: > > This patch is a copy of > > https://cgit.freedesktop.org/mesa/drm/commit/?id=7040fea0280bad527ed4b3d5eee7d7bfbf303efc > > by Adam Jackson. > > > > Commit 43c5a65b034a243700cf