Re: [PATCH libinput 0/1] Fix debouncing algorithm

2017-11-01 Thread Peter Hutterer
On Thu, Nov 02, 2017 at 12:34:01AM +0100, Vicente Bergas wrote: > Hi Peter, > > >Hi Vicente > > > >sorry about the delay, too many things on right now. > > Thank you for taking the time to review the patch. > > >... > >Note: the current algorithm does ignore spurious actions, at least after the

[PATCH libinput 0/1] Fix debouncing algorithm

2017-11-01 Thread Vicente Bergas
Hi Peter, >Hi Vicente > >sorry about the delay, too many things on right now. Thank you for taking the time to review the patch. >... >Note: the current algorithm does ignore spurious actions, at least after the >very first one. AIUI it's not that uncommon either when the contacts are >wobbly. S

[PATCH libinput 1/1] Fix debouncing algorithm

2017-11-01 Thread Vicente Bergas
Bouncing can occur when a button toggles, both press and release, and can bounce multiple times for each toggling. The algorithm has two states: cancel_noise==false and cancel_noise==true. When not canceling noise, the default state, any event received is inmediately committed and state is changed

Enabling Android-style per application user ids

2017-11-01 Thread Matt Hoosier
There has been a surge of recent interest in the details of using Wayland on nontraditional systems that don't have the normal notion of human-user login sessions. Discussions are ongoing about the details of how to manage the allocation of TTYs and Weston's vision of the best practices for assigni

Re: [PATCH weston 3/3] weston-launch: improve help text for -u and -t

2017-11-01 Thread Quentin Glidic
On 11/1/17 3:24 PM, Pekka Paalanen wrote: From: Pekka Paalanen Explain that -u requires root and -t requires -u. Most importantly, document in what format does -t expect the tty to be given. It has been confusing, because Weston's --tty option takes an integer, weston-launch takes a full devic

Re: [PATCH weston 2/3] weston-launch: fix -t option parsing

2017-11-01 Thread Quentin Glidic
On 11/1/17 3:24 PM, Pekka Paalanen wrote: From: Pekka Paalanen Fix an issue introduced in: commit ab4999492ce630e6bb1c93215fc052c2c29913bd Author: Kristian Høgsberg Date: Fri Jul 19 21:26:24 2013 -0700 weston-launch: Drop sleep_fork option where the option string accidentally

Re: [PATCH weston 1/3] weston-launch: quit if -t without -u

2017-11-01 Thread Quentin Glidic
On 11/1/17 3:24 PM, Pekka Paalanen wrote: From: Pekka Paalanen setup_tty() function uses the tty argument for choosing the tty/VT only if wl->new_user (the -u option) is given. If the tty option is given without -u, it will only be used for misleading error messages. To make it clear to the us

Re: [PATCH weston] weston: add wait-for-debugger option

2017-11-01 Thread Quentin Glidic
On 11/1/17 3:23 PM, Pekka Paalanen wrote: From: Pekka Paalanen When you need to start Weston via weston-launch, systemd unit, or any other runner, it is annoying to try to get in with a debugger, especially if the thing you are interested in happens at start-up. To make it easy, a new option is

[PATCH weston 3/3] weston-launch: improve help text for -u and -t

2017-11-01 Thread Pekka Paalanen
From: Pekka Paalanen Explain that -u requires root and -t requires -u. Most importantly, document in what format does -t expect the tty to be given. It has been confusing, because Weston's --tty option takes an integer, weston-launch takes a full device path. Signed-off-by: Pekka Paalanen ---

[PATCH weston 2/3] weston-launch: fix -t option parsing

2017-11-01 Thread Pekka Paalanen
From: Pekka Paalanen Fix an issue introduced in: commit ab4999492ce630e6bb1c93215fc052c2c29913bd Author: Kristian Høgsberg Date: Fri Jul 19 21:26:24 2013 -0700 weston-launch: Drop sleep_fork option where the option string accidentally became "t::". That causes $ weston-lauc

[PATCH weston 1/3] weston-launch: quit if -t without -u

2017-11-01 Thread Pekka Paalanen
From: Pekka Paalanen setup_tty() function uses the tty argument for choosing the tty/VT only if wl->new_user (the -u option) is given. If the tty option is given without -u, it will only be used for misleading error messages. To make it clear to the user that -t without -u does not work the way

[PATCH weston] weston: add wait-for-debugger option

2017-11-01 Thread Pekka Paalanen
From: Pekka Paalanen When you need to start Weston via weston-launch, systemd unit, or any other runner, it is annoying to try to get in with a debugger, especially if the thing you are interested in happens at start-up. To make it easy, a new option is introduced. The new option, implemented bo

Re: [PATCH weston v12 00/40] Atomic modesetting

2017-11-01 Thread Daniel Stone
Hi Emre. On 1 November 2017 at 11:56, Ucan, Emre (ADITG/ESB) wrote: > Is this the latest WIP branch to test " > https://gitlab.collabora.com/daniels/weston/commits/wip/2017-10/atomic-v13"; ? Right you are. > In my opinion, it would easier to review/test your patches if you can > separate them

RE: [PATCH weston v12 00/40] Atomic modesetting

2017-11-01 Thread Ucan, Emre (ADITG/ESB)
Hi Daniel, Is this the latest WIP branch to test " https://gitlab.collabora.com/daniels/weston/commits/wip/2017-10/atomic-v13"; ? In my opinion, it would easier to review/test your patches if you can separate them in multiple patch series. For example, you can send at first up to "compositor-d

Re: Automatically choosing a VT for DRM compositor?

2017-11-01 Thread Pekka Paalanen
On Tue, 31 Oct 2017 08:21:29 -0500 Matt Hoosier wrote: > This discussion seems to hinge on whether logind can be made to work for > Weston as spawned by system units (rather than user-session units). I find > that sd_pid_get_session() has always failed for me (leading to the "logind > not running