Re: [PATCH v2 3/6] launcher-logind: only get a VT on seat0, as only seat0 supports VTs

2017-10-06 Thread Dima Ryazanov
On Tue, Oct 3, 2017 at 7:28 PM, nerdopolis wrote: > As only seat0 supports TTYs, this changes the logind launcher where > it detects a TTY, only if the seat is seat0. This has only been > tested for logind > --- > libweston/launcher-logind.c | 22 -- > libweston/launcher-util

[PATCH weston 2/2] desktop-shell: Handle the fullscreen to maximized case safely

2017-10-06 Thread Derek Foreman
When a client transitions from maximized to fullscreen to maximized (run weston-terminal, maximize it, hit f11 twice) we're sending size 0,0 for the unfullscreen configure, which still has maximized set. This results in clients correctly picking any size they like, and weston disconnecting them fo

[PATCH weston 1/2] desktop-shell: refactor maximized size calculation into its own function

2017-10-06 Thread Derek Foreman
We need to calculate maximized size to resolve a bug with unsetting fullscreen, might as well share the code. Signed-off-by: Derek Foreman --- desktop-shell/shell.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/desktop-shell/shell.c b/desktop-shell/sh

Re: [PATCH weston] gl-renderer: Set pitch correctly for subsampled textures

2017-10-06 Thread Daniel Stone
Hi Pekka, On 6 October 2017 at 08:41, Pekka Paalanen wrote: > I feel the commit message needs more rationale on why this is the > correct fix before I can give a R-b. Fair enough. > How confident are we that waylandsink and the others (which?) are > correct and did not have an unintended code c

Re: [PATCH weston] gl-renderer: Set pitch correctly for subsampled textures

2017-10-06 Thread Pekka Paalanen
On Thu, 5 Oct 2017 15:36:08 +0100 Daniel Stone wrote: > Multi-plane sub-sampled textures have partial width/height, e.g. > YUV420/I420 has a full-size Y plane, followed by a half-width/height U > plane, and a half-width/height V plane. > > zwp_linux_dmabuf_v1 allows clients to pass an explicit