Re: [PATCH weston v4] buildsystem: add missing pkg-config stub for libweston uninstalled

2017-10-05 Thread Reynaldo H. Verdejo Pinochet
Changes from v3: Correctly require libweston-uninstalled for libweston-desktop-uninstalled Rebased on top of today's master Changes from v2: Change the commit log to explain what these files are for Changes from v1: Don't put the version # in the -uninstalled.pc name add libweston-desktop-unins

[PATCH weston] gl-renderer: Set pitch correctly for subsampled textures

2017-10-05 Thread Daniel Stone
Multi-plane sub-sampled textures have partial width/height, e.g. YUV420/I420 has a full-size Y plane, followed by a half-width/height U plane, and a half-width/height V plane. zwp_linux_dmabuf_v1 allows clients to pass an explicit pitch for each plane, but for wl_shm this must be inferred. gl-rend

Re: [PATCH v2] compositor-drm: Add the aspect ratio parsing support

2017-10-05 Thread Pekka Paalanen
On Thu, 5 Oct 2017 16:28:37 +0530 "Nautiyal, Ankit K" wrote: > Hi Pekka, > > Thanks a lot for your review comments and the suggestions, and pointing > out the things I had missed. > > I agree to most of the changes, please find my response inline. > > I will shortly send the next version of t

Re: [RFC wayland 2/9] wayland-egl: correct wayland-egl.pc description/version

2017-10-05 Thread Daniel Stone
Hi, On 5 October 2017 at 13:39, Emil Velikov wrote: > On 29 September 2017 at 14:00, Emil Velikov wrote: >> With the above data in mind, we can reuse the current Wayland version >> AKA WAYLAND_VERSION. >> It should just work for all the known cases, plus it provides >> consistency as a nice bon

Re: [RFC wayland 2/9] wayland-egl: correct wayland-egl.pc description/version

2017-10-05 Thread Emil Velikov
On 29 September 2017 at 14:00, Emil Velikov wrote: > On 15 September 2017 at 11:29, Emil Velikov wrote: >> From: Emil Velikov >> >> Drop the "Mesa" part from the commit message and change the version to >> XXX. The number is based on the following users (and suppliers). >> >> Note: the "users" l

Re: [PATCH v2] compositor-drm: Add the aspect ratio parsing support

2017-10-05 Thread Nautiyal, Ankit K
Hi Pekka, Thanks a lot for your review comments and the suggestions, and pointing out the things I had missed. I agree to most of the changes, please find my response inline. I will shortly send the next version of the patch in a couple of days. On 10/4/2017 2:13 PM, Pekka Paalanen wrote: O

Re: [PATCH weston v12 03/40] [TEST] compositor-drm: Allow disabling universal planes

2017-10-05 Thread Daniel Stone
Hi Emil, On 2 October 2017 at 10:29, Pekka Paalanen wrote: > On Fri, 29 Sep 2017 14:21:02 +0100 > Emil Velikov wrote: >> Just a general idea, please don't bother with it for now: >> >> Normally it's great if one can have clear description of the format >> env. variables expect. >> Quick grep sho

Re: [PATCH weston] gl-renderer: Ignore INVALID modifier

2017-10-05 Thread Daniel Stone
On 5 October 2017 at 08:15, Pekka Paalanen wrote: > On Wed, 4 Oct 2017 18:35:45 +0100 > Daniel Stone wrote: >> If the user has passed an INVALID modifier, it's because there is no >> applicable modifier, and the buffer layout should be determined by a >> magic side-channel call (e.g. bo_get_tili

Re: [PATCH weston] gl-renderer: Ignore INVALID modifier

2017-10-05 Thread Pekka Paalanen
On Wed, 4 Oct 2017 18:35:45 +0100 Daniel Stone wrote: > If the user has passed an INVALID modifier, it's because there is no > applicable modifier, and the buffer layout should be determined by a > magic side-channel call (e.g. bo_get_tiling). If the modifier is > INVALID, don't try to pass it t