Re: [PATCH wayland-protocols v3] protocol: add compositor-debug.xml

2017-10-04 Thread Pekka Paalanen
On Wed, 4 Oct 2017 17:19:56 +0300 Pekka Paalanen wrote: > On Wed, 4 Oct 2017 10:07:30 -0400 > Jonas Ådahl wrote: > > > On Tue, Oct 03, 2017 at 11:45:41AM +0300, Pekka Paalanen wrote: > > > On Fri, 22 Sep 2017 11:17:49 +0200 > > > Maniraj Devadoss wrote: > > > > > > > From: Pekka Paalane

[PATCH weston] gl-renderer: Ignore INVALID modifier

2017-10-04 Thread Daniel Stone
If the user has passed an INVALID modifier, it's because there is no applicable modifier, and the buffer layout should be determined by a magic side-channel call (e.g. bo_get_tiling). If the modifier is INVALID, don't try to pass it through to EGL, but just drop it. On the other hand, if a modifie

Re: [PATCH wayland-protocols v3] protocol: add compositor-debug.xml

2017-10-04 Thread Pekka Paalanen
On Wed, 4 Oct 2017 10:07:30 -0400 Jonas Ådahl wrote: > On Tue, Oct 03, 2017 at 11:45:41AM +0300, Pekka Paalanen wrote: > > On Fri, 22 Sep 2017 11:17:49 +0200 > > Maniraj Devadoss wrote: > > > > > From: Pekka Paalanen > > > > > > This is a new debugging extension for non-production environme

Re: [PATCH wayland-protocols v3] protocol: add compositor-debug.xml

2017-10-04 Thread Jonas Ådahl
On Tue, Oct 03, 2017 at 11:45:41AM +0300, Pekka Paalanen wrote: > On Fri, 22 Sep 2017 11:17:49 +0200 > Maniraj Devadoss wrote: > > > From: Pekka Paalanen > > > > This is a new debugging extension for non-production environments. The > > aim is to replace all build-time choosable debug prints in

Re: [PATCH weston 00/21] Fixes and reorganization, clone mode prep

2017-10-04 Thread Pekka Paalanen
On Wed, 4 Oct 2017 13:52:32 +0100 Daniel Stone wrote: > Hi Pekka, > > On 22 September 2017 at 15:31, Pekka Paalanen wrote: > > I have been working towards clone mode[1] and thought it would be a time to > > shorten my patch series. This series here is a selection of patches from my > > clone mo

Re: [PATCH weston 05/21] libweston: weston_output_init(..., +name)

2017-10-04 Thread Pekka Paalanen
On Wed, 4 Oct 2017 13:47:56 +0100 Daniel Stone wrote: > Hi Pekka, > > On 22 September 2017 at 15:31, Pekka Paalanen wrote: > > * > > * \param output The weston_output object to initialize > > * \param compositor The compositor instance. > > + * \param name Name for the output.

Re: [PATCH weston 00/21] Fixes and reorganization, clone mode prep

2017-10-04 Thread Daniel Stone
Hi Pekka, On 22 September 2017 at 15:31, Pekka Paalanen wrote: > I have been working towards clone mode[1] and thought it would be a time to > shorten my patch series. This series here is a selection of patches from my > clone mode preparations. > > It's a colorful bunch. There are refactorings,

Re: [PATCH weston 05/21] libweston: weston_output_init(..., +name)

2017-10-04 Thread Daniel Stone
Hi Pekka, On 22 September 2017 at 15:31, Pekka Paalanen wrote: > * > * \param output The weston_output object to initialize > * \param compositor The compositor instance. > + * \param name Name for the output. Please document that @name is duplicated internally, i.e. reference bo

Re: [PATCH weston 15/21] compositor-fbdev: simplify FB destroy/unmap/disable

2017-10-04 Thread Pekka Paalanen
On Tue, 26 Sep 2017 06:24:56 + "Ray, Ian (GE Healthcare)" wrote: > On 22/09/2017, 17.33, "wayland-devel on behalf of Pekka Paalanen" > ppaala...@gmail.com> wrote: > > > > From: Pekka Paalanen > > > > Rename fbdev_frame_buffer_destroy() to fbdev_frame_buffer_unmap() > > because that is wh

Re: [PATCH weston 01/21] libweston: move weston_output::mode_list init to core

2017-10-04 Thread Pekka Paalanen
On Tue, 26 Sep 2017 06:30:16 + "Ray, Ian (GE Healthcare)" wrote: > On 22/09/2017, 17.32, "wayland-devel on behalf of Pekka Paalanen" > ppaala...@gmail.com> wrote: > > > > From: Pekka Paalanen > > > > Initialize the list in weston_output_init() instead of doing it > > separately in each b

Re: [PATCH weston v12 15/40] compositor-drm: Atomic modesetting support

2017-10-04 Thread Pekka Paalanen
On Tue, 26 Sep 2017 18:15:48 +0100 Daniel Stone wrote: > Add support for using the atomic-modesetting API to apply output state. > Unlike previous series, this commit does not unflip sprites_are_broken, > until further work has been done with assign_planes to make it reliable. > > Signed-off-by:

Re: [PATCH weston v12 16/40] compositor-drm: Allow disabling atomic

2017-10-04 Thread Pekka Paalanen
On Tue, 26 Sep 2017 18:15:49 +0100 Daniel Stone wrote: > Add a test environment variable to allow disabling atomic modesetting. > > Signed-off-by: Daniel Stone > --- > libweston/compositor-drm.c | 12 +++- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/libweston/co

Re: [PATCH weston v12 14/40] compositor-drm: Add to_drm_mode helper

2017-10-04 Thread Pekka Paalanen
On Tue, 26 Sep 2017 18:15:47 +0100 Daniel Stone wrote: > Much like we already have to_drm_output and to_drm_backend. > > Signed-off-by: Daniel Stone > --- > libweston/compositor-drm.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/libweston/compositor-drm.c b/

Re: [PATCH weston v12 13/40] compositor-drm: Add blob_id member to drm_mode

2017-10-04 Thread Pekka Paalanen
On Tue, 26 Sep 2017 18:15:46 +0100 Daniel Stone wrote: > For atomic modesetting support, the mode is identified by a blob > property ID, rather than being passed inline. Add a blob_id member to > drm_mode to handle this, including refactoring mode destruction into a > helper function. > > Signed

Re: [PATCH weston v12 12/40] compositor-drm: Discover atomic properties

2017-10-04 Thread Pekka Paalanen
On Tue, 26 Sep 2017 18:15:45 +0100 Daniel Stone wrote: > From: Pekka Paalanen > > Set the atomic client cap, where it exists, and use this to discover the > plane/CRTC/connector properties we require for atomic modesetting. > > Signed-off-by: Daniel Stone > Co-authored-by: Pekka Paalanen > -

Re: [PATCH weston v12 11/40] compositor-drm: Don't restore original CRTC mode

2017-10-04 Thread Pekka Paalanen
On Tue, 26 Sep 2017 18:15:44 +0100 Daniel Stone wrote: > When leaving Weston, don't attempt to restore the previous CRTC > settings. The framebuffer may well have disappeared, and in every > likelihood, whoever gets the KMS device afterwards will be repainting > anyway. > > Signed-off-by: Daniel

Re: [PATCH v2] compositor-drm: Add the aspect ratio parsing support

2017-10-04 Thread Pekka Paalanen
On Wed, 20 Sep 2017 17:33:00 +0530 Nautiyal Ankit wrote: > From: Ankit Nautiyal > > DRM layer populates aspect ratio information for CEA video modes, > but we lose it while parsing modeline (Aspect ratio patch series > in drm layer: https://patchwork.freedesktop.org/series/10850). > The flag bi