Re: [PATCH weston] libweston-desktop/xdg-shell: Properly properly handle ack_configure

2017-07-26 Thread Derek Foreman
On 2017-07-26 03:32 PM, Quentin Glidic wrote: On 7/26/17 9:39 PM, Derek Foreman wrote: commit 749637a8a306588964885fe6b25fda6087a84ccd introduced this feature, but the break is outside of any conditional so only the first item in the list is ever tested. If a client skips a few configures and t

Re: [PATCH weston] input: Stop leaking libinput event source on session deactivation

2017-07-26 Thread Peter Hutterer
On Tue, Jul 25, 2017 at 04:49:52PM -0500, Derek Foreman wrote: > On 2017-07-25 04:39 PM, Derek Foreman wrote: > > This is easily noticed as a leaked fd on every VC switch. > > > > Signed-off-by: Derek Foreman > > --- > > libweston/libinput-seat.c | 5 - > > 1 file changed, 4 insertions(+),

Re: [PATCH weston] libweston-desktop/xdg-shell: Properly properly handle ack_configure

2017-07-26 Thread Quentin Glidic
On 7/26/17 9:39 PM, Derek Foreman wrote: commit 749637a8a306588964885fe6b25fda6087a84ccd introduced this feature, but the break is outside of any conditional so only the first item in the list is ever tested. If a client skips a few configures and then acks the most recent it's still operating w

[PATCH weston] libweston-desktop/xdg-shell: Properly properly handle ack_configure

2017-07-26 Thread Derek Foreman
commit 749637a8a306588964885fe6b25fda6087a84ccd introduced this feature, but the break is outside of any conditional so only the first item in the list is ever tested. If a client skips a few configures and then acks the most recent it's still operating within spec, so the break should only occur

Re: [PATCH wayland 2/3] scanner: Allow adding a prefix to exported symbols

2017-07-26 Thread Emil Velikov
On 25 July 2017 at 10:24, Pekka Paalanen wrote: > On Tue, 25 Jul 2017 15:25:58 +0800 > Jonas Ådahl wrote: > >> On Mon, Jul 24, 2017 at 02:16:04PM +0300, Pekka Paalanen wrote: >> > On Mon, 3 Jul 2017 17:16:45 +0800 >> > Jonas Ådahl wrote: >> > >> > > Two different protocols may use interfaces wi

Re: [PATCH weston] logind: actually close fd in launcher_logind_close

2017-07-26 Thread Pekka Paalanen
On Tue, 25 Jul 2017 16:17:36 -0500 Derek Foreman wrote: > We still need to close fds passed to us - or we leak quite a few fds > on VC switch. > > Regression, originally fixed in 8f5acc2f3a29c3831af4ddd6bed57f703c98dc77 > and re-broken in commit 72dea06d7952e3ce8dd8057f7106186da4fa2678 > but onl

Re: [PATCH wayland 1/3] Pass input/output files as arguments to wayland-scanner

2017-07-26 Thread Emil Velikov
On 3 July 2017 at 10:16, Jonas Ådahl wrote: > When input/output files are passed as arguments to wayland-scanner, > instead of using stdin/stdout, warning and error messages will contain > the file name, together with line number, of the warning/error. Doing > this helps IDEs jump to the correct l

Re: [PATCH] libweston-desktop/xdg-shell: Check window geometry instead of surface size against configured size

2017-07-26 Thread Quentin Glidic
Nit: You should do "git config format.subjectprefix 'PATCH weston'" to your repo, to keep patches linked to Weston. On 7/26/17 2:02 PM, Philipp Kerling wrote: Shell surfaces may have a geometry that is different to the size of their main surface, e.g. due to subcompositing. In states where si

Re Weston with fbdev-backend shows blank screen on display

2017-07-26 Thread saikishore
t. And what is the command line parameters of weston-simple-shm. Thanks Sai -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 833 bytes Desc: OpenPGP digital signature URL:

Re: wayland-devel Digest, Vol 83, Issue 72

2017-07-26 Thread saikishore
d... Name: not available Type: application/pgp-signature Size: 833 bytes Desc: OpenPGP digital signature URL: <https://lists.freedesktop.org/archives/wayland-devel/ attachments/20170726/51ddd8d2/attachment-0001.sig> -- Message: 2 Date: Wed, 26 Jul 2017 16:55:40

[PATCH 5/5] wayland-scanner.mk: default --object-type to static

2017-07-26 Thread Emil Velikov
From: Emil Velikov Unlike the core wayland library, it's recommended that one statically embeds the protocol within their binary. Signed-off-by: Emil Velikov --- wayland-scanner.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/wayland-scanner.mk b/wayland-scanner.mk index

[PATCH 4/5] build: set the scanner --object-type option

2017-07-26 Thread Emil Velikov
From: Emil Velikov Unlike most other scanner users, the core wayland interfaces are public ally available via the libwayland DSO. Signed-off-by: Emil Velikov --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index d0c8bd3..4055d04 100

[PATCH 1/5] scanner: remove unused scanner.mk

2017-07-26 Thread Emil Velikov
From: Emil Velikov Nothing in the existing codebase references the file. Signed-off-by: Emil Velikov --- src/scanner.mk | 8 1 file changed, 8 deletions(-) delete mode 100644 src/scanner.mk diff --git a/src/scanner.mk b/src/scanner.mk deleted file mode 100644 index 1b6963c..000

[PATCH 3/5] scanner: introduce --object-type option

2017-07-26 Thread Emil Velikov
From: Emil Velikov The option is used to indicate how the code will be used - would it be a part of shared or static one. In the former case one needs to export the specific symbols, although normally people want to statically build the protocol code into their project. If the option is missing

[PATCH 2/5] scanner: use tabs for indentation.

2017-07-26 Thread Emil Velikov
From: Emil Velikov File uses tabs, barring the few instances fixed with this patch. Signed-off-by: Emil Velikov --- src/scanner.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/scanner.c b/src/scanner.c index 517068c..c345ed6 100644 --- a/src/scanner.c +++ b/src/

[PATCH 0/5] Allow user to specify how the code is used

2017-07-26 Thread Emil Velikov
Hi all, Here is an alternative version of the "symbol visibility" series by Jonas. It starts with a couple of mildly related cleanups, which are trivial and can be applied irrespective of the rest. Key goals/differences: - use "object type" as opposed to "symbol visibility" Defines the goal, a

Re: [PATCH weston] ivi-shell: Added tests for screen-remove-layer API

2017-07-26 Thread Pekka Paalanen
On Wed, 26 Jul 2017 14:22:49 +0200 Michael Teyfel wrote: > Two cases are tested: success and fail case of the screen-remove-layer API. > > Signed-off-by: Michael Teyfel > --- > tests/ivi_layout-internal-test.c | 69 > > 1 file changed, 69 insertions(+)

Re: Weston with fbdev-backend shows blank screen on display

2017-07-26 Thread Pekka Paalanen
On Wed, 26 Jul 2017 17:24:33 +0530 saikishore wrote: > Hi, > I have ran weston with fbdev-backend on my embedded platform with no input > devices (evdev is not enabled) and the below is log and i see blank screen. > Any advice on this please? it will be great help to me > > > # weston-launch

Re: [PATCH wayland v2 1/4] scanner: Add --visibility flag for setting symbol visibility

2017-07-26 Thread Pekka Paalanen
On Wed, 26 Jul 2017 16:16:33 +0800 Jonas Ådahl wrote: > Add a --visibility flag that enables the user to tweak the visibility > of the symbols generated by wayland-scanner. Three alternatives are > exposed: > > 'export': as has always been done up until now, export the symbols > using WL_EXPORT,

RE: [PATCH weston] ivi-shell: Added tests for screen-remove-layer API

2017-07-26 Thread Teyfel, Michael (ADITG/ESB)
Hi Pekka, thank you for reviewing and also your remarks. I adjusted my patch accordingly and resent it to ML. Best regards Michael Teyfel Engineering Software Base (ADITG/ESB) Tel. +49 5121 49 6932 -Original Message- From: Pekka Paalanen [mailto:ppaala...@gmail.com] Sent: Mittwoch,

[PATCH weston] ivi-shell: Added tests for screen-remove-layer API

2017-07-26 Thread Michael Teyfel
Two cases are tested: success and fail case of the screen-remove-layer API. Signed-off-by: Michael Teyfel --- tests/ivi_layout-internal-test.c | 69 1 file changed, 69 insertions(+) diff --git a/tests/ivi_layout-internal-test.c b/tests/ivi_layout-interna

Re: [PATCH 1/2] scanner: Add --visibility flag for setting symbol visibility

2017-07-26 Thread Emil Velikov
Hi guys, On 25 July 2017 at 11:39, Jonas Ådahl wrote: > Add a --visibility flag that enables the user to tweak the visibility > of the symbols generated by wayland-scanner. Three alternatives are > exposed: > > 'export': as has always been done up until now, export the symbols > using WL_EXPORT,

[PATCH] libweston-desktop/xdg-shell: Check window geometry instead of surface size against configured size

2017-07-26 Thread Philipp Kerling
Shell surfaces may have a geometry that is different to the size of their main surface, e.g. due to subcompositing. In states where size is strictly enforced (fullscreen and maximized), the size that the compositor wants must be checked against the window geometry and not just the main surface siz

Weston with fbdev-backend shows blank screen on display

2017-07-26 Thread saikishore
Hi, I have ran weston with fbdev-backend on my embedded platform with no input devices (evdev is not enabled) and the below is log and i see blank screen. Any advice on this please? it will be great help to me # weston-launch -- --backend=fbdev-backend.so Date: 1970-01-01 UTC [00:00:00.439

Re: [PATCH wayland 2/3] scanner: Allow adding a prefix to exported symbols

2017-07-26 Thread Pekka Paalanen
On Wed, 26 Jul 2017 18:39:52 +0800 Jonas Ådahl wrote: > On Wed, Jul 26, 2017 at 09:28:45AM +0100, Daniel Stone wrote: > > Hi, > > > > On 25 July 2017 at 10:24, Pekka Paalanen wrote: > > > Quentin proposed we add a scanner option > > > --visibility={static|compiler|export}. It would affect al

Re: [PATCH] desktop-shell: Track focused shell surface by main surface

2017-07-26 Thread Quentin Glidic
On 7/26/17 12:02 PM, Philipp Kerling wrote: The focused surface is used for determining whether shell surfaces are activated. They should also be considered activated when a subsurface has focus. Inserting a call to weston_surface_get_main_surface fixes this. seat->focused_surface is only used f

Re: [PATCH wayland 2/3] scanner: Allow adding a prefix to exported symbols

2017-07-26 Thread Jonas Ådahl
On Wed, Jul 26, 2017 at 09:28:45AM +0100, Daniel Stone wrote: > Hi, > > On 25 July 2017 at 10:24, Pekka Paalanen wrote: > > recapping the discussion from IRC, we pretty much agreed that prefixing > > is not a nice solution. Jonas found out that we cannot actually prefix > > everything, because th

[PATCH] desktop-shell: Track focused shell surface by main surface

2017-07-26 Thread Philipp Kerling
The focused surface is used for determining whether shell surfaces are activated. They should also be considered activated when a subsurface has focus. Inserting a call to weston_surface_get_main_surface fixes this. seat->focused_surface is only used for shell_surface keyboard focus tracking. ---

Re: [PATCH 1/2] scanner: Add --visibility flag for setting symbol visibility

2017-07-26 Thread Pekka Paalanen
On Wed, 26 Jul 2017 15:49:57 +0800 Jonas Ådahl wrote: > On Tue, Jul 25, 2017 at 02:44:29PM +0300, Pekka Paalanen wrote: > > On Tue, 25 Jul 2017 18:39:56 +0800 > > Jonas Ådahl wrote: > > > > > Add a --visibility flag that enables the user to tweak the visibility > > > of the symbols generated

Re: [PATCH weston] ivi-shell: Added tests for screen-remove-layer API

2017-07-26 Thread Pekka Paalanen
On Tue, 25 Jul 2017 15:59:06 +0200 Michael Teyfel wrote: > Two cases are tested: success and fail case of the screen-remove-layer API. > > Signed-off-by: Michael Teyfel > --- > tests/ivi_layout-internal-test.c | 62 > > 1 file changed, 62 insertions(+)

Re: [PATCH wayland 2/3] scanner: Allow adding a prefix to exported symbols

2017-07-26 Thread Daniel Stone
Hi, On 25 July 2017 at 10:24, Pekka Paalanen wrote: > recapping the discussion from IRC, we pretty much agreed that prefixing > is not a nice solution. Jonas found out that we cannot actually prefix > everything, because there usually are references to other protocol > things (like you would neve

[PATCH wayland v2 4/4] tests/scanner-test: Add tests for visibility

2017-07-26 Thread Jonas Ådahl
Signed-off-by: Jonas Ådahl --- tests/data/noexport-small-client-core.h | 195 tests/data/noexport-small-code-core.c | 61 ++ tests/data/noexport-small-server-core.h | 154 + tests/data/static-small-client-core.h | 195 +

[PATCH wayland v2 1/4] scanner: Add --visibility flag for setting symbol visibility

2017-07-26 Thread Jonas Ådahl
Add a --visibility flag that enables the user to tweak the visibility of the symbols generated by wayland-scanner. Three alternatives are exposed: 'export': as has always been done up until now, export the symbols using WL_EXPORT, making making them exposed externally. This is the default in order

[PATCH wayland v2 2/4] tests: Test static symbol visibility

2017-07-26 Thread Jonas Ådahl
Test that it is possible to inline the protocol 'code' file generated by wayland-scanner in the source code files using it. Signed-off-by: Jonas Ådahl --- Changes since v1: none. .gitignore| 5 ++ Makefile.am | 32 - tests/data/tiny.xml

[PATCH wayland v2 3/4] tests: Test compiler-default symbol visibility

2017-07-26 Thread Jonas Ådahl
Test that it is possible to not export protocol symbols. Signed-off-by: Jonas Ådahl --- .gitignore | 5 ++ Makefile.am | 27 ++- tests/noexport-symbol-test-client.c | 77 +++ tests/noexport-symbol-test-server.c | 146 ++

[PATCH v5] Add xdg-output protocol

2017-07-26 Thread Olivier Fourdan
This protocol aims at describing outputs in way which is more in line with the concept of an output on desktop oriented systems. Some information are more specific to the concept of an output for a desktop oriented system and may not make sense in other applications, such as IVI systems for exampl

Re: [PATCH 1/2] scanner: Add --visibility flag for setting symbol visibility

2017-07-26 Thread Jonas Ådahl
On Tue, Jul 25, 2017 at 02:44:29PM +0300, Pekka Paalanen wrote: > On Tue, 25 Jul 2017 18:39:56 +0800 > Jonas Ådahl wrote: > > > Add a --visibility flag that enables the user to tweak the visibility > > of the symbols generated by wayland-scanner. Three alternatives are > > exposed: > > > > 'expo