Re: [PATCH libinput] touchpad: pull the tap exclusion zone down to the full edge zone

2017-05-09 Thread Hans de Goede
Hi, On 10-05-17 04:21, Peter Hutterer wrote: This was originally left outside of the button areas in case users tap in those zones, but we're getting false tap events in that zone. On a 100mm touchpad, the edge zone is merely 5mm, it's acceptable to ignore taps in that area even in the software

[PATCH libinput 5/5] evdev: fix a compiler warning about a missing field initializer

2017-05-09 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- src/evdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/evdev.c b/src/evdev.c index d24a5646..a2be6fce 100644 --- a/src/evdev.c +++ b/src/evdev.c @@ -92,7 +92,7 @@ static const struct evdev_udev_tag_match evdev_udev_tag_matches[] = {

[PATCH libinput 2/5] util: fix container_of() macro

2017-05-09 Thread Peter Hutterer
Fixes a bunch of warnings of the kind ../src/evdev.h:378:32: warning: variable 'f' is uninitialized when used here [-Wuninitialized] return container_of(dispatch, f, base); Just typecasting NULL means we can ignore sample but for the type. https://bugs.freedesktop.org/show_bug.cgi?id=100

[PATCH libinput 4/5] Ensure enums are size int

2017-05-09 Thread Peter Hutterer
Because otherwise things go boom, but unless you passed -fshort-enums this shouldn't happen anyway. And gcc's documentation says don't do that. So don't do that, or we'll scream at you. Signed-off-by: Peter Hutterer --- src/libinput.c | 31 +++ 1 file changed, 31 inse

[PATCH libinput 3/5] Fix va_start compiler warning

2017-05-09 Thread Peter Hutterer
../src/libinput.c:56:17: warning: passing an object that undergoes default argument promotion to 'va_start' has undefined behavior [-Wvarargs] The enum's size is compiler-defined, so the enum gets promoted to whatever the compiler chose. That promotion is undefined, so let's use an int here. Sign

[PATCH libinput 1/5] util: drop GCC specifics for container_of

2017-05-09 Thread Peter Hutterer
clang supports __typeof__ which was the only real difference. Not sure any other compilers matter (that don't support __typeof__) Signed-off-by: Peter Hutterer --- src/libinput-util.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/libinput-util.h b/src/libinput-util.h index 4e97e01

[PATCH libinput] touchpad: pull the tap exclusion zone down to the full edge zone

2017-05-09 Thread Peter Hutterer
This was originally left outside of the button areas in case users tap in those zones, but we're getting false tap events in that zone. On a 100mm touchpad, the edge zone is merely 5mm, it's acceptable to ignore taps in that area even in the software button. We can revisit this if we see tap detec

Re: [PATCH weston v10 17/61] compositor-drm: Refactor sprite create/destroy into helpers

2017-05-09 Thread Pekka Paalanen
On Mon, 17 Apr 2017 20:54:21 +0100 Daniel Stone wrote: > Hi, > > On 7 April 2017 at 15:36, Pekka Paalanen wrote: > > On Tue, 4 Apr 2017 17:54:35 +0100 > > Daniel Stone wrote: > >> +/** > >> + * Destroy one DRM plane > >> + * > >> + * Destroy a DRM plane, removing it from screen and releasin