Re: [PATCH libinput 5/9] touchpad: add touch-size based touch handling

2017-03-30 Thread Peter Hutterer
On Wed, Mar 29, 2017 at 02:59:04PM +1000, Peter Hutterer wrote: > Apple touchpads don't use ABS_MT_PRESSURE but they are multitouch touchpads, > so the current pressure-based handling code doesn't apply because it expects > slot-based pressure for mt touchpads. > > Apple does however send useful d

Re: [PATCH weston] wcap: Prevent fd leak in wcap_decoder_create() fail path

2017-03-30 Thread Quentin Glidic
On 3/29/17 10:41 PM, Sergi Granell wrote: Signed-off-by: Sergi Granell Well, good: ;-) Reviewed-by: Quentin Glidic And pushed: fec723ef..597dde5c master -> master Thanks, --- wcap/wcap-decode.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/wcap/wcap-decode.c b/wcap/wcap-decod

Re: [PATCH weston] compositor-wayland: Properly dealloc mmap data using munmap

2017-03-30 Thread Quentin Glidic
On 3/29/17 10:23 PM, Raúl Peñacoba wrote: Signed-off-by: Raúl Peñacoba Really nice catch: Reviewed-by: Quentin Glidic And pushed: 745e647f..fec723ef master -> master Thanks, --- libweston/compositor-wayland.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libwest

Re: [PATCH weston] editor: Add missing free() and display_destroy() in main

2017-03-30 Thread Quentin Glidic
On 3/29/17 6:16 PM, Raúl Peñacoba wrote: Signed-off-by: Raúl Peñacoba Good: Reviewed-by: Quentin Glidic And pushed: bd8dc0a2..745e647f master -> master Thanks, --- clients/editor.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/clients/editor.c b/clients/editor.c index a0cc97a

Re: [PATCH weston] ivi-layout: Add missing free() in ivi_view_create

2017-03-30 Thread Quentin Glidic
On 3/29/17 6:13 PM, Raúl Peñacoba wrote: Signed-off-by: Raúl Peñacoba Nice catch: Reviewed-by: Quentin Glidic And pushed: 5fc8d5eb..bd8dc0a2 master -> master Thanks, --- ivi-shell/ivi-layout.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ivi-shell/ivi-layout.c b/ivi-shell/ivi-l

Re: [PATCH weston] gl-renderer: Change 'data' type to 'uint8_t *', since 'void *' arithmetic is undefined

2017-03-30 Thread Quentin Glidic
On 3/28/17 6:17 PM, Raúl Peñacoba wrote: Signed-off-by: Raúl Peñacoba Good: Reviewed-by: Quentin Glidic And pushed: ceb5981a..5fc8d5eb master -> master Thanks, --- libweston/gl-renderer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libweston/gl-renderer.c b/lib

Re: [PATCH weston] compositor-drm: Add missing drmModeFreeResources in drm_device_is_kms

2017-03-30 Thread Quentin Glidic
On 3/28/17 12:44 PM, Sergi Granell wrote: Signed-off-by: Sergi Granell Nice: Reviewed-by: Quentin Glidic And pushed: eaa73584..ceb5981a master -> master Thanks, --- libweston/compositor-drm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libweston/compositor-drm.c b/libweston/

Re: [PATCH weston v2 10/11] [RFC] Account for very large repaint window misses

2017-03-30 Thread Mario Kleiner
On 03/30/2017 11:53 AM, Pekka Paalanen wrote: On Wed, 29 Mar 2017 22:35:46 +0200 Mario Kleiner wrote: On 03/29/2017 12:30 PM, Pekka Paalanen wrote: On Tue, 28 Mar 2017 20:53:53 +0200 Mario Kleiner wrote: ... Agreed. The adjustment can never be more than 1 refresh period, ergo doesn't nee

[PATCH wayland] wl-utils: wl_list_insert_list

2017-03-30 Thread Oktay Sarimehmet
It doesnt add an element which is adressed as other`s adress. Signed-off-by: Oktay Sarimehmet --- src/wayland-util.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/wayland-util.c b/src/wayland-util.c index cab7fc5..50c52b2 100644 --- a/src/wayland-util.c +++ b/src/wa

[PATCH wayland] wl-utils: wl_list_insert_list

2017-03-30 Thread Oktay Sarimehmet
It doesnt add an element which is adressed as other`s adress. --- src/wayland-util.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/wayland-util.c b/src/wayland-util.c index cab7fc5..50c52b2 100644 --- a/src/wayland-util.c +++ b/src/wayland-util.c @@ -87,8 +87,8 @@ wl_

Re: [PATCH weston v9 14/62] compositor-drm: Introduce fb_last member

2017-03-30 Thread Pekka Paalanen
On Wed, 29 Mar 2017 18:46:03 +0100 Daniel Stone wrote: > Hi Pekka, > > On 24 March 2017 at 10:30, Pekka Paalanen wrote: > > On Thu, 23 Mar 2017 15:56:55 + > > Daniel Stone wrote: > >> On 22 March 2017 at 14:35, Pekka Paalanen wrote: > >> > I think this patch could use a better explana

Re: [PATCH weston v2 10/11] [RFC] Account for very large repaint window misses

2017-03-30 Thread Pekka Paalanen
On Wed, 29 Mar 2017 22:35:46 +0200 Mario Kleiner wrote: > On 03/29/2017 12:30 PM, Pekka Paalanen wrote: > > On Tue, 28 Mar 2017 20:53:53 +0200 > > Mario Kleiner wrote: > > > ... > >> > >> Agreed. The adjustment can never be more than 1 refresh period, ergo > >> doesn't need a loop, unless we'd