Re: [PATCH wayland] scanner: Reword fallthrough comment to quiet GCC

2017-03-17 Thread Daniel Stone
Hey Yong, On 17 March 2017 at 17:55, Yong Bakos wrote: > This mere comment change seems innocuous enough. > (Should the standard `__attribute__ ((fallthrough))` be used instead?) It could be good, but then we'd need autoconf bits to detect that and come up with a macro for it ... seemed a bit ov

Re: [PATCH wayland] scanner: Reword fallthrough comment to quiet GCC

2017-03-17 Thread Yong Bakos
Hi Daniel, > On Mar 17, 2017, at 10:36 AM, Daniel Stone wrote: > > GCC 7 now requires an explicit comment noting that case statements > without a break fall through. We already had one of those in the > scanner, but GCC wasn't smart enough to pick it up. > > Quiet the warning by making the comm

Re: [PATCH weston 2/2] weston-launch: Add sysmacros.h include for major()

2017-03-17 Thread Daniel Stone
Hi, On 14 March 2017 at 17:26, Daniel Stone wrote: > Same as with c4d7f66c, but I hadn't done a full-tree rebuild so didn't > see this one go by. Accidentally pushed this whilst pushing weston-terminal --maximized. :( I thought about force-pushing to clear it, but it's trivial, and if it needs t

Re: [PATCH weston] weston-terminal: Add a --maximized command line parameter

2017-03-17 Thread Daniel Stone
Hi, On 8 March 2017 at 17:58, Derek Foreman wrote: > This is useful for testing compositor response to a client that > requests a maximized initial surface. I tested this, and it results in the terminal requesting a top-level, committing, setting maximised, getting a configure for the initial to

Re: [PATCH weston v2] libinput: Suppress unhandled-case warning

2017-03-17 Thread Daniel Stone
Hi, On 16 March 2017 at 22:52, Peter Hutterer wrote: > On Thu, Mar 16, 2017 at 10:01:05AM +, Daniel Stone wrote: >> When the wheel tilt source is present, gcc complains that we don't >> handle all possible enumeration values. We already ensure this cannot >> happen in its only caller (handle_

[PATCH wayland] scanner: Reword fallthrough comment to quiet GCC

2017-03-17 Thread Daniel Stone
GCC 7 now requires an explicit comment noting that case statements without a break fall through. We already had one of those in the scanner, but GCC wasn't smart enough to pick it up. Quiet the warning by making the comment less elaborate. Signed-off-by: Daniel Stone --- src/scanner.c | 4 +---

wl_shm formats on big-endian

2017-03-17 Thread Pekka Paalanen
Hi, this is a re-send of a part of "Re: [PATCH weston 01/68] libweston: Add pixel-format helpers" which I believe deserves its own thread. The core question is, what do WL_SHM_FORMAT_ARGB888 and WL_SHM_FORMAT_XRGB888 formats mean on big-endian? There is a possible clash with Cairo. As summary,

Re: [PATCH weston v9 03/62] compositor-drm: Calculate more cursor state up front

2017-03-17 Thread Pekka Paalanen
On Fri, 3 Mar 2017 23:05:14 + Daniel Stone wrote: > Make drm_output_set_cursor more deterministic, by calculating more state > and performing more plane manipulation, inside > drm_output_prepare_cursor_view. > > Differential Revision: https://phabricator.freedesktop.org/D1485 Hi, maybe re

Re: [PATCH wayland v2 3/4] wayland-util: build/ship as separate shared library

2017-03-17 Thread Pekka Paalanen
On Fri, 17 Mar 2017 12:07:45 + Emil Velikov wrote: > On 17 March 2017 at 11:10, Pekka Paalanen wrote: > > On Thu, 16 Mar 2017 15:32:46 + > > Emil Velikov wrote: > > > >> On 16 March 2017 at 12:40, Pekka Paalanen wrote: > >> > Hi, > >> > > >> > since I have so much trouble making m

Re: [PATCH wayland v2 3/4] wayland-util: build/ship as separate shared library

2017-03-17 Thread Daniel Stone
Hi, On 17 March 2017 at 12:07, Emil Velikov wrote: > On 17 March 2017 at 11:10, Pekka Paalanen wrote: >> On Thu, 16 Mar 2017 15:32:46 + >> Emil Velikov wrote: >>> - managing the compat server/client DSO in any build system will be a pain >> >> How so? Whose build system? >> >> User project

Re: [PATCH wayland v2 3/4] wayland-util: build/ship as separate shared library

2017-03-17 Thread Emil Velikov
On 17 March 2017 at 11:10, Pekka Paalanen wrote: > On Thu, 16 Mar 2017 15:32:46 + > Emil Velikov wrote: > >> On 16 March 2017 at 12:40, Pekka Paalanen wrote: >> > On Tue, 21 Feb 2017 16:14:28 + >> > Emil Velikov wrote: >> > >> >> From: Emil Velikov >> >> >> >> Currently both of libwayl

Re: [PATCH weston] simple-dmabuf-v4l: Remove incorrect assert

2017-03-17 Thread Pekka Paalanen
On Fri, 10 Mar 2017 14:21:32 -0600 Derek Foreman wrote: > According to v4l2 documentation, DQBUF always clears FLAG_DONE, so > this assert can be expected to fire 100% of the time. > > Signed-off-by: Derek Foreman > --- > clients/simple-dmabuf-v4l.c | 2 -- > 1 file changed, 2 deletions(-) >

Re: [PATCH wayland v2 3/4] wayland-util: build/ship as separate shared library

2017-03-17 Thread Pekka Paalanen
On Thu, 16 Mar 2017 15:32:46 + Emil Velikov wrote: > On 16 March 2017 at 12:40, Pekka Paalanen wrote: > > On Tue, 21 Feb 2017 16:14:28 + > > Emil Velikov wrote: > > > >> From: Emil Velikov > >> > >> Currently both of libwayland-{client,server} export the same util > >> (amongst other